mirror of
https://github.com/overleaf/overleaf.git
synced 2024-12-01 21:52:28 -05:00
4a3eed35d6
* Fix accept changes request for new review panel * Implement pessimistic UI updates for new review panel (#20986) * Implement pessimistic UI updates for new review panel * deleteThread, reopenThread handlers * use finally * handleSubmit in useCallback GitOrigin-RevId: 358181a6b5601ad1b3579e001564dfa4da67a81d
210 lines
6.8 KiB
TypeScript
210 lines
6.8 KiB
TypeScript
import { memo, useCallback, useState } from 'react'
|
|
import { useRangesActionsContext } from '../context/ranges-context'
|
|
import {
|
|
Change,
|
|
DeleteOperation,
|
|
EditOperation,
|
|
} from '../../../../../types/change'
|
|
import { useTranslation } from 'react-i18next'
|
|
import classnames from 'classnames'
|
|
import { usePermissionsContext } from '@/features/ide-react/context/permissions-context'
|
|
import { Button } from 'react-bootstrap'
|
|
import Tooltip from '@/shared/components/tooltip'
|
|
import MaterialIcon from '@/shared/components/material-icon'
|
|
import { formatTimeBasedOnYear } from '@/features/utils/format-date'
|
|
import { useChangesUsersContext } from '../context/changes-users-context'
|
|
import { ReviewPanelChangeUser } from './review-panel-change-user'
|
|
import { ReviewPanelEntry } from './review-panel-entry'
|
|
import { useModalsContext } from '@/features/ide-react/context/modals-context'
|
|
|
|
export const ReviewPanelChange = memo<{
|
|
change: Change<EditOperation>
|
|
aggregate?: Change<DeleteOperation>
|
|
top?: number
|
|
editable?: boolean
|
|
docId: string
|
|
hoverRanges?: boolean
|
|
hovered?: boolean
|
|
onEnter?: () => void
|
|
onLeave?: () => void
|
|
}>(
|
|
({
|
|
change,
|
|
aggregate,
|
|
top,
|
|
docId,
|
|
hoverRanges,
|
|
editable = true,
|
|
hovered,
|
|
onEnter,
|
|
onLeave,
|
|
}) => {
|
|
const { t } = useTranslation()
|
|
const { acceptChanges, rejectChanges } = useRangesActionsContext()
|
|
const permissions = usePermissionsContext()
|
|
const changesUsers = useChangesUsersContext()
|
|
const { showGenericMessageModal } = useModalsContext()
|
|
|
|
const [accepting, setAccepting] = useState(false)
|
|
|
|
const acceptHandler = useCallback(async () => {
|
|
setAccepting(true)
|
|
try {
|
|
if (aggregate) {
|
|
await acceptChanges(change.id, aggregate.id)
|
|
} else {
|
|
await acceptChanges(change.id)
|
|
}
|
|
} catch (err) {
|
|
showGenericMessageModal(
|
|
t('accept_change_error_title'),
|
|
t('accept_change_error_description')
|
|
)
|
|
} finally {
|
|
setAccepting(false)
|
|
}
|
|
}, [acceptChanges, aggregate, change.id, showGenericMessageModal, t])
|
|
|
|
if (!changesUsers) {
|
|
// if users are not loaded yet, do not show "Unknown" user
|
|
return null
|
|
}
|
|
|
|
return (
|
|
<ReviewPanelEntry
|
|
className={classnames('review-panel-entry-change', {
|
|
'review-panel-entry-insert': 'i' in change.op,
|
|
'review-panel-entry-delete': 'd' in change.op,
|
|
'review-panel-entry-hover': hovered,
|
|
// TODO: aggregate
|
|
})}
|
|
top={top}
|
|
op={change.op}
|
|
position={change.op.p}
|
|
docId={docId}
|
|
hoverRanges={hoverRanges}
|
|
disabled={accepting}
|
|
>
|
|
<div
|
|
className="review-panel-entry-indicator"
|
|
onMouseEnter={onEnter}
|
|
onMouseLeave={onLeave}
|
|
>
|
|
<MaterialIcon type="edit" className="review-panel-entry-icon" />
|
|
</div>
|
|
|
|
<div
|
|
className="review-panel-entry-content"
|
|
onMouseEnter={onEnter}
|
|
onMouseLeave={onLeave}
|
|
>
|
|
<div className="review-panel-entry-header">
|
|
<div>
|
|
<div className="review-panel-entry-user">
|
|
<ReviewPanelChangeUser change={change} />
|
|
</div>
|
|
<div className="review-panel-entry-time">
|
|
{formatTimeBasedOnYear(change.metadata?.ts)}
|
|
</div>
|
|
</div>
|
|
{editable && permissions.write && (
|
|
<div className="review-panel-entry-actions">
|
|
<Tooltip
|
|
id="accept-change"
|
|
overlayProps={{ placement: 'bottom' }}
|
|
description={t('accept_change')}
|
|
tooltipProps={{ className: 'review-panel-tooltip' }}
|
|
>
|
|
<Button onClick={acceptHandler} bsStyle={null}>
|
|
<MaterialIcon
|
|
type="check"
|
|
className="review-panel-entry-actions-icon"
|
|
accessibilityLabel={t('accept_change')}
|
|
/>
|
|
</Button>
|
|
</Tooltip>
|
|
|
|
<Tooltip
|
|
id="reject-change"
|
|
description={t('reject_change')}
|
|
overlayProps={{ placement: 'bottom' }}
|
|
tooltipProps={{ className: 'review-panel-tooltip' }}
|
|
>
|
|
<Button
|
|
bsStyle={null}
|
|
onClick={() =>
|
|
aggregate
|
|
? rejectChanges(change.id, aggregate.id)
|
|
: rejectChanges(change.id)
|
|
}
|
|
>
|
|
<MaterialIcon
|
|
className="review-panel-entry-actions-icon"
|
|
accessibilityLabel={t('reject_change')}
|
|
type="close"
|
|
/>
|
|
</Button>
|
|
</Tooltip>
|
|
</div>
|
|
)}
|
|
</div>
|
|
|
|
<div className="review-panel-change-body">
|
|
{'i' in change.op && (
|
|
<>
|
|
{aggregate ? (
|
|
<MaterialIcon
|
|
className="review-panel-entry-icon review-panel-entry-change-icon review-panel-entry-icon-changed"
|
|
type="edit"
|
|
/>
|
|
) : (
|
|
<MaterialIcon
|
|
className="review-panel-entry-icon review-panel-entry-change-icon review-panel-entry-icon-accept"
|
|
type="add_circle"
|
|
/>
|
|
)}
|
|
|
|
{aggregate ? (
|
|
<span>
|
|
{t('aggregate_changed')}:{' '}
|
|
<del className="review-panel-content-highlight">
|
|
{aggregate.op.d}
|
|
</del>{' '}
|
|
{t('aggregate_to')}{' '}
|
|
<ins className="review-panel-content-highlight">
|
|
{change.op.i}
|
|
</ins>
|
|
</span>
|
|
) : (
|
|
<span>
|
|
{t('tracked_change_added')}:
|
|
<ins className="review-panel-content-highlight">
|
|
{change.op.i}
|
|
</ins>
|
|
</span>
|
|
)}
|
|
</>
|
|
)}
|
|
|
|
{'d' in change.op && (
|
|
<>
|
|
<MaterialIcon
|
|
className="review-panel-entry-icon review-panel-entry-change-icon review-panel-entry-icon-reject"
|
|
type="delete"
|
|
/>
|
|
|
|
<span>
|
|
{t('tracked_change_deleted')}:
|
|
<del className="review-panel-content-highlight">
|
|
{change.op.d}
|
|
</del>
|
|
</span>
|
|
</>
|
|
)}
|
|
</div>
|
|
</div>
|
|
</ReviewPanelEntry>
|
|
)
|
|
}
|
|
)
|
|
ReviewPanelChange.displayName = 'ReviewPanelChange'
|