mirror of
https://github.com/overleaf/overleaf.git
synced 2024-11-30 02:15:13 -05:00
b2ef7a935f
* Add a unit test on `SubscriptionFormatters.formatPrice` * Add JSDoc to `formatPrice` Also: Name the functions before exporting: This fixes my IDE (WebStorm) navigation * Make `'USD'` the default param instead of reassigning * Create `formatCurrency` function * Use `formatCurrency` in SubscriptionFormatters * Use an `isNoCentsCurrency` logic for `CLP` `JPY` `KRW` `VND` And remove custom `CLP` logic and locale * Add `locale` param to `formatPrice` * Generate `groups.json` and `localizedPlanPricing.json` ``` bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir ``` * Update scripts/plan-prices/plans.js to generate numbers instead of localized amounts * Generate `groups.json` and `localizedPlanPricing.json` ``` bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir ``` * Remove generation of `plans.json` As /services/web/frontend/js/main/plans.js was removed in https://github.com/overleaf/internal/pull/12593 * Sort currencies in alphabetical order in scripts/plan-prices/plans.js * Generate `groups.json` and `localizedPlanPricing.json` ``` bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir ``` * Use `formatCurrency` in price-summary.tsx * Use `formatCurrency` in Subscription Pug files * Fix unit tests SubscriptionHelperTests.js * Remove unused `currencySymbol` * Change to `formatCurrency` in other React components * Add `CurrencyCode` JSDoc types * Duplicate `formatCurrency` into services/web/app/src/util * Wrap tests in a top-level describe block * Use `narrowSymbol` * Fix tests with `narrowSymbol` expects * Revert deletion of old `formatPrice` in SubscriptionFormatters.js * Rename `formatCurrency` -> `formatCurrencyLocalized` * Revert deletion of `CurrencySymbol` * Add split-test in SubscriptionController.js * Add split-test in SubscriptionViewModelBuilder.js * Add split-test in plans * Add split-test in subscription-dashboard-context.tsx * Add split-test in 4 more components * Update tests * Show currency and payment methods in interstitial page * Fix `–` being printed. Use `–` instead * Fix test with NOK * Storybook: Fix missing `SplitTestProvider` * Storybook: Revert "Remove unused `currencySymbol`" This reverts commit e55387d4753f97bbf8e39e0fdc3ad17312122aaa. * Replace `getSplitTestVariant` by `useSplitTestContext` * Use parameterize currencyFormat in `generateInitialLocalizedGroupPrice` * Fixup import paths of `formatCurrencyLocalized` * Replace `% 1 === 0` by `Number.isInteger` * Add comment explaining that any combinations of languages/currencies could happen * Fixup after rebase: import `useSplitTestContext` * Revert "Remove SplitTestProvider from subscription root" This reverts commit be9f378fda715b86589ab0759737581c72321d87. * Revert "Remove split test provider from some tests" This reverts commit 985522932b550cfd38fa6a4f4c3d2ebaee6ff7df. GitOrigin-RevId: 59a83cbbe0f7cc7e45f189c654e23fcf9bfa37af
90 lines
2.6 KiB
JavaScript
90 lines
2.6 KiB
JavaScript
import { expect } from 'chai'
|
||
import { createLocalizedGroupPlanPrice } from '../../../../frontend/js/features/plans/utils/group-plan-pricing'
|
||
import { formatCurrencyLocalized } from '@/shared/utils/currency'
|
||
|
||
describe('group-plan-pricing', function () {
|
||
beforeEach(function () {
|
||
window.metaAttributesCache = window.metaAttributesCache || new Map()
|
||
window.metaAttributesCache.set('ol-groupPlans', {
|
||
enterprise: {
|
||
professional: {
|
||
CHF: {
|
||
2: {
|
||
price_in_cents: 10000,
|
||
},
|
||
},
|
||
DKK: {
|
||
2: {
|
||
price_in_cents: 20000,
|
||
},
|
||
},
|
||
USD: {
|
||
2: {
|
||
price_in_cents: 30000,
|
||
},
|
||
},
|
||
},
|
||
},
|
||
})
|
||
window.metaAttributesCache.set('ol-currencySymbols', {
|
||
CHF: 'Fr',
|
||
DKK: 'kr',
|
||
USD: '$',
|
||
})
|
||
})
|
||
|
||
afterEach(function () {
|
||
window.metaAttributesCache = new Map()
|
||
})
|
||
|
||
describe('createLocalizedGroupPlanPrice', function () {
|
||
describe('CHF currency', function () {
|
||
it('should return the correct localized price', function () {
|
||
const localizedGroupPlanPrice = createLocalizedGroupPlanPrice({
|
||
plan: 'professional',
|
||
currency: 'CHF',
|
||
licenseSize: '2',
|
||
usage: 'enterprise',
|
||
formatCurrency: formatCurrencyLocalized,
|
||
})
|
||
|
||
expect(localizedGroupPlanPrice).to.deep.equal({
|
||
localizedPrice: 'CHF 100',
|
||
localizedPerUserPrice: 'CHF 50',
|
||
})
|
||
})
|
||
})
|
||
describe('DKK currency', function () {
|
||
it('should return the correct localized price', function () {
|
||
const localizedGroupPlanPrice = createLocalizedGroupPlanPrice({
|
||
plan: 'professional',
|
||
currency: 'DKK',
|
||
licenseSize: '2',
|
||
usage: 'enterprise',
|
||
formatCurrency: formatCurrencyLocalized,
|
||
})
|
||
|
||
expect(localizedGroupPlanPrice).to.deep.equal({
|
||
localizedPrice: 'kr 200',
|
||
localizedPerUserPrice: 'kr 100',
|
||
})
|
||
})
|
||
})
|
||
describe('other supported currencies', function () {
|
||
it('should return the correct localized price', function () {
|
||
const localizedGroupPlanPrice = createLocalizedGroupPlanPrice({
|
||
plan: 'professional',
|
||
currency: 'USD',
|
||
licenseSize: '2',
|
||
usage: 'enterprise',
|
||
formatCurrency: formatCurrencyLocalized,
|
||
})
|
||
|
||
expect(localizedGroupPlanPrice).to.deep.equal({
|
||
localizedPrice: '$300',
|
||
localizedPerUserPrice: '$150',
|
||
})
|
||
})
|
||
})
|
||
})
|
||
})
|