github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
overleaf/libraries/overleaf-editor-core
History
Domagoj Kriskovic c9b9ae4180 [overleaf-core-editor] Make comment properties immutable (#17022) 
* make range class immutable

* rename variable

* use newRanges

* range readonly props

* skrinkBy test

* Fix range shrinking bug

* [overleaf-core-editor] Make comment properties immutable

* remove added line

* format fix

* make readonly array

* [overleaf-editor-core] AddCommentOperation and DeleteCommentOperation (#16871)

* [overleaf-editor-core] AddCommentOperation and DeleteCommentOperation

* added add comment op test

* delete comment op test

* import core to escape circle deps

* desctructure in tests

* require directly in builder

* invert of add comment is always delete comment

* no merging on compose

* NoOp if comment is not found

* use comment.clone()

* update test

* change CommentRawData type

* jsdoc assert type

* fix formating

* EditNoOperation

* return other in compose

* use ReturnType

* Revert "use ReturnType"

This reverts commit 2c7e04f1541310e9fc08963170a783a437ed1992.

* transorm add comment operation

* transform delete comment operation

* moved comment.js

* format fix

* fix transform addComment and textoperation

* fix merge

* test more complex test operations

* change to else if

* move range.js

* fix types

* fix AddComment and TextOperation transform

* fixed AddComment-TextOperation trasform, added test

* deletecommentoperation should win

* should not delete comment

* remove unused function, fix type

* fix format

* add resolved for existing comment

* transform EditNoOperation

* fix test description

* change the order of EditNoOperation

* fix DeleteCommentOperation-DeleteCommentOperation transform

* fix types after merging main

* refactor operation types

* fix errors after merging

* fix bad merge

* format fix

* removed comment.clone()

* return old comment

* remove unused var

GitOrigin-RevId: e31d723075cb04b0b7177e7cae0014c295f92a68
2024-02-21 09:03:21 +00:00
..
lib [overleaf-core-editor] Make comment properties immutable (#17022) 2024-02-21 09:03:21 +00:00
test [overleaf-core-editor] Make comment properties immutable (#17022) 2024-02-21 09:03:21 +00:00
.dockerignore Avoid duplicating a math-closing dollar sign (#11227) 2023-01-16 08:41:42 +00:00
.gitignore Avoid duplicating a math-closing dollar sign (#11227) 2023-01-16 08:41:42 +00:00
.nvmrc Merge pull request #17170 from overleaf/jpa-node-18-19-1 2024-02-20 09:04:55 +00:00
buildscript.txt Merge pull request #17170 from overleaf/jpa-node-18-19-1 2024-02-20 09:04:55 +00:00
index.js [overleaf-editor-core] AddCommentOperation and DeleteCommentOperation (#16871) 2024-02-19 09:04:15 +00:00
package.json Merge pull request #16661 from overleaf/em-fix-tsconfig 2024-01-24 09:05:09 +00:00
tsconfig.json Merge pull request #16524 from overleaf/em-fix-typescript-backend 2024-01-17 09:03:42 +00:00