overleaf/services
Antoine Clausse b2ef7a935f [web] Use localized number formatting for currencies (#17622)
* Add a unit test on `SubscriptionFormatters.formatPrice`

* Add JSDoc to `formatPrice`

Also: Name the functions before exporting:
This fixes my IDE (WebStorm) navigation

* Make `'USD'` the default param instead of reassigning

* Create `formatCurrency` function

* Use `formatCurrency` in SubscriptionFormatters

* Use an `isNoCentsCurrency` logic for `CLP` `JPY` `KRW` `VND`

And remove custom `CLP` logic and locale

* Add `locale` param to `formatPrice`

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Update scripts/plan-prices/plans.js to generate numbers instead of localized amounts

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Remove generation of `plans.json`

As /services/web/frontend/js/main/plans.js was removed in https://github.com/overleaf/internal/pull/12593

* Sort currencies in alphabetical order in scripts/plan-prices/plans.js

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Use `formatCurrency` in price-summary.tsx

* Use `formatCurrency` in Subscription Pug files

* Fix unit tests SubscriptionHelperTests.js

* Remove unused `currencySymbol`

* Change to `formatCurrency` in other React components

* Add `CurrencyCode` JSDoc types

* Duplicate `formatCurrency` into services/web/app/src/util

* Wrap tests in a top-level describe block

* Use `narrowSymbol`

* Fix tests with `narrowSymbol` expects

* Revert deletion of old `formatPrice` in SubscriptionFormatters.js

* Rename `formatCurrency` -> `formatCurrencyLocalized`

* Revert deletion of `CurrencySymbol`

* Add split-test in SubscriptionController.js

* Add split-test in SubscriptionViewModelBuilder.js

* Add split-test in plans

* Add split-test in subscription-dashboard-context.tsx

* Add split-test in 4 more components

* Update tests

* Show currency and payment methods in interstitial page

* Fix `–` being printed. Use `–` instead

* Fix test with NOK

* Storybook: Fix missing `SplitTestProvider`

* Storybook: Revert "Remove unused `currencySymbol`"

This reverts commit e55387d4753f97bbf8e39e0fdc3ad17312122aaa.

* Replace `getSplitTestVariant` by `useSplitTestContext`

* Use parameterize currencyFormat in `generateInitialLocalizedGroupPrice`

* Fixup import paths of `formatCurrencyLocalized`

* Replace `% 1 === 0` by `Number.isInteger`

* Add comment explaining that any combinations of languages/currencies could happen

* Fixup after rebase: import `useSplitTestContext`

* Revert "Remove SplitTestProvider from subscription root"

This reverts commit be9f378fda715b86589ab0759737581c72321d87.

* Revert "Remove split test provider from some tests"

This reverts commit 985522932b550cfd38fa6a4f4c3d2ebaee6ff7df.

GitOrigin-RevId: 59a83cbbe0f7cc7e45f189c654e23fcf9bfa37af
2024-04-19 08:03:54 +00:00
..
chat Merge pull request #17748 from overleaf/bg-node-security-upgrade-2024-04-05 2024-04-08 08:04:41 +00:00
clsi Merge pull request #17874 from overleaf/jpa-ol-project-id-in-env 2024-04-12 08:04:56 +00:00
contacts Merge pull request #17748 from overleaf/bg-node-security-upgrade-2024-04-05 2024-04-08 08:04:41 +00:00
docstore Merge pull request #17748 from overleaf/bg-node-security-upgrade-2024-04-05 2024-04-08 08:04:41 +00:00
document-updater [document-updater] Avoid sending empty ops to project-history (#17920) 2024-04-17 08:04:22 +00:00
filestore Merge pull request #17748 from overleaf/bg-node-security-upgrade-2024-04-05 2024-04-08 08:04:41 +00:00
git-bridge
history-v1 Merge pull request #17748 from overleaf/bg-node-security-upgrade-2024-04-05 2024-04-08 08:04:41 +00:00
notifications Merge pull request #17748 from overleaf/bg-node-security-upgrade-2024-04-05 2024-04-08 08:04:41 +00:00
project-history Send operations to project-history when accepting tracked changes (#17599) 2024-04-17 08:04:17 +00:00
real-time Merge pull request #17879 from overleaf/rh-refresh-collab 2024-04-17 08:05:18 +00:00
spelling Merge pull request #17748 from overleaf/bg-node-security-upgrade-2024-04-05 2024-04-08 08:04:41 +00:00
web [web] Use localized number formatting for currencies (#17622) 2024-04-19 08:03:54 +00:00