mirror of
https://github.com/overleaf/overleaf.git
synced 2024-11-07 20:31:06 -05:00
acb7d7df5a
When the user provides a function as last argument for socket.emit,
socket.io will flag this as an RPC and add a cb as the last argument
to the client.on('event', ...) handler on the server side.
Without a function as last argument for socket.emit, the callback
argument on the server side is undefined, leading to invalid function
calls (`undefined()`) and an unhandled exception.
The user can also provide lots of other arguments, so the 2nd/3rd ...
argument is of arbitrary type, again leading to invalid function calls
-- e.g. `1()`.
76 lines
1.9 KiB
CoffeeScript
76 lines
1.9 KiB
CoffeeScript
async = require "async"
|
|
{expect} = require("chai")
|
|
|
|
RealTimeClient = require "./helpers/RealTimeClient"
|
|
FixturesManager = require "./helpers/FixturesManager"
|
|
|
|
|
|
describe "Router", ->
|
|
describe "joinProject", ->
|
|
describe "when there is no callback provided", ->
|
|
after () ->
|
|
process.removeListener('unhandledRejection', @onUnhandled)
|
|
|
|
before (done) ->
|
|
@onUnhandled = (error) ->
|
|
done(error)
|
|
process.on('unhandledRejection', @onUnhandled)
|
|
async.series [
|
|
(cb) =>
|
|
FixturesManager.setUpProject {
|
|
privilegeLevel: "owner"
|
|
project: {
|
|
name: "Test Project"
|
|
}
|
|
}, (e, {@project_id, @user_id}) =>
|
|
cb(e)
|
|
|
|
(cb) =>
|
|
@client = RealTimeClient.connect()
|
|
@client.on "connectionAccepted", cb
|
|
|
|
(cb) =>
|
|
@client = RealTimeClient.connect()
|
|
@client.on "connectionAccepted", cb
|
|
|
|
(cb) =>
|
|
@client.emit "joinProject", project_id: @project_id
|
|
setTimeout(cb, 100)
|
|
], done
|
|
|
|
it "should keep on going", ->
|
|
expect('still running').to.exist
|
|
|
|
describe "when there are too many arguments", ->
|
|
after () ->
|
|
process.removeListener('unhandledRejection', @onUnhandled)
|
|
|
|
before (done) ->
|
|
@onUnhandled = (error) ->
|
|
done(error)
|
|
process.on('unhandledRejection', @onUnhandled)
|
|
async.series [
|
|
(cb) =>
|
|
FixturesManager.setUpProject {
|
|
privilegeLevel: "owner"
|
|
project: {
|
|
name: "Test Project"
|
|
}
|
|
}, (e, {@project_id, @user_id}) =>
|
|
cb(e)
|
|
|
|
(cb) =>
|
|
@client = RealTimeClient.connect()
|
|
@client.on "connectionAccepted", cb
|
|
|
|
(cb) =>
|
|
@client = RealTimeClient.connect()
|
|
@client.on "connectionAccepted", cb
|
|
|
|
(cb) =>
|
|
@client.emit "joinProject", 1, 2, 3, 4, 5, (@error) =>
|
|
cb()
|
|
], done
|
|
|
|
it "should return an error message", ->
|
|
expect(@error.message).to.equal('unexpected arguments')
|