overleaf/services/document-updater/test/acceptance/js/SizeCheckTests.js
Brian Gough 865a973426 Merge pull request #5132 from overleaf/bg-fix-size-check
[docupdater] use more accurate doc size check

GitOrigin-RevId: f66d68a7f7fdc127cc31539abdcab65549823d02
2021-09-21 08:02:55 +00:00

194 lines
5.5 KiB
JavaScript

const { expect } = require('chai')
const Settings = require('@overleaf/settings')
const MockWebApi = require('./helpers/MockWebApi')
const DocUpdaterClient = require('./helpers/DocUpdaterClient')
const DocUpdaterApp = require('./helpers/DocUpdaterApp')
describe('SizeChecks', function () {
before(function (done) {
DocUpdaterApp.ensureRunning(done)
})
beforeEach(function () {
this.version = 0
this.update = {
doc: this.doc_id,
op: [
{
i: 'insert some more lines that will bring it above the limit\n',
p: 42,
},
],
v: this.version,
}
this.project_id = DocUpdaterClient.randomId()
this.doc_id = DocUpdaterClient.randomId()
})
describe('when a doc is above the doc size limit already', function () {
beforeEach(function () {
this.lines = ['x'.repeat(Settings.max_doc_length)] // including the extra newline, this will be over the limit
MockWebApi.insertDoc(this.project_id, this.doc_id, {
lines: this.lines,
v: this.version,
})
})
it('should error when fetching the doc', function (done) {
DocUpdaterClient.getDoc(this.project_id, this.doc_id, (error, res) => {
if (error) return done(error)
expect(res.statusCode).to.equal(500)
done()
})
})
describe('when trying to update', function () {
beforeEach(function (done) {
const update = {
doc: this.doc_id,
op: this.update.op,
v: this.version,
}
DocUpdaterClient.sendUpdate(
this.project_id,
this.doc_id,
update,
error => {
if (error != null) {
throw error
}
setTimeout(done, 200)
}
)
})
it('should still error when fetching the doc', function (done) {
DocUpdaterClient.getDoc(this.project_id, this.doc_id, (error, res) => {
if (error) return done(error)
expect(res.statusCode).to.equal(500)
done()
})
})
})
})
describe('when the stringified JSON is above the doc size limit but the doc character count is not', function () {
beforeEach(function () {
let charsRemaining = Settings.max_doc_length
this.lines = []
// Take the maximum allowed doc length and split it into N lines of 63 characters + a newline.
// The character count will be exactly max_doc_length
// The JSON stringified size will exceed max_doc_length, due to the JSON formatting of the array.
// This document should be allowed, because we use the character count as the limit, not the JSON size.
while (charsRemaining > 0) {
const charstoAdd = Math.min(charsRemaining - 1, 63) // allow for additional newline
this.lines.push('x'.repeat(charstoAdd))
charsRemaining -= charstoAdd + 1
}
MockWebApi.insertDoc(this.project_id, this.doc_id, {
lines: this.lines,
v: this.version,
})
})
it('should be able to fetch the doc', function (done) {
DocUpdaterClient.getDoc(
this.project_id,
this.doc_id,
(error, res, doc) => {
if (error) return done(error)
expect(doc.lines).to.deep.equal(this.lines)
done()
}
)
})
describe('when trying to update', function () {
beforeEach(function (done) {
const update = {
doc: this.doc_id,
op: this.update.op,
v: this.version,
}
DocUpdaterClient.sendUpdate(
this.project_id,
this.doc_id,
update,
error => {
if (error != null) {
throw error
}
setTimeout(done, 200)
}
)
})
it('should not update the doc', function (done) {
DocUpdaterClient.getDoc(
this.project_id,
this.doc_id,
(error, res, doc) => {
if (error) return done(error)
expect(doc.lines).to.deep.equal(this.lines)
done()
}
)
})
})
})
describe('when a doc is just below the doc size limit', function () {
beforeEach(function () {
this.lines = ['x'.repeat(Settings.max_doc_length - 1)] // character count is exactly max_doc_length after including the newline
MockWebApi.insertDoc(this.project_id, this.doc_id, {
lines: this.lines,
v: this.version,
})
})
it('should be able to fetch the doc', function (done) {
DocUpdaterClient.getDoc(
this.project_id,
this.doc_id,
(error, res, doc) => {
if (error) return done(error)
expect(doc.lines).to.deep.equal(this.lines)
done()
}
)
})
describe('when trying to update', function () {
beforeEach(function (done) {
const update = {
doc: this.doc_id,
op: this.update.op,
v: this.version,
}
DocUpdaterClient.sendUpdate(
this.project_id,
this.doc_id,
update,
error => {
if (error != null) {
throw error
}
setTimeout(done, 200)
}
)
})
it('should not update the doc', function (done) {
DocUpdaterClient.getDoc(
this.project_id,
this.doc_id,
(error, res, doc) => {
if (error) return done(error)
expect(doc.lines).to.deep.equal(this.lines)
done()
}
)
})
})
})
})