mirror of
https://github.com/overleaf/overleaf.git
synced 2024-09-23 02:55:13 -04:00
87634be542
[misc] re-land: remove mongojs and bump mongoose GitOrigin-RevId: eba9f80fbd58dbb8aed131fead3ec0b928a555aa
722 lines
21 KiB
JavaScript
722 lines
21 KiB
JavaScript
/* eslint-disable
|
|
handle-callback-err,
|
|
max-len,
|
|
no-return-assign,
|
|
no-unused-vars,
|
|
*/
|
|
// TODO: This file was created by bulk-decaffeinate.
|
|
// Fix any style issues and re-enable lint.
|
|
/*
|
|
* decaffeinate suggestions:
|
|
* DS102: Remove unnecessary code created because of implicit returns
|
|
* Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
|
|
*/
|
|
const should = require('chai').should()
|
|
const SandboxedModule = require('sandboxed-module')
|
|
const assert = require('assert')
|
|
const path = require('path')
|
|
const sinon = require('sinon')
|
|
const modulePath = path.join(
|
|
__dirname,
|
|
'../../../../app/src/Features/TokenAccess/TokenAccessHandler'
|
|
)
|
|
const { expect } = require('chai')
|
|
const { ObjectId } = require('mongodb')
|
|
|
|
describe('TokenAccessHandler', function() {
|
|
beforeEach(function() {
|
|
this.token = 'abcdefabcdef'
|
|
this.projectId = ObjectId()
|
|
this.project = {
|
|
_id: this.projectId,
|
|
publicAccesLevel: 'tokenBased',
|
|
owner_ref: ObjectId()
|
|
}
|
|
this.userId = ObjectId()
|
|
this.req = {}
|
|
return (this.TokenAccessHandler = SandboxedModule.require(modulePath, {
|
|
globals: {
|
|
console: console
|
|
},
|
|
requires: {
|
|
mongodb: { ObjectId },
|
|
'../../models/Project': { Project: (this.Project = {}) },
|
|
'settings-sharelatex': (this.settings = {}),
|
|
'../Collaborators/CollaboratorsGetter': (this.CollaboratorsGetter = {}),
|
|
'../User/UserGetter': (this.UserGetter = {}),
|
|
'../V1/V1Api': (this.V1Api = {
|
|
request: sinon.stub()
|
|
}),
|
|
crypto: (this.Crypto = require('crypto'))
|
|
}
|
|
}))
|
|
})
|
|
|
|
describe('getTokenType', function() {
|
|
it('should determine tokens correctly', function() {
|
|
const specs = {
|
|
abcdefabcdef: 'readOnly',
|
|
aaaaaabbbbbb: 'readOnly',
|
|
'54325aaaaaa': 'readAndWrite',
|
|
'54325aaaaaabbbbbb': 'readAndWrite',
|
|
'': null,
|
|
abc123def: null
|
|
}
|
|
for (var token of Object.keys(specs)) {
|
|
expect(this.TokenAccessHandler.getTokenType(token)).to.equal(
|
|
specs[token]
|
|
)
|
|
}
|
|
})
|
|
})
|
|
|
|
describe('getProjectByReadOnlyToken', function() {
|
|
beforeEach(function() {
|
|
this.token = 'abcdefabcdef'
|
|
this.Project.findOne = sinon.stub().callsArgWith(2, null, this.project)
|
|
})
|
|
|
|
it('should get the project', function(done) {
|
|
this.TokenAccessHandler.getProjectByReadOnlyToken(
|
|
this.token,
|
|
(err, project) => {
|
|
expect(err).to.not.exist
|
|
expect(project).to.exist
|
|
expect(this.Project.findOne.callCount).to.equal(1)
|
|
done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('getProjectByReadAndWriteToken', function() {
|
|
beforeEach(function() {
|
|
sinon.spy(this.Crypto, 'timingSafeEqual')
|
|
this.token = '1234abcdefabcdef'
|
|
this.project.tokens = {
|
|
readAndWrite: this.token,
|
|
readAndWritePrefix: '1234'
|
|
}
|
|
this.Project.findOne = sinon.stub().callsArgWith(2, null, this.project)
|
|
})
|
|
|
|
afterEach(function() {
|
|
this.Crypto.timingSafeEqual.restore()
|
|
})
|
|
|
|
it('should get the project and do timing-safe comparison', function(done) {
|
|
this.TokenAccessHandler.getProjectByReadAndWriteToken(
|
|
this.token,
|
|
(err, project) => {
|
|
expect(err).to.not.exist
|
|
expect(project).to.exist
|
|
expect(this.Crypto.timingSafeEqual.callCount).to.equal(1)
|
|
expect(
|
|
this.Crypto.timingSafeEqual.calledWith(Buffer.from(this.token))
|
|
).to.equal(true)
|
|
expect(this.Project.findOne.callCount).to.equal(1)
|
|
done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('addReadOnlyUserToProject', function() {
|
|
beforeEach(function() {
|
|
return (this.Project.updateOne = sinon.stub().callsArgWith(2, null))
|
|
})
|
|
|
|
it('should call Project.updateOne', function(done) {
|
|
return this.TokenAccessHandler.addReadOnlyUserToProject(
|
|
this.userId,
|
|
this.projectId,
|
|
err => {
|
|
expect(this.Project.updateOne.callCount).to.equal(1)
|
|
expect(
|
|
this.Project.updateOne.calledWith({
|
|
_id: this.projectId
|
|
})
|
|
).to.equal(true)
|
|
expect(
|
|
this.Project.updateOne.lastCall.args[1].$addToSet
|
|
).to.have.keys('tokenAccessReadOnly_refs')
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
|
|
it('should not produce an error', function(done) {
|
|
return this.TokenAccessHandler.addReadOnlyUserToProject(
|
|
this.userId,
|
|
this.projectId,
|
|
err => {
|
|
expect(err).to.not.exist
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
|
|
describe('when Project.updateOne produces an error', function() {
|
|
beforeEach(function() {
|
|
return (this.Project.updateOne = sinon
|
|
.stub()
|
|
.callsArgWith(2, new Error('woops')))
|
|
})
|
|
|
|
it('should produce an error', function(done) {
|
|
return this.TokenAccessHandler.addReadOnlyUserToProject(
|
|
this.userId,
|
|
this.projectId,
|
|
err => {
|
|
expect(err).to.exist
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('addReadAndWriteUserToProject', function() {
|
|
beforeEach(function() {
|
|
return (this.Project.updateOne = sinon.stub().callsArgWith(2, null))
|
|
})
|
|
|
|
it('should call Project.updateOne', function(done) {
|
|
return this.TokenAccessHandler.addReadAndWriteUserToProject(
|
|
this.userId,
|
|
this.projectId,
|
|
err => {
|
|
expect(this.Project.updateOne.callCount).to.equal(1)
|
|
expect(
|
|
this.Project.updateOne.calledWith({
|
|
_id: this.projectId
|
|
})
|
|
).to.equal(true)
|
|
expect(
|
|
this.Project.updateOne.lastCall.args[1].$addToSet
|
|
).to.have.keys('tokenAccessReadAndWrite_refs')
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
|
|
it('should not produce an error', function(done) {
|
|
return this.TokenAccessHandler.addReadAndWriteUserToProject(
|
|
this.userId,
|
|
this.projectId,
|
|
err => {
|
|
expect(err).to.not.exist
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
|
|
describe('when Project.updateOne produces an error', function() {
|
|
beforeEach(function() {
|
|
return (this.Project.updateOne = sinon
|
|
.stub()
|
|
.callsArgWith(2, new Error('woops')))
|
|
})
|
|
|
|
it('should produce an error', function(done) {
|
|
return this.TokenAccessHandler.addReadAndWriteUserToProject(
|
|
this.userId,
|
|
this.projectId,
|
|
err => {
|
|
expect(err).to.exist
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('grantSessionTokenAccess', function() {
|
|
beforeEach(function() {
|
|
return (this.req = { session: {}, headers: {} })
|
|
})
|
|
|
|
it('should add the token to the session', function(done) {
|
|
this.TokenAccessHandler.grantSessionTokenAccess(
|
|
this.req,
|
|
this.projectId,
|
|
this.token
|
|
)
|
|
expect(
|
|
this.req.session.anonTokenAccess[this.projectId.toString()]
|
|
).to.equal(this.token)
|
|
return done()
|
|
})
|
|
})
|
|
|
|
describe('validateTokenForAnonymousAccess', function() {
|
|
describe('when a read-only project is found', function() {
|
|
beforeEach(function() {
|
|
this.TokenAccessHandler.getTokenType = sinon.stub().returns('readOnly')
|
|
this.TokenAccessHandler.getProjectByToken = sinon
|
|
.stub()
|
|
.callsArgWith(2, null, this.project)
|
|
})
|
|
|
|
it('should try to find projects with both kinds of token', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, allowed) => {
|
|
expect(
|
|
this.TokenAccessHandler.getProjectByToken.callCount
|
|
).to.equal(1)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
|
|
it('should allow read-only access', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, rw, ro) => {
|
|
expect(err).to.not.exist
|
|
expect(rw).to.equal(false)
|
|
expect(ro).to.equal(true)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('when a read-and-write project is found', function() {
|
|
beforeEach(function() {
|
|
this.TokenAccessHandler.getTokenType = sinon
|
|
.stub()
|
|
.returns('readAndWrite')
|
|
this.TokenAccessHandler.getProjectByToken = sinon
|
|
.stub()
|
|
.callsArgWith(2, null, this.project)
|
|
})
|
|
|
|
describe('when Anonymous token access is not enabled', function(done) {
|
|
beforeEach(function() {
|
|
this.TokenAccessHandler.ANONYMOUS_READ_AND_WRITE_ENABLED = false
|
|
})
|
|
|
|
it('should try to find projects with both kinds of token', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, rw, ro) => {
|
|
expect(
|
|
this.TokenAccessHandler.getProjectByToken.callCount
|
|
).to.equal(1)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
|
|
it('should not allow read-and-write access', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, rw, ro) => {
|
|
expect(err).to.not.exist
|
|
expect(rw).to.equal(false)
|
|
expect(ro).to.equal(false)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('when anonymous token access is enabled', function(done) {
|
|
beforeEach(function() {
|
|
this.TokenAccessHandler.ANONYMOUS_READ_AND_WRITE_ENABLED = true
|
|
})
|
|
|
|
it('should try to find projects with both kinds of token', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, rw, ro) => {
|
|
expect(
|
|
this.TokenAccessHandler.getProjectByToken.callCount
|
|
).to.equal(1)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
|
|
it('should allow read-and-write access', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, rw, ro) => {
|
|
expect(err).to.not.exist
|
|
expect(rw).to.equal(true)
|
|
expect(ro).to.equal(false)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('when no project is found', function() {
|
|
beforeEach(function() {
|
|
this.TokenAccessHandler.getProjectByToken = sinon
|
|
.stub()
|
|
.callsArgWith(2, null, null, null)
|
|
})
|
|
|
|
it('should try to find projects with both kinds of token', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, allowed) => {
|
|
expect(
|
|
this.TokenAccessHandler.getProjectByToken.callCount
|
|
).to.equal(1)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
|
|
it('should not allow any access', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, rw, ro) => {
|
|
expect(err).to.not.exist
|
|
expect(rw).to.equal(false)
|
|
expect(ro).to.equal(false)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('when findProject produces an error', function() {
|
|
beforeEach(function() {
|
|
this.TokenAccessHandler.getProjectByToken = sinon
|
|
.stub()
|
|
.callsArgWith(2, new Error('woops'))
|
|
})
|
|
|
|
it('should try to find projects with both kinds of token', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, allowed) => {
|
|
expect(
|
|
this.TokenAccessHandler.getProjectByToken.callCount
|
|
).to.equal(1)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
|
|
it('should produce an error and not allow access', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, rw, ro) => {
|
|
expect(err).to.exist
|
|
expect(err).to.be.instanceof(Error)
|
|
expect(rw).to.equal(undefined)
|
|
expect(ro).to.equal(undefined)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('when project is not set to token-based access', function() {
|
|
beforeEach(function() {
|
|
return (this.project.publicAccesLevel = 'private')
|
|
})
|
|
|
|
describe('for read-and-write project', function() {
|
|
beforeEach(function() {
|
|
this.TokenAccessHandler.getTokenType = sinon
|
|
.stub()
|
|
.returns('readAndWrite')
|
|
this.TokenAccessHandler.getProjectByToken = sinon
|
|
.stub()
|
|
.callsArgWith(2, null, this.project)
|
|
})
|
|
|
|
it('should not allow any access', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, rw, ro) => {
|
|
expect(err).to.not.exist
|
|
expect(rw).to.equal(false)
|
|
expect(ro).to.equal(false)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('for read-only project', function() {
|
|
beforeEach(function() {
|
|
this.TokenAccessHandler.getTokenType = sinon
|
|
.stub()
|
|
.returns('readOnly')
|
|
this.TokenAccessHandler.getProjectByToken = sinon
|
|
.stub()
|
|
.callsArgWith(2, null, this.project)
|
|
})
|
|
|
|
it('should not allow any access', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
this.token,
|
|
(err, rw, ro) => {
|
|
expect(err).to.not.exist
|
|
expect(rw).to.equal(false)
|
|
expect(ro).to.equal(false)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('with nothing', function() {
|
|
beforeEach(function() {
|
|
this.TokenAccessHandler.getProjectByToken = sinon
|
|
.stub()
|
|
.callsArgWith(1, null, null, null)
|
|
})
|
|
|
|
it('should not allow any access', function(done) {
|
|
return this.TokenAccessHandler.validateTokenForAnonymousAccess(
|
|
this.projectId,
|
|
null,
|
|
(err, rw, ro) => {
|
|
expect(err).to.not.exist
|
|
expect(rw).to.equal(false)
|
|
expect(ro).to.equal(false)
|
|
return done()
|
|
}
|
|
)
|
|
})
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('protectTokens', function() {
|
|
beforeEach(function() {
|
|
return (this.project = {
|
|
tokens: {
|
|
readAndWrite: 'rw',
|
|
readOnly: 'ro',
|
|
readAndWritePrefix: 'pre'
|
|
}
|
|
})
|
|
})
|
|
|
|
it('should hide write token from read-only user', function() {
|
|
this.TokenAccessHandler.protectTokens(this.project, 'readOnly')
|
|
expect(this.project.tokens.readAndWrite).to.equal('')
|
|
expect(this.project.tokens.readAndWritePrefix).to.equal('')
|
|
return expect(this.project.tokens.readOnly).to.equal('ro')
|
|
})
|
|
|
|
it('should hide read token from read-write user', function() {
|
|
this.TokenAccessHandler.protectTokens(this.project, 'readAndWrite')
|
|
expect(this.project.tokens.readAndWrite).to.equal('rw')
|
|
return expect(this.project.tokens.readOnly).to.equal('')
|
|
})
|
|
|
|
it('should leave tokens in place for owner', function() {
|
|
this.TokenAccessHandler.protectTokens(this.project, 'owner')
|
|
expect(this.project.tokens.readAndWrite).to.equal('rw')
|
|
return expect(this.project.tokens.readOnly).to.equal('ro')
|
|
})
|
|
})
|
|
|
|
describe('getDocPublishedInfo', function() {
|
|
beforeEach(function() {
|
|
return (this.callback = sinon.stub())
|
|
})
|
|
|
|
describe('when v1 api not set', function() {
|
|
beforeEach(function() {
|
|
this.settings.apis = { v1: undefined }
|
|
return this.TokenAccessHandler.getV1DocPublishedInfo(
|
|
this.token,
|
|
this.callback
|
|
)
|
|
})
|
|
|
|
it('should not check access and return default info', function() {
|
|
expect(this.V1Api.request.called).to.equal(false)
|
|
return expect(
|
|
this.callback.calledWith(null, {
|
|
allow: true
|
|
})
|
|
).to.equal(true)
|
|
})
|
|
})
|
|
|
|
describe('when v1 api is set', function() {
|
|
beforeEach(function() {
|
|
return (this.settings.apis = { v1: { url: 'v1Url' } })
|
|
})
|
|
|
|
describe('on V1Api.request success', function() {
|
|
beforeEach(function() {
|
|
this.V1Api.request = sinon
|
|
.stub()
|
|
.callsArgWith(1, null, null, 'mock-data')
|
|
return this.TokenAccessHandler.getV1DocPublishedInfo(
|
|
this.token,
|
|
this.callback
|
|
)
|
|
})
|
|
|
|
it('should return response body', function() {
|
|
expect(
|
|
this.V1Api.request.calledWith({
|
|
url: `/api/v1/sharelatex/docs/${this.token}/is_published`
|
|
})
|
|
).to.equal(true)
|
|
return expect(this.callback.calledWith(null, 'mock-data')).to.equal(
|
|
true
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('on V1Api.request error', function() {
|
|
beforeEach(function() {
|
|
this.V1Api.request = sinon.stub().callsArgWith(1, 'error')
|
|
return this.TokenAccessHandler.getV1DocPublishedInfo(
|
|
this.token,
|
|
this.callback
|
|
)
|
|
})
|
|
|
|
it('should callback with error', function() {
|
|
return expect(this.callback.calledWith('error')).to.equal(true)
|
|
})
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('getV1DocInfo', function() {
|
|
beforeEach(function() {
|
|
this.v2UserId = 123
|
|
return (this.callback = sinon.stub())
|
|
})
|
|
|
|
describe('when v1 api not set', function() {
|
|
beforeEach(function() {
|
|
return this.TokenAccessHandler.getV1DocInfo(
|
|
this.token,
|
|
this.v2UserId,
|
|
this.callback
|
|
)
|
|
})
|
|
|
|
it('should not check access and return default info', function() {
|
|
expect(this.V1Api.request.called).to.equal(false)
|
|
return expect(
|
|
this.callback.calledWith(null, {
|
|
exists: true,
|
|
exported: false
|
|
})
|
|
).to.equal(true)
|
|
})
|
|
})
|
|
|
|
describe('when v1 api is set', function() {
|
|
beforeEach(function() {
|
|
return (this.settings.apis = { v1: 'v1' })
|
|
})
|
|
|
|
describe('on UserGetter.getUser success', function() {
|
|
beforeEach(function() {
|
|
this.UserGetter.getUser = sinon.stub().yields(null, {
|
|
overleaf: { id: 1 }
|
|
})
|
|
return this.TokenAccessHandler.getV1DocInfo(
|
|
this.token,
|
|
this.v2UserId,
|
|
this.callback
|
|
)
|
|
})
|
|
|
|
it('should get user', function() {
|
|
return expect(
|
|
this.UserGetter.getUser.calledWith(this.v2UserId)
|
|
).to.equal(true)
|
|
})
|
|
})
|
|
|
|
describe('on UserGetter.getUser error', function() {
|
|
beforeEach(function() {
|
|
this.error = new Error('failed to get user')
|
|
this.UserGetter.getUser = sinon.stub().yields(this.error)
|
|
return this.TokenAccessHandler.getV1DocInfo(
|
|
this.token,
|
|
this.v2UserId,
|
|
this.callback
|
|
)
|
|
})
|
|
|
|
it('should callback with error', function() {
|
|
return expect(this.callback.calledWith(this.error)).to.equal(true)
|
|
})
|
|
})
|
|
|
|
describe('on V1Api.request success', function() {
|
|
beforeEach(function() {
|
|
this.v1UserId = 1
|
|
this.UserGetter.getUser = sinon.stub().yields(null, {
|
|
overleaf: { id: this.v1UserId }
|
|
})
|
|
this.V1Api.request = sinon
|
|
.stub()
|
|
.callsArgWith(1, null, null, 'mock-data')
|
|
return this.TokenAccessHandler.getV1DocInfo(
|
|
this.token,
|
|
this.v2UserId,
|
|
this.callback
|
|
)
|
|
})
|
|
|
|
it('should return response body', function() {
|
|
expect(
|
|
this.V1Api.request.calledWith({
|
|
url: `/api/v1/sharelatex/users/${this.v1UserId}/docs/${
|
|
this.token
|
|
}/info`
|
|
})
|
|
).to.equal(true)
|
|
return expect(this.callback.calledWith(null, 'mock-data')).to.equal(
|
|
true
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('on V1Api.request error', function() {
|
|
beforeEach(function() {
|
|
this.UserGetter.getUser = sinon.stub().yields(null, {
|
|
overleaf: { id: 1 }
|
|
})
|
|
this.V1Api.request = sinon.stub().callsArgWith(1, 'error')
|
|
return this.TokenAccessHandler.getV1DocInfo(
|
|
this.token,
|
|
this.v2UserId,
|
|
this.callback
|
|
)
|
|
})
|
|
|
|
it('should callback with error', function() {
|
|
return expect(this.callback.calledWith('error')).to.equal(true)
|
|
})
|
|
})
|
|
})
|
|
})
|
|
})
|