overleaf/services/web
Antoine Clausse 78a0bc2b05 [web] Convert RecurlyWrapper functions to async (#18384)
* Rename `RecurlyWrapper` to `promises`, as it will only contain the promises soon

* Update `apiRequest`

* Update `_parseXml`

* Update `_parseXmlAndGetAttribute`

* Update `_parse*Xml`

* Update `updateAccountEmailAddress`

* Update `checkAccountExists`

* Update `createAccount`

* Update `createBillingInfo`

* Update `setAddressAndCompanyBillingInfo`

* Update `createSubscription`

* Update `_createPaypalSubscription`

* Update `_handle422Response`

* Update `_createCreditCardSubscription`

* Update `createSubscription`

* Update `getSubscriptions`

* Update `getSubscription`

* Update `getPaginatedEndpoint`

* Update `getAccount`

* Update `getAccountActiveCoupons`

* Update `getCoupon`

* Update `getBillingInfo`

* Update `getAccountPastDueInvoices`

* Update `attemptInvoiceCollection`

* Update `updateSubscription`

* Update `createFixedAmmountCoupon`

* Update `lookupCoupon`

* Update `redeemCoupon`

* Update `extendTrial`

* Update `listAccountActiveSubscriptions`

* To find which functions to add as callbackified, I used this Regex:
`RecurlyWrapper\.(?!promises)[^.\s]*`

And after adding callbackified functions, we're left with no results with the Regex:
`RecurlyWrapper\.(?!promises|apiUrl|_buildXml|_parseXml|attemptInvoiceCollection|createFixedAmmountCoupon|getAccountActiveCoupons|getBillingInfo|getPaginatedEndpoint|getSubscription|updateAccountEmailAddress)[^.\s]*`

* Update unit tests

* Test `getSubscription` both as "promise" and as "callback"

I'm not sure if we want to generalize this.

* Fix: add missing `await`s (!!)

* Change `apiRequest` to reject errors instead of resolving it in an object

* Fixup for CollectPayPalPastDueInvoice test

* Fix: callbackify `getSubscriptions` (!!)

* Replace `.then(...)` chain by multiple `await`

* Fixup `attemptInvoicesCollection`: prevent reading length of undefined

* Use `return await` when returning promises

Per https://github.com/overleaf/internal/pull/18384#pullrequestreview-2065738771

GitOrigin-RevId: ceda755b24fd29f97a27e60ac5db9bc7e369f932
2024-05-27 10:21:26 +00:00
..
.storybook [web] Add with-split-tests util for storybook (#17809) 2024-05-15 08:04:38 +00:00
.vscode
app [web] Convert RecurlyWrapper functions to async (#18384) 2024-05-27 10:21:26 +00:00
bin Merge pull request #15700 from overleaf/gs-verify-cdn-upload 2023-11-10 09:03:51 +00:00
config Merge pull request #18283 from overleaf/bg-session-secret-use-session-secret-in-web 2024-05-14 08:03:57 +00:00
cypress Merge pull request #17127 from overleaf/jdt-wf-loader-tests 2024-04-04 08:05:05 +00:00
data
frontend Merge pull request #18424 from overleaf/ii-delete-with-body-fe 2024-05-21 08:04:48 +00:00
locales auto update translation 2024-05-20 08:04:36 +00:00
migrations Merge pull request #18186 from overleaf/em-migration-dependencies 2024-05-03 08:04:36 +00:00
modules [web] Update revokeAllUserSessions and rename it to removeSessionsFromRedis (#18360) 2024-05-20 08:04:12 +00:00
public Merge pull request #17914 from overleaf/mf-remove-old-homepage-css-rules 2024-05-15 08:05:15 +00:00
scripts [web] Convert RecurlyWrapper functions to async (#18384) 2024-05-27 10:21:26 +00:00
test [web] Convert RecurlyWrapper functions to async (#18384) 2024-05-27 10:21:26 +00:00
transform/o-error
types Merge pull request #17127 from overleaf/jdt-wf-loader-tests 2024-04-04 08:05:05 +00:00
webpack-plugins
.dockerignore
.eastrc
.eslintignore
.eslintrc Merge pull request #17816 from overleaf/bg-eslint-rule-for-find-with-await 2024-05-17 08:04:58 +00:00
.gitignore
.nvmrc Merge pull request #17870 from overleaf/bg-node-upgrade-18-20-2 2024-04-24 08:05:16 +00:00
.prettierignore
.prettierrc
.stylelintrc.json Merge pull request #17309 from overleaf/rd-bootstrap-5-stylelint 2024-05-01 08:04:13 +00:00
app.js Merge pull request #18116 from overleaf/jpa-bulk-replace-localhost 2024-04-26 08:04:39 +00:00
babel.config.json Use more native code instead of Babel polyfills, for performance (#16966) 2024-02-12 09:03:13 +00:00
cloudbuild-storybook-index.html.m4 Move Storybook back into web (#13219) 2023-12-15 09:03:15 +00:00
cloudbuild-storybook.yaml Merge pull request #17870 from overleaf/bg-node-upgrade-18-20-2 2024-04-24 08:05:16 +00:00
cypress.config.ts
docker-compose.ci.yml Merge pull request #16849 from overleaf/hb-issue-16799-mongdodb-v5-to-v6 2024-02-14 09:04:38 +00:00
docker-compose.common.env Merge pull request #18116 from overleaf/jpa-bulk-replace-localhost 2024-04-26 08:04:39 +00:00
docker-compose.cypress.yml Upgrade Cypress to 13.6.6 (#17521) 2024-03-26 09:04:15 +00:00
docker-compose.yml Merge pull request #17870 from overleaf/bg-node-upgrade-18-20-2 2024-04-24 08:05:16 +00:00
Dockerfile Merge pull request #18167 from overleaf/em-simpler-typescript-backend 2024-05-07 08:04:00 +00:00
Dockerfile.frontend Merge pull request #17870 from overleaf/bg-node-upgrade-18-20-2 2024-04-24 08:05:16 +00:00
Dockerfile.frontend.ci
Dockerfile.frontend_ct
i18next-scanner.config.js Merge pull request #18136 from overleaf/jpa-fix-i18n-scanner-glob 2024-04-29 08:04:45 +00:00
install_deps.sh Merge pull request #16859 from overleaf/jpa-sharelatex-cleanup 2024-02-09 09:04:11 +00:00
LICENSE
local-dev.env Move (duplicated) HIBP env var from docker-compose.yml to dev-env env file (#17469) 2024-04-24 08:04:30 +00:00
local-test.env Merge pull request #18116 from overleaf/jpa-bulk-replace-localhost 2024-04-26 08:04:39 +00:00
Makefile Merge pull request #16849 from overleaf/hb-issue-16799-mongdodb-v5-to-v6 2024-02-14 09:04:38 +00:00
Makefile.module Merge pull request #17163 from overleaf/jel-dev-env-tests-mongo 2024-02-19 09:04:32 +00:00
package.json Add uppy subdependencies (#18378) 2024-05-21 08:04:35 +00:00
README.md
tsconfig.backend.json Merge pull request #16385 from overleaf/em-typescript-other-services 2024-01-12 09:03:22 +00:00
tsconfig.json Merge pull request #18167 from overleaf/em-simpler-typescript-backend 2024-05-07 08:04:00 +00:00
webpack.config.dev.js Disable webpack error overlay(s) (#16906) 2024-02-06 09:03:37 +00:00
webpack.config.js Merge pull request #18276 from overleaf/td-bs5-load-js 2024-05-16 08:04:59 +00:00
webpack.config.prod.js

overleaf/web

overleaf/web is the front-end web service of the open-source web-based collaborative LaTeX editor, Overleaf. It serves all the HTML pages, CSS and javascript to the client. overleaf/web also contains a lot of logic around creating and editing projects, and account management.

The rest of the Overleaf stack, along with information about contributing can be found in the overleaf/overleaf repository.

Running the app

The app runs natively using npm and Node on the local system:

$ npm install
$ npm run start

Running Tests

To run all tests run:

make test

To run both unit and acceptance tests for a module run:

make test_module MODULE=overleaf-integration

Unit Tests

The test suites run in Docker.

Unit tests can be run in the test_unit container defined in docker-compose.tests.yml.

The makefile contains a short cut to run these:

make test_unit

During development it is often useful to only run a subset of tests, which can be configured with arguments to the mocha CLI:

make test_unit MOCHA_GREP='AuthorizationManager'

To run only the unit tests for a single module do:

make test_unit_module MODULE=overleaf-integration

Module tests can also use a MOCHA_GREP argument:

make test_unit_module MODULE=overleaf-integration MOCHA_GREP=SSO

Acceptance Tests

Acceptance tests are run against a live service, which runs in the acceptance_test container defined in docker-compose.tests.yml.

To run the tests out-of-the-box, the makefile defines:

make test_acceptance

However, during development it is often useful to leave the service running for rapid iteration on the acceptance tests. This can be done with:

make test_acceptance_app_start_service
make test_acceptance_app_run # Run as many times as needed during development
make test_acceptance_app_stop_service

make test_acceptance just runs these three commands in sequence and then runs make test_acceptance_modules which performs the tests for each module in the modules directory. (Note that there is not currently an equivalent to the -start / -run x n / -stop series for modules.)

During development it is often useful to only run a subset of tests, which can be configured with arguments to the mocha CLI:

make test_acceptance_run MOCHA_GREP='AuthorizationManager'

To run only the acceptance tests for a single module do:

make test_acceptance_module MODULE=overleaf-integration

Module tests can also use a MOCHA_GREP argument:

make test_acceptance_module MODULE=overleaf-integration MOCHA_GREP=SSO

Routes

Run bin/routes to print out all routes in the project.

License and Credits

This project is licensed under the AGPLv3 license

Stylesheets

Overleaf is based on Bootstrap, which is licensed under the MIT license. All modifications (*.less files in public/stylesheets) are also licensed under the MIT license.

Artwork

Silk icon set 1.3

We gratefully acknowledge Mark James for releasing his Silk icon set under the Creative Commons Attribution 2.5 license. Some of these icons are used within Overleaf inside the public/img/silk and public/brand/icons directories.

IconShock icons

We gratefully acknowledge IconShock for use of the icons in the public/img/iconshock directory found via findicons.com