mirror of
https://github.com/overleaf/overleaf.git
synced 2024-11-29 08:03:42 -05:00
aa9d6c8dc9
* [misc] decaff cleanup: RoomManager * [misc] decaff cleanup: RedisClientManager * [misc] decaff cleanup: SafeJsonParse * [misc] decaff cleanup: WebApiManager * [misc] decaff cleanup: WebsocketController * [misc] decaff cleanup: WebsocketLoadBalancer * [misc] decaff cleanup: SessionSockets * [misc] decaff cleanup: HttpController * [misc] decaff cleanup: HttpApiController * [misc] decaff cleanup: HealthCheckManager * [misc] decaff cleanup: EventLogger * [misc] decaff cleanup: Errors o-error will eliminate most of it -- when we migrate over. * [misc] decaff cleanup: DrainManager * [misc] decaff cleanup: DocumentUpdaterManager * [misc] decaff cleanup: DocumentUpdaterController: no-unused-vars * [misc] decaff cleanup: DocumentUpdaterController: Array.from * [misc] decaff cleanup: DocumentUpdaterController: implicit return * [misc] decaff cleanup: DocumentUpdaterController: IIFE * [misc] decaff cleanup: DocumentUpdaterController: null checks * [misc] decaff cleanup: DocumentUpdaterController: simpler loops * [misc] decaff cleanup: DocumentUpdaterController: move module name def * [misc] decaff cleanup: ConnectedUsersManager: handle-callback-err * [misc] decaff cleanup: ConnectedUsersManager: implicit returns * [misc] decaff cleanup: ConnectedUsersManager: null checks * [misc] decaff cleanup: ChannelManager: no-unused-vars * [misc] decaff cleanup: ChannelManager: implicit returns * [misc] decaff cleanup: ChannelManager: other cleanup - var -> const - drop variable assignment before return * [misc] decaff cleanup: AuthorizationManager: handle-callback-err Note: This requires a change in WebsocketController to provide a dummy callback. * [misc] decaff cleanup: AuthorizationManager: Array.from * [misc] decaff cleanup: AuthorizationManager: implicit returns * [misc] decaff cleanup: AuthorizationManager: null checks * [misc] decaff cleanup: Router: handle-callback-err * [misc] decaff cleanup: Router: standard/no-callback-literal * [misc] decaff cleanup: Router: Array.from * [misc] decaff cleanup: Router: implicit returns * [misc] decaff cleanup: Router: refactor __guard__ wrapper * [misc] decaff cleanup: Router: null checks And a minor bug fix: user.id -> user._id * [misc] decaff cleanup: Router: move variable declarations to assignments * [misc] decaff cleanup: app: implicit returns * [misc] decaff cleanup: app: __guard__ * [misc] decaff cleanup: app: null checks * [misc] decaff cleanup: app: function definitions * [misc] decaff cleanup: app: drop unused next argument * [misc] decaff cleanup: app: var -> const
57 lines
1.6 KiB
JavaScript
57 lines
1.6 KiB
JavaScript
/* eslint-disable
|
|
camelcase,
|
|
*/
|
|
|
|
let HttpController
|
|
module.exports = HttpController = {
|
|
// The code in this controller is hard to unit test because of a lot of
|
|
// dependencies on internal socket.io methods. It is not critical to the running
|
|
// of ShareLaTeX, and is only used for getting stats about connected clients,
|
|
// and for checking internal state in acceptance tests. The acceptances tests
|
|
// should provide appropriate coverage.
|
|
_getConnectedClientView(ioClient) {
|
|
const client_id = ioClient.id
|
|
const {
|
|
project_id,
|
|
user_id,
|
|
first_name,
|
|
last_name,
|
|
email,
|
|
connected_time
|
|
} = ioClient.ol_context
|
|
const client = {
|
|
client_id,
|
|
project_id,
|
|
user_id,
|
|
first_name,
|
|
last_name,
|
|
email,
|
|
connected_time
|
|
}
|
|
client.rooms = Object.keys(ioClient.manager.roomClients[client_id] || {})
|
|
// drop the namespace
|
|
.filter((room) => room !== '')
|
|
// room names are composed as '<NAMESPACE>/<ROOM>' and the default
|
|
// namespace is empty (see comments in RoomManager), just drop the '/'
|
|
.map((fullRoomPath) => fullRoomPath.slice(1))
|
|
return client
|
|
},
|
|
|
|
getConnectedClients(req, res) {
|
|
const io = req.app.get('io')
|
|
const ioClients = io.sockets.clients()
|
|
|
|
res.json(ioClients.map(HttpController._getConnectedClientView))
|
|
},
|
|
|
|
getConnectedClient(req, res) {
|
|
const { client_id } = req.params
|
|
const io = req.app.get('io')
|
|
const ioClient = io.sockets.sockets[client_id]
|
|
if (!ioClient) {
|
|
res.sendStatus(404)
|
|
return
|
|
}
|
|
res.json(HttpController._getConnectedClientView(ioClient))
|
|
}
|
|
}
|