mirror of
https://github.com/overleaf/overleaf.git
synced 2024-12-05 07:38:53 -05:00
e41315364d
[web] Fix remaining strict type checks GitOrigin-RevId: 69881c37938f88c7ea4a630f362712a804085bc8
648 lines
18 KiB
TypeScript
648 lines
18 KiB
TypeScript
import {
|
|
render,
|
|
screen,
|
|
fireEvent,
|
|
waitForElementToBeRemoved,
|
|
} from '@testing-library/react'
|
|
import userEvent from '@testing-library/user-event'
|
|
import EmailsSection from '../../../../../../frontend/js/features/settings/components/emails-section'
|
|
import { expect } from 'chai'
|
|
import fetchMock from 'fetch-mock'
|
|
import { UserEmailData } from '../../../../../../types/user-email'
|
|
import { Affiliation } from '../../../../../../types/affiliation'
|
|
|
|
const userEmailData: UserEmailData & { affiliation: Affiliation } = {
|
|
affiliation: {
|
|
cachedConfirmedAt: null,
|
|
cachedEntitlement: null,
|
|
cachedLastDayToReconfirm: null,
|
|
cachedPastReconfirmDate: false,
|
|
cachedReconfirmedAt: null,
|
|
department: 'Art History',
|
|
institution: {
|
|
commonsAccount: false,
|
|
confirmed: true,
|
|
id: 1,
|
|
isUniversity: true,
|
|
maxConfirmationMonths: null,
|
|
name: 'Overleaf',
|
|
ssoEnabled: false,
|
|
ssoBeta: false,
|
|
},
|
|
inReconfirmNotificationPeriod: false,
|
|
inferred: false,
|
|
licence: 'pro_plus',
|
|
pastReconfirmDate: false,
|
|
portal: { slug: '', templates_count: 1 },
|
|
role: 'Reader',
|
|
},
|
|
email: 'baz@overleaf.com',
|
|
default: false,
|
|
}
|
|
|
|
const institutionDomainData = [
|
|
{
|
|
university: {
|
|
id: 1234,
|
|
ssoEnabled: true,
|
|
name: 'Auto Complete University',
|
|
},
|
|
hostname: 'autocomplete.edu',
|
|
confirmed: true,
|
|
},
|
|
] as const
|
|
|
|
function resetFetchMock() {
|
|
fetchMock.reset()
|
|
fetchMock.get('express:/institutions/domains', [])
|
|
}
|
|
|
|
describe('<EmailsSection />', function () {
|
|
beforeEach(function () {
|
|
window.metaAttributesCache.set('ol-ExposedSettings', {
|
|
hasAffiliationsFeature: true,
|
|
hasSamlFeature: true,
|
|
samlInitPath: 'saml/init',
|
|
})
|
|
fetchMock.reset()
|
|
})
|
|
|
|
afterEach(function () {
|
|
window.metaAttributesCache = new Map()
|
|
resetFetchMock()
|
|
})
|
|
|
|
it('renders "add another email" button', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
await fetchMock.flush(true)
|
|
|
|
screen.getByRole('button', { name: /add another email/i })
|
|
})
|
|
|
|
it('renders input', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
const addAnotherEmailBtn = (await screen.findByRole('button', {
|
|
name: /add another email/i,
|
|
})) as HTMLButtonElement
|
|
fireEvent.click(addAnotherEmailBtn)
|
|
|
|
screen.getByLabelText(/email/i)
|
|
})
|
|
|
|
it('renders "Start adding your address" until a valid email is typed', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
const addAnotherEmailBtn = (await screen.findByRole('button', {
|
|
name: /add another email/i,
|
|
})) as HTMLButtonElement
|
|
fireEvent.click(addAnotherEmailBtn)
|
|
|
|
const input = screen.getByLabelText(/email/i)
|
|
|
|
// initially the text is displayed and the "add email" button disabled
|
|
screen.getByText('Start by adding your email address.')
|
|
expect(
|
|
(
|
|
screen.getByRole('button', {
|
|
name: /add new email/i,
|
|
}) as HTMLButtonElement
|
|
).disabled
|
|
).to.be.true
|
|
|
|
// no changes while writing the email address
|
|
fireEvent.change(input, {
|
|
target: { value: 'partial@email' },
|
|
})
|
|
screen.getByText('Start by adding your email address.')
|
|
expect(
|
|
(
|
|
screen.getByRole('button', {
|
|
name: /add new email/i,
|
|
}) as HTMLButtonElement
|
|
).disabled
|
|
).to.be.true
|
|
|
|
// the text is removed when the complete email address is typed, and the "add button" is reenabled
|
|
fireEvent.change(input, {
|
|
target: { value: 'valid@email.com' },
|
|
})
|
|
expect(screen.queryByText('Start by adding your email address.')).to.be.null
|
|
expect(
|
|
(
|
|
screen.getByRole('button', {
|
|
name: /add new email/i,
|
|
}) as HTMLButtonElement
|
|
).disabled
|
|
).to.be.false
|
|
})
|
|
|
|
it('renders "add new email" button', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
const addAnotherEmailBtn = (await screen.findByRole('button', {
|
|
name: /add another email/i,
|
|
})) as HTMLButtonElement
|
|
fireEvent.click(addAnotherEmailBtn)
|
|
|
|
screen.getByRole('button', { name: /add new email/i })
|
|
})
|
|
|
|
it('adds new email address', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
await fetchMock.flush(true)
|
|
resetFetchMock()
|
|
fetchMock
|
|
.get('/user/emails?ensureAffiliation=true', [userEmailData])
|
|
.post('/user/emails', 200)
|
|
|
|
const addAnotherEmailBtn = await screen.findByRole('button', {
|
|
name: /add another email/i,
|
|
})
|
|
|
|
fireEvent.click(addAnotherEmailBtn)
|
|
const input = screen.getByLabelText(/email/i)
|
|
|
|
fireEvent.change(input, {
|
|
target: { value: userEmailData.email },
|
|
})
|
|
|
|
const submitBtn = screen.getByRole('button', {
|
|
name: /add new email/i,
|
|
}) as HTMLButtonElement
|
|
|
|
expect(submitBtn.disabled).to.be.false
|
|
|
|
fireEvent.click(submitBtn)
|
|
|
|
expect(submitBtn.disabled).to.be.true
|
|
|
|
await waitForElementToBeRemoved(() =>
|
|
screen.getByRole('button', {
|
|
name: /add new email/i,
|
|
})
|
|
)
|
|
|
|
screen.getByText(userEmailData.email)
|
|
})
|
|
|
|
it('fails to add add new email address', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
await fetchMock.flush(true)
|
|
resetFetchMock()
|
|
fetchMock
|
|
.get('/user/emails?ensureAffiliation=true', [])
|
|
.post('/user/emails', 400)
|
|
|
|
const addAnotherEmailBtn = screen.getByRole('button', {
|
|
name: /add another email/i,
|
|
})
|
|
|
|
fireEvent.click(addAnotherEmailBtn)
|
|
const input = screen.getByLabelText(/email/i)
|
|
|
|
fireEvent.change(input, {
|
|
target: { value: userEmailData.email },
|
|
})
|
|
|
|
const submitBtn = screen.getByRole('button', {
|
|
name: /add new email/i,
|
|
}) as HTMLButtonElement
|
|
|
|
expect(submitBtn.disabled).to.be.false
|
|
|
|
fireEvent.click(submitBtn)
|
|
|
|
expect(submitBtn.disabled).to.be.true
|
|
|
|
await screen.findByText(
|
|
/Invalid Request. Please correct the data and try again./i
|
|
)
|
|
expect(submitBtn).to.not.be.null
|
|
expect(submitBtn.disabled).to.be.false
|
|
})
|
|
|
|
it('can link email address to an existing SSO institution', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
await fetchMock.flush(true)
|
|
fetchMock.reset()
|
|
fetchMock.get('express:/institutions/domains', institutionDomainData)
|
|
|
|
await userEvent.click(
|
|
screen.getByRole('button', {
|
|
name: /add another email/i,
|
|
})
|
|
)
|
|
|
|
const input = screen.getByLabelText(/email/i)
|
|
fireEvent.change(input, {
|
|
target: { value: 'user@autocomplete.edu' },
|
|
})
|
|
|
|
await screen.findByRole('button', { name: 'Link Accounts and Add Email' })
|
|
})
|
|
|
|
it('adds new email address with existing institution and custom departments', async function () {
|
|
const country = 'Germany'
|
|
const customDepartment = 'Custom department'
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
await fetchMock.flush(true)
|
|
resetFetchMock()
|
|
|
|
await userEvent.click(
|
|
screen.getByRole('button', {
|
|
name: /add another email/i,
|
|
})
|
|
)
|
|
|
|
await userEvent.type(screen.getByLabelText(/email/i), userEmailData.email)
|
|
|
|
await userEvent.click(screen.getByRole('button', { name: /let us know/i }))
|
|
|
|
const universityInput = screen.getByRole('textbox', {
|
|
name: /university/i,
|
|
}) as HTMLInputElement
|
|
|
|
expect(universityInput.disabled).to.be.true
|
|
|
|
fetchMock.get(/\/institutions\/list/, [
|
|
{
|
|
id: userEmailData.affiliation.institution.id,
|
|
name: userEmailData.affiliation.institution.name,
|
|
country_code: 'de',
|
|
departments: [customDepartment],
|
|
},
|
|
])
|
|
|
|
// Select the country from dropdown
|
|
await userEvent.type(
|
|
screen.getByRole('textbox', {
|
|
name: /country/i,
|
|
}),
|
|
country
|
|
)
|
|
await userEvent.click(screen.getByText(country))
|
|
|
|
expect(universityInput.disabled).to.be.false
|
|
|
|
await fetchMock.flush(true)
|
|
resetFetchMock()
|
|
|
|
// Select the university from dropdown
|
|
await userEvent.click(universityInput)
|
|
await userEvent.click(
|
|
screen.getByText(userEmailData.affiliation.institution.name)
|
|
)
|
|
|
|
const roleInput = screen.getByRole('textbox', { name: /role/i })
|
|
await userEvent.type(roleInput, userEmailData.affiliation.role!)
|
|
const departmentInput = screen.getByRole('textbox', { name: /department/i })
|
|
await userEvent.click(departmentInput)
|
|
await userEvent.click(screen.getByText(customDepartment))
|
|
|
|
const userEmailDataCopy = {
|
|
...userEmailData,
|
|
affiliation: {
|
|
...userEmailData.affiliation,
|
|
department: customDepartment,
|
|
},
|
|
}
|
|
|
|
fetchMock
|
|
.get('/user/emails?ensureAffiliation=true', [userEmailDataCopy])
|
|
.post(/\/user\/emails/, 200)
|
|
|
|
await userEvent.click(
|
|
screen.getByRole('button', {
|
|
name: /add new email/i,
|
|
})
|
|
)
|
|
|
|
const [[, request]] = fetchMock.calls(/\/user\/emails/)
|
|
|
|
expect(JSON.parse(request?.body?.toString() || '{}')).to.deep.equal({
|
|
email: userEmailData.email,
|
|
university: {
|
|
id: userEmailData.affiliation?.institution.id,
|
|
},
|
|
role: userEmailData.affiliation?.role,
|
|
department: customDepartment,
|
|
})
|
|
|
|
screen.getByText(userEmailData.email)
|
|
screen.getByText(userEmailData.affiliation.institution.name)
|
|
screen.getByText(userEmailData.affiliation.role!, { exact: false })
|
|
screen.getByText(customDepartment, { exact: false })
|
|
})
|
|
|
|
it('autocompletes institution name', async function () {
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
await fetchMock.flush(true)
|
|
resetFetchMock()
|
|
|
|
fetchMock.get(/\/institutions\/list/, [
|
|
{
|
|
id: 1,
|
|
name: 'University of Bonn',
|
|
},
|
|
{
|
|
id: 2,
|
|
name: 'Bochum institute of Science',
|
|
},
|
|
])
|
|
|
|
// open "add new email" section and click "let us know" to open the Country/University form
|
|
await userEvent.click(
|
|
screen.getByRole('button', {
|
|
name: /add another email/i,
|
|
})
|
|
)
|
|
await userEvent.type(screen.getByLabelText(/email/i), userEmailData.email)
|
|
await userEvent.click(screen.getByRole('button', { name: /let us know/i }))
|
|
|
|
// select a country
|
|
const countryInput = screen.getByRole('textbox', {
|
|
name: /country/i,
|
|
}) as HTMLInputElement
|
|
await userEvent.click(countryInput)
|
|
await userEvent.type(countryInput, 'Germ')
|
|
await userEvent.click(await screen.findByText('Germany'))
|
|
|
|
// match several universities on initial typing
|
|
const universityInput = screen.getByRole('textbox', {
|
|
name: /university/i,
|
|
}) as HTMLInputElement
|
|
await userEvent.click(universityInput)
|
|
await userEvent.type(universityInput, 'bo')
|
|
screen.getByText('University of Bonn')
|
|
screen.getByText('Bochum institute of Science')
|
|
|
|
// match a single university when typing to refine the search
|
|
await userEvent.type(universityInput, 'nn')
|
|
screen.getByText('University of Bonn')
|
|
expect(screen.queryByText('Bochum institute of Science')).to.be.null
|
|
})
|
|
|
|
it('adds new email address without existing institution', async function () {
|
|
const country = 'Germany'
|
|
const countryCode = 'de'
|
|
const newUniversity = 'Abcdef'
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
await fetchMock.flush(true)
|
|
resetFetchMock()
|
|
|
|
await userEvent.click(
|
|
screen.getByRole('button', {
|
|
name: /add another email/i,
|
|
})
|
|
)
|
|
|
|
await userEvent.type(screen.getByLabelText(/email/i), userEmailData.email)
|
|
|
|
await userEvent.click(screen.getByRole('button', { name: /let us know/i }))
|
|
|
|
const universityInput = screen.getByRole('textbox', {
|
|
name: /university/i,
|
|
}) as HTMLInputElement
|
|
|
|
expect(universityInput.disabled).to.be.true
|
|
|
|
fetchMock.get(/\/institutions\/list/, [
|
|
{
|
|
id: userEmailData.affiliation.institution.id,
|
|
name: userEmailData.affiliation.institution.name,
|
|
country_code: 'de',
|
|
departments: [],
|
|
},
|
|
])
|
|
|
|
// Select the country from dropdown
|
|
await userEvent.type(
|
|
screen.getByRole('textbox', {
|
|
name: /country/i,
|
|
}),
|
|
country
|
|
)
|
|
await userEvent.click(screen.getByText(country))
|
|
|
|
expect(universityInput.disabled).to.be.false
|
|
|
|
await fetchMock.flush(true)
|
|
resetFetchMock()
|
|
|
|
// Enter the university manually
|
|
await userEvent.type(universityInput, newUniversity)
|
|
|
|
const roleInput = screen.getByRole('textbox', { name: /role/i })
|
|
await userEvent.type(roleInput, userEmailData.affiliation.role!)
|
|
const departmentInput = screen.getByRole('textbox', { name: /department/i })
|
|
await userEvent.type(departmentInput, userEmailData.affiliation.department!)
|
|
|
|
const userEmailDataCopy = {
|
|
...userEmailData,
|
|
affiliation: {
|
|
...userEmailData.affiliation,
|
|
institution: {
|
|
...userEmailData.affiliation.institution,
|
|
name: newUniversity,
|
|
},
|
|
},
|
|
}
|
|
|
|
fetchMock
|
|
.get('/user/emails?ensureAffiliation=true', [userEmailDataCopy])
|
|
.post(/\/user\/emails/, 200)
|
|
|
|
await userEvent.click(
|
|
screen.getByRole('button', {
|
|
name: /add new email/i,
|
|
})
|
|
)
|
|
|
|
const [[, request]] = fetchMock.calls(/\/user\/emails/)
|
|
|
|
expect(JSON.parse(request?.body?.toString() || '{}')).to.deep.equal({
|
|
email: userEmailData.email,
|
|
university: {
|
|
name: newUniversity,
|
|
country_code: countryCode,
|
|
},
|
|
role: userEmailData.affiliation?.role,
|
|
department: userEmailData.affiliation?.department,
|
|
})
|
|
|
|
screen.getByText(userEmailData.email)
|
|
screen.getByText(newUniversity)
|
|
screen.getByText(userEmailData.affiliation.role!, { exact: false })
|
|
screen.getByText(userEmailData.affiliation.department!, { exact: false })
|
|
})
|
|
|
|
it('shows country, university, role and department fields based on whether `change` was clicked or not', async function () {
|
|
const institutionDomainDataCopy = [
|
|
{
|
|
...institutionDomainData[0],
|
|
university: {
|
|
...institutionDomainData[0].university,
|
|
ssoEnabled: false,
|
|
},
|
|
},
|
|
]
|
|
const hostnameFirstChar = institutionDomainDataCopy[0].hostname.charAt(0)
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
await fetchMock.flush(true)
|
|
fetchMock.reset()
|
|
fetchMock.get(
|
|
`/institutions/domains?hostname=${hostnameFirstChar}&limit=1`,
|
|
institutionDomainDataCopy
|
|
)
|
|
|
|
await userEvent.click(
|
|
screen.getByRole('button', {
|
|
name: /add another email/i,
|
|
})
|
|
)
|
|
|
|
await userEvent.type(
|
|
screen.getByLabelText(/email/i),
|
|
`user@${hostnameFirstChar}`
|
|
)
|
|
|
|
await userEvent.keyboard('{Tab}')
|
|
await fetchMock.flush(true)
|
|
fetchMock.reset()
|
|
|
|
expect(
|
|
screen.queryByRole('textbox', {
|
|
name: /country/i,
|
|
})
|
|
).to.be.null
|
|
expect(
|
|
screen.queryByRole('textbox', {
|
|
name: /university/i,
|
|
})
|
|
).to.be.null
|
|
screen.getByRole('textbox', {
|
|
name: /role/i,
|
|
})
|
|
screen.getByRole('textbox', {
|
|
name: /department/i,
|
|
})
|
|
|
|
await userEvent.click(screen.getByRole('button', { name: /change/i }))
|
|
|
|
screen.getByRole('textbox', {
|
|
name: /country/i,
|
|
})
|
|
screen.getByRole('textbox', {
|
|
name: /university/i,
|
|
})
|
|
expect(
|
|
screen.queryByRole('textbox', {
|
|
name: /role/i,
|
|
})
|
|
).to.be.null
|
|
expect(
|
|
screen.queryByRole('textbox', {
|
|
name: /department/i,
|
|
})
|
|
).to.be.null
|
|
})
|
|
|
|
it('displays institution name with change button when autocompleted and adds new record', async function () {
|
|
const institutionDomainDataCopy = [
|
|
{
|
|
...institutionDomainData[0],
|
|
university: {
|
|
...institutionDomainData[0].university,
|
|
ssoEnabled: false,
|
|
},
|
|
},
|
|
]
|
|
const hostnameFirstChar = institutionDomainDataCopy[0].hostname.charAt(0)
|
|
fetchMock.get('/user/emails?ensureAffiliation=true', [])
|
|
render(<EmailsSection />)
|
|
|
|
await fetchMock.flush(true)
|
|
fetchMock.reset()
|
|
fetchMock.get(
|
|
`/institutions/domains?hostname=${hostnameFirstChar}&limit=1`,
|
|
institutionDomainDataCopy
|
|
)
|
|
|
|
await userEvent.click(
|
|
screen.getByRole('button', {
|
|
name: /add another email/i,
|
|
})
|
|
)
|
|
|
|
await userEvent.type(
|
|
screen.getByLabelText(/email/i),
|
|
`user@${hostnameFirstChar}`
|
|
)
|
|
|
|
await userEvent.keyboard('{Tab}')
|
|
await fetchMock.flush(true)
|
|
fetchMock.reset()
|
|
|
|
screen.getByText(institutionDomainDataCopy[0].university.name)
|
|
|
|
const userEmailDataCopy = {
|
|
...userEmailData,
|
|
affiliation: {
|
|
...userEmailData.affiliation,
|
|
institution: {
|
|
...userEmailData.affiliation.institution,
|
|
name: institutionDomainDataCopy[0].university.name,
|
|
},
|
|
},
|
|
}
|
|
|
|
fetchMock
|
|
.get('/user/emails?ensureAffiliation=true', [userEmailDataCopy])
|
|
.post('/user/emails', 200)
|
|
|
|
await userEvent.type(
|
|
screen.getByRole('textbox', { name: /role/i }),
|
|
userEmailData.affiliation.role!
|
|
)
|
|
await userEvent.type(
|
|
screen.getByRole('textbox', { name: /department/i }),
|
|
userEmailData.affiliation.department!
|
|
)
|
|
await userEvent.click(
|
|
screen.getByRole('button', {
|
|
name: /add new email/i,
|
|
})
|
|
)
|
|
|
|
await fetchMock.flush(true)
|
|
fetchMock.reset()
|
|
|
|
screen.getByText(userEmailDataCopy.affiliation.institution.name, {
|
|
exact: false,
|
|
})
|
|
screen.getByText(userEmailDataCopy.affiliation.role!, { exact: false })
|
|
screen.getByText(userEmailDataCopy.affiliation.department!, {
|
|
exact: false,
|
|
})
|
|
})
|
|
})
|