mirror of
https://github.com/overleaf/overleaf.git
synced 2024-09-23 02:55:13 -04:00
1095851dfe
Sinon does not check the contents of the passed error when checked via
sinon.stub().calledWith.
```
callback = sinon.stub()
callback(new Error("some message"))
.calledWith(new Error("completely different message"))
=== true
```
Cherry-pick plus an additional patch for the joinProject bail-out.
(cherry picked from commit d9570fee70701a5f431c39fdbec5f8bc5a7843fe)
174 lines
6.1 KiB
CoffeeScript
174 lines
6.1 KiB
CoffeeScript
chai = require "chai"
|
|
chai.should()
|
|
expect = chai.expect
|
|
sinon = require("sinon")
|
|
SandboxedModule = require('sandboxed-module')
|
|
path = require "path"
|
|
modulePath = '../../../app/js/AuthorizationManager'
|
|
|
|
describe 'AuthorizationManager', ->
|
|
beforeEach ->
|
|
@client =
|
|
params: {}
|
|
get: (param, cb) ->
|
|
cb null, @params[param]
|
|
set: (param, value, cb) ->
|
|
@params[param] = value
|
|
cb()
|
|
del: (param, cb) ->
|
|
delete @params[param]
|
|
cb()
|
|
|
|
@AuthorizationManager = SandboxedModule.require modulePath, requires: {}
|
|
|
|
describe "assertClientCanViewProject", ->
|
|
it "should allow the readOnly privilegeLevel", (done) ->
|
|
@client.params.privilege_level = "readOnly"
|
|
@AuthorizationManager.assertClientCanViewProject @client, (error) ->
|
|
expect(error).to.be.null
|
|
done()
|
|
|
|
it "should allow the readAndWrite privilegeLevel", (done) ->
|
|
@client.params.privilege_level = "readAndWrite"
|
|
@AuthorizationManager.assertClientCanViewProject @client, (error) ->
|
|
expect(error).to.be.null
|
|
done()
|
|
|
|
it "should allow the owner privilegeLevel", (done) ->
|
|
@client.params.privilege_level = "owner"
|
|
@AuthorizationManager.assertClientCanViewProject @client, (error) ->
|
|
expect(error).to.be.null
|
|
done()
|
|
|
|
it "should return an error with any other privilegeLevel", (done) ->
|
|
@client.params.privilege_level = "unknown"
|
|
@AuthorizationManager.assertClientCanViewProject @client, (error) ->
|
|
error.message.should.equal "not authorized"
|
|
done()
|
|
|
|
describe "assertClientCanEditProject", ->
|
|
it "should not allow the readOnly privilegeLevel", (done) ->
|
|
@client.params.privilege_level = "readOnly"
|
|
@AuthorizationManager.assertClientCanEditProject @client, (error) ->
|
|
error.message.should.equal "not authorized"
|
|
done()
|
|
|
|
it "should allow the readAndWrite privilegeLevel", (done) ->
|
|
@client.params.privilege_level = "readAndWrite"
|
|
@AuthorizationManager.assertClientCanEditProject @client, (error) ->
|
|
expect(error).to.be.null
|
|
done()
|
|
|
|
it "should allow the owner privilegeLevel", (done) ->
|
|
@client.params.privilege_level = "owner"
|
|
@AuthorizationManager.assertClientCanEditProject @client, (error) ->
|
|
expect(error).to.be.null
|
|
done()
|
|
|
|
it "should return an error with any other privilegeLevel", (done) ->
|
|
@client.params.privilege_level = "unknown"
|
|
@AuthorizationManager.assertClientCanEditProject @client, (error) ->
|
|
error.message.should.equal "not authorized"
|
|
done()
|
|
|
|
# check doc access for project
|
|
|
|
describe "assertClientCanViewProjectAndDoc", ->
|
|
beforeEach () ->
|
|
@doc_id = "12345"
|
|
@callback = sinon.stub()
|
|
@client.params = {}
|
|
|
|
describe "when not authorised at the project level", ->
|
|
beforeEach () ->
|
|
@client.params.privilege_level = "unknown"
|
|
|
|
it "should not allow access", () ->
|
|
@AuthorizationManager.assertClientCanViewProjectAndDoc @client, @doc_id, (err) ->
|
|
err.message.should.equal "not authorized"
|
|
|
|
describe "even when authorised at the doc level", ->
|
|
beforeEach (done) ->
|
|
@AuthorizationManager.addAccessToDoc @client, @doc_id, done
|
|
|
|
it "should not allow access", () ->
|
|
@AuthorizationManager.assertClientCanViewProjectAndDoc @client, @doc_id, (err) ->
|
|
err.message.should.equal "not authorized"
|
|
|
|
describe "when authorised at the project level", ->
|
|
beforeEach () ->
|
|
@client.params.privilege_level = "readOnly"
|
|
|
|
describe "and not authorised at the document level", ->
|
|
it "should not allow access", () ->
|
|
@AuthorizationManager.assertClientCanViewProjectAndDoc @client, @doc_id, (err) ->
|
|
err.message.should.equal "not authorized"
|
|
|
|
describe "and authorised at the document level", ->
|
|
beforeEach (done) ->
|
|
@AuthorizationManager.addAccessToDoc @client, @doc_id, done
|
|
|
|
it "should allow access", () ->
|
|
@AuthorizationManager.assertClientCanViewProjectAndDoc @client, @doc_id, @callback
|
|
@callback
|
|
.calledWith(null)
|
|
.should.equal true
|
|
|
|
describe "when document authorisation is added and then removed", ->
|
|
beforeEach (done) ->
|
|
@AuthorizationManager.addAccessToDoc @client, @doc_id, () =>
|
|
@AuthorizationManager.removeAccessToDoc @client, @doc_id, done
|
|
|
|
it "should deny access", () ->
|
|
@AuthorizationManager.assertClientCanViewProjectAndDoc @client, @doc_id, (err) ->
|
|
err.message.should.equal "not authorized"
|
|
|
|
describe "assertClientCanEditProjectAndDoc", ->
|
|
beforeEach () ->
|
|
@doc_id = "12345"
|
|
@callback = sinon.stub()
|
|
@client.params = {}
|
|
|
|
describe "when not authorised at the project level", ->
|
|
beforeEach () ->
|
|
@client.params.privilege_level = "readOnly"
|
|
|
|
it "should not allow access", () ->
|
|
@AuthorizationManager.assertClientCanEditProjectAndDoc @client, @doc_id, (err) ->
|
|
err.message.should.equal "not authorized"
|
|
|
|
describe "even when authorised at the doc level", ->
|
|
beforeEach (done) ->
|
|
@AuthorizationManager.addAccessToDoc @client, @doc_id, done
|
|
|
|
it "should not allow access", () ->
|
|
@AuthorizationManager.assertClientCanEditProjectAndDoc @client, @doc_id, (err) ->
|
|
err.message.should.equal "not authorized"
|
|
|
|
describe "when authorised at the project level", ->
|
|
beforeEach () ->
|
|
@client.params.privilege_level = "readAndWrite"
|
|
|
|
describe "and not authorised at the document level", ->
|
|
it "should not allow access", () ->
|
|
@AuthorizationManager.assertClientCanEditProjectAndDoc @client, @doc_id, (err) ->
|
|
err.message.should.equal "not authorized"
|
|
|
|
describe "and authorised at the document level", ->
|
|
beforeEach (done) ->
|
|
@AuthorizationManager.addAccessToDoc @client, @doc_id, done
|
|
|
|
it "should allow access", () ->
|
|
@AuthorizationManager.assertClientCanEditProjectAndDoc @client, @doc_id, @callback
|
|
@callback
|
|
.calledWith(null)
|
|
.should.equal true
|
|
|
|
describe "when document authorisation is added and then removed", ->
|
|
beforeEach (done) ->
|
|
@AuthorizationManager.addAccessToDoc @client, @doc_id, () =>
|
|
@AuthorizationManager.removeAccessToDoc @client, @doc_id, done
|
|
|
|
it "should deny access", () ->
|
|
@AuthorizationManager.assertClientCanEditProjectAndDoc @client, @doc_id, (err) ->
|
|
err.message.should.equal "not authorized"
|