mirror of
https://github.com/overleaf/overleaf.git
synced 2024-11-07 20:31:06 -05:00
6ea0b9cf46
Fix multiple callback and silent failures on institutions controller GitOrigin-RevId: 2883445a4d960e7aca2dfbab45b8e268437e4769
82 lines
2.7 KiB
CoffeeScript
82 lines
2.7 KiB
CoffeeScript
should = require('chai').should()
|
|
SandboxedModule = require('sandboxed-module')
|
|
assert = require('assert')
|
|
path = require('path')
|
|
sinon = require('sinon')
|
|
modulePath = path.join __dirname, "../../../../app/js/Features/Institutions/InstitutionsController"
|
|
expect = require("chai").expect
|
|
|
|
describe "InstitutionsController", ->
|
|
|
|
beforeEach ->
|
|
@logger = err: sinon.stub(), log: ->
|
|
@host = "mit.edu".split('').reverse().join('')
|
|
@stubbedUser1 =
|
|
_id: "3131231"
|
|
name:"bob"
|
|
email:"hello@world.com"
|
|
emails: [
|
|
{"email":"stubb1@mit.edu","reversedHostname":@host},
|
|
{"email":"test@test.com","reversedHostname":"test.com"},
|
|
{"email":"another@mit.edu","reversedHostname":@host}
|
|
]
|
|
@stubbedUser2 =
|
|
_id: "3131232"
|
|
name:"test"
|
|
email:"hello2@world.com"
|
|
emails: [
|
|
{"email":"subb2@mit.edu","reversedHostname":@host}
|
|
]
|
|
|
|
@getUsersByHostname = sinon.stub().callsArgWith(2, null, [ @stubbedUser1, @stubbedUser2 ])
|
|
@addAffiliation = sinon.stub().callsArgWith(3, null)
|
|
@InstitutionsController = SandboxedModule.require modulePath, requires:
|
|
'logger-sharelatex': @logger
|
|
'../User/UserGetter':
|
|
getUsersByHostname: @getUsersByHostname
|
|
'../Institutions/InstitutionsAPI':
|
|
addAffiliation: @addAffiliation
|
|
'../../models/Institution': Institution: @Institution =
|
|
findOneAndUpdate: sinon.stub().yields()
|
|
|
|
@req =
|
|
body: hostname: 'mit.edu'
|
|
|
|
@res =
|
|
send: sinon.stub()
|
|
json: sinon.stub()
|
|
@next = sinon.stub()
|
|
|
|
describe 'affiliateUsers', ->
|
|
it 'should add affiliations for matching users', (done)->
|
|
@res.sendStatus = (code) =>
|
|
code.should.equal 200
|
|
@getUsersByHostname.calledOnce.should.equal true
|
|
@addAffiliation.calledThrice.should.equal true
|
|
@addAffiliation.calledWith(@stubbedUser1._id, @stubbedUser1.emails[0].email).should.equal true
|
|
@addAffiliation.calledWith(@stubbedUser1._id, @stubbedUser1.emails[2].email).should.equal true
|
|
@addAffiliation.calledWith(@stubbedUser2._id, @stubbedUser2.emails[0].email).should.equal true
|
|
done()
|
|
@InstitutionsController.confirmDomain @req, @res, @next
|
|
|
|
it 'should return errors if last affiliation cannot be added', (done)->
|
|
@addAffiliation.onCall(2).callsArgWith(3, new Error("error"))
|
|
@next = (error) =>
|
|
expect(error).to.exist
|
|
@getUsersByHostname.calledOnce.should.equal true
|
|
done()
|
|
@InstitutionsController.confirmDomain @req, @res, @next
|
|
|
|
describe 'createInstitution', ->
|
|
it 'should create new institution', (done)->
|
|
@req.body.institution_id = 123
|
|
expectedData = v1Id: 123
|
|
@res.sendStatus = (code) =>
|
|
sinon.assert.calledWith(
|
|
@Institution.findOneAndUpdate,
|
|
expectedData,
|
|
expectedData,
|
|
{ upsert: true }
|
|
)
|
|
done()
|
|
@InstitutionsController.confirmDomain @req, @res, @next
|