mirror of
https://github.com/overleaf/overleaf.git
synced 2024-11-07 20:31:06 -05:00
1437877b5a
Aims to solve following problems which are currently not visible to user: - project is too big, which files are worst offenders? - when there are duplicate file names so an 'old' version keeps overrighting a new version - when a file has the same path as a folder which blows up clsi i.e. images/research images/research/1.png
413 lines
13 KiB
CoffeeScript
413 lines
13 KiB
CoffeeScript
sinon = require('sinon')
|
|
chai = require('chai')
|
|
should = chai.should()
|
|
expect = chai.expect
|
|
modulePath = "../../../../app/js/Features/Compile/ClsiManager.js"
|
|
SandboxedModule = require('sandboxed-module')
|
|
|
|
describe "ClsiManager", ->
|
|
beforeEach ->
|
|
@jar = {cookie:"stuff"}
|
|
@ClsiCookieManager =
|
|
getCookieJar: sinon.stub().callsArgWith(1, null, @jar)
|
|
setServerId: sinon.stub().callsArgWith(2)
|
|
_getServerId:sinon.stub()
|
|
@ClsiManager = SandboxedModule.require modulePath, requires:
|
|
"settings-sharelatex": @settings =
|
|
apis:
|
|
filestore:
|
|
url: "filestore.example.com"
|
|
secret: "secret"
|
|
clsi:
|
|
url: "http://clsi.example.com"
|
|
clsi_priority:
|
|
url: "https://clsipremium.example.com"
|
|
"../../models/Project": Project: @Project = {}
|
|
"../Project/ProjectEntityHandler": @ProjectEntityHandler = {}
|
|
"./ClsiCookieManager": @ClsiCookieManager
|
|
"logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub(), warn: sinon.stub() }
|
|
"request": @request = sinon.stub()
|
|
@project_id = "project-id"
|
|
@callback = sinon.stub()
|
|
|
|
describe "sendRequest", ->
|
|
beforeEach ->
|
|
@ClsiManager._buildRequest = sinon.stub().callsArgWith(2, null, @request = "mock-request")
|
|
@ClsiCookieManager._getServerId.callsArgWith(1, null, "clsi3")
|
|
|
|
describe "with a successful compile", ->
|
|
beforeEach ->
|
|
@ClsiManager._postToClsi = sinon.stub().callsArgWith(3, null, {
|
|
compile:
|
|
status: @status = "success"
|
|
outputFiles: [{
|
|
url: "#{@settings.apis.clsi.url}/project/#{@project_id}/output/output.pdf"
|
|
type: "pdf"
|
|
build: 1234
|
|
},{
|
|
url: "#{@settings.apis.clsi.url}/project/#{@project_id}/output/output.log"
|
|
type: "log"
|
|
build: 1234
|
|
}]
|
|
})
|
|
@ClsiManager.sendRequest @project_id, {compileGroup:"standard"}, @callback
|
|
|
|
it "should build the request", ->
|
|
@ClsiManager._buildRequest
|
|
.calledWith(@project_id)
|
|
.should.equal true
|
|
|
|
it "should send the request to the CLSI", ->
|
|
@ClsiManager._postToClsi
|
|
.calledWith(@project_id, @request, "standard")
|
|
.should.equal true
|
|
|
|
it "should call the callback with the status and output files", ->
|
|
outputFiles = [{
|
|
path: "output.pdf"
|
|
type: "pdf"
|
|
build: 1234
|
|
},{
|
|
path: "output.log"
|
|
type: "log"
|
|
build: 1234
|
|
}]
|
|
@callback.calledWith(null, @status, outputFiles).should.equal true
|
|
|
|
describe "with a failed compile", ->
|
|
beforeEach ->
|
|
@ClsiManager._postToClsi = sinon.stub().callsArgWith(3, null, {
|
|
compile:
|
|
status: @status = "failure"
|
|
})
|
|
@ClsiManager.sendRequest @project_id, {}, @callback
|
|
|
|
it "should call the callback with a failure statue", ->
|
|
@callback.calledWith(null, @status).should.equal true
|
|
|
|
describe "deleteAuxFiles", ->
|
|
beforeEach ->
|
|
@ClsiManager._makeRequest = sinon.stub().callsArg(2)
|
|
|
|
describe "with the standard compileGroup", ->
|
|
beforeEach ->
|
|
@ClsiManager.deleteAuxFiles @project_id, {compileGroup: "standard"}, @callback
|
|
|
|
it "should call the delete method in the standard CLSI", ->
|
|
@ClsiManager._makeRequest
|
|
.calledWith(@project_id, { method:"DELETE", url:"#{@settings.apis.clsi.url}/project/#{@project_id}"})
|
|
.should.equal true
|
|
|
|
it "should call the callback", ->
|
|
@callback.called.should.equal true
|
|
|
|
|
|
describe "_buildRequest", ->
|
|
beforeEach ->
|
|
@project =
|
|
_id: @project_id
|
|
compiler: @compiler = "latex"
|
|
rootDoc_id: "mock-doc-id-1"
|
|
imageName: @image = "mock-image-name"
|
|
|
|
@docs = {
|
|
"/main.tex": @doc_1 = {
|
|
name: "main.tex"
|
|
_id: "mock-doc-id-1"
|
|
lines: ["Hello", "world"]
|
|
},
|
|
"/chapters/chapter1.tex": @doc_2 = {
|
|
name: "chapter1.tex"
|
|
_id: "mock-doc-id-2"
|
|
lines: [
|
|
"Chapter 1"
|
|
]
|
|
}
|
|
}
|
|
|
|
@files = {
|
|
"/images/image.png": @file_1 = {
|
|
name: "image.png"
|
|
_id: "mock-file-id-1"
|
|
created: new Date()
|
|
}
|
|
}
|
|
|
|
@Project.findById = sinon.stub().callsArgWith(2, null, @project)
|
|
@ProjectEntityHandler.getAllDocs = sinon.stub().callsArgWith(1, null, @docs)
|
|
@ProjectEntityHandler.getAllFiles = sinon.stub().callsArgWith(1, null, @files)
|
|
|
|
describe "with a valid project", ->
|
|
beforeEach (done) ->
|
|
@ClsiManager._buildRequest @project_id, {timeout:100}, (error, request) =>
|
|
@request = request
|
|
done()
|
|
|
|
it "should get the project with the required fields", ->
|
|
@Project.findById
|
|
.calledWith(@project_id, {compiler:1, rootDoc_id: 1, imageName: 1})
|
|
.should.equal true
|
|
|
|
it "should get all the docs", ->
|
|
@ProjectEntityHandler.getAllDocs
|
|
.calledWith(@project_id)
|
|
.should.equal true
|
|
|
|
it "should get all the files", ->
|
|
@ProjectEntityHandler.getAllFiles
|
|
.calledWith(@project_id)
|
|
.should.equal true
|
|
|
|
it "should build up the CLSI request", ->
|
|
expect(@request).to.deep.equal(
|
|
compile:
|
|
options:
|
|
compiler: @compiler
|
|
timeout : 100
|
|
imageName: @image
|
|
draft: false
|
|
rootResourcePath: "main.tex"
|
|
resources: [{
|
|
path: "main.tex"
|
|
content: @doc_1.lines.join("\n")
|
|
}, {
|
|
path: "chapters/chapter1.tex"
|
|
content: @doc_2.lines.join("\n")
|
|
}, {
|
|
path: "images/image.png"
|
|
url: "#{@settings.apis.filestore.url}/project/#{@project_id}/file/#{@file_1._id}"
|
|
modified: @file_1.created.getTime()
|
|
}]
|
|
)
|
|
|
|
|
|
describe "when root doc override is valid", ->
|
|
beforeEach (done) ->
|
|
@ClsiManager._buildRequest @project_id, {rootDoc_id:"mock-doc-id-2"}, (error, request) =>
|
|
@request = request
|
|
done()
|
|
|
|
it "should change root path", ->
|
|
@request.compile.rootResourcePath.should.equal "chapters/chapter1.tex"
|
|
|
|
|
|
describe "when root doc override is invalid", ->
|
|
beforeEach (done) ->
|
|
@ClsiManager._buildRequest @project_id, {rootDoc_id:"invalid-id"}, (error, request) =>
|
|
@request = request
|
|
done()
|
|
|
|
it "should fallback to default root doc", ->
|
|
@request.compile.rootResourcePath.should.equal "main.tex"
|
|
|
|
|
|
|
|
describe "when the project has an invalid compiler", ->
|
|
beforeEach (done) ->
|
|
@project.compiler = "context"
|
|
@ClsiManager._buildRequest @project, null, (error, request) =>
|
|
@request = request
|
|
done()
|
|
|
|
it "should set the compiler to pdflatex", ->
|
|
@request.compile.options.compiler.should.equal "pdflatex"
|
|
|
|
describe "when there is no valid root document", ->
|
|
beforeEach (done) ->
|
|
@project.rootDoc_id = "not-valid"
|
|
@ClsiManager._buildRequest @project, null, (@error, @request) =>
|
|
done()
|
|
|
|
it "should set to main.tex", ->
|
|
@request.compile.rootResourcePath.should.equal "main.tex"
|
|
|
|
describe "with the draft option", ->
|
|
it "should add the draft option into the request", (done) ->
|
|
@ClsiManager._buildRequest @project_id, {timeout:100, draft: true}, (error, request) =>
|
|
request.compile.options.draft.should.equal true
|
|
done()
|
|
|
|
|
|
describe '_postToClsi', ->
|
|
beforeEach ->
|
|
@req = { mock: "req" }
|
|
|
|
describe "successfully", ->
|
|
beforeEach ->
|
|
@ClsiManager._makeRequest = sinon.stub().callsArgWith(2, null, {statusCode: 204}, @body = { mock: "foo" })
|
|
@ClsiManager._postToClsi @project_id, @req, "standard", @callback
|
|
|
|
it 'should send the request to the CLSI', ->
|
|
url = "#{@settings.apis.clsi.url}/project/#{@project_id}/compile"
|
|
@ClsiManager._makeRequest.calledWith(@project_id, {
|
|
method: "POST",
|
|
url: url
|
|
json: @req
|
|
}).should.equal true
|
|
|
|
it "should call the callback with the body and no error", ->
|
|
@callback.calledWith(null, @body).should.equal true
|
|
|
|
describe "when the CLSI returns an error", ->
|
|
beforeEach ->
|
|
@ClsiManager._makeRequest = sinon.stub().callsArgWith(2, null, {statusCode: 500}, @body = { mock: "foo" })
|
|
@ClsiManager._postToClsi @project_id, @req, "standard", @callback
|
|
|
|
it "should call the callback with the body and the error", ->
|
|
@callback.calledWith(new Error("CLSI returned non-success code: 500"), @body).should.equal true
|
|
|
|
|
|
describe "wordCount", ->
|
|
beforeEach ->
|
|
@ClsiManager._makeRequest = sinon.stub().callsArgWith(2, null, {statusCode: 200}, @body = { mock: "foo" })
|
|
@ClsiManager._buildRequest = sinon.stub().callsArgWith(2, null, @req = { compile: { rootResourcePath: "rootfile.text", options: {} } })
|
|
@ClsiManager._getCompilerUrl = sinon.stub().returns "compiler.url"
|
|
|
|
describe "with root file", ->
|
|
beforeEach ->
|
|
@ClsiManager.wordCount @project_id, false, {}, @callback
|
|
|
|
it "should call wordCount with root file", ->
|
|
@ClsiManager._makeRequest
|
|
.calledWith(@project_id, { method: "GET", url: "compiler.url/project/#{@project_id}/wordcount?file=rootfile.text" })
|
|
.should.equal true
|
|
|
|
it "should call the callback", ->
|
|
@callback.called.should.equal true
|
|
|
|
describe "with param file", ->
|
|
beforeEach ->
|
|
@ClsiManager.wordCount @project_id, "main.tex", {}, @callback
|
|
|
|
it "should call wordCount with param file", ->
|
|
@ClsiManager._makeRequest
|
|
.calledWith(@project_id, { method: "GET", url: "compiler.url/project/#{@project_id}/wordcount?file=main.tex" })
|
|
.should.equal true
|
|
|
|
describe "with image", ->
|
|
beforeEach ->
|
|
@req.compile.options.imageName = @image = "example.com/mock/image"
|
|
@ClsiManager.wordCount @project_id, "main.tex", {}, @callback
|
|
|
|
it "should call wordCount with file and image", ->
|
|
@ClsiManager._makeRequest
|
|
.calledWith(@project_id, { method: "GET", url: "compiler.url/project/#{@project_id}/wordcount?file=main.tex&image=#{encodeURIComponent(@image)}" })
|
|
.should.equal true
|
|
|
|
|
|
|
|
describe "_makeRequest", ->
|
|
|
|
beforeEach ->
|
|
@response = {there:"something"}
|
|
@request.callsArgWith(1, null, @response)
|
|
@opts =
|
|
method: "SOMETHIGN"
|
|
url: "http://a place on the web"
|
|
|
|
it "should process a request with a cookie jar", (done)->
|
|
@ClsiManager._makeRequest @project_id, @opts, =>
|
|
args = @request.args[0]
|
|
args[0].method.should.equal @opts.method
|
|
args[0].url.should.equal @opts.url
|
|
args[0].jar.should.equal @jar
|
|
done()
|
|
|
|
it "should set the cookie again on response as it might have changed", (done)->
|
|
@ClsiManager._makeRequest @project_id, @opts, =>
|
|
@ClsiCookieManager.setServerId.calledWith(@project_id, @response).should.equal true
|
|
done()
|
|
|
|
|
|
|
|
describe "_checkRecoursesForErrors", ->
|
|
|
|
beforeEach ->
|
|
@resources = [{
|
|
path: "main.tex"
|
|
content: ["stuff"]
|
|
}, {
|
|
path: "chapters/chapter1"
|
|
content: ["other stuff"]
|
|
}, {
|
|
path: "stuff/image/image.png"
|
|
url: "#{@settings.apis.filestore.url}/project/#{@project_id}/file/1234124321312"
|
|
modified: ["more stuff"]
|
|
}]
|
|
|
|
it "should call _checkForFilesWithSameName and _checkForConflictingPaths", (done)->
|
|
|
|
@ClsiManager._checkForFilesWithSameName = sinon.stub().callsArgWith(1)
|
|
@ClsiManager._checkForConflictingPaths = sinon.stub().callsArgWith(1)
|
|
@ClsiManager._checkDocsAreUnderSizeLimit = sinon.stub().callsArgWith(1)
|
|
@ClsiManager._checkRecoursesForErrors @resources, =>
|
|
@ClsiManager._checkForFilesWithSameName.called.should.equal true
|
|
@ClsiManager._checkForConflictingPaths.called.should.equal true
|
|
@ClsiManager._checkDocsAreUnderSizeLimit.called.should.equal true
|
|
done()
|
|
|
|
describe "_checkForFilesWithSameName", ->
|
|
|
|
it "should flag up 2 nested files with same path", (done)->
|
|
|
|
@resources.push({
|
|
path: "chapters/chapter1"
|
|
url: "http://somwhere.com"
|
|
})
|
|
|
|
@ClsiManager._checkForFilesWithSameName @resources, (err, duplicateErrors)->
|
|
duplicateErrors.length.should.equal 1
|
|
duplicateErrors[0].path.should.equal "chapters/chapter1"
|
|
done()
|
|
|
|
describe "_checkForConflictingPaths", ->
|
|
|
|
it "should flag up when a nested file has folder with same subpath as file elsewhere", (done)->
|
|
@resources.push({
|
|
path: "stuff/image"
|
|
url: "http://somwhere.com"
|
|
})
|
|
|
|
@resources.push({
|
|
path: "chapters/chapter1.tex"
|
|
content: ["other stuff"]
|
|
})
|
|
|
|
@resources.push({
|
|
path: "chapters.tex"
|
|
content: ["other stuff"]
|
|
})
|
|
|
|
@ClsiManager._checkForConflictingPaths @resources, (err, conflictPathErrors)->
|
|
conflictPathErrors.length.should.equal 1
|
|
conflictPathErrors[0].path.should.equal "stuff/image"
|
|
done()
|
|
|
|
|
|
describe "_checkDocsAreUnderSizeLimit", ->
|
|
|
|
it "should error when there is more than 2mb of data", (done)->
|
|
|
|
@resources.push({
|
|
path: "massive.tex"
|
|
content: [require("crypto").randomBytes(1000 * 1000 * 5).toString("hex")]
|
|
})
|
|
|
|
while @resources.length < 20
|
|
@resources.push({path:"chapters/chapter1.tex",url: "http://somwhere.com"})
|
|
|
|
@ClsiManager._checkDocsAreUnderSizeLimit @resources, (err, sizeError)->
|
|
sizeError.tooLarge.should.equal true
|
|
sizeError.totalSize.should.equal 10000016
|
|
sizeError.resources.length.should.equal 10
|
|
sizeError.resources[0].path.should.equal "massive.tex"
|
|
sizeError.resources[0].size.should.equal 1000 * 1000 * 10
|
|
done()
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|