github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity
overleaf/services/web/scripts
History
Antoine Clausse 9419cc3b37 [web] Add tests to collect_paypal_past_due_invoice.js + update logging (#18310) 
* Fix: Invoices collected array length comparison

Update the code with the correct condition to respect the intent of the previous implementation ("exit with non zero code when no invoicess were processed").
See 5476f39984

However, I'm not sure if erroring when no invoices are collected is actually what we want to do.

* Wrap `collect_paypal_past_due_invoice` script and export the function

* Fixup typo `accoutns`

* Log invoices collection data before throwing

* Add note: `handleAPIError` is silencing the errors

* Create a test on `collect_paypal_past_due_invoice`

* Replace `console.log` by `@overleaf/logger` (bunyan)

Our `console.warn` show up as Errors (in red) in GCP. For example the following is an error in GCP:
```
Errors in attemptInvoiceCollection with id=2693634 OError: Recurly API returned with status code: 400
```
https://github.com/overleaf/internal/blob/5476f39/services/web/scripts/recurly/collect_paypal_past_due_invoice.js#L9

---

Does it correctly set the levels as warnings if we use `@overleaf/logger`

GitOrigin-RevId: 37c8bdf4afd8cef4706700aafb44480ec8966a74
2024-05-15 08:04:46 +00:00
..
analytics Merge pull request #17525 from overleaf/ae-upgrade-prettier 2024-03-26 09:04:05 +00:00
delete-duplicate-splittest-versions Merge pull request #13349 from overleaf/jdt-delete-splittest-version-dupes 2023-07-17 10:38:31 +00:00
delete-orphaned-docs Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
example
helpers Merge pull request #17926 from overleaf/jpa-batched-update-sorting 2024-04-17 08:04:09 +00:00
history Merge pull request #14198 from overleaf/jpa-history-migration 2023-08-11 08:04:01 +00:00
learn/checkSanitize Merge pull request #13760 from overleaf/em-fetch-utils-web 2023-07-17 11:02:40 +00:00
lezer-latex Merge pull request #14991 from overleaf/jpa-log-tree 2023-09-28 08:04:17 +00:00
oauth Merge pull request #17457 from overleaf/dp-local-collabratec-helpers 2024-03-26 09:04:00 +00:00
plan-prices [web] Use localized number formatting for currencies (#17622) 2024-04-19 08:03:54 +00:00
recurly [web] Add tests to collect_paypal_past_due_invoice.js + update logging (#18310) 2024-05-15 08:04:46 +00:00
sync-user-entitlements
translations Merge pull request #17870 from overleaf/bg-node-upgrade-18-20-2 2024-04-24 08:05:16 +00:00
ukamf Merge pull request #16948 from overleaf/jpa-rails-sharelatex-rebranding-step-2 2024-02-13 09:03:35 +00:00
add_feature_override.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
add_notification_ieee_collabratec_users.js Merge pull request #17586 from overleaf/dp-fix-IEEE-script 2024-03-20 09:03:06 +00:00
add_user_count_to_csv.js Merge pull request #14610 from overleaf/bg-filter-csv-by-registered-user-domains 2023-09-04 08:05:03 +00:00
back_fill_deleted_files.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
back_fill_doc_name_for_deleted_docs.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
back_fill_doc_rev.js Merge pull request #12277 from overleaf/jpa-cleanup-batched-update-interface 2023-03-23 09:04:29 +00:00
back_fill_dummy_doc_meta.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
back_fill_staff_access.js Merge pull request #12575 from overleaf/em-fix-chunk-replace-transaction 2023-04-19 08:03:10 +00:00
back_fill_warning_user_personal_and_group_subscription.js Merge pull request #15044 from overleaf/mf-send-warning-to-users-with-personal-and-group-subscriptions 2023-10-18 08:05:04 +00:00
backfill_mixpanel_user_properties.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
backfill_project_image_name.js
backfill_user_properties.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
backfill_users_sso_attribute.js
bench_bcrypt.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
check_institution_users.js
check_saml_emails.js
clear_feedback_collection.js
clear_institution_notifications.js
clear_project_tokens.js
clear_sessions_2fa.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
clear_sessions_set_must_reconfirm.js
confirmed_at_to_dates.js
convert_archived_state.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
convert_doc_to_file.js
count_encrypted_access_tokens.js Merge pull request #12575 from overleaf/em-fix-chunk-replace-transaction 2023-04-19 08:03:10 +00:00
count_files_in_projects.js
count_image_files.js Merge pull request #12575 from overleaf/em-fix-chunk-replace-transaction 2023-04-19 08:03:10 +00:00
count_project_size.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
create_oauth_personal_access_token.js [web] Issue Oauth2 access tokens (#12788) 2023-04-28 08:04:10 +00:00
create_project.js Merge pull request #11593 from overleaf/bg-create-project-with-random-history 2023-02-02 18:22:09 +00:00
delete_dangling_file_refs.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
delete_orphaned_chat_threads.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
delete_orphaned_data_helper.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
delete_orphaned_doc_comment_ranges.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
delete_orphaned_docs_online_check.js Merge pull request #17525 from overleaf/ae-upgrade-prettier 2024-03-26 09:04:05 +00:00
delete_subscriptions.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
disconnect_all_users.js Merge pull request #15923 from overleaf/jpa-tweak-delay-in-seconds 2023-11-27 09:04:02 +00:00
ensure_affiliations.js
extract_onboardingdatacollection_csv.js Create a script to extract OnboardingDataCollection (#17657) 2024-03-28 09:04:33 +00:00
find_malformed_filetrees.js Merge pull request #12575 from overleaf/em-fix-chunk-replace-transaction 2023-04-19 08:03:10 +00:00
fix_group_invite_emails_to_lowercase.js Merge pull request #12277 from overleaf/jpa-cleanup-batched-update-interface 2023-03-23 09:04:29 +00:00
fix_malformed_filetree.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
fix_oversized_docs.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
force_doc_flush.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
inst_table.js
invalidate_tokens.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
mark_migration.js
merge_group_subscription_members.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
migrate_audit_logs.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
process_lapsed_reconfirmations.js
purge_non_logged_in_sessions.js Merge pull request #17291 from overleaf/bg-purge-non-logged-in-sessions 2024-02-27 17:02:10 +00:00
recover_docs_from_redis.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
refresh_features.js
refresh_institution_users.js
regenerate_duplicate_referral_ids.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
remove_deleted_users_from_token_access_refs.js add missing token access fields to projects (#17372) 2024-03-06 17:27:26 +00:00
remove_email.js
remove_oauth_application.js Merge pull request #11960 from overleaf/jk-script-to-remove-oauth-application 2023-03-01 09:02:59 +00:00
remove_unwanted_ieee_collabratec_users.js Merge pull request #17645 from overleaf/dp-ac-ieee-deprecation-script-remove-users 2024-03-29 09:04:17 +00:00
restore_orphaned_docs.js Merge pull request #12409 from overleaf/bg-restore-orphaned-docs 2023-03-30 08:03:59 +00:00
restore_soft_deleted_docs.js Merge pull request #17525 from overleaf/ae-upgrade-prettier 2024-03-26 09:04:05 +00:00
set_tex_live_image.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
soft_delete_project.js
split_tests_assigned_at_to_dates.js
sso_id_migration_check.js Merge pull request #17525 from overleaf/ae-upgrade-prettier 2024-03-26 09:04:05 +00:00
sso_id_remove_not_migrated.js Merge pull request #17525 from overleaf/ae-upgrade-prettier 2024-03-26 09:04:05 +00:00
stress_test.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
tsconfig.json Merge pull request #16353 from overleaf/em-typescript-in-web-backend 2024-01-04 09:03:43 +00:00
undelete_project_to_user.js
unlink_third_party_id.js Merge pull request #17611 from overleaf/dp-unlink-sso-script 2024-03-26 09:04:40 +00:00
validate-data-of-model.js Merge pull request #12276 from overleaf/jpa-batched-update-window 2023-03-22 09:04:09 +00:00