overleaf/services/web/scripts
Antoine Clausse b2ef7a935f [web] Use localized number formatting for currencies (#17622)
* Add a unit test on `SubscriptionFormatters.formatPrice`

* Add JSDoc to `formatPrice`

Also: Name the functions before exporting:
This fixes my IDE (WebStorm) navigation

* Make `'USD'` the default param instead of reassigning

* Create `formatCurrency` function

* Use `formatCurrency` in SubscriptionFormatters

* Use an `isNoCentsCurrency` logic for `CLP` `JPY` `KRW` `VND`

And remove custom `CLP` logic and locale

* Add `locale` param to `formatPrice`

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Update scripts/plan-prices/plans.js to generate numbers instead of localized amounts

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Remove generation of `plans.json`

As /services/web/frontend/js/main/plans.js was removed in https://github.com/overleaf/internal/pull/12593

* Sort currencies in alphabetical order in scripts/plan-prices/plans.js

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Use `formatCurrency` in price-summary.tsx

* Use `formatCurrency` in Subscription Pug files

* Fix unit tests SubscriptionHelperTests.js

* Remove unused `currencySymbol`

* Change to `formatCurrency` in other React components

* Add `CurrencyCode` JSDoc types

* Duplicate `formatCurrency` into services/web/app/src/util

* Wrap tests in a top-level describe block

* Use `narrowSymbol`

* Fix tests with `narrowSymbol` expects

* Revert deletion of old `formatPrice` in SubscriptionFormatters.js

* Rename `formatCurrency` -> `formatCurrencyLocalized`

* Revert deletion of `CurrencySymbol`

* Add split-test in SubscriptionController.js

* Add split-test in SubscriptionViewModelBuilder.js

* Add split-test in plans

* Add split-test in subscription-dashboard-context.tsx

* Add split-test in 4 more components

* Update tests

* Show currency and payment methods in interstitial page

* Fix `–` being printed. Use `–` instead

* Fix test with NOK

* Storybook: Fix missing `SplitTestProvider`

* Storybook: Revert "Remove unused `currencySymbol`"

This reverts commit e55387d4753f97bbf8e39e0fdc3ad17312122aaa.

* Replace `getSplitTestVariant` by `useSplitTestContext`

* Use parameterize currencyFormat in `generateInitialLocalizedGroupPrice`

* Fixup import paths of `formatCurrencyLocalized`

* Replace `% 1 === 0` by `Number.isInteger`

* Add comment explaining that any combinations of languages/currencies could happen

* Fixup after rebase: import `useSplitTestContext`

* Revert "Remove SplitTestProvider from subscription root"

This reverts commit be9f378fda715b86589ab0759737581c72321d87.

* Revert "Remove split test provider from some tests"

This reverts commit 985522932b550cfd38fa6a4f4c3d2ebaee6ff7df.

GitOrigin-RevId: 59a83cbbe0f7cc7e45f189c654e23fcf9bfa37af
2024-04-19 08:03:54 +00:00
..
analytics Merge pull request #17525 from overleaf/ae-upgrade-prettier 2024-03-26 09:04:05 +00:00
delete-duplicate-splittest-versions
delete-orphaned-docs Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
example
helpers Merge pull request #17926 from overleaf/jpa-batched-update-sorting 2024-04-17 08:04:09 +00:00
history Merge pull request #14198 from overleaf/jpa-history-migration 2023-08-11 08:04:01 +00:00
learn/checkSanitize
lezer-latex Merge pull request #14991 from overleaf/jpa-log-tree 2023-09-28 08:04:17 +00:00
oauth Merge pull request #17457 from overleaf/dp-local-collabratec-helpers 2024-03-26 09:04:00 +00:00
plan-prices [web] Use localized number formatting for currencies (#17622) 2024-04-19 08:03:54 +00:00
recurly
sync-user-entitlements
translations Merge pull request #17748 from overleaf/bg-node-security-upgrade-2024-04-05 2024-04-08 08:04:41 +00:00
ukamf Merge pull request #16948 from overleaf/jpa-rails-sharelatex-rebranding-step-2 2024-02-13 09:03:35 +00:00
add_feature_override.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
add_notification_ieee_collabratec_users.js Merge pull request #17586 from overleaf/dp-fix-IEEE-script 2024-03-20 09:03:06 +00:00
add_user_count_to_csv.js Merge pull request #14610 from overleaf/bg-filter-csv-by-registered-user-domains 2023-09-04 08:05:03 +00:00
back_fill_deleted_files.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
back_fill_doc_name_for_deleted_docs.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
back_fill_doc_rev.js
back_fill_dummy_doc_meta.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
back_fill_staff_access.js
back_fill_warning_user_personal_and_group_subscription.js Merge pull request #15044 from overleaf/mf-send-warning-to-users-with-personal-and-group-subscriptions 2023-10-18 08:05:04 +00:00
backfill_mixpanel_user_properties.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
backfill_project_image_name.js
backfill_user_properties.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
backfill_users_sso_attribute.js
bench_bcrypt.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
check_institution_users.js
check_saml_emails.js
clear_feedback_collection.js
clear_institution_notifications.js
clear_project_tokens.js
clear_sessions_2fa.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
clear_sessions_set_must_reconfirm.js
confirmed_at_to_dates.js
convert_archived_state.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
convert_doc_to_file.js
count_encrypted_access_tokens.js
count_files_in_projects.js
count_image_files.js
count_project_size.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
create_oauth_personal_access_token.js
create_project.js
delete_dangling_file_refs.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
delete_orphaned_chat_threads.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
delete_orphaned_data_helper.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
delete_orphaned_doc_comment_ranges.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
delete_orphaned_docs_online_check.js Merge pull request #17525 from overleaf/ae-upgrade-prettier 2024-03-26 09:04:05 +00:00
delete_subscriptions.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
disconnect_all_users.js Merge pull request #15923 from overleaf/jpa-tweak-delay-in-seconds 2023-11-27 09:04:02 +00:00
ensure_affiliations.js
extract_onboardingdatacollection_csv.js Create a script to extract OnboardingDataCollection (#17657) 2024-03-28 09:04:33 +00:00
find_malformed_filetrees.js
fix_group_invite_emails_to_lowercase.js
fix_malformed_filetree.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
fix_oversized_docs.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
force_doc_flush.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
inst_table.js
invalidate_tokens.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
mark_migration.js
merge_group_subscription_members.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
migrate_audit_logs.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
migration_compile_timeout_60s_to_20s.js Merge pull request #17925 from overleaf/jpa-ac-20s-timeout-migration-logging-tweaks 2024-04-17 08:04:30 +00:00
process_lapsed_reconfirmations.js
purge_non_logged_in_sessions.js Merge pull request #17291 from overleaf/bg-purge-non-logged-in-sessions 2024-02-27 17:02:10 +00:00
recover_docs_from_redis.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
refresh_features.js
refresh_institution_users.js
regenerate_duplicate_referral_ids.js Merge pull request #15172 from overleaf/em-promise-utils 2023-10-20 08:04:05 +00:00
remove_deleted_users_from_token_access_refs.js add missing token access fields to projects (#17372) 2024-03-06 17:27:26 +00:00
remove_email.js
remove_oauth_application.js
remove_unwanted_ieee_collabratec_users.js Merge pull request #17645 from overleaf/dp-ac-ieee-deprecation-script-remove-users 2024-03-29 09:04:17 +00:00
restore_orphaned_docs.js
restore_soft_deleted_docs.js Merge pull request #17525 from overleaf/ae-upgrade-prettier 2024-03-26 09:04:05 +00:00
set_tex_live_image.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
soft_delete_project.js
split_tests_assigned_at_to_dates.js
sso_id_migration_check.js Merge pull request #17525 from overleaf/ae-upgrade-prettier 2024-03-26 09:04:05 +00:00
sso_id_remove_not_migrated.js Merge pull request #17525 from overleaf/ae-upgrade-prettier 2024-03-26 09:04:05 +00:00
stress_test.js Merge pull request #16186 from overleaf/mj-mongo-object-id 2023-12-19 09:04:02 +00:00
tsconfig.json Merge pull request #16353 from overleaf/em-typescript-in-web-backend 2024-01-04 09:03:43 +00:00
undelete_project_to_user.js
unlink_third_party_id.js Merge pull request #17611 from overleaf/dp-unlink-sso-script 2024-03-26 09:04:40 +00:00
validate-data-of-model.js