mirror of
https://github.com/overleaf/overleaf.git
synced 2024-11-21 20:47:08 -05:00
276310bd23
Handle users who haven't migrated better on password reset GitOrigin-RevId: f123a6fe4a5a958f558e3cf34c3180e8fc96d159
219 lines
8 KiB
CoffeeScript
219 lines
8 KiB
CoffeeScript
should = require('chai').should()
|
|
SandboxedModule = require('sandboxed-module')
|
|
assert = require('assert')
|
|
path = require('path')
|
|
sinon = require('sinon')
|
|
modulePath = path.join __dirname, "../../../../app/js/Features/PasswordReset/PasswordResetHandler"
|
|
expect = require("chai").expect
|
|
|
|
describe "PasswordResetHandler", ->
|
|
|
|
beforeEach ->
|
|
|
|
@settings =
|
|
siteUrl: "www.sharelatex.com"
|
|
@OneTimeTokenHandler =
|
|
getNewToken:sinon.stub()
|
|
getValueFromTokenAndExpire:sinon.stub()
|
|
@UserGetter =
|
|
getUserByMainEmail:sinon.stub()
|
|
getUser: sinon.stub()
|
|
getUserByAnyEmail: sinon.stub()
|
|
@EmailHandler =
|
|
sendEmail:sinon.stub()
|
|
@AuthenticationManager =
|
|
setUserPassword:sinon.stub()
|
|
setUserPasswordInV1:sinon.stub()
|
|
setUserPasswordInV2:sinon.stub()
|
|
@V1Api =
|
|
request: sinon.stub()
|
|
@PasswordResetHandler = SandboxedModule.require modulePath, requires:
|
|
"../User/UserGetter": @UserGetter
|
|
"../Security/OneTimeTokenHandler": @OneTimeTokenHandler
|
|
"../Email/EmailHandler":@EmailHandler
|
|
"../Authentication/AuthenticationManager":@AuthenticationManager
|
|
"../V1/V1Api": @V1Api
|
|
"settings-sharelatex": @settings
|
|
"logger-sharelatex":
|
|
log:->
|
|
err:->
|
|
@token = "12312321i"
|
|
@user_id = "user_id_here"
|
|
@user =
|
|
email : @email = "bob@bob.com"
|
|
@password = "my great secret password"
|
|
@callback = sinon.stub()
|
|
|
|
|
|
describe "generateAndEmailResetToken", ->
|
|
describe "when in ShareLaTeX", ->
|
|
it "should check the user exists", (done)->
|
|
@UserGetter.getUserByMainEmail.callsArgWith(1)
|
|
@UserGetter.getUserByAnyEmail.callsArgWith(1)
|
|
@OneTimeTokenHandler.getNewToken.yields()
|
|
@PasswordResetHandler.generateAndEmailResetToken @user.email, (err, status)=>
|
|
should.equal(status, null)
|
|
done()
|
|
|
|
it "should send the email with the token", (done)->
|
|
@UserGetter.getUserByMainEmail.callsArgWith(1, null, @user)
|
|
@OneTimeTokenHandler.getNewToken.yields(null, @token)
|
|
@EmailHandler.sendEmail.callsArgWith(2)
|
|
@PasswordResetHandler.generateAndEmailResetToken @user.email, (err, status)=>
|
|
@EmailHandler.sendEmail.called.should.equal true
|
|
status.should.equal 'primary'
|
|
args = @EmailHandler.sendEmail.args[0]
|
|
args[0].should.equal "passwordResetRequested"
|
|
args[1].setNewPasswordUrl.should.equal "#{@settings.siteUrl}/user/password/set?passwordResetToken=#{@token}&email=#{encodeURIComponent(@user.email)}"
|
|
done()
|
|
|
|
it "should return exists == null for a holdingAccount", (done) ->
|
|
@user.holdingAccount = true
|
|
@UserGetter.getUserByMainEmail.callsArgWith(1, null, @user)
|
|
@UserGetter.getUserByAnyEmail.callsArgWith(1)
|
|
@OneTimeTokenHandler.getNewToken.yields()
|
|
@PasswordResetHandler.generateAndEmailResetToken @user.email, (err, status)=>
|
|
should.equal(status, null)
|
|
done()
|
|
|
|
describe "when in overleaf", ->
|
|
beforeEach ->
|
|
@settings.overleaf = true
|
|
|
|
describe "when the email exists", ->
|
|
beforeEach ->
|
|
@V1Api.request.yields(null, {}, { user_id: 42 })
|
|
@OneTimeTokenHandler.getNewToken.yields(null, @token)
|
|
@EmailHandler.sendEmail.yields()
|
|
@PasswordResetHandler.generateAndEmailResetToken @email, @callback
|
|
|
|
it 'should call the v1 api for the user', ->
|
|
@V1Api.request.calledWith({
|
|
url: "/api/v1/sharelatex/user_emails"
|
|
qs:
|
|
email: @email
|
|
expectedStatusCodes: [404]
|
|
}).should.equal true
|
|
|
|
it 'should set the password token data to the user id and email', ->
|
|
@OneTimeTokenHandler.getNewToken
|
|
.calledWith('password', {
|
|
v1_user_id: 42
|
|
})
|
|
.should.equal true
|
|
|
|
it 'should send an email with the token', ->
|
|
@EmailHandler.sendEmail.called.should.equal true
|
|
args = @EmailHandler.sendEmail.args[0]
|
|
args[0].should.equal "passwordResetRequested"
|
|
args[1].setNewPasswordUrl.should.equal "#{@settings.siteUrl}/user/password/set?passwordResetToken=#{@token}&email=#{encodeURIComponent(@user.email)}"
|
|
|
|
it 'should return status == true', ->
|
|
@callback.calledWith(null, 'primary').should.equal true
|
|
|
|
describe "when the email doesn't exist", ->
|
|
beforeEach ->
|
|
@V1Api.request = sinon.stub().yields(null, { statusCode: 404 }, {})
|
|
@UserGetter.getUserByAnyEmail.callsArgWith(1)
|
|
@PasswordResetHandler.generateAndEmailResetToken @email, @callback
|
|
|
|
it 'should not set the password token data', ->
|
|
@OneTimeTokenHandler.getNewToken
|
|
.called.should.equal false
|
|
|
|
it 'should send an email with the token', ->
|
|
@EmailHandler.sendEmail.called.should.equal false
|
|
|
|
it 'should return status == null', ->
|
|
@callback.calledWith(null, null).should.equal true
|
|
|
|
describe "when the user isn't on v2", ->
|
|
beforeEach ->
|
|
@V1Api.request = sinon.stub().yields(null, { statusCode: 404 }, {})
|
|
@UserGetter.getUserByAnyEmail.callsArgWith(1, null, @user)
|
|
@PasswordResetHandler.generateAndEmailResetToken @email, @callback
|
|
|
|
it 'should not set the password token data', ->
|
|
@OneTimeTokenHandler.getNewToken
|
|
.called.should.equal false
|
|
|
|
it 'should not send an email with the token', ->
|
|
@EmailHandler.sendEmail.called.should.equal false
|
|
|
|
it 'should return status == sharelatex', ->
|
|
@callback.calledWith(null, 'sharelatex').should.equal true
|
|
|
|
describe "when the email is a secondary email", ->
|
|
beforeEach ->
|
|
@V1Api.request = sinon.stub().yields(null, { statusCode: 404 }, {})
|
|
@user.overleaf = {id: 101}
|
|
@UserGetter.getUserByAnyEmail.callsArgWith(1, null, @user)
|
|
@PasswordResetHandler.generateAndEmailResetToken @email, @callback
|
|
|
|
it 'should not set the password token data', ->
|
|
@OneTimeTokenHandler.getNewToken
|
|
.called.should.equal false
|
|
|
|
it 'should not send an email with the token', ->
|
|
@EmailHandler.sendEmail.called.should.equal false
|
|
|
|
it 'should return status == secondary', ->
|
|
@callback.calledWith(null, 'secondary').should.equal true
|
|
|
|
describe "setNewUserPassword", ->
|
|
describe "when no data is found", ->
|
|
beforeEach ->
|
|
@OneTimeTokenHandler.getValueFromTokenAndExpire.yields(null, null)
|
|
@PasswordResetHandler.setNewUserPassword @token, @password, @callback
|
|
|
|
it 'should return exists == false', ->
|
|
@callback.calledWith(null, false).should.equal true
|
|
|
|
describe 'when the data is an old style user_id', ->
|
|
beforeEach ->
|
|
@AuthenticationManager.setUserPassword.yields(null, true, @user_id)
|
|
@OneTimeTokenHandler.getValueFromTokenAndExpire.yields(null, @user_id)
|
|
@PasswordResetHandler.setNewUserPassword @token, @password, @callback
|
|
|
|
it 'should call setUserPasswordInV2', ->
|
|
@AuthenticationManager.setUserPassword
|
|
.calledWith(@user_id, @password)
|
|
.should.equal true
|
|
|
|
it 'should reset == true and the user_id', ->
|
|
@callback.calledWith(null, true, @user_id).should.equal true
|
|
|
|
describe 'when the data is a new style user_id', ->
|
|
beforeEach ->
|
|
@AuthenticationManager.setUserPassword.yields(null, true, @user_id)
|
|
@OneTimeTokenHandler.getValueFromTokenAndExpire.yields(null, {@user_id})
|
|
@PasswordResetHandler.setNewUserPassword @token, @password, @callback
|
|
|
|
it 'should call setUserPasswordInV2', ->
|
|
@AuthenticationManager.setUserPassword
|
|
.calledWith(@user_id, @password)
|
|
.should.equal true
|
|
|
|
it 'should reset == true and the user_id', ->
|
|
@callback.calledWith(null, true, @user_id).should.equal true
|
|
|
|
describe 'when the data is v1 id', ->
|
|
beforeEach ->
|
|
@v1_user_id = 2345
|
|
@AuthenticationManager.setUserPasswordInV1.yields(null, true)
|
|
@UserGetter.getUser.withArgs({'overleaf.id': @v1_user_id}).yields(null, { _id: @user_id })
|
|
@OneTimeTokenHandler.getValueFromTokenAndExpire.yields(null, {@v1_user_id})
|
|
@PasswordResetHandler.setNewUserPassword @token, @password, @callback
|
|
|
|
it 'should call setUserPasswordInV1', ->
|
|
@AuthenticationManager.setUserPasswordInV1
|
|
.calledWith(@v1_user_id, @password)
|
|
.should.equal true
|
|
|
|
it 'should look up the user by v1 id for the v2 user id', ->
|
|
@UserGetter.getUser
|
|
.calledWith({'overleaf.id': @v1_user_id})
|
|
.should.equal true
|
|
|
|
it 'should reset == true and the user_id', ->
|
|
@callback.calledWith(null, true, @user_id).should.equal true
|