Alasdair Smith
864bf771a4
Merge pull request #362 from sharelatex/as-linting
...
Linting new ES code
2018-02-27 11:06:11 +00:00
James Allen
1f62df17c8
Merge pull request #363 from sharelatex/ja-guest-track-changes
...
Tidy up logic (a bit) around guest track changes
2018-02-23 14:41:12 +00:00
Alasdair Smith
94b7cdcae0
Fix linting
2018-02-23 11:29:54 +00:00
Alasdair Smith
85ceab5310
Tear down Ace session when aceEditor is destroyed
...
This cleans up the Ace worker that parses syntax, preventing a memory leak
2018-02-23 10:13:24 +00:00
Alasdair Smith
5e39e61c9b
Merge pull request #348 from sharelatex/as-fix-cm-share
...
Fix CodeMirror/ShareJS binding when switching docs
2018-02-23 10:12:12 +00:00
Alasdair Smith
92260e7b52
Merge pull request #340 from sharelatex/ja-remove-brand
...
Remove the public/brand folder
2018-02-23 10:11:47 +00:00
James Allen
1d3db923f0
Tidy up logic (a bit) around guest track changes
2018-02-23 09:55:57 +00:00
Alasdair Smith
2be37795bd
TODO for cleaning up sharejs callbacks
2018-02-22 11:44:09 +00:00
Alasdair Smith
598837e17c
Use applyAsync to prevent issue when switching docs
2018-02-22 11:44:09 +00:00
Alasdair Smith
c5735a31df
Remove unused listener
2018-02-22 11:44:09 +00:00
Alasdair Smith
e1187f3d8a
Listen for changes to the CodeMirror Doc, instead of all changes to the editor
...
This prevents an issue where switching docs (i.e. files) would cause the newly
opened doc from being inserted into the old doc.
This approach is similar to Ace's sessions.
2018-02-22 11:44:09 +00:00
Alasdair Smith
c85e9ba3b1
Instead of setting value of CM, swap Docs
...
This allows for tracking changes on individual docs (i.e. files), instead of
just changes to the editor. This is similar to how Ace works with sessions
2018-02-22 11:44:09 +00:00
Alasdair Smith
eae8b5a592
Merge pull request #330 from sharelatex/as-karma-tests
...
Karma tests
2018-02-22 11:06:56 +00:00
Paulo Reis
f1a36919f9
Make sure the widget does not overlap the footer.
2018-02-21 13:39:39 +00:00
Alasdair Smith
0b77e97df2
Added angular mocks for testing and stub out globals
2018-02-20 14:01:02 +00:00
Brian Gough
fc1e94b14a
Merge pull request #343 from sharelatex/bg-block-javascript-property-names
...
block javascript property names being used as file names
2018-02-16 14:07:12 +00:00
Brian Gough
2ba7db603f
Merge pull request #337 from sharelatex/ja-allow-javascript-property-names
...
Use bare objects without prototypes for tracking filenames
2018-02-16 14:05:21 +00:00
Brian Gough
8a10e98b56
block javascript property names being used as file names
2018-02-16 10:31:47 +00:00
Paulo Reis
3f14a727e3
Make sure the hamburger menu plays well with the brand.
2018-02-16 10:26:26 +00:00
James Allen
6f143603a3
Remove unused brand folder
2018-02-15 14:54:34 +00:00
Paulo Reis
51b14e412f
Increase hamburguer menu max-height; 340px was less than SL menu fully expanded.
2018-02-15 11:51:45 +00:00
Paulo Reis
e2874998b3
Improve hamburguer menu in v2, still not perfect.
2018-02-15 11:46:40 +00:00
Paulo Reis
f01b027da0
Make sure the menu behaviour does not change in desktop resolutions.
2018-02-15 11:29:29 +00:00
Paulo Reis
058a58d099
Only apply horizontal paddings (to align with the header).
2018-02-15 11:12:32 +00:00
Paulo Reis
ebad9091c7
Create class to scope main header changes (avoids overriding too much Bootstrap stuff); apply styles.
2018-02-15 11:08:12 +00:00
James Allen
4754f1e78a
Use bare objects without prototypes for tracking filenames
2018-02-15 11:06:40 +00:00
Paulo Reis
f1717bfa1f
Allow header content to be on top of main content.
2018-02-15 10:58:36 +00:00
James Allen
a7fabb8e43
Merge pull request #321 from sharelatex/ja-recompile-tweaks
...
Animate toolbar for auto-compile and consolidate trigger logic
2018-02-14 09:34:16 +00:00
James Allen
29d2b408ad
Don't error when detaching from history with no sharejsDoc
2018-02-13 08:43:00 +00:00
James Allen
5d3ecdb924
Add explicit editor init event
2018-02-13 08:27:48 +00:00
James Allen
3802df5cfa
Use popup instance variable like Ace autocompleter does
2018-02-13 08:27:41 +00:00
James Allen
5d6925921c
Fix read only links
2018-02-12 10:42:57 +00:00
James Allen
92e59f7008
Remove unneeded apply
2018-02-09 17:58:19 +00:00
James Allen
ab940fb462
Fix typo in comment
2018-02-09 17:54:58 +00:00
James Allen
9e86abbb04
Remove unneeded webkit prefix in css
2018-02-09 17:54:42 +00:00
Alasdair Smith
6088fcf82b
Merge pull request #310 from sharelatex/ja-link-sharing-tweaks
...
Link sharing UX improvments
2018-02-09 11:23:28 +00:00
Alasdair Smith
7ff0f40477
Merge pull request #266 from sharelatex/as-cm
...
CodeMirror
2018-02-09 11:23:11 +00:00
Alasdair Smith
b7200066e9
Inject rich text variable to conditionally show rich text styles
2018-02-09 10:42:11 +00:00
Alasdair Smith
bfda9c595b
Hide rich text behind feature flag
2018-02-09 10:42:11 +00:00
Alasdair Smith
4c23a3c8f0
Fix bug where spell check cache would error when toggling between ace & cm
2018-02-09 10:42:11 +00:00
Alasdair Smith
d15efc6fb6
Create cmEditor directive to connect to ShareJS
2018-02-09 10:42:11 +00:00
Alasdair Smith
b9327cb2d4
Add toolbar with button to toggle rich text
2018-02-09 10:42:00 +00:00
Alasdair Smith
7783e18a50
Allow Documents to be attached to CM
2018-02-09 10:38:51 +00:00
Alasdair Smith
09fbafa1f6
Include ShareJS CM adapter in compiled lib and fix bug with CM adapter
...
Because the CM & Ace scripts are naively concat-ed together, the Ace
applyToShareJS function would be overwritten by the CM version.
Also fixes bugs where adapter was calling old version of ShareJS api
and the old CM api
2018-02-09 10:38:51 +00:00
Alasdair Smith
f5b6d3ff3e
Load basic CM instance with dummy content
2018-02-09 10:38:51 +00:00
Henry Oswald
ba1e45d12c
Merge pull request #317 from sharelatex/ho-nice-recaptcha-message
...
improved recaptcha error message
2018-02-09 10:26:33 +00:00
Alasdair Smith
d8e87997c1
Install codemirror
2018-02-09 10:02:36 +00:00
James Allen
bd9f30d858
Adjust icon spacing in PDF toolbar
2018-02-08 14:41:39 +00:00
James Allen
7866a91d21
Refactor auto-compile trigger logic
2018-02-08 13:39:59 +00:00
James Allen
5bf2ff0a47
Show animated bar while auto-compile is pending
2018-02-08 13:39:56 +00:00
Henry Oswald
696e9d27d6
send invalid_email error type down when sharing project
2018-02-08 10:35:18 +00:00
Brian Gough
9224e164fe
Merge pull request #315 from sharelatex/bg-validate-filenames-client
...
validate filenames on the client
2018-02-08 09:16:05 +00:00
Brian Gough
b083e4bc5f
remove redundant MAX_PATH definition
2018-02-07 16:14:56 +00:00
Brian Gough
c14380d563
use the SafePath.coffee file in the client too
2018-02-07 15:50:29 +00:00
Henry Oswald
a52aed9070
improved recaptcha error message
...
- works on register and share project
- decided not to go down i18n for register, would be scope creep on async form
2018-02-07 14:15:13 +00:00
James Allen
5edeff36b6
Vertically center caret
2018-02-06 16:22:20 +00:00
Brian Gough
76281a3d79
use extended file validation rules in frontend
2018-02-06 11:46:50 +00:00
Brian Gough
ddf1d6e65e
add valid-file directive for front-end
2018-02-06 11:46:50 +00:00
Alasdair Smith
e93e055b13
Merge pull request #309 from sharelatex/ja-tags-folders-tweaks
...
UX tweaks to tags/folders side bar entry
2018-02-06 10:36:15 +00:00
Alasdair Smith
0c2d7e250f
Merge pull request #308 from sharelatex/as-upgrade-less
...
Update Less/grunt-contrib-less to latest version
2018-02-06 10:21:14 +00:00
James Allen
4f89506afc
Make link sharing more prominant
2018-02-06 10:06:32 +00:00
James Allen
37115b8408
Add loading indicator while server returns links
2018-02-06 10:00:59 +00:00
James Allen
e7ba75c2e5
Don't show pop-up when changing link sharing status
2018-02-06 09:56:46 +00:00
James Allen
3e5527b826
UX tweaks to tags/folders side bar entry
2018-02-05 17:04:56 +00:00
Paulo Reis
3c3bb0a892
Use globalVars strategy to do v2-specific styling.
2018-02-05 16:20:33 +00:00
Alberto Fernández Capel
ae33b84289
Ignore heartbeat event handler params
...
They are not used for anything and the cause an error when
the handler is called from a scroll event.
2018-02-05 13:48:52 +00:00
James Allen
9e5c98dd07
Use local references to variable
2018-02-01 16:52:43 +00:00
Shane Kilkelly
19c97cb15b
Merge pull request #289 from sharelatex/afc-track-edit-sessions
...
Send editing session heartbeat to the analytics service
2018-02-01 12:31:38 +00:00
Brian Gough
5e52ade1ff
Merge pull request #286 from sharelatex/bg-prevent-duplicate-filenames
...
prevent duplicate filenames
2018-01-31 11:50:45 +00:00
James Allen
9a9938083c
Merge pull request #267 from sharelatex/as-remove-rollout
...
Remove rollout logic for auto compile and link sharing
2018-01-31 10:27:09 +00:00
James Allen
aa6c16593e
Add renamingToName override name for instant apparent renames
2018-01-31 09:42:41 +00:00
James Allen
9721dffbb6
Add missing state reset to error handler
2018-01-31 09:41:58 +00:00
Brian Gough
1c6dc66ed1
prevent double calls to rename
2018-01-29 16:45:59 +00:00
Brian Gough
6ed181d52c
fix check for name in filetree move
2018-01-29 15:27:52 +00:00
Brian Gough
63fa024d98
client-side duplicate check for move/rename/create
2018-01-29 15:24:51 +00:00
Alberto Fernández Capel
839ea496f1
Track clicks anywhere on the window as activity when the editor is open
2018-01-25 16:32:00 +00:00
Alberto Fernández Capel
a68489a604
Track session activvity if the user scrolls the editor
2018-01-25 16:10:47 +00:00
Alberto Fernández Capel
7d0d18ea5e
Use the cursor:editor:update event to track user activity
...
It is strictly a superset of the change event we were using
before: if there's a change, there will be always a cursor
update, but there can be cursor updates (like when the user
presses the arrow keys) that don't change the document.
This is coherent with what we do to track user activity at
dfb9943521/public/coffee/ide/connection/ConnectionManager.coffee (L49-L50)
2018-01-24 17:20:30 +00:00
Alberto Fernández Capel
e42d1f9b13
Change heartbeat backoff logic
...
Send first two heartbeats at 0 and 30 secs, then increase the backoff
interval 1min per call until a maximun of 5min.
2018-01-24 16:05:53 +00:00
Alberto Fernández Capel
dd2e9d7431
Remove unused var
2018-01-24 15:37:16 +00:00
Alberto Fernández Capel
f0777f996c
Space editing sessions heartbeats with an increasing backoff
...
We send the first heartbeat as soon as the session start.
The next ones are sent (if there's any activity)
when the editing session is about 30 and 60 seconds.
Then at 2min, 3min, 4min, 5min and later on every 5min.
The backoff is not reset, so if due to inactivity the
session expires in the server the backoff will still be
the same.
2018-01-24 15:22:41 +00:00
Brian Gough
feb02dacd4
only update client filetree on success
2018-01-24 10:07:42 +00:00
James Allen
28deb4e107
Merge pull request #292 from sharelatex/ja-v1-ownership
...
Fallback to project creator when there is no owner
2018-01-24 09:50:20 +00:00
Alberto Fernández Capel
8a1523cc03
Read project id from the global window var
2018-01-23 15:58:59 +00:00
James Allen
a558d05ac6
Only show import modal for owned projects
2018-01-23 15:12:00 +00:00
Nate Stemen
ea5063d7ea
dont return needsClosingBrace from Helpers
2018-01-23 09:35:24 -05:00
Nate Stemen
91302cfb16
move end bracket logic to helpers and remove unecessary unpacking
2018-01-23 09:35:24 -05:00
Nate Stemen
30eca714eb
fix random things with snippets
2018-01-23 09:35:24 -05:00
Nate Stemen
d2adc753aa
use helpers to see if there is '}' already
2018-01-23 09:35:24 -05:00
James Allen
d7706f642b
Show the creator as the owner if no owner present
2018-01-23 13:47:48 +00:00
James Allen
ce9a1fec87
Revert "Go back to allowing v1 projects to be imported"
2018-01-23 11:49:33 +00:00
James Allen
2fb4059633
Merge pull request #258 from sharelatex/ja-allow-v1-imports
...
Go back to allowing v1 projects to be imported
2018-01-23 10:30:23 +00:00
Alberto Fernández Capel
b3b05d1af3
Disable the trailing throttle event in the editing session heartbeat
...
Throttle sends an event as soon as the function is called. Then
we wait X minutes, but we only want to send another event if
there's any activity *after* those X minutes.
2018-01-23 10:29:11 +00:00
Alberto Fernández Capel
0bef5531bb
Rename editSession -> editingSession
2018-01-23 10:29:11 +00:00
Alberto Fernández Capel
868e32c1bc
Send edit sessions heartbeat to the analytics service
2018-01-22 15:10:52 +00:00
Alberto Fernández Capel
1a1ccc9f46
Remove trailing whitespace
2018-01-22 15:00:56 +00:00
Alasdair Smith
06e2f0df1c
Remove unused styles for auto compile & link sharing onboarding
2018-01-17 16:04:10 +00:00
Alasdair Smith
4d29c4d769
Remove unused link sharing onboarding now at 100%
2018-01-17 15:18:40 +00:00
Alasdair Smith
45de9bb5dc
Remove unused autocompile rollout logic now that at 100%
2018-01-17 15:17:55 +00:00
James Allen
c466025df4
Go back to allowing v1 projects to be imported
2018-01-16 09:40:58 +00:00
