github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity
20222 commits 3 branches 7 tags 201 MiB
Commit graph

27 commits

Author SHA1 Message Date
M Fahru
82cd2d2a77 perform null check on the old value instead of the new one since to follow the non-react version behaviour 
GitOrigin-RevId: 33ef74e1b1da41db8a86fc79ae04fbe49ed194df
 2023-01-11 09:10:00 +00:00
M Fahru
94ab78b427 Log error in a promise catch block 
GitOrigin-RevId: 09756d52bd6351c55051a74f22f38c450af9a275
 2023-01-11 09:09:51 +00:00
M Fahru
7475237170 Refactor project-wide settings: 
- Change api function argument (readability)
- create a new wrapper hooks for saving the project to both server-side and angular scope
- Implement the new save project settings hooks on project-wide settings update
- On spell check language update function, add new comment to give more context about the decision

GitOrigin-RevId: 93d558d1e1d4db265a943eeb4366842430900c43
 2023-01-11 09:09:40 +00:00
M Fahru
654144dd40 Refactor saveUserSettings: Move sendMB inside the function and change function from supporting multiple settings to only support single key/value pair. 
GitOrigin-RevId: 77b9d8fd5cdcbc78f38fd42329b74cf592615638
 2023-01-11 09:09:32 +00:00
M Fahru
b2cf833e9d Remove scope suffix from variable name in react-related files since it's an angular-specific concept 
GitOrigin-RevId: b8eea8c8113a977f6cbe07649e1338eea8281841
 2023-01-11 09:09:18 +00:00
M Fahru
4548f504f7 standardize the naming for rootDocId. 
- Remove the `scope` variable suffix
- change `rootDoc_id` to `rootDocId`

GitOrigin-RevId: d8e646ef5f99ba0dbce84ff63c588e63b956a4ec
 2023-01-11 09:09:04 +00:00
M Fahru
e3d0380e6f Remove multiple source of type imports; add type on type imports. 
GitOrigin-RevId: a6630bb284c456bfbe61901f7331cdd3c13c7f8b
 2023-01-11 09:08:42 +00:00
M Fahru
12f5c845b4 Simplify function by removing generic 
GitOrigin-RevId: 7732b6782cd1e0130eb56f6b674c03548b8e8315
 2023-01-11 09:08:35 +00:00
M Fahru
10bb724197 Fix wrong hook name 
GitOrigin-RevId: 58f98b508cf650a6ecab38772faf9ecd38c9a7bc
 2023-01-11 09:08:28 +00:00
M Fahru
f85d17f894 Remove disabling update while listening on socket (ignoreUpdates state) since the logic is more complicated that was originally thought and it will be tested/revisited on a different PR 
GitOrigin-RevId: 70cee2f0fc565aaebfb3ead2dd1a58fc5371c816
 2023-01-11 09:08:13 +00:00
M Fahru
677ec173ed Disable updating project-wide settings while socket is currently listening to update project-wide settings in a project. 
This may happen if the project is being used by multiple people, and we want to avoid race condition on the update since it's possible for multiple people to update setting value at the same time.

GitOrigin-RevId: cdad6a6456e2d9e4ef1812ebfd6f6ef59f23747f
 2023-01-11 09:08:06 +00:00
M Fahru
af01ace5a0 refactor function by simplifying function argument (from two arguments to a single object) 
GitOrigin-RevId: e4244a07a4ca196afa226e3fac9de74d30f7d4ea
 2023-01-11 09:07:59 +00:00
M Fahru
777beaadc3 Don't send spellCheckLanguage request if the old value is the same as the new one 
GitOrigin-RevId: 4ef34be7563ff707b6abd44dc8034293c88d2f72
 2023-01-11 09:07:52 +00:00
M Fahru
ae5a08e680 Add 'setting-changed' tracking when user changes user-wide settings 
GitOrigin-RevId: 04ed66dcdff7fa04e783fe4028505d981a39b37b
 2023-01-11 09:07:45 +00:00
M Fahru
85cbc5b721 Apply prettier 
GitOrigin-RevId: 34c7e3b95d061c270c77337c7c82502af289b556
 2023-01-11 09:07:38 +00:00
M Fahru
06b0833e33 Add a comment explaining why user settings may be undefined 
GitOrigin-RevId: 4460d4184cde5639d326da07121b2728d444c782
 2023-01-11 09:07:30 +00:00
M Fahru
5597736057 Fix numerous test fails because of unitialized user settings scope on the test environment 
GitOrigin-RevId: a27454285b0c89c6abef560f05c52d35f81fa570
 2023-01-11 09:07:23 +00:00
M Fahru
56395d9a95 Save spellCheckLanguage to both project-wide and user-wide setting 
GitOrigin-RevId: 059cc64d0fe2e955814a7192f82d4ff8ea4e2572
 2023-01-11 09:07:16 +00:00
M Fahru
4bf09e21de Fix tsc lint error by restricting the generic type 
GitOrigin-RevId: 11ef7ab4111c7b312b283283829e9b28a80c475c
 2023-01-11 09:07:09 +00:00
M Fahru
98fbd330b2 Add socket listener for compiler, imageName, and spellCheckLanguage 
GitOrigin-RevId: b12644152387e479e433a014e1a1041ebae36f12
 2023-01-11 09:07:02 +00:00
M Fahru
132bb40a21 replace save project setting hooks with common function and implement set root doc id change 
GitOrigin-RevId: e5b204cd93fc188288def529cb22018b3d4f89b6
 2023-01-11 09:06:40 +00:00
M Fahru
8ae9839f79 apply prettier 
GitOrigin-RevId: dd750756d2bfc625817760510e9bdbade186aef3
 2023-01-11 09:06:33 +00:00
M Fahru
c2b0707c2a Change variable declaration location + apply prettier 
GitOrigin-RevId: 3237a417c23d5c66c47385e55f8d3cb68bdfc3ca
 2023-01-11 09:06:26 +00:00
M Fahru
414540af5c Reduce save/setScope user setting duplication by introducing a new shared hooks 
GitOrigin-RevId: 6054143eb042e4ff336b1f325a8cef693ae8c4bd
 2023-01-11 09:06:19 +00:00
M Fahru
09b1974a3d Migrate updating overallTheme to react 
GitOrigin-RevId: 024ceb3c32c8d90ac0067fbb72d6e7d327b869f0
 2023-01-11 09:06:12 +00:00
M Fahru
6c41a65200 migrate user-wide settings post request from angular controller to react 
GitOrigin-RevId: b5440178a11b82c5a5840eb310416f1519f85bae
 2023-01-11 09:05:57 +00:00
M Fahru
f01a2920cf Migrate editor settings controller to react (this commit includes project-wide settings) 
GitOrigin-RevId: 8c47a2699a2f11fda7fd60c5173bf2e29858e37a
 2023-01-11 09:05:50 +00:00