Commit graph

626 commits

Author SHA1 Message Date
M Fahru
f27562eb12 Data handling for settings in editor left menu react migration (#10470)
- Importing SettingsController from the angular code, which enables post requests for every select menu and socket handler for compiler, texlive version, and main document select option
 - New context for the data handling infrastructure between react and angular. The data is still located in the angular version, and I use the context only as a proxy to fetch/post new data.

GitOrigin-RevId: 59009bceb128d82969a2318e90036aacf79f9887
2022-11-30 09:04:32 +00:00
Alf Eaton
65b0fd73ea Improve "compile" keyboard shortcut handling (#10624)
* Improve "compile" keypress handling
* Remove "compile" keypress handling from PDF preview
* Remove compile shortcuts from CM6
* Use an event for Vim keybindings
* Remove event handlers from Angular/Ace
* Move useCompileTriggers into DetachCompileProvider

GitOrigin-RevId: 7f0e667b5106a849458e06ebb0f7a413d5d63430
2022-11-29 09:04:04 +00:00
M Fahru
31c503be2d Add 10 seconds delay before showing grammarly warning
GitOrigin-RevId: 11bb3ca5704ef5cc782d14eb6f4f10a1fa2a656e
2022-11-25 09:04:33 +00:00
M Fahru
6dcc22642a Update "go to line" hotkey for cm6 and add new info text in hotkeys modal
* Update "go to line" hotkey for cm6 and add new info text in hotkeys modal

* Differentiate modal title between cm6 and ace hotkeys

* Update test to reflect change in hotkeys modal title

* Add test for hotkeys modal bottom text

* Update test on editor left menu hotkeys button to reflect change in hotkeys modal title

GitOrigin-RevId: 61bae16313ea7a37fa3b9441dbe5a93ab7823d01
2022-11-25 09:04:20 +00:00
ilkin-overleaf
791732005c Merge pull request #10647 from overleaf/ii-dashboard-react-issues-fix
[web] Projects dashboard react bug fixes

GitOrigin-RevId: 4984515de97eb0d7ec50d9d497aff52c6a4a8b7e
2022-11-25 09:03:54 +00:00
Jessica Lawshe
a9741c190c Merge pull request #10471 from overleaf/jel-disabled-btn
[web] Style updates for `btn-danger` and deprecated secondary btns

GitOrigin-RevId: bd121147aa6c7b0a8f6b492b47667adb9369d078
2022-11-18 09:06:28 +00:00
Jessica Lawshe
024f6ee24e Merge pull request #10467 from overleaf/ds-btn-info-new-css-part-2
Updating`btn-info` to `btn-info-secondary` - part 2

GitOrigin-RevId: 934dd633494454277432810c4a1e70bb17829bd7
2022-11-18 09:05:51 +00:00
M Fahru
d70e0b1c0e Implement grammarly warning alert on cm6 users
GitOrigin-RevId: ed272bbc385faa69811ec1891075906cdca1c984
2022-11-16 09:06:39 +00:00
Davinder Singh
09be606a4e Merge pull request #10342 from overleaf/ds-buttons-project-page
New buttons on project dashboard

GitOrigin-RevId: 6e6a93a1ca1264dd214ccaf7976b665e45e7b10b
2022-11-16 09:04:34 +00:00
Davinder Singh
c6f8b17647 Merge pull request #10286 from overleaf/jel-ds-toggle
Fix toggle and  `Switch to PDF` aligment

GitOrigin-RevId: d3c77ff34829af875d2b8b9e3797e0e7db867631
2022-11-16 09:04:26 +00:00
M Fahru
5eff354971 Create settings menu react elements in editor left menu for editor left menu react migration
GitOrigin-RevId: e75581a43a8694398b20bee3dc5ec69b60db86ab
2022-11-15 09:07:01 +00:00
M Fahru
044d6fde65 Fix webpack build failure on server pro/CE:
- Add missing modules for local image dev env
- Use macro import to import modules

GitOrigin-RevId: 403a9950bc74063a9c9d34c9bc912af18f418e85
2022-11-15 09:06:54 +00:00
Jessica Lawshe
62cf8c9d61 Merge pull request #10262 from overleaf/jel-ds-btn-secondary
[web] Buttons for new CSS build

GitOrigin-RevId: 9ae4284ba89296b77c37d61ba9b221bcab2f6458
2022-11-15 09:06:25 +00:00
Mathias Jakobsen
81e2265e72 Merge pull request #10397 from overleaf/td-memoize-file-outline
Memoize file outline

GitOrigin-RevId: cb086bab2b6ead251362180d776e7eaff18fc639
2022-11-15 09:05:12 +00:00
Alf Eaton
28414b118d Merge pull request #10383 from overleaf/jpa-pdf-caching-avoid-cache-for-range-request
[web] pdf-caching: avoid browser cache for range requests on output.pdf

GitOrigin-RevId: 546380cfb24094db0af7de0f47f5a69c60b0586d
2022-11-10 09:04:06 +00:00
Mathias Jakobsen
8ddfd958d2 Merge pull request #10348 from overleaf/mj-outline-fixes-redo
[cm6] File outline improvements

GitOrigin-RevId: 9f4859cb35476d4baf0b3e3c2c2cb5d1678fd4a8
2022-11-09 09:04:08 +00:00
Jakob Ackermann
f803563673 Merge pull request #10376 from overleaf/jpa-pdf-caching-disable-first-error
[web] pdf-caching: disable pdf-caching after the first non-404 error

GitOrigin-RevId: f022e75acd9d5140ae02041b60af9819baa25e62
2022-11-09 09:04:03 +00:00
Jakob Ackermann
aeade59677 Merge pull request #10371 from overleaf/jpa-pdf-caching-disable-in-opera
[web] pdf-caching: disable pdf-caching in Opera browser

GitOrigin-RevId: 8c0cefc4fa4fccd74c58649c000be14643788514
2022-11-09 09:03:57 +00:00
Alf Eaton
381cdf34ce Use imported components directly
GitOrigin-RevId: 4533d7eb59ed543a301d99a9dce4ff54af6cfe6c
2022-11-09 09:03:48 +00:00
M Fahru
7e5ccecc7c Change react key to use unique string with index
GitOrigin-RevId: 591cda98d0a34c777cc8a41b2ec64119a1226dfb
2022-11-09 09:03:13 +00:00
M Fahru
c008a1aece Migrate github-sync menu to react
GitOrigin-RevId: 87e767a064421c7bad6c4fa3c7053959bfdb4cd4
2022-11-09 09:03:08 +00:00
Miguel Serrano
9e50ab8d1e Merge pull request #10350 from overleaf/jpa-pdf-caching-debug-context
[web] pdf-caching: more debug context

GitOrigin-RevId: ef9b20ef8d9a3b0c6b1b8c200eead1c0f8cf6bde
2022-11-09 09:03:00 +00:00
Jakob Ackermann
1c529d5dcf Merge pull request #10339 from overleaf/as-fix-switch-back
Fix bug in CM6 switch away survey where going back from Ace to CM6 will still show the survey

GitOrigin-RevId: 5900fafb1a4a5fab7d949b1c70af31e19a764e6e
2022-11-08 09:04:38 +00:00
Jakob Ackermann
665ab24cbd Merge pull request #10337 from overleaf/jpa-localized-network-error-messages
[web] pdf-caching: handle localize network error messages

GitOrigin-RevId: 41b0b9e87818d87d08c4cf24991751779243ae32
2022-11-08 09:04:18 +00:00
Jakob Ackermann
3db03ef678 Merge pull request #10313 from overleaf/jpa-pdf-caching-ranges-in-sentry
[web] pdf-caching: display ranges in sentry debug context

GitOrigin-RevId: d58e9c5292b1202e629c3b0706ade067c15e08a0
2022-11-08 09:04:11 +00:00
Jakob Ackermann
e9bc195483 Merge pull request #10301 from overleaf/jpa-pdf-caching-ignore-errors-for-stale-output
[web] pdf-caching: flag more errors as expected

GitOrigin-RevId: a5351db16d268bb8d9d67a86c34698c8b04f4f1a
2022-11-08 09:04:04 +00:00
Jakob Ackermann
111cce4ca4 Merge pull request #10299 from overleaf/jpa-nicer-warning-message-for-missing-pdf
[web] show a nicer warning message for missing pdf exceptions

GitOrigin-RevId: f519ec145d7ff4fe725241742fb66a1defdd257e
2022-11-08 09:03:57 +00:00
Miguel Serrano
4a3fb3344b Merge pull request #10323 from overleaf/ae-pdf-dblclick-page
Ensure only one dblclick listener is attached to a PDF page

GitOrigin-RevId: cadaa2f3bbaba8c496a6ece698b2ba7f12f340c4
2022-11-08 09:03:38 +00:00
Brian Gough
782294abae Merge pull request #10212 from overleaf/ii-dashboard-shorten-text-in-dropdowns
[web] Project dashboard add ellipsis to long text in the project filter dropdown on mobile

GitOrigin-RevId: 4b0d4e097ff0f26820c158086d8b089cbf1e364f
2022-11-07 09:03:38 +00:00
Brian Gough
db15c83c35 Merge pull request #10244 from overleaf/ii-jump-to-error
[web] Jump to error on files with double slash

GitOrigin-RevId: eec2ac6ba7a34d32f757f5e3a088e92d0d494422
2022-11-07 09:03:31 +00:00
M Fahru
b593bfa56e Don't show cm6 switch away survey if cm6 is not available
GitOrigin-RevId: e283fc424055f6df85015f02c83ad8314865697d
2022-11-04 09:06:10 +00:00
M Fahru
19dd2f67e2 Implement "switch away survey" when users switching back to ace from cm6 (#10201)
Implement legacy source editor survey:

* Force user to switch to cm6 if they haven't seen switch away survey

* Only show user switch away survey if they open ace from another editor

* We need to wait 3 seconds until the survey is being shown

* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users

* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey

* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that

* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses

GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
2022-11-04 09:05:50 +00:00
Mathias Jakobsen
aac9e6616e Merge pull request #10285 from overleaf/jpa-pdf-caching-ignore-404-from-fallback
[web] pdf-caching: double down on ignoring 404 from output.pdf requests

GitOrigin-RevId: 6b489180c221a29758b862884dae4ed6ed954a23
2022-11-04 09:04:53 +00:00
Mathias Jakobsen
a54b633726 Merge pull request #10111 from overleaf/mj-lezer-file-outline
[web] Parser backed file outline

GitOrigin-RevId: 0825f4887ba4dae24a14dd1880d07b791d0b4cd9
2022-11-04 09:04:33 +00:00
Jakob Ackermann
986d52b8d4 Merge pull request #10274 from overleaf/jpa-pdf-caching-check-response-size
[web] pdf-caching: bailout early on unexpectedly large response size

GitOrigin-RevId: b2b1cf0abf2367ec7a7f0f5ca7a9f67a03e2fa0d
2022-11-04 09:04:02 +00:00
M Fahru
a30e934692 Migrate "help menu" in editor left menu to react
GitOrigin-RevId: 7ebbfa693205de1f57b1d54e25c46cfb1851acc8
2022-11-03 09:03:49 +00:00
Jakob Ackermann
28c1cc2ea9 Merge pull request #10218 from overleaf/jpa-adjust-prefetching
[web] pdf-caching: try to prefetch other smaller chunks

GitOrigin-RevId: 2bf1d33d48c2026ec3794baaaef8346dc9104db3
2022-11-02 09:05:04 +00:00
Jakob Ackermann
6f00659865 Merge pull request #10246 from overleaf/jpa-pdf-caching-object-id-back-fill
[web] pdf-caching: double down on back-filling of object-id

GitOrigin-RevId: 751392dc5ed59eb621eca3813040c7b92ef1369e
2022-11-02 09:04:57 +00:00
Jakob Ackermann
85547ffe40 Merge pull request #10234 from overleaf/jpa-pdf-caching-ignore-404
[web] pdf-caching: stop counting 404s on the output.pdf as failure

GitOrigin-RevId: eb76570fdce3dd79b8e0ea961722e428446672ac
2022-11-02 09:04:21 +00:00
ilkin-overleaf
641db6b8d9 Merge pull request #10184 from overleaf/ii-ignore-received-chat-messages-test
[web] Outdated chat context tests for receiving messages

GitOrigin-RevId: c91cda5ada1c0ef26d41589cdbee31a8afd1e36a
2022-11-01 09:05:17 +00:00
ilkin-overleaf
feb5ae56f5 Merge pull request #10152 from overleaf/ii-settings-sso-unescape-characters
[web] Settings page incorrect character escaping

GitOrigin-RevId: 3bd27a905394d5476487038b4d30ed208d6901ac
2022-11-01 09:05:09 +00:00
ilkin-overleaf
7180ee8700 Merge pull request #10132 from overleaf/ii-dashboard-are-you-affiliated-migration
[web] Project dashboard are you affiliated migration

GitOrigin-RevId: 455ad915dd023c5fab3ce9a5165aa7e960915f1f
2022-11-01 09:05:02 +00:00
Jakob Ackermann
79e6fecc4a Merge pull request #10231 from overleaf/jpa-pdf-caching-bounds-debug
[web] pdf-caching: debug bounds when reassembling the range from chunks

GitOrigin-RevId: 11871241d07880ebd2659cc5d0feb1f2c29014b6
2022-11-01 09:04:12 +00:00
M Fahru
b85ae6e58e Migrate actions menu in editor left menu to react (#10102)
* Migrate actions menu in editor left menu to react

* Move margin from inline style to css file

* remove focus selector to avoid "highlighting" the button after closing modal and regain focus

* Add disabled state on word count button when the compiling is loading or failed

* Use div instead of button for disabled word count button

* Add accessibility text props when LeftMenuButton is disabled

* Add actions menu test cases and storybook components

* use util assign function and wrap function prop in usecallback

GitOrigin-RevId: 81ab104be21fbcf5dfbc72c07d29eeb32976c61f
2022-10-28 08:05:14 +00:00
Jakob Ackermann
a0c180d133 Merge pull request #10156 from overleaf/jpa-web-disable-prefetch
[web] pdf-caching: double down on disabling of prefetching

GitOrigin-RevId: 60ccea883786bad306a747b5a182982bc648bbbd
2022-10-26 08:04:13 +00:00
Miguel Serrano
c30f887727 Merge pull request #9936 from overleaf/msm-itm-referrer
`itm_referrer` for subscription attribution

GitOrigin-RevId: 2787b55e8b7e9e415e66abef8deb669f3adf0f0d
2022-10-26 08:03:52 +00:00
Jakob Ackermann
956cacaef7 Merge pull request #10139 from overleaf/jpa-split-test-min-chunk-size
[misc] add split test for a per request pdfCachingMinChunkSize

GitOrigin-RevId: 6a8a3c6267501789f2047a67b03db6ac6df427c3
2022-10-26 08:03:39 +00:00
Jakob Ackermann
abaecac268 Merge pull request #10007 from overleaf/jpa-pdf-caching-latency-compute
[web] collect latencyCompute metric from pdf-caching

GitOrigin-RevId: f20fa2b54078a7106b2413432c4f47375878a5d6
2022-10-26 08:03:31 +00:00
M Fahru
797b9b2532 Migrate download menu in editor left menu to react (#10046)
* Initialize left menu react migration and migration download menu UI to react

* Add test case to DownloadMenu react component

* Update test description and add an href check to one of the download link

* Extract storybook document mock to its own fixture file

* Add mockCompileOnLoad config on storybook editor scope
  - if mockCompileOnLoad: true (default), then the default compile mock will be used
  - If mockCompileOnLoad: false, then we have to provide a compile mock on the storybook component

* Create download menu storybook component

* Use a single "editor-left-menu" controller on the editor left menu migrations

* Remove the form import from the react version of the left menu

* Change inline style to utility class name

GitOrigin-RevId: 5357c7bfc78bf40f52b9b308df8f2b60d793fbf7
2022-10-25 08:04:19 +00:00
Jessica Lawshe
58ba814cd1 Merge pull request #10114 from overleaf/jel-dash-survey-container
[web] Fix desktop dash survey container click behavior

GitOrigin-RevId: 9e94ee572e348fca1f950698dd5a7449195a52da
2022-10-25 08:04:12 +00:00