Commit graph

132 commits

Author SHA1 Message Date
Jakob Ackermann
0c6e12a5cb Merge pull request #3189 from overleaf/jpa-mongodb-latest
[misc] upgrade mongodb package and run codemod for find projections

GitOrigin-RevId: 01291b3095779abe045e39b82f071ac84285a508
2020-10-06 02:04:39 +00:00
Jakob Ackermann
b3197b5f12 [misc] back-fill stubbing of mongodb package in sandboxed-module imports (#3209)
* [misc] back-fill stubbing of mongodb package in sandboxed-module imports

Unit tests are about 10 percent faster: 9m16s vs 10m8s.

* [misc] stubs: app code should have access to the ObjectId only

GitOrigin-RevId: 9a52186e190863c9463b3aeb98c3db68011926e4
2020-10-06 02:04:22 +00:00
Jakob Ackermann
e3c6637339 Merge pull request #3187 from overleaf/jpa-mongodb-native
[misc] migrate the app to the native mongo driver

GitOrigin-RevId: 9030b18c4cf62e3a01d3d8f450bf0e02f9f89c22
2020-10-02 02:04:18 +00:00
Jessica Lawshe
35897cf492 Merge pull request #3221 from overleaf/jel-institution-sso-email
Note which institution email was linked/unlinked in email alert

GitOrigin-RevId: 7e5ef743c8ec8b12c14f833fdd2b01676c95c1b6
2020-09-30 02:04:28 +00:00
Jessica Lawshe
9d3f2eb7dc Merge pull request #3227 from overleaf/jel-security-email-alerts
Move security alert handling to private function

GitOrigin-RevId: a59b6b0802986b2caa9e9715d80225eb11b163a9
2020-09-30 02:04:23 +00:00
Jakob Ackermann
12b407c18b Merge pull request #3186 from overleaf/jpa-mongodb-native-prep
[misc] mongodb: use findOne and find().toArray()

GitOrigin-RevId: 52457b1a73c1b49ff78ff9b3096dd80e330fcf25
2020-09-29 02:05:52 +00:00
Jakob Ackermann
018a44eeb5 Merge pull request #3185 from overleaf/jpa-normalize-mongo-imports
[misc] normalize mongo imports

GitOrigin-RevId: ac653d9982e0d36736b90f4c03d4c00be88ea76a
2020-09-25 02:04:20 +00:00
Chrystal Maria Griffiths
e6307237e4 Merge pull request #3207 from overleaf/jpa-drop-console-log
[misc] drop console.log calls in tests

GitOrigin-RevId: 156c94761e55648a92cf98d4c3cce20abb5de623
2020-09-19 02:04:38 +00:00
Jessica Lawshe
aee83bc0cf Merge pull request #3173 from overleaf/jel-institution-sso-audit-log
Update audit log when institution SSO is linked/unlinked

GitOrigin-RevId: 264ffbed025dccb4dd202f86afe545c3bf0c1f76
2020-09-15 02:04:24 +00:00
Timothée Alby
d9c435a77a Merge pull request #2957 from overleaf/ew-validate-saml-email
Validate saml email before register

GitOrigin-RevId: 6dcf3bccd280abd7bd3ced2d4fd2f69c590f74c1
2020-09-02 02:05:07 +00:00
Timothée Alby
bbf3132a16 Merge pull request #3096 from overleaf/jel-security-alert-primary-email
Send security alert email when primary email changed

GitOrigin-RevId: a01f38a2478dc280261b9a43ef1a01751d4601fb
2020-08-13 02:06:44 +00:00
Timothée Alby
3babf23444 Merge pull request #3091 from overleaf/jel-log-default-email-change
Update audit log for default email changes

GitOrigin-RevId: c7b4e4e888aa5ffd976062d72f660ded303f0885
2020-08-13 02:06:40 +00:00
Timothée Alby
d932c153c0 Merge pull request #3090 from overleaf/jel-async-setDefaultEmailAddress
Convert setDefaultEmailAddress to async

GitOrigin-RevId: 1f915af03c3dbe54b2cce439ecd55eeb3a3f35d3
2020-08-13 02:06:31 +00:00
Miguel Serrano
2e8f66ac6b Merge pull request #3075 from overleaf/msm-codemod-oerror-v3-logging
Replaced logger.warn statements with OError.tag()

GitOrigin-RevId: 4d821ec48a0006abb1fcffe07dbb5511c88f5b9a
2020-08-12 02:07:03 +00:00
Miguel Serrano
d2845d9a38 Merge pull request #3074 from overleaf/msm-update-oerror-logger-v3
Update o-error to v3 and logger-sharelatex to v3

GitOrigin-RevId: 5e6386f65b7893949336aa4ff021212aebd98f4a
2020-08-12 02:06:58 +00:00
Miguel Serrano
42c917d909 Merge pull request #3046 from overleaf/msm-cleanup-oerror-http
Finish o-error/http cleanup

GitOrigin-RevId: 1f8cf7f1e0503d1071c51b41ac136f7fb7f38872
2020-08-12 02:06:53 +00:00
Jessica Lawshe
7eee20f914 Merge pull request #3079 from overleaf/jel-log-password-update
Update audit log when password updated

GitOrigin-RevId: 3228e39e8a3682d6e77264cd6ee580f3fc40642a
2020-08-10 15:56:11 +00:00
Jessica Lawshe
33365e56bc Merge pull request #3061 from overleaf/jel-security-alert-clear-sessions
Send security alert email when sessions are cleared

GitOrigin-RevId: d1620214e84211edb69d7419ed64cf7618d1b460
2020-08-10 15:54:51 +00:00
Jessica Lawshe
c3450e4414 Merge pull request #3051 from overleaf/jel-log-when-email-added
Add entry to auditLog when user adds an email

GitOrigin-RevId: 797c85e18cb2b201e09fd2631b1e5ea066adfc37
2020-08-10 15:54:42 +00:00
Ersun Warncke
88683e9fec refactor SAMLController to use async throughout
GitOrigin-RevId: dafd76042f460cd34596c8c9023e2378145105e8
2020-08-10 15:54:15 +00:00
Jessica Lawshe
305f82459f Merge pull request #3040 from overleaf/jel-email-added-alert
Secondary email added alert

GitOrigin-RevId: 6bfe8eb54110a522281b32490b0107db8890ab64
2020-07-28 02:06:48 +00:00
Jessica Lawshe
cbe21d1f77 Merge pull request #3024 from overleaf/jel-log-cleared-sessions
Log cleared user sessions in user.auditLog

GitOrigin-RevId: 829c4ea037d897689c02c1dfe12d38542a7216c0
2020-07-28 02:06:43 +00:00
Jakob Ackermann
9d8e20d3d8 Merge pull request #3043 from overleaf/hb-increase-timeout-on-onboarding-email
Increase timeout on user onboarding email endpoint

GitOrigin-RevId: d7c9aaae407e31ae2e9cfea5a6dce853c2737ab9
2020-07-25 02:06:37 +00:00
Miguel Serrano
b0dc73a61c Remove HttpErrors.InternalServerError (#3027)
* Added legacyInternal() 500 to HttpErrorHandler
* replaced HttpErrors.InternalServerError being thrown with calls to HttpHandler.legacyInternal()

GitOrigin-RevId: 0b7086a9693b57cdf93976d4221b90315960e8bb
2020-07-23 02:06:50 +00:00
Jessica Lawshe
8f773318c1 Merge pull request #3023 from overleaf/jel-add-user-audit-log
User audit log

GitOrigin-RevId: 687448d5da5d783c6db0fadb53c020cc9c3876b9
2020-07-22 02:06:16 +00:00
Jessica Lawshe
d8b2537f48 Merge pull request #2983 from overleaf/jel-security-emails
Add security email template and switch institution SSO alerts to use it

GitOrigin-RevId: c6f07655165e352527a9efbcfffc5bd2f635405c
2020-07-22 02:06:11 +00:00
Eric Mc Sween
f251d661ed Merge pull request #3021 from overleaf/msm-oerror-remove-conflict-error
Replace ConflictError thrown with calls to HttpErrorHandler.conflict()

GitOrigin-RevId: 3b4d98af1b31e49ceab4b1b55b94b8f0323c8a9b
2020-07-21 02:06:18 +00:00
Miguel Serrano
6562f3003d Merge pull request #2985 from overleaf/msm-oerror-remove-unprocessable-entity-error
Replace UnprocessableEntityError with calls to unprocessableEntity() handler

GitOrigin-RevId: 4bba389c8cdf87a40137d49db571fa81aaac4239
2020-07-17 02:06:19 +00:00
Jakob Ackermann
53927bca95 [misc] move /user/activate into a module (#2962)
* [misc] move /user/activate into a module

Co-Authored-By: Nate Stemen <nate.stemen@overleaf.com>

* [misc] setup copybara for the new user-activate module

* [misc] move the /user/activate route behind a feature flag

...which is by default enabled.

Co-authored-by: Nate Stemen <nate.stemen@overleaf.com>
GitOrigin-RevId: 87fc5ae869a7e282ffdbeea0ff7b7c55b8b9b31b
2020-07-16 02:06:51 +00:00
Hugh O'Brien
eaa7491c2b Merge pull request #2948 from overleaf/hb-onboarding-email
User onboarding email

GitOrigin-RevId: 367fd8b6292024bfcad2139728c16cf00f2fb1cb
2020-07-14 02:06:47 +00:00
Ersun Warncke
387695c2b1 send tpds updates for all dropbox users
GitOrigin-RevId: b690693b98b0b6288a4c3a734d4ff2d28901a496
2020-06-18 02:10:38 +00:00
Shane Kilkelly
74313e4b82 Merge pull request #2883 from overleaf/ta-email-remove-features-refresh
Refresh User's Features After Removing Email

GitOrigin-RevId: 0085a5341a806d1d22f4a1fb5bb98c93675e242e
2020-06-05 02:09:52 +00:00
Miguel Serrano
cab1335371 Removed email lookup on CE user activation (#2879)
GitOrigin-RevId: 567936295ef3b043adc7bbd735970f5ca6d91b73
2020-06-03 10:31:27 +00:00
Simon Detheridge
ca916f0cac Merge pull request #2844 from overleaf/ta-admin-affiliations
Improve Admin Affiliations UI

GitOrigin-RevId: 1e3bcb425e1cb8463b2c3c7bbc757ab444b391a3
2020-05-23 03:18:25 +00:00
Eric Mc Sween
00bdc52fab Merge pull request #2840 from overleaf/jel-sso-redundant-subscription-notification
Redundant subscription notification if entitlement via SSO

GitOrigin-RevId: 8529204e78c3a43d87acbb375fea15c62cad48a3
2020-05-21 03:22:51 +00:00
Miguel Serrano
0583f7a667 Merge pull request #2746 from overleaf/ew-jpa-fix-deprecated-express-methods
[misc] fix express deprecations

GitOrigin-RevId: 78c730578c6a671f142837c98f98d5fd260332a5
2020-05-07 03:27:56 +00:00
Eric Mc Sween
d8615ddba3 Merge pull request #2761 from overleaf/jpa-user-controller-bail-out-next
[UserController] updateUserSettings: bail out after calling next(err)

GitOrigin-RevId: f1905c0c54f3feb98836443cbf8e080888d4901c
2020-04-24 03:31:04 +00:00
Jakob Ackermann
825d0701e8 Merge pull request #2742 from overleaf/jpa-hotfix-user-lookup
[UserPagesController] block arbitrary user lookups

GitOrigin-RevId: 4d88abbd0ad14289a73e7f502c0686f206617459
2020-04-14 03:19:24 +00:00
Jessica Lawshe
a433235310 Merge pull request #2643 from overleaf/jel-affiliations-cron-job
Ensure affiliations cron job

GitOrigin-RevId: 4ac6f8b29b1e1460d627a86172fcdf1fa27a59a8
2020-03-12 04:18:47 +00:00
Eric Mc Sween
b2ee3bf2bb Merge pull request #2634 from overleaf/jel-ensure-affiliations
Ensure affiliations after loading the settings page

GitOrigin-RevId: bf9982fb436d0e75d6fbd8418ca2d19e00fe3b66
2020-03-03 04:21:44 +00:00
Eric Mc Sween
174af14d46 Merge pull request #2610 from overleaf/ta-recurly-email-update-auto
Update Recurly Email on Default Email Change

GitOrigin-RevId: e2821d7bdc4bc6befff2152d92c76952c38694f9
2020-02-28 04:18:09 +00:00
Eric Mc Sween
403c9ae66b Merge pull request #2627 from overleaf/jel-decaf-cleanup
Decaf cleanup

GitOrigin-RevId: 9e0770ce6c5362ea288fc1706014aacd45608008
2020-02-28 04:18:04 +00:00
Timothée Alby
995dbc514d Merge pull request #2594 from overleaf/jel-flag-affiliation-when-registering
Flag unchecked affiliation when registering

GitOrigin-RevId: c9da12ceb5a1712c8c477222f967fb54eceef252
2020-02-21 04:21:16 +00:00
Timothée Alby
506543d6a0 Merge pull request #2605 from overleaf/jel-sso-registration
Do not block SSO registration on nonessential errors

GitOrigin-RevId: c9d6a7803aa8a48dbc1a8aae84d6f2588bad654e
2020-02-21 04:21:07 +00:00
Simon Detheridge
b812109cb7 Merge pull request #2593 from overleaf/ta-affiliation-licence-check
Check Licence on Affiliations Rather Than Institutions

GitOrigin-RevId: 7effe7f564ff953e60ed77bcdf92f3cb177d4aee
2020-02-19 04:20:39 +00:00
Simon Detheridge
9e6323caeb Merge pull request #2584 from overleaf/spd-duplicate-deleted-things
Prevent creation of (and clean up) duplicate deletedUsers and deletedProjects

GitOrigin-RevId: 5e52578b514f05779290c61cf7d4e630cc3ba6f7
2020-02-13 04:20:49 +00:00
Jessica Lawshe
528b2b5728 Merge pull request #2563 from overleaf/jel-add-affiliation-when-registering
Add affiliation when registering

GitOrigin-RevId: e1915bbdc0a4fef399ef9b4a2154ede31e282cc3
2020-02-12 04:21:10 +00:00
nate stemen
8253d0385c Merge pull request #2462 from overleaf/hb-mangled-links-confirmation
Mangled confirmation links fix

GitOrigin-RevId: 334704a93159044a617b7373398a7f384b08783e
2020-01-14 04:15:02 +00:00
Ersun Warncke
051700688b handle saml array values and first/last name
GitOrigin-RevId: f571cb466ac8618f09e6a77682bff1420060e457
2020-01-07 04:21:14 +00:00
Timothée Alby
7c9e83de2a Merge pull request #2441 from overleaf/em-cg-null-users
Remove existing sessions of deleted users

GitOrigin-RevId: cde9f8421fd9745b0922849a2269b44508d670f1
2019-12-10 08:25:09 +00:00
Ersun Warncke
2c335802ca remove excessive logging
GitOrigin-RevId: 62024bbe0415a4fdae66eb1b9c6707e5faec7cd1
2019-11-27 12:17:32 +00:00
Eric Mc Sween
4f9eb281b7 Merge pull request #2356 from overleaf/em-upgrade-test-deps
Upgrade test dependencies

GitOrigin-RevId: 0bda49dea086f525211836b6008f67bafa2bbe48
2019-11-18 14:53:42 +00:00
Shane Kilkelly
cbf08c599b Merge pull request #2333 from overleaf/em-unhandled-rejections
Fail tests on unhandled promise rejection

GitOrigin-RevId: 3cc53ce5b46c63c62374eb83f9442b8d6979272e
2019-11-07 10:48:36 +00:00
Jessica Lawshe
e27577bd5b Merge pull request #2231 from overleaf/jel-institution-sso-link-error
Add SSO error handling for when identifier linked

GitOrigin-RevId: e2bfa4dba896767d985476ecb78fcee86512a381
2019-10-15 16:22:37 +00:00
Eric Mc Sween
9a492257af Merge pull request #2220 from overleaf/jel-email-confirmation
Email confirmation only for non-institution SSO emails

GitOrigin-RevId: 95bd0ce077031c11b9d60d2f736a1abe7431a265
2019-10-14 13:37:57 +00:00
Eric Mc Sween
526d4982a1 Merge pull request #2219 from overleaf/jel-institution-email-already-exists
Check for email before adding institution identifier

GitOrigin-RevId: 71f498116c8c8df2c3c1a33eafce3e56c87e7ee0
2019-10-14 13:37:50 +00:00
Jessica Lawshe
61d895c8fc Merge pull request #2210 from overleaf/jel-provider-id-institution-registration
Include provider ID with email data for institution registrations

GitOrigin-RevId: a752005c03494bab717be0cbb915cbcb7a0aa729
2019-10-07 15:41:56 +00:00
Jessica Lawshe
d8e6535691 Merge pull request #2184 from overleaf/jel-unlink-institution-and-email-notifications
Unlink institution login and send email link/unlink notifications

GitOrigin-RevId: d0fe96804d69e3c332c2b866fad5af026b5e2f8f
2019-10-03 14:34:58 +00:00
Eric Mc Sween
039b5eaba0 Merge pull request #2167 from overleaf/jel-saml-account-settings-layout
Account settings layout for institution SSO

GitOrigin-RevId: d9c9e5eeb3b4a215456b0f5294139c1b8d4968c3
2019-09-30 13:36:41 +00:00
Simon Detheridge
6e7007ef3e Merge pull request #2170 from overleaf/ta-confirmation-email-missing-fix
Prevent Email Confirmation If Email Is Missing for User

GitOrigin-RevId: cab9667103b0a5596cf067f85f747b1481ca4e66
2019-09-25 14:48:25 +00:00
Simon Detheridge
8ec2f1a896 Merge pull request #2157 from overleaf/jel-saml-logout-redirect
Redirect handling after logging out

GitOrigin-RevId: 01562dbe71ff4f3571fb0d433b96ccca34aad24e
2019-09-25 14:48:19 +00:00
Simon Detheridge
111d22d260 Don't leave dangling users in mailchimp when change-address fails (#2165)
* Don't leave dangling users in mailchimp when change-address fails

Also prevents upserting of users when unsubscribing

bug: overleaf/issues#2220
bug: overleaf/issues#2301
bug: overleaf/issues#2302

* Tidy up NewsletterManager. Enable deletion of contacts on account delete.

GitOrigin-RevId: ab7cde7a7b7018b37dea54ffa154e02c5aea0244
2019-09-25 14:47:57 +00:00
Ersun Warncke
3c1f64782f convert UserCreator to async/promises
GitOrigin-RevId: a040b9dd65aa834d1dd9e552ffc1434a17c43eae
2019-09-25 12:33:43 +00:00
Brian Gough
837599d89c Merge pull request #2146 from overleaf/bg-fix-redis-user-session-expiry
fix expiry of user sessions in redis

GitOrigin-RevId: e53aa93bba99fe0cd632ac8bce36c0228e20d04a
2019-09-12 08:18:43 +00:00
Miguel Serrano
dc6e4b3a12 Added missing email field when registering user token (#2130)
GitOrigin-RevId: f7aaeae1f82e0188c838d7d1d975a81664950f78
2019-09-04 11:17:15 +00:00
Eric Mc Sween
869fcf7952 Merge pull request #2089 from overleaf/em-mailchimp-unsubscribe
Handle error on Mailchimp unsubscribe when deleting users

GitOrigin-RevId: 8923480e6d50de45003fd7741610f995753a412b
2019-09-03 15:25:01 +00:00
Miguel Serrano
9a8a182c1b Fix UserGetter email retrieval with affiliations disabled (#2085)
GitOrigin-RevId: f868333f3c18f674b7ba9c387315c2d5ad1fd80b
2019-08-19 15:19:57 +00:00
Simon Detheridge
a815c6a3e8 Merge pull request #2016 from overleaf/sk-fix-session-data
Fix mismatched user session data

GitOrigin-RevId: d464d05431ac86e279109aa3f7bc26dcf76662f4
2019-08-07 15:29:31 +00:00
Simon Detheridge
7588393580 Merge pull request #2047 from overleaf/spd-eslint-mocha-arrows
Enforce consistent callback style in mocha tests

GitOrigin-RevId: a64c293dae6926ef5831abe97eaf2044942a5c85
2019-08-07 15:29:25 +00:00
Timothée Alby
018b2cc474 Merge pull request #2010 from overleaf/ta-http-errors
Add More Http Errors

GitOrigin-RevId: d7aab42e1c7cec8757d6f2c6fc839a6c3f204351
2019-07-31 08:33:25 +00:00
Hugh O'Brien
a638f9e567 Merge pull request #1976 from overleaf/hb-v1-history-metadata-from-mongo
Fetch history metadata for v1 users

GitOrigin-RevId: a65971dbef2be02c17ff07b1bf22c0f7b15c1780
2019-07-29 09:58:35 +00:00
Simon Detheridge
285edfff36 Merge pull request #1994 from overleaf/ta-missing-stub
Add missing EmailHandler stub

GitOrigin-RevId: d497807068623e1338a95d2dfa02c56726ca39d1
2019-07-25 15:20:51 +00:00
Ersun Warncke
d9b5941642 do not use v1 for setting default email
GitOrigin-RevId: 00d4610ae55c0a90699d4bc79e7d08d432087abe
2019-07-23 10:59:58 +00:00
Timothée Alby
e38a86d9f4 Merge pull request #1934 from overleaf/ta-error-type-handler
Implement ErrorType Handler

GitOrigin-RevId: 7cd735bb248c74815182e10fd54d687dd35914b8
2019-07-19 09:51:05 +00:00
Simon Detheridge
bf740f1e25 Merge pull request #1959 from overleaf/spd-integration-soft-deletion
Integration: Merge soft-deletion features into master
GitOrigin-RevId: 83baf730be2f256ad0d02271600392fda144b761
2019-07-18 14:34:22 +00:00
Ersun Warncke
d624c29b6f remove v1 deps for password change/reset
GitOrigin-RevId: be25f19ae589c50bfde0b170860127fa8d6f63b7
2019-07-17 15:09:24 +00:00
Ersun Warncke
a61a59be20 remove user.overleaf.id dependencies
GitOrigin-RevId: ca495010a4f0ee462bde696dd0c442b2bd57bf30
2019-07-17 15:09:18 +00:00
Shane Kilkelly
238e2b2565 Merge pull request #1937 from overleaf/spd-sandboxedmodule-global-console
Add 'console' to SandboxedModule globals

GitOrigin-RevId: fad442ca128561a4fa193b929f217cf31ad0f043
2019-07-15 10:44:47 +00:00
Timothée Alby
e73a5d9103 Merge pull request #1923 from overleaf/ta-error-log-level
Reduce Log Level

GitOrigin-RevId: 63a8859e6b78cb0774a28069089f4bce73eb91ec
2019-07-01 14:06:36 +00:00
Simon Detheridge
757ae39487 Merge pull request #1899 from overleaf/spd-implicit-return-tests
Decaf cleanup: Remove implicit return from 'it' and 'describe' in tests

GitOrigin-RevId: f297820e6212dddc0d60697a2fe1612ef27403b6
2019-06-21 13:58:57 +00:00
Timothée Alby
e659703745 Merge pull request #1842 from overleaf/ta-remove-v1-sync
Remove v1 Sync on Features Refresh

GitOrigin-RevId: a99e0a74c4fc503bf81d0b847b3f331b3228e24f
2019-06-11 13:34:11 +00:00
Alasdair Smith
0ca81de78c Merge pull request #1717 from overleaf/as-decaffeinate-backend
Decaffeinate backend

GitOrigin-RevId: 4ca9f94fc809cab6f47cec8254cacaf1bb3806fa
2019-05-29 09:32:21 +00:00