Commit graph

1046 commits

Author SHA1 Message Date
David
56d396a6cf Merge pull request #20617 from overleaf/dk-review-indicator-hover
Improve "mini" view popovers for new review panel

GitOrigin-RevId: ff5fc0af70bd9660d5cc17437b25824ef4c9a704
2024-10-14 10:59:38 +00:00
David
a331ac6116 Merge pull request #19796 from overleaf/dp-more-comments-2
Add More Comments buttons

GitOrigin-RevId: 3cd6539683cbc53ceb63488ab9e9b0ffe53e079c
2024-10-14 10:59:29 +00:00
David
70535f9baa Merge pull request #20713 from overleaf/dp-fix-dark-mode-styles
Set default review panel color so that it renders correctly in a dark editor theme

GitOrigin-RevId: a3bbaef35dca294822d76eef2e18ca3f03f11857
2024-10-14 10:59:20 +00:00
Davinder Singh
2d737810d4 Merge pull request #20720 from overleaf/ds-cms-bs5-blog-sidebar
CMS BS5 Migration - Update the blog sidebar to match the figma design.

GitOrigin-RevId: d5ea3917d88d78972e610b1b7c6766e441af6f37
2024-10-14 10:58:32 +00:00
Jessica Lawshe
7cef8b5bdc Merge pull request #20723 from overleaf/jel-cms-lists-headers
[web] Reduce bottom margin on headers in styled lists

GitOrigin-RevId: 0cbf93d4ef4e251afe71b4b726346b4d9e382f4f
2024-10-14 10:57:48 +00:00
Jessica Lawshe
af811ec1ed Merge pull request #20612 from overleaf/as-cms-card-styles
[web] CMS - Add grey and green border cards

GitOrigin-RevId: dc421ec9032e9d695cba1af4a9536d63cb476400
2024-10-01 08:06:03 +00:00
Jessica Lawshe
514bf1f7f8 Merge pull request #20680 from overleaf/ds-cms-bs5-font-size-override
BS5 Migration CMS - Adding UL and OL to the override list in CSS styling

GitOrigin-RevId: 0919f6b1c5ebb2c6d5764a425189e3395bce903a
2024-10-01 08:05:59 +00:00
M Fahru
5b0bf3f915 Merge pull request #20662 from overleaf/mf-fix-bs5-nav-tab-li-hover
[web] BS5 CMS - Fix tab nav hover effect (remove underline)

GitOrigin-RevId: fdcb566b63afd567c1cf0ef95e72c66491137f30
2024-10-01 08:05:54 +00:00
M Fahru
9ee6954bc1 Merge pull request #20543 from overleaf/gtm-cms-icons
[web] Implement "Element | Icon" content type in CMS

GitOrigin-RevId: 369eed94d9306ef6fe5c974bb72231c8fb0b5560
2024-10-01 08:05:46 +00:00
M Fahru
0428a017a8 Merge pull request #20512 from overleaf/mf-bs5-language-picker
[web] Fix language picker color for website redesign footer

GitOrigin-RevId: 4ba974af79de5eed0d40e3ff7da3daf616525133
2024-10-01 08:05:42 +00:00
Jessica Lawshe
138f99fe49 Merge pull request #20701 from overleaf/jel-styled-latex-cms
[web] Render new styled text option

GitOrigin-RevId: 5e9ae7825fdd0daa5a1ea81345a0bc5d3a86ce5c
2024-10-01 08:05:38 +00:00
Antoine Clausse
9997c4874f [web] Migrate /user/subscription to BS5 (#20513)
* [web] Initialize BS5 in subscription page

* [web] Update subscription-dashboard.tsx for BS5

* [web] Update row-link.tsx for BS5

* [web] Update modals

* [web] Add `btn` to `btn-inline-link` classes

* [web] Update circle change-to-group circle price element

* [web] Replace `list-item-with-margin-bottom` with `mb-3`

* [web] Update form elements to BS5

* [web] Use `useContactUsModal`

* [web] Adjust tables margin/padding, and more

* [web] Update change-to-group-modal.tsx

* [web] Add gap to subscription buttons

* [web] Remove subscription page colspan for md and above

* [web] Use Notification component

* [web] Update "leave group" buttons

* [web] Fix tests: add `ol-user` meta tag

* [web] Nest .hover-highlight in #subscription-dashboard-root

* [web] Update to OLRow/OLCol

* [web] Update to OLButtons

* [web] Update to OLFormGroup

* [web] Naming: use BSversion prefix

* [web] Set CancelSubscriptionButton as ghost directly in component

* [web] Set "Plan" font size

* [web] Simplify cancel-subscription buttons

* [web] Remove `--neutral-10` ModalFooter background

* [web] Simplify circle styles

* [web] Center discount badge

* [web] Update fieldset label

* [web] Add `<ul>` around RowLink

* [web] Define SCSS for row-link component

* [web] Remove some use of utility classes

* [web] Revert and update `fieldset` changes (fixes tests)

* [web] Fixup some more OLButtons

* [web] Fixup use of OLRow/OLCol

* [web] Reduce spacing below "legend-as-label"

* [web] Use h5 instead of small in OLModalTitle

* [web] Revert OLCol removal on lg screens

I had removed them by mistake because I wasn't using the proper breakpoints

* [web] Add backdrop to nested modal ContactUsModal

* [web] Don't prefill project URL in ContactUsModal

* [web] Fix lint

* [web] Share `className` prop in BS5 and BS3 modals

* [web] Set sub-title font sans serif (BS3)

* [web] Update remaining Alerts to OLNotification

GitOrigin-RevId: 7fd975ae3e992cebfaf71d4e182f8e13ec886d09
2024-10-01 08:05:14 +00:00
Antoine Clausse
d4bf47932e [web] Migrate /subscription/invites/:token to BS5 (#20640)
* [web] Wiring work for `/subscription/invites/:token` BS5 migration

* [web] Add SCSS for .enrollment-invite

* [web] Update invite_logged_out PUG file for BS5

* [web] Update `GroupInviteViews` (and children) to BS5

* [web] Update `InviteManaged` to BS5

* [web] Update Logout button

* [web] Update subtitles

This removes the `text-overflow:ellipsis`. I think it's better without it, because it can be an accessibility issue.

* [web] Add margin on inner-card

* [web] Style action buttons in InviteManaged

* [web] Add missing container around Row

This was causing the row to overflow the body.

Increased the col width to compensate.

* [web] Fixup lint

* [web] Fix `ManagedUserCannotJoin` title in BS3 (!)

I checked all the other `OLNotification`: we don't use `title` anywhere else

* [web] Put title in OLNotification content

See https://github.com/overleaf/internal/pull/20640#discussion_r1777551257

* [web] Use translations for "aria-label="Email address""

* [web] Handle OLButton `isLoading` in `bs3Props`

* [web] Remove duplicated `btn` class

* [web] Add margin-bottom to InviteManaged title and fix logout button CSS in BS3

* [web] Adjust col class in Pug file for BS3 and BS5

* [web] Revert migration to OLNotification

Revert back to `@/shared/components/notification`

* [web] Add note to remove .team-invite-name after BS5 migration

* [web] Set `btn-link-logout` in BS3 only

* [web] Update OLButton so other classNames automatically get passed to the BS3 implementation

* [web] Revert OLButton changes for BS3 classnames

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>

* [web] Update services/web/modules/group-settings/frontend/js/components/invite-managed.tsx

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>

* [web] Use OLFormGroup `controlId`

---------

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
GitOrigin-RevId: 64b3f79c83002a9c9585bfb8e344e80b2e8eac5c
2024-10-01 08:05:09 +00:00
ilkin-overleaf
8c4c118da9 Merge pull request #20707 from overleaf/ii-bs3-btn-group
[web] BS3 button group colours fix

GitOrigin-RevId: 6986336d04b9e5f30531a9bc2836444e7b12907f
2024-10-01 08:05:00 +00:00
ilkin-overleaf
35728d7681 Merge pull request #20436 from overleaf/ii-bs5-editor-toolbar
[web] BS5 editor toolbar

GitOrigin-RevId: a517fd52d648d165e89231d6f5551c026a951c43
2024-10-01 08:04:42 +00:00
Davinder Singh
ecbafcfbe8 BS5 CMS migration - Add border radius on images option to CMS (#20659)
* introducing new classes for border radius

* adding if else for conditionals

GitOrigin-RevId: dae2a11e3ba98801d9559127f93af2dbe06a1d89
2024-09-30 08:05:08 +00:00
Davinder Singh
610e3839ae BS5 Migration to CMS - Adding the new styling for form labels (#20582)
* adding styling for form label under bs5 styling

* moving label color to website-redesign

* adding spacing-02

* fixing a linting error

* adding label styling within website-redesign

GitOrigin-RevId: bc99c13e5d60dc68c3557db752292faf5eb5a34e
2024-09-30 08:05:00 +00:00
David
8c09b5866a Merge pull request #20635 from overleaf/dk-fix-review-footer
Fix review panel footer and header positioning

GitOrigin-RevId: 6da19c26fa844d0bf673cbcb113d3c47a6d04936
2024-09-27 08:04:43 +00:00
David
e253b48bc0 Merge pull request #20634 from overleaf/dp-resolved-comments-font
Add explicit font-size to review-panel-entry-content

GitOrigin-RevId: 7c0dd2a441ad011bd9d706f1f6a1f965d3b80b51
2024-09-27 08:04:30 +00:00
Jessica Lawshe
3561e6315f Merge pull request #20602 from overleaf/jel-cms-bottom-align-card
[web] Fix bottom alignment in cards on CMS BS5

GitOrigin-RevId: a09e7f21b0eab3642b7c22cec39a08842f8614a5
2024-09-26 08:06:06 +00:00
Jessica Lawshe
518647c13d Merge pull request #20601 from overleaf/jel-cms-max-width
[web] Use `.container` `max-width` from Bootstrap 5 for CMS sections

GitOrigin-RevId: 1642de2024723584be7c7ad84d7cda0ee4af05a6
2024-09-26 08:06:02 +00:00
Jessica Lawshe
771397beac Merge pull request #20594 from overleaf/jel-premium-card-p
[web] Do not change `p` color in premium cards

GitOrigin-RevId: 4115416459b75db31b30cf31787cf027c1179e41
2024-09-26 08:05:55 +00:00
Rebeka Dekany
ca49eada95 Merge pull request #20589 from overleaf/rd-bs5-dropdown-fix
[web] Fix the dropdown toggle arrow positioning on the tag menu

GitOrigin-RevId: 41935fd059c3a2a197f5f445d8c72c82415de6d7
2024-09-26 08:05:51 +00:00
Rebeka Dekany
ac74ba9e8c Merge pull request #20501 from overleaf/rd-filetree-toolbar
Migrate the file tree toolbar to Bootstrap 5

GitOrigin-RevId: 00ebe585206bf163bf9a00aa56b52d43effd5605
2024-09-26 08:05:47 +00:00
Rebeka Dekany
abb59e4603 Merge pull request #20298 from overleaf/rd-ide-filetree
[web] Migrate the file tree on the editor page to Bootstrap 5

GitOrigin-RevId: e2efec26242c8cdab37a54bc182b83bfb0f1eb3c
2024-09-26 08:05:43 +00:00
Antoine Clausse
d480faf60b [web] Make the welcome page cards all have the same widths (implementation 2) (#20570)
* welcome page adjusted columns in BS5

* [web] Fix card color

* [web] Fixup card width in BS3

* [web] Fix lint

* [web] Fix cards text color in BS3

* [web] Fix cards positioning in BS3

* [web] Prevent cards from becoming too large on big screens

---------

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
GitOrigin-RevId: 9b91c073a62dae7cad4402908a34f9880ecdb0ac
2024-09-26 08:04:55 +00:00
Jessica Lawshe
e4b3ee8988 Merge pull request #20508 from overleaf/as-cms-bs5-link-colours
[web] Adjust link behaviour for Website Redesign in BS5

GitOrigin-RevId: d09831de1f51c4e2a9bc06b0c9fd9f4a1909d7f0
2024-09-25 08:06:19 +00:00
Jessica Lawshe
e8f602db9b Merge pull request #20545 from overleaf/jel-remove-comment
[web] Remove commented out CSS code

GitOrigin-RevId: 8d6c392735eb2637a3c7bbc4cd4d17d5dc92d1e4
2024-09-25 08:06:11 +00:00
Jessica Lawshe
ecb0655241 Merge pull request #20572 from overleaf/jel-cms-styled-list
[web] Render styled lists on `Element | Content`

GitOrigin-RevId: 9d951e2339a85cc89b14991bbde2bc4d4316852a
2024-09-25 08:06:06 +00:00
Jessica Lawshe
d43efc2d7c Merge pull request #20523 from overleaf/jel-cms-padding-fix
[web] CMS BS5 - Fix mobile top padding when columns reversed, apply `max-width` to rows as cards

GitOrigin-RevId: 0c8745c171dc8e24389b2e54e4d6fd605c30e145
2024-09-25 08:06:01 +00:00
Jessica Lawshe
705035a972 Merge pull request #20544 from overleaf/jel-cms-bs5-fonts
[web] Font size overrides for CMS BS5 pages

GitOrigin-RevId: 0803b3b76b3a1c60a26bf56d94a27d67270b7313
2024-09-25 08:05:55 +00:00
Davinder Singh
ba0f95aaf0 BS5 Migration - Blog post cards migration to BS5 (#20539)
* copying blog-posts.less into blog-posts.scss, will not compile yet

* making variable changes in the file

* adding card-body under blog-post

* adding spacing-09 to the list

* format:fix

* rendering bs5 for blog/blog_post

* adding card-body for blog post page card

* fixing some linting errors

* adding neutral-40 as a replacement of ol-blue-gray-2

* selecting the closest spacing

* removing margin

GitOrigin-RevId: e0cad15cec2adccb41d773e38feb99d9fd9f5e07
2024-09-25 08:05:38 +00:00
Davinder Singh
4c2425fe25 Premium Badge - BS5 migration (#20496)
* migrating premium badge to BS5 and changing the unit test

* fixing unit test

* using badge badge-prepend classes for the premium badge

* fixing unit test

* adding font-weight variable

* removing unused CSS

* adding aria-hidden

GitOrigin-RevId: a1ab2eeedd95ee500c21607abd09a0a8a07289f0
2024-09-25 08:05:33 +00:00
Davinder Singh
248fc3699a CMS Bootstrap 5 migration - Tabs using bootstrap 5 classes (#20478)
* adding classes according to bootstrap 5 tabs

* adding JS for tabs handeling in BS5

* adding styling for tabs to match the redesign styling

* making sure tabs are being highlighted when active

* adding a scroll-margin-top to have some extra space

* removing extra import, it is not needed here because we already import it in bootstrap-x.js files

* using the media-breakpoint-down for a media query styling

* introducing .nav-tabs-container to make the tab triggers horizontally scrollable

* creating a mixin box-shadow-button-input under scss for bootstrap-5

* moving border-width-base to tabs.scss

* aligning tabs to the left under screen size of 768px

* removing focus-style mixin from scss files becuase it was a duplicate

GitOrigin-RevId: 45780c62681fc9b61961f5436d2d55de66a976b6
2024-09-25 08:05:21 +00:00
David
7002d1e4bf Merge pull request #20511 from overleaf/dp-review-panel-footer
Update UI for new review panel footer

GitOrigin-RevId: 8beb554f78fa5876d5349981d96b44a16ab5567c
2024-09-25 08:05:07 +00:00
David
ab43a44b76 Merge pull request #20526 from overleaf/dp-mini-review-panel
Styling updates for mini review panel

GitOrigin-RevId: 1bbf7f1d2e02f5d6f3f50937d2b7b9cdc5a0878f
2024-09-25 08:05:02 +00:00
MoxAmber
2c53687ea1 Merge pull request #20477 from overleaf/as-jel-cms-bs5-quotes
[web] Use Bootstrap 5 for CMS Quotes

GitOrigin-RevId: 9f3699cd4588412176466ebfea1ddfa160da1535
2024-09-20 08:05:55 +00:00
MoxAmber
4b281becdd Merge pull request #20468 from overleaf/jel-cms-bs5-top-padding
[web] Update top padding on CMS BS5 pages

GitOrigin-RevId: c663886a9f28992a7056ac3f568980d1a5603699
2024-09-20 08:05:50 +00:00
MoxAmber
68eaec6d8e Merge pull request #20485 from overleaf/jel-cms-bs5-mobile-breakpoint
[web] Update mobile breakpoint for CMS pages using BS5

GitOrigin-RevId: b855faf378b03788caff8574747d88b96706de2a
2024-09-20 08:05:46 +00:00
MoxAmber
d7a482966f Merge pull request #20463 from overleaf/as-jel-cms-text-align
[web] Option on CMS pages to center text only on destkop or mobile devices

GitOrigin-RevId: fd5006e4b46c53627cdc39cc41ea75f016411003
2024-09-20 08:05:31 +00:00
David
08a6caab80 Merge pull request #20405 from overleaf/dp-fix-empty-state-position
Fix positioning of review panel empty state

GitOrigin-RevId: d1c93e1a8bef59ad68e9f3e62106a949b7f9efdd
2024-09-20 08:04:57 +00:00
Jessica Lawshe
f2d986feb8 Merge pull request #20431 from overleaf/jel-cms-bs5-card
[web] Update cards for CMS BS5 pages

GitOrigin-RevId: d398f534993c187c2010a69d8ae0e5a067ab2a40
2024-09-19 08:05:04 +00:00
Jessica Lawshe
7ca2e47d78 Merge pull request #20429 from overleaf/jel-cms-bs5-vertical-spacing
[web] Always set top padding on columns on mobile for BS5 CMS pages

GitOrigin-RevId: 1532d960686ad324216a414e44a45ad5479ab564
2024-09-19 08:04:55 +00:00
Jessica Lawshe
a066e96b92 Merge pull request #20428 from overleaf/jel-cms-bootstrap5
[web] Updates for CMS pages using BS5 and new site design

GitOrigin-RevId: 08b66d1bfb3062a229f16a44efe70527f6fa67a7
2024-09-19 08:04:51 +00:00
Jessica Lawshe
3b839dc885 Merge pull request #20382 from overleaf/jel-bs5-website-redesign
[web] Begin to migrate `website-redesign.less` to BS5

GitOrigin-RevId: e3cf2162e819f7c137bbc2715dcd9a9fe6d72f3f
2024-09-17 08:06:21 +00:00
Jessica Lawshe
0d1c9ce79d Merge pull request #20372 from overleaf/jel-content-page-css-bs5
[web]  Copy content page CSS for BS5 build

GitOrigin-RevId: b12bc6e187d2f2709129948604f29f1092cb6bd9
2024-09-17 08:06:16 +00:00
Jessica Lawshe
8fc888bc90 Merge pull request #20349 from overleaf/jel-cms-css-bs5
[web] Copy CMS CSS for BS5 build

GitOrigin-RevId: 014c7014a14e242acf6d1104c472ad6971b62880
2024-09-17 08:06:08 +00:00
Jessica Lawshe
3746abc640 Merge pull request #20346 from overleaf/jel-font-bs5
[web] Copy text rendering CSS from BS3 for BS5

GitOrigin-RevId: a07fdc70aa0da6096f349c61ea6d74546724844a
2024-09-17 08:05:58 +00:00
Jessica Lawshe
e3c9017a85 Merge pull request #20328 from overleaf/jel-plans-tooltip
[web] Fix opacity on tooltip on light touch redesign plans page

GitOrigin-RevId: 3254fec50356815e223dec8e13e1c6351d642a1e
2024-09-17 08:05:53 +00:00
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00