Alf Eaton
ff7eec48de
[cm6] Improve performance of the editor toolbar ( #13915 )
...
* Memoize figure and math dropdowns
* Only build section heading overlay when open
* Memoise currentLevel
* Remove memo from ToolbarOverflow
* Calculate listDepth in the container component
* Avoid using document.querySelector
GitOrigin-RevId: d5ec8817d35d04e0e2c60c8eecc8678ede69f82a
2023-07-19 08:04:24 +00:00
Alf Eaton
930cec2189
Calculate overflow when languageName
or visual
change ( #13872 )
...
GitOrigin-RevId: f2d200d0d34e810688defe78b8143829f095df9f
2023-07-19 08:04:20 +00:00
Alf Eaton
b284434ad2
[visual] Move the cursor after leading whitespace when creating a new list item on Enter ( #13828 )
...
GitOrigin-RevId: 2f5941627b64fb53efce0bdd6f2d888986f45a9d
2023-07-19 08:04:16 +00:00
Alf Eaton
05adb9d14d
[visual] Add decorations for theorem environments ( #13708 )
...
GitOrigin-RevId: ba78be534fd7efba7d8722a214d69b21b0e3917c
2023-07-19 08:04:12 +00:00
Tim Down
38c673d057
Merge pull request #13720 from overleaf/td-review-panel-entry-pos
...
React review panel entry positioning
GitOrigin-RevId: c22617b1d3243b7d54b093426358aeb291421b9e
2023-07-19 08:03:52 +00:00
Eric Mc Sween
cce1a91205
Merge pull request #13897 from overleaf/ae-completion-event
...
Fix regular expression for completion event logging
GitOrigin-RevId: fbe3b91722fe40d4bb1116f23a78ebcebbd02b37
2023-07-17 11:13:27 +00:00
ilkin-overleaf
66f540c6eb
Merge pull request #13845 from overleaf/ii-rp-incorrect-date
...
[web] Fix date issues in review panel
GitOrigin-RevId: 447185cc97aae5a2e6d8944be578fa103b39325b
2023-07-17 11:07:35 +00:00
ilkin-overleaf
680d5e0a6f
Merge pull request #13839 from overleaf/ii-rp-word-break
...
[web] Break long text to new line in change entry
GitOrigin-RevId: e0effb86b08e7fe04b25040a8f3775c047203828
2023-07-17 11:07:26 +00:00
ilkin-overleaf
dbef201e3f
Merge pull request #13801 from overleaf/ii-review-panel-migration-upgrade-track-changes-modal
...
[web] Create upgrade track changes modal
GitOrigin-RevId: 704ddef862ea9a2f8ca2bf63880da6e88f783724
2023-07-17 11:07:16 +00:00
ilkin-overleaf
84bbdf9772
Merge pull request #13767 from overleaf/ii-review-panel-migration-in-editor-widgets
...
[web] Create in editor widgets
GitOrigin-RevId: 53dfb9935ee59bbdedc353aad5e5b19f389a513c
2023-07-17 11:07:06 +00:00
Mathias Jakobsen
b008c19dc3
Merge pull request #13836 from overleaf/mj-bibtex-identifier
...
[lezer] Change bibtex identifier to deny-list
GitOrigin-RevId: 005b256a22acbafbeefd641cec82460f603fbc7a
2023-07-17 11:06:22 +00:00
Mathias Jakobsen
37582f7b72
Merge pull request #13805 from overleaf/mj-bibtex-content-outside
...
[lezer] Allow content outside declarations in bibtex
GitOrigin-RevId: 8051db5567eeb52c3b12f63afafe07a7a97df650
2023-07-17 11:05:37 +00:00
Alf Eaton
bbbf38d76b
Add decorations for textmd and textsf ( #13716 )
...
GitOrigin-RevId: c5bedf2260c4e075e458ac38f90e5746dccdde81
2023-07-17 11:04:50 +00:00
Alf Eaton
809172d531
Decorate verbatim and lstlisting environments ( #13722 )
...
GitOrigin-RevId: 2e5af20bf2fe0c7769011ecd26797e93290b4fdb
2023-07-17 11:04:40 +00:00
Alf Eaton
b0b829f69b
Add syntax highlighting for Ampersand nodes ( #13737 )
...
GitOrigin-RevId: 39c81ecb765adc4b33244b5f0f1eab81594dcba1
2023-07-17 11:04:30 +00:00
Alf Eaton
e7d36903bb
[cm6] Add Tilde to the LaTeX grammar ( #13740 )
...
GitOrigin-RevId: 98a2e968056ba4d6e36310d4ea0f7ff2f25e373a
2023-07-17 11:04:21 +00:00
Alf Eaton
faff4a87b4
Never decorate inside math ( #13810 )
...
GitOrigin-RevId: c28d0aaa3ce267d989db779c13f6b3e91f376686
2023-07-17 11:04:11 +00:00
Alf Eaton
e86c5dc137
[cm6] Add analytics for bold and italic shortcuts ( #13785 )
...
GitOrigin-RevId: 62f2f9976778083b7ca6566f79e3d055585e7bb7
2023-07-17 11:04:01 +00:00
Alf Eaton
48e758a5fe
Record each completion selection for analytics ( #13665 )
...
GitOrigin-RevId: bc8e92ceca51f6365c4311204a35fc85914969b0
2023-07-17 11:03:43 +00:00
Alf Eaton
5a786029a3
[cm6] Hide list indentation shortcuts in button tooltips in Code Editor ( #13797 )
...
GitOrigin-RevId: d5184310d81953d9765f6e1ae2343fdeb824ae01
2023-07-17 11:03:34 +00:00
Alf Eaton
34fa28c90b
Hide most toolbar buttons for non-latex documents ( #13725 )
...
GitOrigin-RevId: 3bf487d86d1a465a1653b40891277380270ea7ff
2023-07-17 11:03:16 +00:00
Domagoj Kriskovic
8ab6239a24
[cm6] support \emph and \textbf in maketitle ( #13703 )
...
* [cm6] support \textbf in maketitle
* support for emph
* added support for \\textbf
* fix overlapping ignored ranges
* fix overlapping fn, added test
* multiple maketitle cases in the same test
* prettier
* simplify from calculation
* added test cases from #13736
GitOrigin-RevId: 00dcf15d6d62903ae30b387a16929e68dde8ca1b
2023-07-17 11:02:11 +00:00
Domagoj Kriskovic
9cb0122ea3
[visual] support for multiple authors in /maketitle ( #13713 )
...
* [visual] support for multiple titles in /maketitle
* support \and in author name
* using isMatchWith
* fix isMatchWith check
* fix isMatchWith... again
* add tests
* test author text replace and mouse events
* prettier
* don't handle updating node events
* use the arguments order as before
GitOrigin-RevId: 99b3d1c22a2dc1258a5cdf95738852028895f54a
2023-07-17 11:00:07 +00:00
Domagoj Kriskovic
7487f37bc1
[cm6] use tooltips on disabled toolbar buttons ( #13678 )
...
* [cm6] use tooltips on disabled toolbar buttons
* not-allowed cursor
* prettier
* fix css selector
GitOrigin-RevId: f9c61fdabb1141daa2bde76aa4e3cd4da60e029e
2023-07-17 10:59:58 +00:00
Domagoj Kriskovic
b0d994575d
[visual] fix styling for showing authors ( #13772 )
...
* [visual] fix styling for showing authors
* add horizontal padding
* use gap
* prettier
* maxWidth and flex wrap
* min-width
* use only min-width
GitOrigin-RevId: 1fdc1baac6fd98ee909f847716f6aedf88e96aec
2023-07-17 10:59:49 +00:00
ilkin-overleaf
13a7e752d5
Merge pull request #13710 from overleaf/ii-review-panel-migration-bulk-actions-entry
...
[web] Create bulk actions entry and bulk actions modal
GitOrigin-RevId: c88ce6213304a110ee7410529813310b863178c1
2023-07-17 10:59:19 +00:00
Mathias Jakobsen
e0a3dfec36
[lezer] Allow slash in bibtex identifier
...
GitOrigin-RevId: 88f5cf069563940b1e42763babdc1e58d65c1d31
2023-07-17 10:58:05 +00:00
Mathias Jakobsen
6aa4435fc3
Merge pull request #13769 from overleaf/mj-bibtex-enter
...
[lezer] Fix bug with bracket matching for bibtex
GitOrigin-RevId: 2570bab50b73f05508af1bdeef0eab6aee4e02a9
2023-07-17 10:57:12 +00:00
ilkin-overleaf
debb438128
Merge pull request #13691 from overleaf/mj-linter-error
...
[cm6] Fix error in linter on input command
GitOrigin-RevId: 87c640ec6bd0e9d5942e6348616e0858d5bb07be
2023-07-17 10:57:02 +00:00
ilkin-overleaf
12bcdad850
Merge pull request #13744 from overleaf/mj-big-projects
...
[cm6] Optimise getUpdatedProjection
GitOrigin-RevId: af321d3828185b245f557ab0e046851192c97296
2023-07-17 10:56:52 +00:00
ilkin-overleaf
225de683c7
Merge pull request #13687 from overleaf/ii-review-panel-migration-add-comment-entry
...
[web] Create add comment entry
GitOrigin-RevId: 019f508eeb3982fce082df153e56d6c3c3e3bae5
2023-07-17 10:56:42 +00:00
Alf Eaton
0dc9aa3d21
Improve CM6 dev tools extension ( #13712 )
...
GitOrigin-RevId: 3af5e051cb3fed322d980ba71d3ec1fc9817f8e3
2023-07-17 10:56:23 +00:00
Alf Eaton
b63cb6e029
Merge pull request #13623 from overleaf/ae-symbol-palette-toolbar
...
[cm6] Only show symbol palette toolbar button when available
GitOrigin-RevId: 34e2c4e8ac1077a4da15277188ea0456db26e0af
2023-07-17 10:55:45 +00:00
Eric Mc Sween
d89b62e965
Merge pull request #13671 from overleaf/ii-review-panel-migration-aggregate-change-entry
...
[web] Create aggregate change entries
GitOrigin-RevId: 685ac40739f3c39665d84bd402ada21e00db5146
2023-07-17 10:54:50 +00:00
Davinder Singh
b1f246b9ba
Merge pull request #13658 from overleaf/ii-review-panel-migration-change-entry
...
[web] Create change entries
GitOrigin-RevId: 4d49f8b02b9bfcfe470f6db21f5347080ff47562
2023-07-17 10:53:56 +00:00
ilkin-overleaf
936ab81b65
Merge pull request #13641 from overleaf/ii-review-panel-migration-overview-view
...
[web] Create overview view shell for review panel
GitOrigin-RevId: 21cc8a744253aec53f089ec6e6c1221d7153f3a4
2023-07-17 10:50:58 +00:00
Alf Eaton
87013d20f8
Revert "[cm6] Show "move" cursor when the selection is ready to be dragged ( #13532 )" ( #13673 )
...
This reverts commit 1a89abceeadb6e1c53b4bc779df19b6723eab738.
GitOrigin-RevId: 05025068f75f1012626359230952e252e941d675
2023-07-17 10:50:49 +00:00
Alf Eaton
1cfc1eb269
[cm6] Show "move" cursor when the selection is ready to be dragged ( #13532 )
...
GitOrigin-RevId: 1a89abceeadb6e1c53b4bc779df19b6723eab738
2023-07-17 10:50:40 +00:00
Domagoj Kriskovic
39bd64b0a4
[cm6] fix toolbar overflow button calculation ( #13669 )
...
GitOrigin-RevId: 11380a5661067a285e0c0de82a37e085fc395f03
2023-07-17 10:50:30 +00:00
Alf Eaton
7202d7413e
[rich text] Cover the whole command when selecting end-to-end ( #11683 )
...
GitOrigin-RevId: c3559ce68798047e7001b2a9857f2c168633af6c
2023-07-17 10:50:12 +00:00
Alf Eaton
7e20d41c4c
Remove list items when list is toggled off ( #13580 )
...
GitOrigin-RevId: 19c63b26798fcf3c8e631090c614f0a693d4f071
2023-07-17 10:50:02 +00:00
Alf Eaton
52d9ee79a3
[visual] Handle selections adjacent to lists and section headings ( #13581 )
...
GitOrigin-RevId: 35b289102110f88587679740eeed575e16f6788b
2023-07-17 10:49:53 +00:00
Alf Eaton
1d33231392
Merge pull request #13597 from overleaf/ae-request-measure-view
...
[visual] Call view.requestMeasure in updateDOM if height could change
GitOrigin-RevId: eac77962d3edffd3ce3220c7948373bc38e6d727
2023-07-17 10:49:43 +00:00
Alf Eaton
a716a500c5
Merge pull request #13607 from overleaf/ae-formatting-keymaps
...
[cm6] Use toggleRanges for bold/italic shortcuts in code editor
GitOrigin-RevId: 90f7344876e84b984469ca2daccb7bbe71d89aa9
2023-07-17 10:49:34 +00:00
Alf Eaton
e41bda3e61
Merge pull request #13664 from overleaf/mj-bibtex-match-brackets
...
Add bibtex match brackets highlighting
GitOrigin-RevId: d0ed07d9874f097dd8b59eff582eb23a59f46332
2023-07-17 10:49:05 +00:00
Alf Eaton
c16d2d5840
[visual] Avoid showing list environment markup when the selection is within list items ( #13461 )
...
GitOrigin-RevId: cadab83774d52dc6c4867fdd7300a1217423b837
2023-07-17 10:48:56 +00:00
Mathias Jakobsen
67e7621633
Merge pull request #13572 from overleaf/mj-bibtex-grammar
...
[cm6] Add support for bibtex
GitOrigin-RevId: 28bc8e47c53df1612c1e30cf690e893b0bbf500c
2023-07-17 10:47:59 +00:00
ilkin-overleaf
e5d6777211
Merge pull request #13628 from overleaf/ii-review-panel-migration-resolved-comments-entry
...
[web] Add resolved comments entries functionality
GitOrigin-RevId: f0a8365b00c0861be12347aeaf486f7c02faf8e5
2023-07-17 10:47:41 +00:00
Domagoj Kriskovic
86753c19e5
[cm6] fix old editor-switch to show code editor ( #13645 )
...
* [cm6] fix old editor-switch to show code editor
* prettier
GitOrigin-RevId: 2c40c249c649b2675963db37a2aaeb4f0c457f7a
2023-07-17 10:46:52 +00:00
Domagoj Kriskovic
17452b51d7
[cm6] Add toolbar to Source Mode for Beta users ( #13429 )
...
* [cm6] toolbar for source mode
* top:0 for new toolbar
* empty div for extensions
* fix legacy css top pos
* show source toolbar split test
* prettier
* show beta icon in source editor
* dropdown toolbar wip
* fix wrong conflict resolve
* math dropdown, chrome extension fixes
* math dropdown cleanup
* sort en.json
* fix sort en.json
* using isVisual
* getMeta in component, pug update
* using flex grow
* toolbar beta badge
* remove extra whitespace
* has-legacy-toolbar class
* Increase container size
* fix tests
* prettier
* styling fixes, using SplitTestBadge
* only show source toolbar if flag is set
* fix typo
---------
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 34b01a9421f4a0d6defc40925c5092901575946e
2023-07-17 10:46:26 +00:00
ilkin-overleaf
9e8be31bdf
Merge pull request #13573 from overleaf/ii-review-panel-migration-comment-entry
...
[web] Create comment entries
GitOrigin-RevId: 7f3fbe672d18d57a0f5e683e5456ea79ed295e2d
2023-07-17 10:45:32 +00:00
Alf Eaton
8402081d9b
[visual] Add decoration for footnotes ( #13428 )
...
GitOrigin-RevId: b0c8e475e9d8b4a19977a48b615596b88ce65797
2023-07-17 10:44:55 +00:00
Alf Eaton
4d39c31acc
Merge pull request #13520 from overleaf/ae-state-tree
...
[visual] Refactoring in the atomic decorations state field
GitOrigin-RevId: e3cfd945dd900b3d7527bc9249132213d2a0e1bc
2023-07-17 10:44:45 +00:00
Alf Eaton
c6d832d6d9
Merge pull request #13594 from overleaf/ae-starred-caption
...
[cm6] Allow an asterisk after CaptionCtrlSeq
GitOrigin-RevId: e76e15afb676f6eddb8f09d710b0d90408584e29
2023-07-17 10:44:36 +00:00
Alf Eaton
62533ace6d
Use StringQuery and selectWord from @codemirror/search ( #12828 )
...
GitOrigin-RevId: 23b3e6a5db8583646f378cef52f41889a73a3672
2023-07-17 10:44:26 +00:00
Alf Eaton
db26446d76
[visual] Avoid showing braces around section headings when editing the section title ( #13464 )
...
GitOrigin-RevId: 050663e752720993ccf1ab745a8b4250d54198fc
2023-07-17 10:44:17 +00:00
Alf Eaton
adbccde085
[cm6] Move cursor over existing closing brace when inserting a required parameter ( #13494 )
...
* Move cursor over existing closing brace
* Update package-lock.json
* Update tests
GitOrigin-RevId: dd729e41c2174d9f4563f2f47efcc075c7453ced
2023-07-17 10:44:06 +00:00
ilkin-overleaf
b61ee4c4d3
Merge pull request #13528 from overleaf/ii-review-panel-migration-current-file-view
...
[web] Create initial current file container
GitOrigin-RevId: 81635922bb10b97637af296d987f28d43cf61262
2023-07-17 10:42:51 +00:00
ilkin-overleaf
15db0ce4e3
Merge pull request #13492 from overleaf/td-review-panel-sync-height
...
Add hook for synchronizing review panel height with editor content height
GitOrigin-RevId: ef0a96ef4e77e7858b28f6f65254a4b0c1e778ea
2023-07-17 10:39:29 +00:00
ilkin-overleaf
423f2604db
Merge pull request #13500 from overleaf/ii-review-panel-migration-nav
...
[web] Create review panel navigation
GitOrigin-RevId: abed4171e9fd52de2f137a6cf7456791bc2ca161
2023-07-17 10:39:20 +00:00
Domagoj Kriskovic
2ab0779374
[cm6] rename to Code Editor | Visual Editor ( #13513 )
...
* [cm6] rename to Code Editor | Visual Editor
* showLegacySourceEditor change
* show info badge
* remove info badge
* display info badge
* use "Visual Editor" in example project
GitOrigin-RevId: 549e25aa4bcfe58522eadc70e35ca35f822317b1
2023-07-17 10:39:10 +00:00
Domagoj Kriskovic
98aa084089
[cm6+rt] getParentNode account for commands with arguments ( #13345 )
...
* [cm6+rt] getParentNode account for commands with arguments
* add explanation comment
* added test
* prettier
* check commandAncestor in same position
* using ancestorOfNodeWithToRange
* function rename
GitOrigin-RevId: bb837d956d029c1026dab03825634f24d5bc3905
2023-07-17 10:39:00 +00:00
ilkin-overleaf
15f4e2e5cc
Merge pull request #13487 from overleaf/ii-review-panel-migration-create-panel-toggler
...
[web] Create review panel toggler
GitOrigin-RevId: f50422b99dbd8bbc2f1fbf323419ee13403c9ba6
2023-07-17 10:36:11 +00:00
Alf Eaton
a4d1ac2f13
Merge pull request #13477 from overleaf/ae-bottom-padding
...
[cm6] Improve bottom padding calculations
GitOrigin-RevId: 91fff97ebf6675cddffdd89118fd06f003321143
2023-07-17 10:36:00 +00:00
Alf Eaton
7bed264d16
Merge pull request #13455 from overleaf/ae-lint-tokens
...
Fix linting in lezer-latex tokens file
GitOrigin-RevId: 2a2b5e8a05455da5f1260710ed34ae605fa8d3c1
2023-07-17 10:35:30 +00:00
ilkin-overleaf
e514e97305
Merge pull request #13438 from overleaf/ii-review-panel-toolbar-shell
...
[web] Create review panel toolbar shell
GitOrigin-RevId: 561fb18e1239c9b96b52944716a83cf3b8606677
2023-07-17 10:34:04 +00:00
ilkin-overleaf
9b930d2849
Merge pull request #13414 from overleaf/ii-review-panel-migration-create-context-api-fix
...
[web] Create context api for review panel FIX
GitOrigin-RevId: fc6d8adf18d07e71b529a28deab4d49d62c43587
2023-07-17 10:32:07 +00:00
Alf Eaton
480ec139ab
Merge pull request #13408 from overleaf/ae-revert-resolve-comment
...
Revert "create context api for review panel"
GitOrigin-RevId: 3be70d7afbe4f238a27149ab2de38175cf1bf029
2023-07-17 10:30:27 +00:00
ilkin-overleaf
1918ef3767
Merge pull request #13378 from overleaf/ii-review-panel-migration-create-context-api
...
[web] Create context api for review panel
GitOrigin-RevId: 3d550e2f3c14ecd0586d088f4ecb75acd44aa782
2023-07-17 10:29:53 +00:00
Alf Eaton
e025088065
Merge pull request #13241 from overleaf/ae-extensions-documentation
...
Add documentation for CodeMirror extensions
GitOrigin-RevId: e5f07084173f201919272f9d46dcdaef4b817874
2023-07-17 10:28:53 +00:00
Domagoj Kriskovic
b70d5faca5
[cm6] alt+click to generate snippet for figure modal ( #13279 )
...
GitOrigin-RevId: fa8c4105ace55d73447b3afc60772f275728994c
2023-07-17 10:27:42 +00:00
Domagoj Kriskovic
e0980d652d
[cm6] swap replace options in figure modal ( #13277 )
...
GitOrigin-RevId: 600ad5e340b1bc182986283c9c6dcb2040d4009f
2023-07-17 10:27:32 +00:00
M Fahru
ed42d0c9ca
Make the switch to editor/pdf button to have the same height ( #12110 )
...
GitOrigin-RevId: 5ceaad73c6c6b74ce2b6e8bbc79563bfad6ab34b
2023-07-17 10:26:34 +00:00
ilkin-overleaf
2fceaa6085
Merge pull request #13343 from overleaf/ii-review-panel-migration-create-feature-flag
...
[web] Create feature flag for review panel
GitOrigin-RevId: e7e83729a536dce1824f604fb66afe1785f4be25
2023-07-17 10:26:04 +00:00
Alexandre Bourdin
584f614656
Merge pull request #13252 from overleaf/mj-rcases
...
[lezer] Support rcases
GitOrigin-RevId: 0bc0650533508ea8fb7c5f5953a6b1dc779db4ef
2023-07-17 10:22:55 +00:00
Mathias Jakobsen
a4c684e266
[cm6] Add toolbar event for figure modal trigger ( #13168 )
...
* [cm6] Add toolbar event for figure modal trigger
* [cm6] Add event to figure modal edit button
GitOrigin-RevId: 04add4f801647dfcc38a54e1969b03c4a31b2462
2023-06-01 08:04:16 +00:00
Domagoj Kriskovic
174761850b
[cm6] snippet using the same label as in figure modal ( #13239 )
...
* [cm6] snippet using the same label as in figure modal
* remove ace editor change
GitOrigin-RevId: 076d8b09ebdf61f992e9d3ce37fab84df38524ee
2023-06-01 08:04:07 +00:00
Domagoj Kriskovic
61e7f6f3a8
hide tooltip when button menu is opened ( #13247 )
...
GitOrigin-RevId: 1b6c1b09477dc9435996f3e190a72eb1a6c1d5cf
2023-06-01 08:03:59 +00:00
Domagoj Kriskovic
a05c201652
[cm6] indent figure modal generated code ( #13213 )
...
* [cm6] indent figure modal generated code
* fix: prettier
* fix indenting issues
* add licence on top
* fix cypress tests
GitOrigin-RevId: 8f74be537f19c2a29de3c742a9bbabe43b1ce40d
2023-06-01 08:03:49 +00:00
Tim Down
9a273949fd
Merge pull request #13154 from overleaf/dk-selectFile-per-project
...
[cm6] rerender SelectFile component on project change
GitOrigin-RevId: ac59bdd100df6704c357a6af08028137f610bb13
2023-05-26 08:04:21 +00:00
Tim Down
1336ff8196
Merge pull request #13169 from overleaf/dk-dropimg-handler
...
[cm6] added drop handler to rich text
GitOrigin-RevId: 9972b788d680645ee83c3bc9376b9446a2b068e9
2023-05-26 08:04:12 +00:00
Mathias Jakobsen
a06118b96d
Merge pull request #13142 from overleaf/mj-figure-modal-paste
...
[cm6] Add image paste handler to rich text
GitOrigin-RevId: 3c814bf64438b387b7b08b8bf89b917347371492
2023-05-22 08:04:42 +00:00
Mathias Jakobsen
948d56e809
Merge pull request #13136 from overleaf/mj-figure-modal-spacing
...
[cm6] Adjust spacing in figure modal
GitOrigin-RevId: dc18186ff422292648d58c6d99718cc33e4d0f84
2023-05-22 08:04:26 +00:00
Mathias Jakobsen
5c95c907ec
Merge pull request #13135 from overleaf/mj-empty-optional-argument-figure-modal
...
[cm6] Allow empty and missing optional arguments for figure modal
GitOrigin-RevId: 64e1310de21bdb3ff7ba244690cc83489bbfed40
2023-05-22 08:04:18 +00:00
Mathias Jakobsen
480672bf7a
Merge pull request #13133 from overleaf/mj-wait-upload
...
[cm6] Wait for file to be ready before inserting code from figure modal
GitOrigin-RevId: 5c4e8f243518bacc7b6ef4272eaf44995192efbc
2023-05-22 08:04:10 +00:00
Christopher Hoskin
5bbe427ed0
Merge branch 'main' of github.com:overleaf/internal
...
GitOrigin-RevId: b0a13b4b4f7ede46d5ac5478dd03642d59e11a98
2023-05-22 08:04:01 +00:00
Alf Eaton
b35db4827d
Merge pull request #13120 from overleaf/dk-drawselection-cm-patch
...
[cm6] apply cm patch for drawSelection bug
GitOrigin-RevId: 3adfcdbea4cc18d2cc197c153323fc62bafc364f
2023-05-19 08:04:34 +00:00
Alf Eaton
40eac4bd67
Remove fontWeight: bold from matched completion text ( #13078 )
...
GitOrigin-RevId: c375765ce0ca14200ba11c54ae1ac2c99a09961f
2023-05-19 08:04:17 +00:00
Mathias Jakobsen
47b1a731fb
Merge pull request #13118 from overleaf/mj-fix-centering-editable-graphics
...
[web] Always update centering in editablegraphics updateDOM
GitOrigin-RevId: 366a109c2006dea3cd3660f7a380fbbc0e203cca
2023-05-17 09:27:43 +00:00
Mathias Jakobsen
988fc57574
Merge pull request #13077 from overleaf/mj-figure-modal-tests
...
[web] Add cypress tests for figure modal
GitOrigin-RevId: 4debae1c665a68fd7bfa9f0dcfc150bec38a7c64
2023-05-17 08:06:33 +00:00
Mathias Jakobsen
c754eaf5c5
Merge pull request #13108 from overleaf/mj-figure-modal-translations
...
[web] Translate figure modal
GitOrigin-RevId: b9f2c2e9ba3141dfee15c0af572a022a2b21fd47
2023-05-17 08:06:16 +00:00
Mathias Jakobsen
f747cb000f
Merge pull request #13097 from overleaf/mj-figure-modal-alpha-changes
...
[cm6+rt] Figure Modal alpha rollout changes
GitOrigin-RevId: f7591893e8f74aa9c9b41f4b98babecaac4b3c8c
2023-05-17 08:06:08 +00:00
Alf Eaton
c7544531c1
Add needsRefresh to lint source config ( #13050 )
...
GitOrigin-RevId: bc6880f87bc81c7f0f022268a4d070c267421c46
2023-05-17 08:05:36 +00:00
Alf Eaton
c8a72e96d4
[cm6] Improve keyboard shortcuts for toggling line comments ( #13067 )
...
GitOrigin-RevId: dd08778ea3621eefa75f306b2dada3f2c484f76c
2023-05-17 08:05:28 +00:00
Alf Eaton
60370d5227
[cm6] Consolidate loose extensions ( #13086 )
...
GitOrigin-RevId: ff937418be5092b2b5197435e9cd60bc61f41b2c
2023-05-17 08:04:40 +00:00
Mathias Jakobsen
e306369b9a
Merge pull request #13085 from overleaf/mj-figure-rt-flicker
...
[cm6+rt] Reduce flickering of rendered figure
GitOrigin-RevId: a88845621228fa3a78ced023d5b5480ed600256a
2023-05-16 08:04:28 +00:00
Mathias Jakobsen
5fd4504f51
Merge pull request #13061 from overleaf/mj-cm6-translations
...
[web] Make translations accessible to CM6
GitOrigin-RevId: ef617638419597548e6e0545bac3ac94216177de
2023-05-16 08:04:11 +00:00
Mathias Jakobsen
31190b967b
[cm6] Add figure modal ( #12751 )
...
GitOrigin-RevId: 3043d1369ed85b38b1fec7479385b123a304c05b
2023-05-16 08:04:02 +00:00
Domagoj Kriskovic
47f541690f
[cm6] fix spell check issue, use new document range ( #13035 )
...
GitOrigin-RevId: 01b642dc867705c5de828fce439f424d7816d175
2023-05-15 08:02:57 +00:00
Domagoj Kriskovic
8c12bce5b6
fix outline issue: allow Ref in Math in latex.grammar ( #13054 )
...
* added failing test
* latex.grammar update: allow Ref in Math
GitOrigin-RevId: 340bf40cf4804e7693965a29b16b869a54a467d7
2023-05-15 08:02:53 +00:00
Alf Eaton
cc47299f62
Merge pull request #13033 from overleaf/ae-autocomplete-description
...
[cm6] Style the completion info to match the autocomplete tooltip
GitOrigin-RevId: d1a4db49fb0fff93e2004521ba8837131d321550
2023-05-11 08:05:46 +00:00
Alf Eaton
ea996582bf
[cm6] Improve begin environment autocompletion ( #12982 )
...
GitOrigin-RevId: 42731e6f2261f7ed9b85523a550c636968698fc3
2023-05-11 08:05:37 +00:00
Alf Eaton
d445ddd410
Unset closeOnBlur
...
GitOrigin-RevId: 481c530c112f02562b7c01fad22cfe42ddfa62eb
2023-05-11 08:05:20 +00:00
Dom Kriskovic
eafa8589c5
Revert "[cm6] close autocomplete menu on blur"
...
This reverts commit d47648044ca15cf29cc0c87479ba2a204f232a86.
GitOrigin-RevId: dc6bbcc30126d46a3b602896bfc18477fd07ab34
2023-05-11 08:05:04 +00:00
Dom Kriskovic
4c2537a753
[cm6] close autocomplete menu on blur
...
GitOrigin-RevId: e1475e1a1b4a0f05ab2926cfc5612abb3b9f39e8
2023-05-11 08:04:56 +00:00
Alf Eaton
466011df86
[cm6] Account for line shifts when updating the spelling line tracker ( #13015 )
...
* Use lineShift
* Use fromA instead of fromB
* Only check the update doc
* Always use oldDoc
* Copy tests
GitOrigin-RevId: 05e5516b09ee4a25d8ac2b5f2994a034f35c9e82
2023-05-11 08:04:48 +00:00
Alf Eaton
f2f7f6b7d6
[cm6] Add beginEnvironmentCompletionSource ( #12913 )
...
GitOrigin-RevId: eb4582606103268f1f2c90da7d372a0a33926e36
2023-05-08 08:04:26 +00:00
Domagoj Kriskovic
27ffe1c814
[cm6] Display non-standard spaces as special chars ( #12927 )
...
* [cm6] Display non-standard spaces as special chars
* specialChar background color
* removed Ideographic Space
* fix: lint error
* added Ideographic Space
* display only for source editor
GitOrigin-RevId: d94942cdc6a0aa17045b1783ac95de601f6ae15a
2023-05-08 08:04:18 +00:00
Alf Eaton
b1929cf16d
[cm6] Improve symbol completion ranking ( #12902 )
...
GitOrigin-RevId: 8ccc87c2b86636bd37a3472d36873ade9a190209
2023-05-08 08:04:09 +00:00
Alf Eaton
009a108c71
Wrap setCursorHighlights in setTimeout ( #12951 )
...
GitOrigin-RevId: 204bf073bc2f4a014d9498c6a802fe38e52b22c5
2023-05-08 08:04:00 +00:00
Alf Eaton
0fba9dc374
Add a $CtrlSym group to the latex language ( #12919 )
...
GitOrigin-RevId: 4ee8ba7fe85f37dbe4cab04dae699b2a66007a2d
2023-05-08 08:03:51 +00:00
Rebeka
0c54e6605b
Remove deprecated uses of badge style
...
GitOrigin-RevId: 47234e95acd42d7e5d23de8e3b67edca2bdd98d1
2023-05-04 08:05:40 +00:00
Alf Eaton
680a02892c
Duplicate the cloneSelectionVertically key mapping to re-allow Ctrl on macOS ( #12918 )
...
GitOrigin-RevId: 747e8889b5e3b34dd9ffef888f4a1d42fea1af74
2023-05-04 08:05:31 +00:00
Alf Eaton
2093d85a5f
Exclude CtrlSym commands from completion ( #12905 )
...
GitOrigin-RevId: f6d1813eba6c17444d2371b024f538137c244963
2023-05-04 08:05:23 +00:00
Alf Eaton
b010d6a5d3
Handle unset editor theme ( #12892 )
...
GitOrigin-RevId: 0e3413c08c6fd0752cd90ee868fec9b0f9f77437
2023-05-04 08:05:14 +00:00
Alf Eaton
09c5bf72d2
[cm6] Use Cmd on macOS for cloneSelectionVertically ( #12855 )
...
GitOrigin-RevId: ea72da47f2ebb377cf22af061ab616a021950502
2023-05-04 08:04:57 +00:00
Alf Eaton
8a12c34fce
[cm6] Emacs: close search form when Enter
is pressed in "Find" input ( #12841 )
...
GitOrigin-RevId: a4c974f45e0dbb13d96b9b424f056768449791fb
2023-05-04 08:04:49 +00:00
Alf Eaton
6c21f0821c
[cm6] Handle multiple selection ranges when applying snippets ( #12830 )
...
* Use fork of @codemirror/autocomplete
* Handle multiple selection ranges when applying snippets
GitOrigin-RevId: 04afc087ac127206463ea3d4950284a50308364a
2023-05-04 08:04:39 +00:00
Alf Eaton
05582567b4
Improve performance of search match counting ( #12808 )
...
GitOrigin-RevId: 70cd1aaf5b079cbd540c4a9f92a04fcb2786b308
2023-05-04 08:04:30 +00:00
Alf Eaton
e0d9069131
[cm6] Add "within selection" option to the search form ( #12798 )
...
* Use forked @codemirror/search
* Use getPanel to get the search panel
* Remove layer-based highlightSelectionMatches
* Add "within selection" option to the search form
* Add test for "replace all within selection"
* Fix tests
GitOrigin-RevId: 95ce76fd017f96278b04c16a1fd34f785f7504a3
2023-05-01 08:05:02 +00:00
Alf Eaton
2606c76aec
Merge pull request #12805 from overleaf/ae-markdown-types
...
[cm6] Fix type for Markdown language loader
GitOrigin-RevId: 725e1b28dd73e9090638f5d682e48e658c957a04
2023-05-01 08:04:45 +00:00
Alf Eaton
1da94f029c
[cm6] Avoid selecting a search match when re-opening the search panel ( #12797 )
...
GitOrigin-RevId: 32bb03b71ce56cc0dbe6f7c92cc6d85151ef1971
2023-05-01 08:04:36 +00:00
Alf Eaton
40cbfc451a
[cm6] Improve search match scrolling into view ( #12787 )
...
GitOrigin-RevId: 6ce9b86253a9c3a2c6ff44c10f78204ff16bd6e2
2023-05-01 08:04:27 +00:00
Alf Eaton
c53411ff1d
Merge pull request #12776 from overleaf/ae-search-close-tooltip
...
[cm6] Add tooltip to search panel close button
GitOrigin-RevId: ba7f4ca5d672580054cb6214be94497fd5141730
2023-05-01 08:04:17 +00:00
Domagoj Kriskovic
3d5e8c9877
add 'Ace removal' notification ( #12800 )
...
* add 'Ace removal' notification
* prettier
* add memo, window.clearTimeout
* remove warning for server pro
* added tracking events
* useCallback for onClick
* fix: event rename
GitOrigin-RevId: 70bce8b93bae233e7183a941abaf2ec7a70ddfb6
2023-04-28 08:04:19 +00:00
Domagoj Kriskovic
cd689e4e1f
[cm6] Show Regex errors in find & replace ( #12720 )
...
* [cm6] Show Regex errors in find & replace
* cleanup, isInvalidRegExp function
* no state variable, less color var
* use @brand-dager
* using var(--ol-cm-search-form-focus-shadow)
* using state-danger-border
GitOrigin-RevId: 844c9dfee5a56d2a7494cd86c266acbe9eacd033
2023-04-27 08:05:14 +00:00
Brian Gough
70072481f4
Merge pull request #12783 from overleaf/ae-dev-tools-localstorage
...
[cm6] Use customLocalStorage in CM6 dev tools
GitOrigin-RevId: df4c40868b5a7b24b30483d55d1fbe75b5703776
2023-04-26 08:04:12 +00:00
Mathias Jakobsen
17ca11fae0
[cm6] Add save command to emacs (recompiles doc) ( #12742 )
...
GitOrigin-RevId: 10cda3f14411147d0d900f688d9b5017f49d2db2
2023-04-25 08:05:35 +00:00
Alf Eaton
f409b96f00
Fix padding in emptyLineFiller and lineWrappingIndentation extensions ( #12736 )
...
GitOrigin-RevId: 8b6a2ad0beb802d917f3e998c378792c6156836a
2023-04-25 08:05:27 +00:00
Alf Eaton
8537a7a5d0
Handle mode: 'none' in keybindings ( #12717 )
...
GitOrigin-RevId: 77d040352b1de2311f663a8b33bd0d20d79a30ae
2023-04-25 08:05:18 +00:00
Alf Eaton
4bb582bdd8
[cm6] Improve Tab behaviour in read-only mode ( #12715 )
...
* Improve Tab behaviour in read-only mode
* Remove Tab shortcuts from Markdown configuration
GitOrigin-RevId: 9eb804fcf820b37b371b1c351cfbdf7bff1ced89
2023-04-25 08:05:10 +00:00
Alf Eaton
08ccdb79d3
[cm6] Improve alignment of review panel elements ( #12710 )
...
* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity
GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
2023-04-25 08:05:02 +00:00
Alf Eaton
acf6abb0fb
[cm6] Use a block widget for padding at the top of the editor ( #12705 )
...
GitOrigin-RevId: 000ce9c90ea6b2ca72ab969704354a19fcea7a87
2023-04-25 08:04:53 +00:00
Mathias Jakobsen
81a8fa2ce3
Merge pull request #12672 from overleaf/ae-emacs-compile-keydown
...
[cm6] Stop propagation of Ctrl-s when Emacs keybindings are enabled
GitOrigin-RevId: 32bebefb583ad813931af221cce7498d40fdbaf1
2023-04-21 08:03:11 +00:00
Mathias Jakobsen
462837b44d
Merge pull request #12701 from overleaf/dk-cm6-autocomplete-item-space
...
[cm6] Add space after item autocomplete
GitOrigin-RevId: 6fff77c0c0563530af981bbac73b1d88e02bb759
2023-04-21 08:03:08 +00:00
Mathias Jakobsen
29b056d5a3
Merge pull request #12682 from overleaf/mj-def-whitespace
...
[lezer] Allow whitespace before macro parameter
GitOrigin-RevId: 14bd8428f0a78fb71184bf300dac0b2b1e3abd3c
2023-04-21 08:03:02 +00:00
Mathias Jakobsen
3bd174631a
Merge pull request #12696 from overleaf/mj-rt-skip-more-preamble
...
[cm6+rt] Update skip-preamble-cursor to skip \maketitle and abstract
GitOrigin-RevId: 3c54d8159bfdb431763872790a2b82ac4cffc09f
2023-04-21 08:02:59 +00:00
Mathias Jakobsen
59b3b9b933
Merge pull request #12631 from overleaf/ae-readonly-focus
...
[cm6] Prevent the editor being focused when read-only
GitOrigin-RevId: 7de9f2df2421b57b3315d59d640f7c8b46caf178
2023-04-21 08:02:56 +00:00
Mathias Jakobsen
c2292a8567
Merge pull request #12677 from overleaf/ae-codemirror-view-upgrade
...
[cm6] Upgrade CodeMirror dependencies
GitOrigin-RevId: cc973b1c5b23eca0fc93a9b3a970c832212e47af
2023-04-21 08:02:53 +00:00
Alf Eaton
924012e21f
[cm6] Avoid overwriting themed syntax highlighting colours when editing Markdown ( #12648 )
...
GitOrigin-RevId: ed5d558544839978862004a8b7feb80806a2100d
2023-04-19 08:03:04 +00:00
Alf Eaton
5717f51042
Merge pull request #12643 from overleaf/ae-initial-active-line-highlight
...
[cm6] Fix initial active line highlight
GitOrigin-RevId: 54de6a176e826ed7d7f1016ba6cee7a8803f0be4
2023-04-19 08:02:53 +00:00
Mathias Jakobsen
c8f7bc54bc
[web] Add split test for testing editor switch naming ( #12596 )
...
Co-authored-by: Ieva Vaiginyte <95856891+ievaoverleaf@users.noreply.github.com>
GitOrigin-RevId: dafe07bda841dad962ebf2894718750fafe86373
2023-04-18 08:04:59 +00:00
Alf Eaton
63b2064420
[cm6] Add scrollIntoView when commands are dispatched ( #11678 )
...
GitOrigin-RevId: be005885330b9b29c7ddbfeacaec0a41d96e5e25
2023-04-17 08:05:33 +00:00
Mathias Jakobsen
7d237d0103
[cm6] Only swallow text in autocomplete insertion if node is well-formed ( #12562 )
...
* [cm6] Only swallow text in autocomplete insertion if node is well-formed
* [cm6] Use longest common prefix heuristic for autocompletion in ill-formed nodes
GitOrigin-RevId: 5adf3dc0314d86b267e2142a1250dece3ab29ef8
2023-04-17 08:05:24 +00:00
Mathias Jakobsen
73191f56e1
[cm6+rt] Make formatting commands work after UnknownCommands without arguments ( #12625 )
...
GitOrigin-RevId: 0eb59e6580d6f217c46424ede0fa6f79c8786940
2023-04-17 08:05:16 +00:00
Mathias Jakobsen
4b2cc907e2
[cm6] Change Emacs commands to visual-line-mode ( #12523 )
...
* [cm6] Change Emacs commands to visual-line-mode
* [cm6] Change line deletion commands to visual line mode
GitOrigin-RevId: 7a4f3d66bec611de410b6c1fbafbfe33b974e37b
2023-04-17 08:05:08 +00:00
Alf Eaton
359255b820
[cm6] Use a modified fork of the closeBrackets extension ( #12573 )
...
GitOrigin-RevId: a24020ed216cb10defff989f5876666c29889de2
2023-04-17 08:04:43 +00:00
Alf Eaton
dda9230c6c
[rich text] Add "Insert Citation" and "Insert Cross-reference" buttons ( #12529 )
...
GitOrigin-RevId: fde2f1a281318afede138ccae12f73ade3fa9f65
2023-04-17 08:04:34 +00:00
Alf Eaton
39df55787c
Improve handling of doc:saved events ( #12522 )
...
GitOrigin-RevId: 0ebf198548f6aeecb356405b0c582d3fd64db391
2023-04-17 08:04:26 +00:00
Alf Eaton
a8ed6b65e1
[cm6] Improve "vertical overflow" handling ( #12405 )
...
* Avoid setting style on the editor view whenever overflowPaddingState changes
* Round values in recalculateScreenPositions
* Refactor ignoreGeometryChangesUntil slightly
* Restore the original value
GitOrigin-RevId: 75c57be21dd16a748c0d9b14058386849a80b831
2023-04-17 08:04:18 +00:00
Alf Eaton
ab10fd99f5
Add CodeMirror dev tools extension ( #12142 )
...
GitOrigin-RevId: 148a0fba5faf6dc8f638fcb4666e2fda6c5c6c40
2023-04-17 08:04:09 +00:00
Alf Eaton
161decd67d
Upgrade @codemirror/view ( #12574 )
...
* Upgrade @codemirror/view
* Disable emptyLineFiller extension
GitOrigin-RevId: 57ce4194ece0ea448e24184f0b3a3e13352cb014
2023-04-17 08:04:00 +00:00
Tim Down
7f37ba737c
Move source editor out of module ( #12457 )
...
* Update Copybara options in preparation for open-sourcing the source editor
* Move files
* Update paths
* Remove source-editor module and checks for its existence
* Explicitly mention CM6 license in files that contain code adapted from CM6
GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
2023-04-13 08:40:56 +00:00
Jessica Lawshe
a4586074d7
Merge pull request #12442 from overleaf/jel-bsStyle
...
[web] Add bsStyle to `react-bootstrap` buttons
GitOrigin-RevId: 0059a457cbd8b4c316aa3b34e4d77f1b92bd690e
2023-04-05 08:02:50 +00:00
Alf Eaton
1807f18b7d
Add a tooltip to the disabled Rich Text toggle ( #11843 )
...
GitOrigin-RevId: e7be96c68d87ab1f1ed40c8e9784160689ee8e96
2023-02-17 09:04:15 +00:00
Miguel Serrano
286cbc66a8
Merge pull request #11771 from overleaf/msm-force-ace-sp
...
[web] Force Ace editor in Server Pro
GitOrigin-RevId: 1ea5675ad1c64a15dc30566c02d694feb2aaed3c
2023-02-10 09:12:26 +00:00
June Kelly
035b5cd456
Merge pull request #11263 from overleaf/ae-rich-text-available
...
Only enable the Rich Text option for supported file extensions
GitOrigin-RevId: ae67435b50701bb5be71bab94d8c3c4da4129d88
2023-02-09 09:05:05 +00:00
Tim Down
fd90261313
Merge pull request #11465 from overleaf/td-remove-ace-tooltip
...
Remove info icon next to editor switch for users without Ace option
GitOrigin-RevId: 69fa8af8ddd40c47a58de50eb9aa79cc82629aa8
2023-01-26 09:04:38 +00:00
Tim Down
a05438d9c7
Merge pull request #11332 from overleaf/td-remove-ace-split-test
...
Add handling for source-editor-legacy split test
GitOrigin-RevId: 9575087c34bc3f2e8b490846984bc97641c560aa
2023-01-25 09:06:26 +00:00
Alf Eaton
017f0b49a0
[rich-text] Add "rich-text" split test ( #11180 )
...
GitOrigin-RevId: 8df79f3c70020c8dba0793c8b548fd1f1e1fbf76
2023-01-13 09:04:31 +00:00
Alf Eaton
9f1f62b9be
Add rich-text mode to CM6 ( #10775 )
...
Co-Authored-By: Mathias Jakobsen <3295293+hrjakobsen@users.noreply.github.com>
GitOrigin-RevId: 00e015cb216bb8a52d083e71b34dbe91a7cd6cc5
2022-12-13 09:03:54 +00:00
Davinder Singh
d6b39c4bb3
Merge pull request #10653 from overleaf/ds-btn-default-to-secondary-in-editor
...
Replacing `btn-default` with `btn-secondary` in the editor
GitOrigin-RevId: 46aa8c92c9981eb2f253828ee65424bfb7217fb2
2022-12-08 09:03:35 +00:00
Tim Down
08567c290e
Add second CM6 switch-away survey ( #10789 )
...
Restart CM6 switch-away survey
GitOrigin-RevId: 1d62aaf27834cb3919f6ca30c269a1ef3c2e9a5e
2022-12-07 09:04:35 +00:00
Tim Down
fa67c3fcff
Merge pull request #10797 from overleaf/td-editor-toggle-analytics
...
Add analytics for switching editor
GitOrigin-RevId: 7b44e53105e8669e97cb9c4821dfbc830faff779
2022-12-07 09:04:06 +00:00
M Fahru
31c503be2d
Add 10 seconds delay before showing grammarly warning
...
GitOrigin-RevId: 11bb3ca5704ef5cc782d14eb6f4f10a1fa2a656e
2022-11-25 09:04:33 +00:00
M Fahru
d70e0b1c0e
Implement grammarly warning alert on cm6 users
...
GitOrigin-RevId: ed272bbc385faa69811ec1891075906cdca1c984
2022-11-16 09:06:39 +00:00
Davinder Singh
c6f8b17647
Merge pull request #10286 from overleaf/jel-ds-toggle
...
Fix toggle and `Switch to PDF` aligment
GitOrigin-RevId: d3c77ff34829af875d2b8b9e3797e0e7db867631
2022-11-16 09:04:26 +00:00
Jakob Ackermann
1c529d5dcf
Merge pull request #10339 from overleaf/as-fix-switch-back
...
Fix bug in CM6 switch away survey where going back from Ace to CM6 will still show the survey
GitOrigin-RevId: 5900fafb1a4a5fab7d949b1c70af31e19a764e6e
2022-11-08 09:04:38 +00:00
M Fahru
b593bfa56e
Don't show cm6 switch away survey if cm6 is not available
...
GitOrigin-RevId: e283fc424055f6df85015f02c83ad8314865697d
2022-11-04 09:06:10 +00:00
M Fahru
19dd2f67e2
Implement "switch away survey" when users switching back to ace from cm6 ( #10201 )
...
Implement legacy source editor survey:
* Force user to switch to cm6 if they haven't seen switch away survey
* Only show user switch away survey if they open ace from another editor
* We need to wait 3 seconds until the survey is being shown
* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users
* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey
* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that
* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses
GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
2022-11-04 09:05:50 +00:00
Timothée Alby
7b8d277437
Merge pull request #8898 from overleaf/ta-change-redundant-controls
...
Change Redundant Layout Controls
GitOrigin-RevId: b50d71b1f75d202334442b3f6cb5037ed0d8a411
2022-07-21 08:04:25 +00:00
ilkin-overleaf
41c715c40d
Merge pull request #8378 from overleaf/ii-cm6-three-way-toggle
...
[cm6] Make cm6 as the default source editor
GitOrigin-RevId: b56724d2c147792c55ce01cf272fbcce16f87916
2022-06-15 08:05:18 +00:00
Timothée Alby
ae207f7559
Merge pull request #8326 from overleaf/ta-pdf-detach-redundant-controls
...
Bring Back Redundant Layout Controls
GitOrigin-RevId: a725e8742ab41612b285bcab23054ba9da15b60f
2022-06-09 08:02:34 +00:00
Brian Gough
fde4f72adf
Merge pull request #6779 from overleaf/ae-cm-editor-switch
...
[web] [cm6] Add a three-way switch for editor choice
GitOrigin-RevId: fff788ddad8d10488e8446de7f1503702da0985f
2022-02-22 09:03:05 +00:00