github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
22329 commits 3 branches 7 tags 206 MiB
Commit graph

2829 commits

Author SHA1 Message Date
David
10d218fe8f Merge pull request #18032 from overleaf/dp-compromised-password-copy 
Update copy and spacing of compromised password page to match latest designs

GitOrigin-RevId: c918e6a32e07c00087452b2c5e1f0521f3677cd0
 2024-04-23 08:04:38 +00:00
Davinder Singh
a179751986 Merge pull request #17866 from overleaf/ds-banner-labels 
Geo Pricing- Update Banner message on Latam america

GitOrigin-RevId: 7a8adf8e31e7ba4bc1b415a26c492bf6e5867328
 2024-04-23 08:04:19 +00:00
ilkin-overleaf
cccd0f06d7 Merge pull request #17908 from overleaf/ii-bs5-badge 
[web] Create Bootstrap 5 badges

GitOrigin-RevId: 72355c7cf7dca2a5d16bc890d7cfa4a432dd15ba
 2024-04-22 08:04:07 +00:00
Tim Down
774b300e17 Merge pull request #17902 from overleaf/td-bs5-settings-page 
Bootstrap 5: Basic page layout styles

GitOrigin-RevId: a3de86b8abdbdb7b31b4ede7511a12b6fd925a13
 2024-04-22 08:04:03 +00:00
Alf Eaton
702615acc9 Use dvh for ide-root height to avoid cutoff (#18009) 
GitOrigin-RevId: efb452a7192a9d5e81376066cd879cefcfb337a8
 2024-04-22 08:03:51 +00:00
Domagoj Kriskovic
945e51b8ed [web] add Revert File button behind a feature flag (#17975) 
* [web] add Revert File button behind a feature flag

* improve error message

* use constant for timeout

GitOrigin-RevId: 047c35d22e948351c52d469e48b869719f44ec4f
 2024-04-19 08:04:06 +00:00
David
0cf17478fe Merge pull request #17810 from overleaf/dp-compormised-password-prompt 
Add compromised password prompt

GitOrigin-RevId: 7910a220943fcb3aa191da6d514d5bc3ae20f5a3
 2024-04-19 08:03:58 +00:00
Antoine Clausse
b2ef7a935f [web] Use localized number formatting for currencies (#17622) 
* Add a unit test on `SubscriptionFormatters.formatPrice`

* Add JSDoc to `formatPrice`

Also: Name the functions before exporting:
This fixes my IDE (WebStorm) navigation

* Make `'USD'` the default param instead of reassigning

* Create `formatCurrency` function

* Use `formatCurrency` in SubscriptionFormatters

* Use an `isNoCentsCurrency` logic for `CLP` `JPY` `KRW` `VND`

And remove custom `CLP` logic and locale

* Add `locale` param to `formatPrice`

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Update scripts/plan-prices/plans.js to generate numbers instead of localized amounts

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Remove generation of `plans.json`

As /services/web/frontend/js/main/plans.js was removed in https://github.com/overleaf/internal/pull/12593

* Sort currencies in alphabetical order in scripts/plan-prices/plans.js

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Use `formatCurrency` in price-summary.tsx

* Use `formatCurrency` in Subscription Pug files

* Fix unit tests SubscriptionHelperTests.js

* Remove unused `currencySymbol`

* Change to `formatCurrency` in other React components

* Add `CurrencyCode` JSDoc types

* Duplicate `formatCurrency` into services/web/app/src/util

* Wrap tests in a top-level describe block

* Use `narrowSymbol`

* Fix tests with `narrowSymbol` expects

* Revert deletion of old `formatPrice` in SubscriptionFormatters.js

* Rename `formatCurrency` -> `formatCurrencyLocalized`

* Revert deletion of `CurrencySymbol`

* Add split-test in SubscriptionController.js

* Add split-test in SubscriptionViewModelBuilder.js

* Add split-test in plans

* Add split-test in subscription-dashboard-context.tsx

* Add split-test in 4 more components

* Update tests

* Show currency and payment methods in interstitial page

* Fix `–` being printed. Use `–` instead

* Fix test with NOK

* Storybook: Fix missing `SplitTestProvider`

* Storybook: Revert "Remove unused `currencySymbol`"

This reverts commit e55387d4753f97bbf8e39e0fdc3ad17312122aaa.

* Replace `getSplitTestVariant` by `useSplitTestContext`

* Use parameterize currencyFormat in `generateInitialLocalizedGroupPrice`

* Fixup import paths of `formatCurrencyLocalized`

* Replace `% 1 === 0` by `Number.isInteger`

* Add comment explaining that any combinations of languages/currencies could happen

* Fixup after rebase: import `useSplitTestContext`

* Revert "Remove SplitTestProvider from subscription root"

This reverts commit be9f378fda715b86589ab0759737581c72321d87.

* Revert "Remove split test provider from some tests"

This reverts commit 985522932b550cfd38fa6a4f4c3d2ebaee6ff7df.

GitOrigin-RevId: 59a83cbbe0f7cc7e45f189c654e23fcf9bfa37af
 2024-04-19 08:03:54 +00:00
M Fahru
b62af4b922 Merge pull request #17988 from overleaf/mf-change-nvidia-to-samsung 
Change NVIDIA to Samsung in our marketing pages

GitOrigin-RevId: fb5ad88075fa9349fff7da66cf7981ddf98ce37d
 2024-04-18 08:04:34 +00:00
M Fahru
4424072ba5 Merge pull request #17891 from overleaf/mf-register-header-logo-link 
[web][website-redesign] In register page, make the top header logo a link to the home page

GitOrigin-RevId: d940c727899222c578ba0780206ca072682c925d
 2024-04-18 08:04:27 +00:00
Thomas
52e6ceef67 Merge pull request #17898 from overleaf/tm-remove-twitter-login 
Remove twitter login code and uninstall passport-twitter

GitOrigin-RevId: 928c877ef2a42d5881652cad7f9d563c7766fd36
 2024-04-18 08:04:16 +00:00
roo hutton
d53a3e315e Merge pull request #17879 from overleaf/rh-refresh-collab 
Refresh websocket on collaborator change

GitOrigin-RevId: b05444d592f5952a08bad51c9f529ed9183d042f
 2024-04-17 08:05:18 +00:00
Rebeka Dekany
fa3f51fb2e Merge pull request #17806 from overleaf/rd-bootstrap-button2 
[web] - Updating the Account Settings page with the Button and Icon Button wrappers

GitOrigin-RevId: 135c4ddaa64d009d3ab8cdfef9cff899fd77669c
 2024-04-17 08:05:10 +00:00
Rebeka Dekany
f6d5152a37 Merge pull request #17904 from overleaf/td-bs5-button-focus-style 
Bootstrap 5: fixes to button focus ring and background colour

GitOrigin-RevId: d89077e975c2aeb7fea385e0b8c34c92c104cc2b
 2024-04-17 08:05:05 +00:00
Alf Eaton
4a68a5f8bc Discontinue the bonus program (#17919) 
GitOrigin-RevId: d30ace08a340dd17a68c3cfe82e589bb37b5959f
 2024-04-17 08:04:58 +00:00
Jakob Ackermann
e100d85940 Merge pull request #17422 from overleaf/jpa-avoid-resize-observer-loop 
[web] avoid ResizeObserver loop when opening logs pane

GitOrigin-RevId: fb9c54e137785b34af01d031e182b66969711e41
 2024-04-17 08:03:59 +00:00
M Fahru
9f38436f10 Merge pull request #17736 from overleaf/ii-bs5-tooltip 
[web] Create Btoostrap 5 tooltips

GitOrigin-RevId: 28c7c389bda74765482049750fc0ae8a5995968e
 2024-04-16 08:04:42 +00:00
M Fahru
a0da44358f Merge pull request #17892 from overleaf/mf-remove-newsletter-artifact 
[web] Remove leftover code from the torn down onboarding flow split test

GitOrigin-RevId: 2d87cfe4d916b0d7a7a224c12f22c599e196d69f
 2024-04-16 08:04:38 +00:00
David
a01d35e0fd Merge pull request #17784 from overleaf/dp-pay-0-teardown 
Tear down pay-0-trial split test

GitOrigin-RevId: dcda9f205120e1e1e17324961f6d3066554f9412
 2024-04-16 08:04:30 +00:00
Andrew Rumble
6100954635 Merge pull request #17863 from overleaf/ar-set-socket-disconnect-timeout-to-match-wire-value 
Set socket disconnect timeout to match wire value

GitOrigin-RevId: b3bfc460090b872500b55b0d5e2167b828ef31f4
 2024-04-16 08:04:22 +00:00
Antoine Clausse
d35204033f Merge pull request #17909 from overleaf/ac-tear-down-compile-timeout-tests-2 
[web]  Remove split-tests `compile-backend-class*` and `compile-timeout-20s*` (attempt 2)

GitOrigin-RevId: 5658f2977d3e7089eec5bbe7a33eee81c153e41d
 2024-04-16 08:04:08 +00:00
ilkin-overleaf
bd570cc473 Merge pull request #17576 from overleaf/ii-bs5-alert 
[web] Bootstrap 5 notifications

GitOrigin-RevId: 4409f1b76923d96f1b8297beb35a383d9aa7ec8c
 2024-04-16 08:04:00 +00:00
Antoine Clausse
491bc2628d Merge pull request #17899 from overleaf/revert-17700-ac-tear-down-compile-timeout-tests 
Revert "[web] Remove split-tests `compile-backend-class*` and `compile-timeout-20s*`"

GitOrigin-RevId: d5070ced06adbd435e782a44b7ef767e395bd6a0
 2024-04-15 08:04:37 +00:00
Antoine Clausse
2dd10c7fee [web] Remove split-tests compile-backend-class* and compile-timeout-20s* (#17700) 
* Remove split-tests of `compile-timeout-20s` and `compile-timeout-20s-existing-users`

* Remove `NEW_COMPILE_TIMEOUT_ENFORCED_CUTOFF` variables

* Revert timeout override `60` -> `20`

* Update settings.overrides.saas.js: `compileTimeout: 20`

* Remove `compile-backend-class-n2d`

* Remove `force_new_compile_timeout`

* Remove `showNewCompileTimeoutUI`

* Remove `compileTimeChanging`

* Simplify code by removing segmentation object

* Remove `CompileTimeoutChangingSoon`

* Remove `user.features.compileTimeout = '20 (with 10s prompt)'`

* Remove `CompileTimeWarning`

* Remove `TimeoutUpgradePrompt` (old)

* Remove `compile-backend-class`

* Remove unused translations

* Update tests

* Fix: Show `CompileTimeout` even if `!window.ExposedSettings.enableSubscriptions`

* Create script to migrate users to 20s compileTimeout

* migration script: exclude `compileTimeout: 20` from the match

* migration script: use `batchedUpdate`

* Remove `showFasterCompilesFeedbackUI` and `FasterCompilesFeedback`

Helped-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Remove `_getCompileBackendClassDetails`, simplify definition of `limits` object

* Remove `Settings.apis.clsi.defaultBackendClass`

* Remove unnecessary second scan of the whole user collection in dry mode

* Override `timeout` to 20 for users having `compileGroup === 'standard' && compileTimeout <= 60`

* Remove second `logCount`: re-run the script in dry-mode if you want to see that count

* Use secondary readPreference when counting users

* Fix script setup and exit 0

* Fix: Remove `user.` from query path!

* Add acceptance test on script migration_compile_timeout_60s_to_20s.js

GitOrigin-RevId: 3cb65130e6d7fbd9c54005f4c213066d0473e9d8
 2024-04-15 08:04:24 +00:00
Jessica Lawshe
f5ac5b0ed3 Merge pull request #17878 from overleaf/mj-keyboard-navigation-firefox-115 
[web] Use getAttribute rather than accessing Element.role

GitOrigin-RevId: a6732180d945ccc4ac0300af07e52228e9f2c928
 2024-04-12 08:06:27 +00:00
Jessica Lawshe
11b3c60f60 Merge pull request #17739 from overleaf/jel-remove-group-beta-badge 
[web] Remove beta badge from group SSO settings page

GitOrigin-RevId: b580515c58cfbe40a50a14c365d2541fc818d53e
 2024-04-12 08:06:13 +00:00
M Fahru
510bb062ee Merge pull request #17845 from overleaf/mf-add-icon-error-login-home 
[web][website-redesign] Add notification icon and make the notification text to be left-justified

GitOrigin-RevId: 8a678f05fbd3467be87198aca2a631ff31d1fb7d
 2024-04-12 08:05:52 +00:00
Tim Down
d0344c482c Merge pull request #17670 from overleaf/td-bs5-green-50 
Update green-50 in Bootstrap 5 styles

GitOrigin-RevId: a2b29abed9e4f16ddb77e5784e842700966d3712
 2024-04-12 08:05:05 +00:00
M Fahru
71bd4ecb22 Merge pull request #17835 from overleaf/mf-fix-mono-font 
[web][website-redesign] Fix all mono text in website redesign pages.

GitOrigin-RevId: b1b2698f621b8dc4e8c56126915ddbbe538d308e
 2024-04-11 08:04:26 +00:00
David
ce5d190c4a Merge pull request #17833 from overleaf/dp-add-secondary-prompt 
Update primary email check form to match new designs

GitOrigin-RevId: b740255e3615bd7807845c533472aabb263d69ea
 2024-04-11 08:04:20 +00:00
Andrew Rumble
b053e73e76 Merge pull request #17815 from overleaf/ar-allow-labels-to-be-added-in-label-list 
Allow labels to be added from label list

GitOrigin-RevId: 61abbc74aff1901f4adb16575b02148f8dbf99e2
 2024-04-11 08:03:43 +00:00
Antoine Clausse
8e0e2041a7 Move "reducing_compile_timeout" notice to the bottom of the box (#17840) 
GitOrigin-RevId: 6dc28cb41af28947c4e43ab57d26518c0c0a3245
 2024-04-11 08:03:29 +00:00
Domagoj Kriskovic
8bde496da4 Send operations to project-history when resolving/unresolving comments (#17540) 
* Send operations to project-history when resolving/unresolving comments

* small fixes

* added doc_id in web unit test

* Revert "added doc_id in web unit test"

This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.

* fix mocked dependency in test

* wip: web unit tests

* document updater, reopen test

* document-updater tests

* format fix

* fix typo

* fix callsArgWith

* fix reopenThread calls in doc updater tests

* fix typos

* log error if chat api resolve failes

* log error when reopening thread

* sendStatus calls done() in tests

* using OError instead of logging

* removed timers

* preserve legacy endpoints

* update after merge

* Remove timer check in HttpControllerTest

* prettier

* added "legacy" in log

* remove metrics.timer

* fix promisify issues

* remove unused cb

GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
 2024-04-10 08:04:08 +00:00
Andrew Rumble
9fda813e20 Merge pull request #17786 from overleaf/ar-select-caption-in-inserted-figures 
Select caption text when new figure inserted

GitOrigin-RevId: 443594ff03c5a5cd316623e60b231a6af4390d3c
 2024-04-09 08:04:36 +00:00
Davinder Singh
998d55d159 Merge pull request #17559 from overleaf/ds-latam-v2 
LATAM Geo Pricing - Introducing split test in LATAM countries Round 2

GitOrigin-RevId: 76ab880262f126f8db7f8e577154d78b5e9abf7a
 2024-04-09 08:04:06 +00:00
Miguel Serrano
d7d63e0f51 Merge pull request #17693 from overleaf/msm-hide-grammarly-sp 
Prevent grammarly ad from rendering in CE/SP

GitOrigin-RevId: 3ef191f282f2ce682236710df9ca32a087271c4c
 2024-04-09 08:03:59 +00:00
M Fahru
9e318f24ff Merge pull request #17594 from overleaf/mf-website-redesign-register 
[web] Website redesign for register page

GitOrigin-RevId: a8ae7327b1d662cb442e44992c5e2676a23cca3e
 2024-04-08 08:04:33 +00:00
ilkin-overleaf
2f74b79d3a Merge pull request #17619 from overleaf/ii-bs5-rows-cols 
[web] Bootstrap 5 containers, rows, cols

GitOrigin-RevId: 2b6b6fd1aebce739971e1428ab7c3cd6ec6c3858
 2024-04-08 08:03:59 +00:00
M Fahru
eaea8a4979 [web] Implement new notification style for homepage registration form (#17695) 
The new notification style is implemented as a separate function (pug mixin), so in order to update all of our forms, we need to explicitly change the function call in the other pug templates. This way, we can update all the other forms with the new notification style gradually.

GitOrigin-RevId: 78b755468e3e70f08500bdfb6280fa79853c3ed1
 2024-04-05 08:04:18 +00:00
Andrew Rumble
1c1b48edab Merge pull request #17707 from overleaf/AR-modal-close-consistency-fixes 
Modal "Close" button consistency fixes

GitOrigin-RevId: 55e5178c9e820fffd220f0010906546f0baa2065
 2024-04-05 08:04:13 +00:00
Jessica Lawshe
5fcc7f63cd Merge pull request #17728 from overleaf/jel-fix-member-view-update 
[web] Fix user view on frontend after unlinking group SSO member

GitOrigin-RevId: 375b798d23ed622453465661ced604c7068c1986
 2024-04-05 08:04:00 +00:00
Andrew Rumble
f02248e1e5 Merge pull request #17708 from overleaf/dp-reg-form-alignment 
Fix alignment of email/password inputs on home registration form

GitOrigin-RevId: 3f1c12a4575f09b73f1d4362c8b3ad83386c6af4
 2024-04-04 08:05:13 +00:00
Jessica Lawshe
b609fbe95c Merge pull request #17716 from overleaf/jel-sso-config-test-data 
[web] Wrap long values in group SSO test result

GitOrigin-RevId: 7d6a7a5ba8a07038e17a815373c3785fa3363f06
 2024-04-04 08:04:57 +00:00
Jessica Lawshe
d8f870555c Merge pull request #17683 from overleaf/jel-unlink 
[web] Unlink group SSO member

GitOrigin-RevId: ac3498fc72538fd0eef639c783dc7675ac593b94
 2024-04-04 08:04:45 +00:00
ilkin-overleaf
ab71a2edb2 Merge pull request #17691 from overleaf/ii-copy-project-mobile 
[web] Show modal on mobile when copying a project

GitOrigin-RevId: db0887b91c80f169539d4d02ae9745d9a60abaa3
 2024-04-04 08:04:20 +00:00
ilkin-overleaf
cfd13b7aa0 Merge pull request #17699 from overleaf/ii-main-style-fix-imports 
[web] Fix css imports within scss files

GitOrigin-RevId: 991b811c80b89a68c5932dd9abe091ea79bd14f4
 2024-04-04 08:04:16 +00:00
ilkin-overleaf
a9436039b6 Merge pull request #17702 from overleaf/ii-bs5-to-bs3-classname-helper 
[web] Bootstrap class name helper

GitOrigin-RevId: 9c2042aa2ea0e4d3828b32c321336e1c3a4a0ef8
 2024-04-04 08:04:11 +00:00
Antoine Clausse
92a58c8f3b [web] Paywall CTA split-test (#17555) 
* Fix `{splitTest.requiredCohortSize && (...)}` can display `0`

* Get `paywall-cta` assignment in ProjectController.js

* CTA change: "Get Dropbox Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286026

* CTA change: "Get GitHub Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get Git integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286283

* CTA change: "Add more collaborators"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763884855

* CTA change: "Get track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764030761

* Update wording and position: "Already subscribed? Try refreshing the page."

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764366969

* Casing update: "Upgrade to track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764209961

* CTA changes: "Get Mendeley integration" + "Get Zotero integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547424

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547269

* CTA change: "Get full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762005

* Casing update: "full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762280

* CTA change: "Get more compile time" in timeout-upgrade-prompt-new.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get more compile time" in compile-timeout-warning.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762726

* CTA change: "Get advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969087

* Update casing and wording: "advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969412

* CTA change: "Get Symbol Palette"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765128906

* Update title: "Subscribe to find the symbols you need faster"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765289664

* Revert use of `satisfies`: it doesn't work with our version of prettier (https://github.com/prettier/prettier/issues/13516)

* CTA change: "Get more compile time" in compile-timeout-changing-soon.tsx

⚠️ not in miro

* Rename `paywallCtaAssignment`, remove useless export and comment

Addressing Fahru's review

* Add alternative texts in `/registration/try-premium` page

* CTA change: "Get more compile time" in timeout-upgrade-prompt.jsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get GitHub Sync" in import-project-from-github-modal-content.tsx

Not in Miro, but related to: https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get more compile time" in compile-time-warning.tsx

Not in Miro, but related to others

* Fix compile-time-warning style (spacings, overflows out of window)

* `npm run format:fix`

GitOrigin-RevId: 0d8d1808b5901c2761d35494c49713d26721bcfd
 2024-04-03 08:04:16 +00:00
David
bdab0d4c91 Merge pull request #17647 from overleaf/dp-update-IEEE-notification-text 
Update IEEE notification text for after retirement

GitOrigin-RevId: 1d5b0789f51f98da70298889015bdf453ee0eae7
 2024-04-03 08:04:05 +00:00
M Fahru
9b8d0ac122 Merge pull request #17664 from overleaf/dp-plans-page-anchor-tags 
Allow for direct linking to monthly plans

GitOrigin-RevId: 842d88eac84eaf94ec486b213ec4a0b13cf70ad6
 2024-03-29 09:04:34 +00:00