Commit graph

15836 commits

Author SHA1 Message Date
Thomas
347649ebaa Merge pull request #6570 from overleaf/revert-6352-tm-dropbox-webhook-signature-verification
Revert "Add dropbox webhook signature verification and decaf cleanup"

GitOrigin-RevId: eb1fab093d7979a010700f0bc3e1e696f3cba6ae
2022-02-02 09:03:18 +00:00
Thomas
bbb97bed26 Merge pull request #6558 from overleaf/tm-wfh2021-ended
Remove notifications for WFH2021 offer, revert side-bar to old Upgrade notice

GitOrigin-RevId: d5f0bb34b40605a335d48b1d2db54df8fab9224a
2022-02-02 09:03:14 +00:00
Thomas
635a478f36 Add plans page split test variant with new layout (#6450)
* Add plans page split test variant with new layout

* Set itm_content to toggle if group modal clicked through via variant view toggle button

* Change split test name to be more specific

GitOrigin-RevId: 0fa48b1b74eea84f15e630e3a62b36be5549da9e
2022-02-02 09:03:11 +00:00
Thomas
1777c075ea Merge pull request #6423 from overleaf/tm-plans-new-events
Add new analytics events to plans page/subscription flow

GitOrigin-RevId: 7b70ee30749ebc671cf2445f3cbdae91a7278b01
2022-02-02 09:03:07 +00:00
Thomas
7a445eb489 Add dropbox webhook signature verification and decaf cleanup (#6352)
* Decaf: move functions to top level, removing unused vars

* Decaf: fix camelcase identifiers

* Decaf: remove unnecessary code created because of implicit returns

* Decaf: remove next() fallback callbacks

* Decaf: shorten null checks, remove decaf/eslint comments

* Add signature verification for Dropbox webhook

* Add overleaf dropbox app secret to web (staging+prod)

* Add simple acceptance test for dropbox webhook events processing

* Add method for modules to register app middleware prior to bodyParser call, move rawBody middleware to Dropbox module

GitOrigin-RevId: 736f489e2eb5906f7b202c1049c4ce143deea74e
2022-02-02 09:03:03 +00:00
Jakob Ackermann
d90dc2bfae Merge pull request #6519 from overleaf/jpa-lodash-4-17-21
[misc] upgrade lodash from 4.x to 4.17.21

GitOrigin-RevId: 08e03981ffe0f2d3e3d29d9b094d98fcb2d95a6f
2022-02-01 09:03:29 +00:00
Jakob Ackermann
2ed696b3e0 Merge pull request #6517 from overleaf/jpa-node-fetch-2-6-7
[misc] upgrade node-fetch from 2.6.x to 2.6.7

GitOrigin-RevId: 5a43e82e23d78fd6e68a38655dab4665a401a9db
2022-02-01 09:03:24 +00:00
Alexandre Bourdin
931c53d04c Split Tests Admin UI - test list (#6411)
* Admin page to list split tests

Admin page to list split tests

Update split test model

Display optional split test fields + Only display link in admin menu in SaaS mode

Add a separate endpoint to update split test info (to avoid creating a new version)

Fix split test tests after rebase

Add name and activeOnly filtering to split test list

Sort split tests by descending order of last modification

Fix lint build error

Add buttons to copy variant assignment as query string

* Move react components to follow our file structure guidelines

* Cleanup and improvements from review

* Small change of report URLs display

* Improve filters display for small screens

GitOrigin-RevId: 498531a1f080419de017883e33d6afed05a3f5c9
2022-01-31 09:03:42 +00:00
Alf Eaton
4cad876173 [web] CodeMirror 6 track changes extension (#6455)
GitOrigin-RevId: 038f375c40e7bc8009ee423016b711a2252f52fa
2022-01-31 09:03:19 +00:00
Alf Eaton
157a380bad Merge pull request #6491 from overleaf/ae-cm6-upgrade
Upgrade CodeMirror 6 packages

GitOrigin-RevId: 997951d9542eb2ad220416e5dc6ee8c2388b2135
2022-01-31 09:03:09 +00:00
Jakob Ackermann
8789296f5a Merge pull request #6481 from overleaf/jpa-node-14-18-3
[misc] upgrade node version from 14.18.1 to 14.18.3

GitOrigin-RevId: 976542fcc0271e323695c59a987dcf1614ee633e
2022-01-28 09:03:53 +00:00
Jakob Ackermann
409d8cd1a8 Merge pull request #6470 from overleaf/jpa-o-error-3-4
[misc] upgrade o-error to v3.4.0 in all the places

GitOrigin-RevId: 7b7ce1211cbe5e41754ca2ae112d237befdcf40e
2022-01-28 09:03:45 +00:00
June Kelly
cc515afe95 Merge pull request #6484 from overleaf/ta-script-require-fix
Fix Require Path

GitOrigin-RevId: 1525890bd24520d8715cfbc8d617c545ef199314
2022-01-28 09:03:32 +00:00
June Kelly
542207b6f9 Merge pull request #6488 from overleaf/ta-survey-future-remove
Remove Product Survey 2021

GitOrigin-RevId: 3db6686a951d192ef86c58ac99e8b3e40947c5b2
2022-01-28 09:03:28 +00:00
Eric Mc Sween
57228c5589 Merge pull request #6442 from overleaf/em-split-tests-user-admin
Show split test assignments in user admin

GitOrigin-RevId: 4563a4899d5278a0ef84188ae25cb5dfd3d5cb57
2022-01-27 09:04:06 +00:00
Jakob Ackermann
7b4102025e Merge pull request #6493 from overleaf/jpa-flaky-delay
[web] HaveIBeenPwnedApiTests: give background check more time

GitOrigin-RevId: 761b3f402f9284eb56bee29e6e78e759ac42ba86
2022-01-27 09:03:53 +00:00
Jakob Ackermann
3730672c97 Merge pull request #6502 from overleaf/jpa-skip-likely-failing-login-request
[web] skip login re-try request when no captcha response was generated

GitOrigin-RevId: 9edc6e8394914a710020983fe9cbcf09d543a82f
2022-01-27 09:03:48 +00:00
Jakob Ackermann
d812b88e76 Merge pull request #6457 from overleaf/jpa-harden-login
[web] harden login process

GitOrigin-RevId: 5c0b7cc725efd5e3e879067ad8a42fe46a47b60d
2022-01-27 09:03:38 +00:00
Jakob Ackermann
8e77ada424 Merge pull request #6417 from overleaf/jpa-device-history
[web] add cookie/JWE based device history for skipping captcha challenge

GitOrigin-RevId: b091564bfd93f7e587d396c860fd864f220f4b63
2022-01-27 09:03:34 +00:00
Brian Gough
89268bee2c Merge pull request #6485 from overleaf/bg-remove-op-from-timeout-error
[web] remove unnecessary content from timeout errors

GitOrigin-RevId: c4913956e6f990afbd4c8f225c6d7c51e6d77e75
2022-01-27 09:03:30 +00:00
Brian Gough
b43a3a6861 Merge pull request #6486 from overleaf/bg-remove-google-analytics-from-errors
[web] remove google analytics for editor errors

GitOrigin-RevId: cac318316780e84cd8d076624a4e3f39b7cf2725
2022-01-27 09:03:26 +00:00
Brian Gough
e1add75eee Merge pull request #6407 from overleaf/bg-linter
port ace linter to codemirror6

GitOrigin-RevId: 080781bf303ebcd25461e6d07a02e14310ab3d59
2022-01-27 09:03:22 +00:00
Jessica Lawshe
6a0da3d204 Merge pull request #6375 from overleaf/jel-reconfirm-check
[web] Use v1 date for reconfirm notification check

GitOrigin-RevId: e14f1b6a1a6ab629628858d962a3757a6078cf79
2022-01-26 09:03:50 +00:00
Jessica Lawshe
7653b46719 Merge pull request #6356 from overleaf/jel-user-admin-panel
[web] v2 admin affiliations tab shows data used for licenses

GitOrigin-RevId: 1038b042a0728b118d3204515ed9f69e35746b18
2022-01-26 09:03:43 +00:00
Jakob Ackermann
cfaec97a3d Merge pull request #6393 from overleaf/ta-backfill-user-properties
Backfill User Properties

GitOrigin-RevId: ea2ffeaaf71d5ce41c76a1bfb2f0014006ef0d08
2022-01-26 09:03:06 +00:00
Jakob Ackermann
b2e18c92a6 Merge pull request #6418 from overleaf/ta-ga-optimize-remove
Cleanup Google Optimize

GitOrigin-RevId: d8cf8008179ad2c355c09f06d947fb2b89cf5a3c
2022-01-26 09:03:02 +00:00
Jakob Ackermann
a13dee04c6 Merge pull request #6424 from overleaf/jpa-multi-submit-async-form
[web] add support for async-form inside a multi-submit page

GitOrigin-RevId: 801363aeacc6c10411aceaf2c09a5e4b3b90fcf7
2022-01-26 09:02:55 +00:00
Alexandre Bourdin
4c49edd89b Assignment by id for recurly webhook (#6465)
* Allow split test assignment by ID for recurly webhook

* Small refactoring of assignment logic

* Add tests for getAssignmentForUser

* Cleanup following review comments

* Provide default value for sync option in split test handler

GitOrigin-RevId: 828cad3a1f3a0f3efd25f427d00a3c530ae2f087
2022-01-25 09:04:05 +00:00
Alexandre Bourdin
1b954fa720 Merge pull request #6332 from overleaf/ab-split-test-param-overrides
Split tests query param overrides

GitOrigin-RevId: 8112710d057ddc22cebf37a619dfc969be57b6cc
2022-01-25 09:03:04 +00:00
Tim Alby
bbac46156b convert price_in_unit to price_in_cents
GitOrigin-RevId: bae030e9c90f8286d6e6550744849984fe81f63d
2022-01-21 09:03:29 +00:00
Tim Alby
3e70546e18 rename price attributes to price_in_cents or price_in_unit
GitOrigin-RevId: 8045472c96862078583fcb522099ad78926281dc
2022-01-21 09:03:23 +00:00
Tim Alby
3dbd913d97 disambiguate between displayPrice and recurlyPrice
GitOrigin-RevId: 38f4c51b9834c417824c0093096767f50e998cb8
2022-01-21 09:03:16 +00:00
Tim Alby
e98084259a renames prices scope var into groupPlans
GitOrigin-RevId: ef53edd8f9b78eb13fb2d4bb488e30ee02858764
2022-01-21 09:03:11 +00:00
Tim Alby
0421fc58f1 remove old angular plans code
GitOrigin-RevId: 84a1173d300ab3ab2e77c0714b7a1315de59876c
2022-01-21 09:03:08 +00:00
Eric Mc Sween
fd60549482 Merge pull request #6386 from overleaf/em-promisify
Promisify UserAdminController

GitOrigin-RevId: 51bf4ddd0673409006658fb0d8cc60a8b4e1071d
2022-01-20 09:04:15 +00:00
Eric Mc Sween
7446523205 Merge pull request #6358 from overleaf/jel-fix-de-ng-link
[web] Fix modal link in plans FAQ

GitOrigin-RevId: 29137e71f5f0930443660086fb3a1cc3d87b05dd
2022-01-20 09:04:09 +00:00
Alf Eaton
f065a7a909 Improve the Icon component (#6245)
GitOrigin-RevId: fbb23b32c47edbe5a22badc627318accbd09e82a
2022-01-20 09:03:58 +00:00
Alf Eaton
ee00ff3c44 [web] Add the meta[viewport] tag to all pages (#6301)
* Always add the meta[viewport] tag
* Set metadata.viewport to false on projects list page
* Remove setting metadata.viewport = true
* Add viewport: false to editor page

GitOrigin-RevId: 6f9d4c1972e3e6fdf1b6c23cd17d57ba866fcaeb
2022-01-20 09:03:48 +00:00
Alf Eaton
d1e210319b Merge pull request #6389 from overleaf/ae-github-capitalisation
Fix "GitHub" capitalisation

GitOrigin-RevId: 9b47d58a3d92c8dd695ca1c8f3d28ea7d6178da5
2022-01-20 09:03:38 +00:00
Alf Eaton
1dd62570a6 Merge pull request #6390 from overleaf/ae-is-visible-binary
[web] Only run updateOnResize when the PDF viewer is visible

GitOrigin-RevId: 90b5632f45406b66af7710c6e8346cf73ffbebea
2022-01-20 09:03:28 +00:00
Jakob Ackermann
5701cc9e4b Merge pull request #6351 from overleaf/jk-cm6-context-menu-revamp
[web] Spelling: use button instead of `a` tag

GitOrigin-RevId: e63a89eb781bbecf33c49cfcd83e8ff7612fa554
2022-01-20 09:03:11 +00:00
Jakob Ackermann
1fc0b3e4aa Merge pull request #6349 from overleaf/jpa-password-strength-checking
[web] data collection for password strength using HaveIBeenPwned api

GitOrigin-RevId: 7e4d57a979c29027fb7ca5294f3935500a0b4cf3
2022-01-20 09:03:07 +00:00
Jakob Ackermann
220daff655 Merge pull request #6384 from overleaf/jpa-fix-proxying-of-json
[web] fix proxying of responses from other services

GitOrigin-RevId: ac1ecc02c06e353f8379fadb47824a46672610e5
2022-01-18 09:03:30 +00:00
Jakob Ackermann
d720d6affa Merge pull request #6317 from overleaf/jpa-send-explicit-content-type
[web] send explicit content type in responses

GitOrigin-RevId: d5aeaba57a7d2fc053fbf5adc2299fb46e435341
2022-01-18 09:03:18 +00:00
Jakob Ackermann
c97e95aeba [web] confirmDomain: skip fetching affiliations per user
Nothing is looking at either
 - `user.emails[i].affiliation` or
 - `user.emails[i].emailHasInstitutionLicence`
So we might as well skip fetching the data.

This eliminates N v1 calls and N mongo calls from the endpoint.

GitOrigin-RevId: bb1d077df19910b9dfb7ef06562cf35ce5302290
2022-01-14 09:03:33 +00:00
Jakob Ackermann
5a7698ddef [web] refactor updating of scroll position in pdf view
Co-Authored-By: Timothée Alby <tim.alby@overleaf.com>
GitOrigin-RevId: 932c880bcd41e68d231928bdcbbaeb06c60f6fd5
2022-01-14 09:03:28 +00:00
lawshe
212430e430 Run script on primary
GitOrigin-RevId: 655191d2948ce3a1cfedc4e660965ed90c0371ba
2022-01-14 09:03:23 +00:00
Tim Alby
d5c574360f remove uses of this in tests
GitOrigin-RevId: 2eea02c91358a7bb5e1d32c8990f793d6f794ac4
2022-01-14 09:03:14 +00:00
Tim Alby
5798011bce always check response's status code in tests
GitOrigin-RevId: 46ed4912a6508aa3ce2048ff8d887af4d8907d6a
2022-01-14 09:03:11 +00:00
Tim Alby
795ed56034 asyncify tests
GitOrigin-RevId: 62f875bb121a599fab830a3244959596796cd6e1
2022-01-14 09:03:08 +00:00