Commit graph

225 commits

Author SHA1 Message Date
Miguel Serrano
296ce0e460 Simplify error hint when symbols are used outside of math mode (#4301)
* Simplify error hint when symbols are used outside of math mode

* Fix rendering and added option to skip rendering on plain mode

* Remove unnecessary WikiLink as it is automatically added

* Remove unused skipPlainRendering prop

Co-authored-by: Alasdair Smith <ali@alasdairsmith.co.uk>
GitOrigin-RevId: 7091873beaa05b04f534628cbdd9a559020cfc8e
2021-08-04 02:05:37 +00:00
Jakob Ackermann
86099725ad Merge pull request #4293 from overleaf/jpa-pdf-js-error-handling
[frontend] fix broken PDF preview caused by missing error handling

GitOrigin-RevId: a7bba8d1b351a53fb20eb670d2ae4c6d215d0d85
2021-07-28 02:06:15 +00:00
Jakob Ackermann
97da586877 Merge pull request #4326 from overleaf/pr-avoid-double-stringify-compile-events
Remove controller-level `stringify` for compile events

GitOrigin-RevId: 1b33b5204a846dc4f25dcfbad02c1edc1e010e9f
2021-07-20 11:33:33 +00:00
Paulo Jorge Reis
51c6d90c17 Handle PDF rendering errors in the new logs UI (#4280)
* Handle PDF rendering errors in the new logs UI

* Remove new logs UI specific code from the PDFController

* Only change view with errors and validation issues in the new logs UI

GitOrigin-RevId: 0761ac224db39fdacbb61692c1aa35c3da82a76b
2021-07-07 02:05:48 +00:00
Paulo Jorge Reis
db8173011e Revert "Revert "Handle PDF failure error case""
This reverts commit 946838e51feaff28025c4a4d733e0dd89a29e890.

GitOrigin-RevId: 63f130c8cfecfb512ec97bda62c6ea1cad2c8fed
2021-07-07 02:05:36 +00:00
Alf Eaton
34ba76aa76 Merge pull request #4286 from overleaf/jpa-clear-clsi-unavailable-state
[frontend] PdfController: clear clsiUnavailable state for new responses

GitOrigin-RevId: 7a89a24db6c8f0e62e775befcb4148e749ce8b4e
2021-07-06 02:05:46 +00:00
Jakob Ackermann
343ab44172 Merge pull request #4279 from overleaf/bg-revert-async-apply-in-pdfcontroller
revert async apply in PdfController

GitOrigin-RevId: 20628ca8c9ba06528271e1323ba062d6b563e08e
2021-07-01 12:29:45 +00:00
Paulo Jorge Reis
4e384e0c3b Revert "Handle PDF failure error case"
This reverts commit 902a97f6f454f09345ba4017b50623fd46e57110.

GitOrigin-RevId: 946838e51feaff28025c4a4d733e0dd89a29e890
2021-06-29 02:05:56 +00:00
Paulo Reis
07f44b99f4 Handle PDF failure error case
GitOrigin-RevId: 902a97f6f454f09345ba4017b50623fd46e57110
2021-06-25 02:06:16 +00:00
Alf Eaton
9b9d6f679e Wrap recompile response handlers in $applyAsync (#4253)
GitOrigin-RevId: 80e5652b88ba70b3ea1aef2cf24430597574353e
2021-06-24 02:07:19 +00:00
Alf Eaton
7c97f8ab6e Switch to new JSX runtime (#4225)
* Use new JSX runtime and update Babel Node target
* Update .eslintrc
* Remove React imports

GitOrigin-RevId: 559de0267f8f2934c56a860ea8701bb522aa861a
2021-06-24 02:06:59 +00:00
Jakob Ackermann
b2bc589ad1 Merge pull request #4236 from overleaf/jpa-cleanup-metrics
[PdfJsMetrics] drop unused metrics

GitOrigin-RevId: 377cb4c97746bb81b9cf90e1d48e0050a8d05893
2021-06-23 02:05:52 +00:00
Timothée Alby
866e2f0aab Merge pull request #4223 from overleaf/bg-load-server-worker-timeout
add timeout on loading of service worker

GitOrigin-RevId: d2153c9abf1dbd6eee3b2fcfd770a21766ebb84e
2021-06-22 02:07:16 +00:00
Jakob Ackermann
a6cce9d2f6 Merge pull request #4210 from overleaf/jpa-pdf-caching-5-percent
[misc] pdf caching out of beta with 5%/5% control/treatment split test

GitOrigin-RevId: 06a741f56510b866be3380a99304d8ee67f849dd
2021-06-17 02:09:15 +00:00
Jakob Ackermann
e8bb0114f8 Merge pull request #4203 from overleaf/bg-admin-disable-service-worker
disable service worker via admin page

GitOrigin-RevId: 96ec9f07b32b831f5271827ab345ad831044f831
2021-06-17 02:09:06 +00:00
Alf Eaton
6ab9fffb49 Remove Angular file tree modal code (#4198)
GitOrigin-RevId: feeae54575cce8b315b4e6bb0df3e17405025855
2021-06-16 02:05:58 +00:00
Jakob Ackermann
d9cd12db4e Merge pull request #4197 from overleaf/jpa-compile-metrics-version
[misc] PdfJsMetrics: add a version number to the compile segmentation

GitOrigin-RevId: 18d1481fe120f12895633adfd06a4036eca62de0
2021-06-15 02:06:29 +00:00
Jakob Ackermann
3b3f1fbb73 Merge pull request #4196 from overleaf/jpa-compile-metrics-version
[misc] PdfJsMetrics: add a version number to the event segmentation

GitOrigin-RevId: 4c5e1df9e3513edbfeae0f47303ce9512a25c118
2021-06-15 02:06:25 +00:00
Shane Kilkelly
05e427624b Merge pull request #4180 from overleaf/ae-new-file-button
Open the new file modal with an event

GitOrigin-RevId: 1eca8faf63bdd2011b931868b0e1073bb047266e
2021-06-12 02:08:36 +00:00
Alf Eaton
8b40e760ca Merge pull request #4133 from overleaf/ae-project-too-large
Display project-too-large error

GitOrigin-RevId: 9078b4f24d3380a4554f9fd91fe0254524763830
2021-06-11 02:06:51 +00:00
Alf Eaton
3ab0aee30c Merge pull request #4131 from overleaf/ae-uneditable-file-outline
Notify the outline manager when a file is opened

GitOrigin-RevId: 246da98f1b9a433aeeb8e5b420ad0999544778c3
2021-06-11 02:06:46 +00:00
Alf Eaton
764234e42b Merge pull request #4158 from overleaf/ae-rename-file-view
Rename `binary-file` components to `file-view`

GitOrigin-RevId: b960d4e6f154ee1a5847782a1fcb1e4e61159603
2021-06-11 02:06:38 +00:00
Jakob Ackermann
c774ddd111 Merge pull request #4169 from overleaf/jpa-pdf-caching-full-beta
[misc] change pdf caching split test for beta users to 50/50 roll out

GitOrigin-RevId: 3153448db82a9f0fa821da9d6cf5255e1feaaf28
2021-06-11 02:06:24 +00:00
Alexandre Bourdin
c634f51eee Merge pull request #4116 from overleaf/ab-paywall-prompt-events
Add paywall prompt events

GitOrigin-RevId: 6b1b3b384590f14828f37210b2e14047e2ee33d6
2021-06-11 02:05:54 +00:00
Jessica Lawshe
4c6933b5b8 Merge pull request #4162 from overleaf/jpa-service-worker-error-reporting
[misc] serviceWorker: add error reporting using postMessage API

GitOrigin-RevId: db021d4f5cd5b7b8a0026b92d412112f60499c0b
2021-06-10 02:05:28 +00:00
Alf Eaton
cce0051be6 Merge pull request #4140 from overleaf/ae-react-share-modal
Remove Angular share modal code

GitOrigin-RevId: 136b10c7b9768f2d8de13e48b16fd71947506624
2021-06-08 02:05:34 +00:00
Eric Mc Sween
568e99ad47 Merge pull request #4125 from overleaf/em-analytics-keepalive
Use keepalive when sending analytics events

GitOrigin-RevId: c4e5884483313cdc67abe98e18852680692ac229
2021-06-04 02:08:19 +00:00
Jakob Ackermann
862f7f413a Merge pull request #4137 from overleaf/jpa-fix-metrics-collection
[PdfJsMetrics] fix metrics collection with disabled service worker

GitOrigin-RevId: 607ecd15a3b95b33a45506c489557e5116168c3d
2021-06-03 02:08:56 +00:00
Jakob Ackermann
58c7b6188f Merge pull request #4123 from overleaf/jpa-pdf-caching-one-split-test
[misc] rework roll-out of pdf caching

GitOrigin-RevId: 98ff50918050fe8e9fb5bfecb862657d48cd2726
2021-06-02 02:05:50 +00:00
Jakob Ackermann
e1516aab2c Merge pull request #4110 from overleaf/jpa-omit-skewed-render-latency
[frontend] PdfJsMetrics: omit render time in case we detect hidden page

GitOrigin-RevId: b1ae3b29dbb9764cf67f2f1b1e2f93c83fe67426
2021-06-02 02:05:46 +00:00
Jakob Ackermann
5988e03dac Merge pull request #4108 from overleaf/jpa-lean-pdf-caching-metrics
[frontend] PdfJsMetrics: submit a subset of data points, flatten nested

GitOrigin-RevId: a98ede58f5823020a4c78f46b9800369185f1336
2021-06-02 02:05:43 +00:00
Jakob Ackermann
0015002e53 Merge pull request #4107 from overleaf/jpa-compile-time-client-e2e
[frontend] PdfController: track the e2e compile time seen by the client

GitOrigin-RevId: 1d7c8b815735fd3c0ad9a32284c37c621798fbd3
2021-06-02 02:05:40 +00:00
Jakob Ackermann
6140b53493 Merge pull request #4081 from overleaf/msm-symbol-toggle-styling
Added 'active' styling to Symbol Palette toggle button

GitOrigin-RevId: a1a51e42a08cd3627d0bc4610e6895e111d951f9
2021-06-01 02:05:37 +00:00
Jakob Ackermann
b93761f275 Merge pull request #4094 from overleaf/jpa-tag-pdf-caching-traffic
[frontend] PdfController: tag traffic that uses the pdf caching logic

GitOrigin-RevId: ab0d847ff1fe31131428c782ce95b3a5b3dff4fd
2021-05-27 02:05:59 +00:00
Alf Eaton
823960f763 Merge pull request #4079 from overleaf/ae-ace-replace-range-symbol
Replace all selected ranges when inserting symbol into source editor

GitOrigin-RevId: bc0d7548f61fd740a87b34bb181516e8dc21fff1
2021-05-26 02:05:17 +00:00
Jakob Ackermann
fa914af56c Merge pull request #4083 from overleaf/bg-avoid-multiple-pdf-renders-on-loading
ignore pdf rendering before loading has completed

GitOrigin-RevId: 3ad435507045decf49c3678abe3bfadd07d0cbca
2021-05-22 02:05:59 +00:00
Jakob Ackermann
f0b3d8a26a Merge pull request #4076 from overleaf/jpa-events-split-test
[misc] submit events and prepare roll-out for pdf caching w/ split test

GitOrigin-RevId: a7b7af65e1adf5bf003b65d96f1641a343b4b09c
2021-05-22 02:05:44 +00:00
Jakob Ackermann
f49a539c91 Merge pull request #4073 from overleaf/jpa-verify-chunks
[misc] serviceWorker: add optional verification of chunk

GitOrigin-RevId: 7fe9619ab9a928409cdf665d938734bb6a77f853
2021-05-22 02:05:41 +00:00
Jakob Ackermann
dfabc3a93b Merge pull request #4072 from overleaf/jpa-pdfjs-metrics
[frontend] PdfController: observe PDF.js fetch/render performance

GitOrigin-RevId: bdd81ba06dabaa944b64266d0c36700d16790a30
2021-05-22 02:05:38 +00:00
Jessica Lawshe
fefb588d71 Merge pull request #3973 from overleaf/as-clean-up-hue-generator
Clean up hue generator

GitOrigin-RevId: 1b7fad05d7c2f6519efbbe0379f2449c273e4f4b
2021-05-19 02:06:15 +00:00
Miguel Serrano
73c47fa0e0 Layout divider for Symbol Palette (#4036)
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: e22635978c16646060c80ceb8376a560bfbf6527
2021-05-18 02:08:12 +00:00
Jakob Ackermann
7db7cd4a49 [misc] merge pdf caching into main (#4033)
* [frontend] WIP: pdf caching using service worker -- squashed

Ref: 920fbaa00b31530f7c457a2d93bad5e553798057
Co-Authored-By: Brian Gough <brian.gough@overleaf.com>
Co-Authored-By: Eric Mc Sween <eric.mcsween@overleaf.com>

* [misc] add contentId into the URL for protecting PDF stream contents

* [misc] gracefully handle missing ranges in serviceWorker

* [misc] support PDF stream caching for anonymous users

* [misc] polish header names and add URL to error message when fetch fails

* [misc] polish event handler registration

* [misc] limit serviceWorker scope to /project/ -- trailing slash

This will block the service worker from intercepting requests on the
 project dashboard.

* [misc] add per-request feature flag for enabling PDF stream caching

* [misc] expose compile stats and timings to the frontend

* [misc] serviceWorker: support clsiServerId and compileGroup url params

* [misc] serviceWorker: polish header maps

* [misc] serviceWorker: drop TODO for p-limit -- the browser has a queue

* [misc] serviceWorker: drop verbose log message on every fetch

* [misc] cut down size of diff in backend code

* [misc] add test case for forwarding of pdf caching and metrics details

* [misc] serviceWorker: drop all the log lines

* [misc] serviceWorker: add boundary guards to the compile request regex

Co-authored-by: Brian Gough <brian.gough@overleaf.com>
Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
GitOrigin-RevId: 4b291b4a4f2866cf07bccf8ec9068f33bbfdc916
2021-05-18 02:07:57 +00:00
Miguel Serrano
bb88af80cf Merge pull request #3947 from overleaf/msm-reenable-eslint-rules
Reenable `eslint` rules

GitOrigin-RevId: a0aa5f941ba1bc49ff758b5256f91d696f442c6d
2021-05-14 02:09:45 +00:00
Miguel Serrano
f9871103bf Merge pull request #3949 from overleaf/msm-reenable-eslint-const-rule
Reenable eslint `prefer-const` rule

GitOrigin-RevId: 4f3825be8b8dff381095209085a36eaab76260d5
2021-05-06 02:09:14 +00:00
Alf Eaton
dbc909ae54 Merge pull request #3970 from overleaf/ae-remove-filetreereactbridge
Remove showReactAddFilesModal, showReactFileTree, useFileTreeAngularListener and FileTreeReactBridge

GitOrigin-RevId: 61fc54efe761922137b032b9b532975fc101264d
2021-05-01 02:13:18 +00:00
Chrystal Maria Griffiths
3dfcb95802 Merge pull request #3960 from overleaf/cmg-binary-file
[BinaryFile] Reopening of Binary file React migration

GitOrigin-RevId: 050e66e3321bd6579d44932b669fc0a31df06d18
2021-04-29 02:09:38 +00:00
Jakob Ackermann
adfde7d26b Merge pull request #3950 from overleaf/msm-reenable-lint-prefer-regex-literals
Reenable `prefer-regex-literals` eslint rule

GitOrigin-RevId: 3c576d92a08dfcb745d447b1bf8c7b828753010d
2021-04-29 02:09:10 +00:00
Miguel Serrano
8fbd4e3340 Merge pull request #3963 from overleaf/revert-3819-msm-update-pdfjs-2-6
Revert "Update `pdf.js` to `2.6.347`"

GitOrigin-RevId: 62402d8e0b99b302206f0edc61411c9477d29249
2021-04-28 02:10:27 +00:00
Miguel Serrano
bac110ee46 Merge pull request #3819 from overleaf/msm-update-pdfjs-2-6
Update `pdf.js` to `2.6.347`

GitOrigin-RevId: fd2a6708077e574a909ff05105ab70ea7c99daf5
2021-04-28 02:10:23 +00:00
Alf Eaton
1be43911b4 Merge pull request #3942 from overleaf/prettier-trailing-comma
Set Prettier's "trailingComma" setting to "es5"

GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00