Commit graph

66 commits

Author SHA1 Message Date
Mathias Jakobsen
fce0a45128 Merge pull request #11234 from overleaf/ae-editor-type-rich-text
Record `cm6-rich-text` editorType in editing session pings

GitOrigin-RevId: 32d8cb60361348123bf5825961eb7e8b6e740ce8
2023-01-17 09:05:05 +00:00
Tim Down
ba3b42def4 Merge pull request #10810 from overleaf/td-ace-perf-lags
Send Ace lags performance metrics to analytics

GitOrigin-RevId: 7c97a085d4c6bc22830549f8bf069bfb638bff33
2022-12-09 09:04:09 +00:00
Tim Down
fd2863bf7a Merge pull request #10747 from overleaf/as-ace-perf-measurement
Add perf measurement of Ace editor

GitOrigin-RevId: b33eeac9f7c7f85355a9e8f34833aa94bee2f70a
2022-12-07 09:04:21 +00:00
Tim Down
c4b1bb87ea Merge pull request #10587 from overleaf/td-commit-hash-metric
Add editing session segmentation values for long tasks and release

GitOrigin-RevId: ee22238ae40b342cbd6b1e6cddcb2d0e67dba138
2022-11-30 09:04:12 +00:00
Alf Eaton
65b0fd73ea Improve "compile" keyboard shortcut handling (#10624)
* Improve "compile" keypress handling
* Remove "compile" keypress handling from PDF preview
* Remove compile shortcuts from CM6
* Use an event for Vim keybindings
* Remove event handlers from Angular/Ace
* Move useCompileTriggers into DetachCompileProvider

GitOrigin-RevId: 7f0e667b5106a849458e06ebb0f7a413d5d63430
2022-11-29 09:04:04 +00:00
M Fahru
d70e0b1c0e Implement grammarly warning alert on cm6 users
GitOrigin-RevId: ed272bbc385faa69811ec1891075906cdca1c984
2022-11-16 09:06:39 +00:00
Tim Down
6ae22ff596 Merge pull request #10361 from overleaf/td-cm6-keypress-paint-metric
Add metric for mean time from keypress to visible character in CM6

GitOrigin-RevId: 8077dc11ca9e3fd1472fef745c6058bfbad1088b
2022-11-11 09:03:49 +00:00
M Fahru
19dd2f67e2 Implement "switch away survey" when users switching back to ace from cm6 (#10201)
Implement legacy source editor survey:

* Force user to switch to cm6 if they haven't seen switch away survey

* Only show user switch away survey if they open ace from another editor

* We need to wait 3 seconds until the survey is being shown

* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users

* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey

* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that

* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses

GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
2022-11-04 09:05:50 +00:00
Mathias Jakobsen
50b346b4ed Merge pull request #10279 from overleaf/jpa-tracing-optimizations
[misc] do not load the tracing module unless enabled

GitOrigin-RevId: 8a3b9da3e9451e3060b852dd44e078c99cf43cfa
2022-11-04 09:05:00 +00:00
Tim Down
a320982f79 Merge pull request #10235 from overleaf/td-cm6-lag-metrics
Add CM6 typing lag metrics

GitOrigin-RevId: 7068647a28980d888ecb5a0203f0a3563ce4c713
2022-11-02 09:03:59 +00:00
Simon Detheridge
3d9c8f80f4 Merge pull request #10227 from overleaf/spd-td-opentelementry
Add opentelemetry to dev environment

GitOrigin-RevId: 31a8234197337a264412b411429692525793c8b0
2022-11-01 09:04:53 +00:00
Tim Down
3dbcc03db2 Merge pull request #10063 from overleaf/td-extra-editing-session-metrics
Add extra editing session metrics

GitOrigin-RevId: d382719364e9fe029cd664e77608faa50204e0e0
2022-10-31 09:04:04 +00:00
Tim Down
bfb8aaffdd Merge pull request #10040 from overleaf/td-cm6-count-inputs-between-dom-updates
Record the maximum number of user input events between CM6 DOM updates

GitOrigin-RevId: 1a779a7d8e3675447cf58e2840afd0781bdc6ab9
2022-10-21 08:03:53 +00:00
Alasdair Smith
47b3b72076 Merge pull request #9938 from overleaf/revert-9935-revert-9901-as-td-cm6-perf-editing-sessions
Bring back reporting of CM6 perf measurement in editing sessions

GitOrigin-RevId: 236c6e23f09a2ddaebf1c231ed77404c4b64179d
2022-10-13 08:04:05 +00:00
Alasdair Smith
82f0792e68 Merge pull request #9935 from overleaf/revert-9901-as-td-cm6-perf-editing-sessions
Revert "Connect CM6 perf measurement to editing sessions"

GitOrigin-RevId: b9793b47d6965a5026c0f770105abb9e07a09a59
2022-10-12 08:04:14 +00:00
Alasdair Smith
980b62aa39 Merge pull request #9901 from overleaf/as-td-cm6-perf-editing-sessions
Connect CM6 perf measurement to editing sessions

GitOrigin-RevId: 04d846fb012477994c069da0630306ea7cf57723
2022-10-12 08:03:43 +00:00
Alf Eaton
4843288b50 Merge pull request #9312 from overleaf/ds-remove-keyShortCut
Remove keyShortCut from compile function options

GitOrigin-RevId: 31b13be5fd6742419d4147b89ef281b1b30227fb
2022-08-22 08:03:49 +00:00
Jakob Ackermann
f11e1a83cd Merge pull request #8776 from overleaf/jpa-drop-service-worker
[web] goodbye service worker

GitOrigin-RevId: ce85d4850faba15c5877ce1f3e78026de30c6eae
2022-07-11 08:03:57 +00:00
Jakob Ackermann
64184a7f56 Merge pull request #8730 from overleaf/jpa-refactor-pdf-caching
[web] refactor pdf caching

GitOrigin-RevId: af6b871fad652f757d8c465085b33a79b955cd6b
2022-07-07 08:03:28 +00:00
Jakob Ackermann
b04bc4798e Merge pull request #8473 from overleaf/ii-cm6-missing-keyboard-shortcuts-2
[cm6] Add missing keyboard shortcuts 2

GitOrigin-RevId: 29f68cd2eb9d0ad931fff463f76ddb91b5275516
2022-06-22 08:05:20 +00:00
Alf Eaton
1f24160005 Switch layouts using custom divider toggle (#7995)
GitOrigin-RevId: 15e517f448165a25df616fd956967202491b15cc
2022-05-23 08:03:30 +00:00
Alf Eaton
9f969d07e0 Delete unused PDF-related code (#6334)
* Remove new logs UI code
* Remove unused preview components
* Move metrics file
* Remove Angular PDF controllers
* Move the service worker util functions
* Remove the ide/pdfng folder
* Remove vendored pdf.js
* Remove showNewPdfPreview
* Use mockCompile
* Remove split test code

GitOrigin-RevId: 723b7440c62cda51f6ad8bb9c691900882166d21
2022-03-16 09:03:04 +00:00
June Kelly
9702346edc Merge pull request #6628 from overleaf/jk-heartbeat-editor-type-metadata
Add editor metadata to editing-session pings

GitOrigin-RevId: f42be772c13f71380d59bae7c447645fe0e16a17
2022-03-02 09:02:34 +00:00
Brian Gough
fde4f72adf Merge pull request #6779 from overleaf/ae-cm-editor-switch
[web] [cm6] Add a three-way switch for editor choice

GitOrigin-RevId: fff788ddad8d10488e8446de7f1503702da0985f
2022-02-22 09:03:05 +00:00
June Kelly
19edfab153 Merge pull request #6624 from overleaf/bg-cm6-autocompile-lint-check
[web] add cm6 hasLintingError support

GitOrigin-RevId: 9e531526003595cb5139623f929605a7fd0f59f8
2022-02-16 11:32:33 +00:00
June Kelly
ef4e137676 Merge pull request #6610 from overleaf/jk-better-editing-heartbeat
[web] CM6: improvements to editor heartbeat

GitOrigin-RevId: b0e5379d221cba76c91d6d21863ca8355749d18e
2022-02-16 11:32:19 +00:00
June Kelly
4b14a14819 Merge pull request #6573 from overleaf/jk-cm6-heartbeat
[web] Move on-scroll heartbeat tracking from ace to IDE

GitOrigin-RevId: e39bc9ebffde228c4a2d6045837fae3b64219bed
2022-02-04 09:03:23 +00:00
Jessica Lawshe
0e20c204a1 Merge pull request #5983 from overleaf/jel-release-disable-ng-router
Release disabling angular router

GitOrigin-RevId: be54f3cda5f0086ac2b6f3fcf56c4fa452d1bc0d
2021-12-03 09:04:28 +00:00
Timothée Alby
8ca159b4b9 Merge pull request #5797 from overleaf/ta-pdf-detach
PDF Detach

GitOrigin-RevId: f69d8a87d1ba2115ad496a719106dfc7707a6ed5
2021-11-16 09:02:57 +00:00
Alf Eaton
73bc3418a2 Add React version of the PDF preview pane (#5135)
GitOrigin-RevId: fcc88a362c3e97c9fddf85d47c3a83a0a0b89432
2021-10-01 08:03:12 +00:00
Alf Eaton
28082e64ff Merge pull request #5015 from overleaf/ae-recompile-on-save
Recompile on save key press when PDF preview is focused

GitOrigin-RevId: 9f2c2c5de44c665c9d4c240fb418b9dc321e3523
2021-09-15 08:03:36 +00:00
Alf Eaton
deafe456b4 Merge pull request #4913 from overleaf/ae-pdf-preview-feature-flag
Add feature flag for React PDF preview pane

GitOrigin-RevId: ac1e7329d13117e72de6f6cf060cd16be81cbbaa
2021-09-06 08:02:52 +00:00
Jakob Ackermann
343ab44172 Merge pull request #4279 from overleaf/bg-revert-async-apply-in-pdfcontroller
revert async apply in PdfController

GitOrigin-RevId: 20628ca8c9ba06528271e1323ba062d6b563e08e
2021-07-01 12:29:45 +00:00
Timothée Alby
866e2f0aab Merge pull request #4223 from overleaf/bg-load-server-worker-timeout
add timeout on loading of service worker

GitOrigin-RevId: d2153c9abf1dbd6eee3b2fcfd770a21766ebb84e
2021-06-22 02:07:16 +00:00
Jakob Ackermann
3414646290 Merge pull request #4207 from overleaf/bg-reset-service-worker
add setting to reset service worker

GitOrigin-RevId: da889e43f99c908eee1b2351f69571b4bccde28d
2021-06-17 02:09:11 +00:00
Alf Eaton
764234e42b Merge pull request #4158 from overleaf/ae-rename-file-view
Rename `binary-file` components to `file-view`

GitOrigin-RevId: b960d4e6f154ee1a5847782a1fcb1e4e61159603
2021-06-11 02:06:38 +00:00
Alf Eaton
cce0051be6 Merge pull request #4140 from overleaf/ae-react-share-modal
Remove Angular share modal code

GitOrigin-RevId: 136b10c7b9768f2d8de13e48b16fd71947506624
2021-06-08 02:05:34 +00:00
Eric Mc Sween
568e99ad47 Merge pull request #4125 from overleaf/em-analytics-keepalive
Use keepalive when sending analytics events

GitOrigin-RevId: c4e5884483313cdc67abe98e18852680692ac229
2021-06-04 02:08:19 +00:00
Timothée Alby
70952906c9 Merge pull request #4043 from overleaf/as-clean-up-exposed-settings
Remove `exposedSettings` from `ApplicationContext`

GitOrigin-RevId: 02acd3a7cf36d184560ff6df13acff515da908fa
2021-05-20 02:05:05 +00:00
Miguel Serrano
73c47fa0e0 Layout divider for Symbol Palette (#4036)
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: e22635978c16646060c80ceb8376a560bfbf6527
2021-05-18 02:08:12 +00:00
Jakob Ackermann
7db7cd4a49 [misc] merge pdf caching into main (#4033)
* [frontend] WIP: pdf caching using service worker -- squashed

Ref: 920fbaa00b31530f7c457a2d93bad5e553798057
Co-Authored-By: Brian Gough <brian.gough@overleaf.com>
Co-Authored-By: Eric Mc Sween <eric.mcsween@overleaf.com>

* [misc] add contentId into the URL for protecting PDF stream contents

* [misc] gracefully handle missing ranges in serviceWorker

* [misc] support PDF stream caching for anonymous users

* [misc] polish header names and add URL to error message when fetch fails

* [misc] polish event handler registration

* [misc] limit serviceWorker scope to /project/ -- trailing slash

This will block the service worker from intercepting requests on the
 project dashboard.

* [misc] add per-request feature flag for enabling PDF stream caching

* [misc] expose compile stats and timings to the frontend

* [misc] serviceWorker: support clsiServerId and compileGroup url params

* [misc] serviceWorker: polish header maps

* [misc] serviceWorker: drop TODO for p-limit -- the browser has a queue

* [misc] serviceWorker: drop verbose log message on every fetch

* [misc] cut down size of diff in backend code

* [misc] add test case for forwarding of pdf caching and metrics details

* [misc] serviceWorker: drop all the log lines

* [misc] serviceWorker: add boundary guards to the compile request regex

Co-authored-by: Brian Gough <brian.gough@overleaf.com>
Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
GitOrigin-RevId: 4b291b4a4f2866cf07bccf8ec9068f33bbfdc916
2021-05-18 02:07:57 +00:00
Miguel Serrano
f9871103bf Merge pull request #3949 from overleaf/msm-reenable-eslint-const-rule
Reenable eslint `prefer-const` rule

GitOrigin-RevId: 4f3825be8b8dff381095209085a36eaab76260d5
2021-05-06 02:09:14 +00:00
Chrystal Maria Griffiths
3dfcb95802 Merge pull request #3960 from overleaf/cmg-binary-file
[BinaryFile] Reopening of Binary file React migration

GitOrigin-RevId: 050e66e3321bd6579d44932b669fc0a31df06d18
2021-04-29 02:09:38 +00:00
Alf Eaton
1be43911b4 Merge pull request #3942 from overleaf/prettier-trailing-comma
Set Prettier's "trailingComma" setting to "es5"

GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00
Chrystal Maria Griffiths
4e9d7c36ff Merge pull request #3952 from overleaf/revert-cmg-binary-file
Revert "Merge pull request #3526 from overleaf/cmg-binary-file"

GitOrigin-RevId: 5f539f26992fefd01b07922b1f43a3a3bc753141
2021-04-24 02:10:12 +00:00
Eric Mc Sween
1186c3e9a4 Merge pull request #3526 from overleaf/cmg-binary-file
[BinaryFile] Binary file React migration

GitOrigin-RevId: e229ad8ec3781607b5ca28387927b84d4af95060
2021-04-24 02:10:07 +00:00
Alf Eaton
1ebc8a79cb Merge pull request #3495 from overleaf/ae-prettier-2
Upgrade Prettier to v2

GitOrigin-RevId: 85aa3fa1acb6332c4f58c46165a43d1a51471f33
2021-04-15 02:05:22 +00:00
Alasdair Smith
d8baef0077 Merge pull request #3712 from overleaf/pr-fix-chat-resizer
Set chat resizer "closed" size to zero

GitOrigin-RevId: 0b774efb9d921134e190c263a8969d9411988501
2021-03-05 03:04:49 +00:00
Eric Mc Sween
2138bd2a80 Merge pull request #3680 from overleaf/as-em-tm-remove-uiconfig
Remove unused uiConfig global variable from frontend and tests

GitOrigin-RevId: 390abdc097cd9904f7a1c1849e58baf70bea5c72
2021-02-23 03:04:39 +00:00
Miguel Serrano
37d45d64b3 [ReactNavToolbar] Integration branch (#3513)
* Created ng-controller for react shared context and set editor.loading

* toolbar-header component with menu button (and story)

* Added editor-navigation-toolbar-root and react2angular plumbing

* Added eslint-disable exception to use <a/> instead of <button/>

* added 'menu' to extracted translation

* [ReactNavToolbar] Added cobranding and back to projects buttons (#3515)

GitOrigin-RevId: 27c3bba85cbc96a123d58c66a0bd5d6a2cfd8aca
2021-01-28 03:05:28 +00:00