- Swap order of "oldContent" and "static" (apparently that makes the
selection more reliable...)
- Turn off spellchecking outside the spellchecking test (avoid DOM
changes from added underline on misspelled words)
- Swap order of opening file and switching to doc under test:
The cy.findByText('static') was occasionally triggering an unhandled
error in codemirror when it ran while the editor was getting swapped.
(something along the lines of "cannot select out-of-dom range")
- Align source and visual editor tests, use ".findByText(oldContent)"
- Double down on waiting for doc switch to finish loading
GitOrigin-RevId: 8b201a6d78a60e3cfa92c22198f63e705d8880ec
* [server-pro] tests: add helper for gitURL
* [server-pro] tests: avoid hard-coding URL scheme/origin
* [server-pro] tests: fix typo in query selector
* [server-pro] tests: fix spelling of GitHub
* [server-pro] tests: double down on matching email in body
* [server-pro] tests: speed up session resumption
* [server-pro] tests: use a single project in editor spec
* [server-pro] drop check on started recompile
The labels changed between versions and making it configurable is too
verbose.
GitOrigin-RevId: d1ace3b534f28c65b8e20c808bac12268f26fa4d
* [server-pro] trim build context
* [misc] remove old Makefile/mvn cache folders from gitignore
* [misc] add extra entries from .gitignore to .dockerignore
Co-authored-by: Antoine Clausse <antoine.clausse@overleaf.com>
---------
Co-authored-by: Antoine Clausse <antoine.clausse@overleaf.com>
GitOrigin-RevId: 2ebca7d6739f778ec31d0c09fd6a75029bf2483e
* [server-pro] tests: avoid opening editor if not needed for test
* [server-pro] tests: use intercept to avoid opening editor page
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
* [server-pro] tests: use times option in intercept
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
---------
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 9530d1f5b06766fec70631da47d8b1049b59ead5
* Update shellcheck files to include non ".sh" files having the sh shebang
* Add shellcheck to root Makefile
* `make shellcheck_fix`
* Add shellcheck to server-ce and server-pro
* Exclude SC1091 (Not following) in SP/CE
* Fix errors in SP
* Fix errors in CE
* Update root shellcheck to ignore all failing rules. We can later remove rules one by one.
* Add shellcheck to web
* Add shellcheck step for server-ce and server-pro in cloudbuild.yaml
* Revert "Add shellcheck to root Makefile"
This reverts commit e0fa56f2
* Revert "`make shellcheck_fix`"
This reverts commit eb179245c109a9e742a7fdeeb75a4bdd03963587.
* `make shellcheck_fix` in server-ce
* Fix: Use $(...) notation instead of legacy backticked
```
In init_scripts/100_set_docker_host_ipaddress.sh line 5:
echo "`route -n | awk '/UG[ \t]/{print $2}'` dockerhost" >> /etc/hosts
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
Did you mean:
echo "$(route -n | awk '/UG[ \t]/{print $2}') dockerhost" >> /etc/hosts
For more information:
https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...
```
* `make shellcheck_fix` in web
* Manual corrections on autofix
* Update SHELLCHECK_FILES to Perl regex so it matches at start of file
GitOrigin-RevId: 815d53f319a3792efa22703beb75570de5977450
Previous attempt failed with `sh: gcr.io/overleaf-ops/texlive-full:2023.1: No such file or directory`.
✅ Now tested with `make prefetch_custom_texlive`
GitOrigin-RevId: 09a5e1d3c270bdb58c761c8be3c665155879290f
`xargs -d` doesn't work on Mac OS: `xargs: illegal option -- d`
There's a workaround using `tr`
See: https://stackoverflow.com/a/71409498/4823861
GitOrigin-RevId: 109c7e1e035b829122d96fd41824f18bdf81468a
* [web] wait for sending project invite notification, send email detached
Errors from sending the notification or email are still logged only.
Wait up-to ~one second for notification to be sent (API timeout is 1s).
* [server-pro] tests: wait for invite action to complete
GitOrigin-RevId: e6998e6134b5267c91b47785d616a46e9651b996
* [server-ce] upgrade mongo to 6.0 in e2e tests
* [server-ce] upgrade mongo to 6.0 for CE dev-env
GitOrigin-RevId: 6a76297d32177a8b5a067d325e74bdb01971af30
* [history-v1] add readOnly lookup for raw chunks
Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
* [history-v1] reduce min poolsize for readOnly pool to 0
Co-authored-by: Brian Gough <brian.gough@overleaf.com>
---------
Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
Co-authored-by: Brian Gough <brian.gough@overleaf.com>
GitOrigin-RevId: a711c4ee4f3ea3775bd090e620d1ef52689fa1f4
* Add `unicorn/prefer-node-protocol`
* Fix `unicorn/prefer-node-protocol` ESLint errors
* Run `npm run format:fix`
* Add sandboxed-module sourceTransformers in mocha setups
Fix `no such file or directory, open 'node:fs'` in `sandboxed-module`
* Remove `node:` in the SandboxedModule requires
* Fix new linting errors with `node:`
GitOrigin-RevId: 68f6e31e2191fcff4cb8058dd0a6914c14f59926
