Eric Mc Sween
88fe3e2942
Merge pull request #17910 from overleaf/em-comment-ids
...
Include id in history Comment instances
GitOrigin-RevId: 25b897e8e9e8d7b19dfe2d90d7f0cafeb5e6e97f
2024-04-17 08:04:41 +00:00
Antoine Clausse
616bd0df16
Merge pull request #17925 from overleaf/jpa-ac-20s-timeout-migration-logging-tweaks
...
[web] timeout 20s split-test teardown cleanups (remove override, remove tests, ...)
GitOrigin-RevId: 8d8c44539cf45d0f5142f84cf8372cecda3bf77a
2024-04-17 08:04:30 +00:00
Domagoj Kriskovic
238e63e08c
[document-updater] Avoid sending empty ops to project-history ( #17920 )
...
GitOrigin-RevId: a5156d99be373feb111bcc956d70c0f47047dd72
2024-04-17 08:04:22 +00:00
Domagoj Kriskovic
c4437c69bc
Send operations to project-history when accepting tracked changes ( #17599 )
...
* added getHistoryOpForAcceptedChange in RangesManager
* rename adjustHistoryUpdatesMetadata to be treated as public
* handle retain op in UpdateTranslator and updateCompressor
* send op to project-history in acceptChanges
* use promises.queueOps
* use ranges in getHistoryOpForAcceptedChange
* using rangesWithChangeRemoved
* acceptChanges acceptance test
* using change.op.hpos
* Revert "using change.op.hpos"
This reverts commit f53333b5099c840ab8fb8bb08df198ad6cfa2d84.
* use getHistoryOpForAcceptedChanges
* fix historyDocLength
* Revert "rename adjustHistoryUpdatesMetadata to be treated as public"
This reverts commit 2ba9443fd040a5c953828584285887c00dc40ea6.
* fix typescript issues
* sort changes before creating history updates
* fix tests
* sinon spy RangesManager.getHistoryUpdatesForAcceptedChanges
* added unit tests
* sort deletes before inserts
* use getDocLength function
* fix docLength calculation
* fix typo
* allow all retains
* fix lint error
* refactor RangesTests
* fix ts error
* fix history_doc_length calculation in RangesManager
* remove retain tracking check from UpdateCompressor
* use makeRanges() properly in tests
* refactor acceptance tests
GitOrigin-RevId: ab12ec53c5f52c20d44827c6037335e048f2edb0
2024-04-17 08:04:17 +00:00
Mathias Jakobsen
1116f9ea9a
[overleaf-editor-core+project-history] Clean up TrackedChangeList api ( #17740 )
...
* [overleaf-editor-core+project-history] Mark TC list backing array as private
* [overleaf-editor-core] Add invariant for overlapping comment ranges
* [overleaf-editor-core] Assert that ranges are non-empty
GitOrigin-RevId: e60a3712eba2326e0767a75a3ffc75333311c057
2024-04-17 08:04:13 +00:00
Jakob Ackermann
3df0fe82ce
Merge pull request #17926 from overleaf/jpa-batched-update-sorting
...
[web] batchedUpdate: use explicit sorting to find first record to update
GitOrigin-RevId: 6f57b92a4e5907f307618bd98642b4874018e9fa
2024-04-17 08:04:09 +00:00
Jakob Ackermann
ac2ea9f34d
Merge pull request #17865 from overleaf/jpa-open-in-overleaf-session-storage
...
[web] open-in-overleaf: cleanup redis and browser session storage
GitOrigin-RevId: af79bb49ff474545fc0d206d2a6f5a0ffa1416bc
2024-04-17 08:04:04 +00:00
Jakob Ackermann
e100d85940
Merge pull request #17422 from overleaf/jpa-avoid-resize-observer-loop
...
[web] avoid ResizeObserver loop when opening logs pane
GitOrigin-RevId: fb9c54e137785b34af01d031e182b66969711e41
2024-04-17 08:03:59 +00:00
CloudBuild
91b67bc0bd
auto update translation
...
GitOrigin-RevId: 3dcbbdf39ec5106a69f592d1e84fdba1a0ac7ec2
2024-04-16 08:05:03 +00:00
M Fahru
9f38436f10
Merge pull request #17736 from overleaf/ii-bs5-tooltip
...
[web] Create Btoostrap 5 tooltips
GitOrigin-RevId: 28c7c389bda74765482049750fc0ae8a5995968e
2024-04-16 08:04:42 +00:00
M Fahru
a0da44358f
Merge pull request #17892 from overleaf/mf-remove-newsletter-artifact
...
[web] Remove leftover code from the torn down onboarding flow split test
GitOrigin-RevId: 2d87cfe4d916b0d7a7a224c12f22c599e196d69f
2024-04-16 08:04:38 +00:00
David
a01d35e0fd
Merge pull request #17784 from overleaf/dp-pay-0-teardown
...
Tear down pay-0-trial split test
GitOrigin-RevId: dcda9f205120e1e1e17324961f6d3066554f9412
2024-04-16 08:04:30 +00:00
Eric Mc Sween
d0cd02d0ac
Merge pull request #17885 from overleaf/em-sp-missing-env
...
Add proper environment in CE/Server Pro preshutdown scripts
GitOrigin-RevId: 84ec76de67e91a4acc1f326a701ebb13a3f1322f
2024-04-16 08:04:26 +00:00
Andrew Rumble
6100954635
Merge pull request #17863 from overleaf/ar-set-socket-disconnect-timeout-to-match-wire-value
...
Set socket disconnect timeout to match wire value
GitOrigin-RevId: b3bfc460090b872500b55b0d5e2167b828ef31f4
2024-04-16 08:04:22 +00:00
Antoine Clausse
d35204033f
Merge pull request #17909 from overleaf/ac-tear-down-compile-timeout-tests-2
...
[web] Remove split-tests `compile-backend-class*` and `compile-timeout-20s*` (attempt 2)
GitOrigin-RevId: 5658f2977d3e7089eec5bbe7a33eee81c153e41d
2024-04-16 08:04:08 +00:00
ilkin-overleaf
bd570cc473
Merge pull request #17576 from overleaf/ii-bs5-alert
...
[web] Bootstrap 5 notifications
GitOrigin-RevId: 4409f1b76923d96f1b8297beb35a383d9aa7ec8c
2024-04-16 08:04:00 +00:00
CloudBuild
1a7f6514a4
auto update translation
...
GitOrigin-RevId: 029337f00be06e0c24ebbf9272b83a7f2fbdd235
2024-04-15 08:05:04 +00:00
Eric Mc Sween
1c0f5357aa
Merge pull request #17843 from overleaf/em-fix-422-resyncs
...
Change in history 422 error messages
GitOrigin-RevId: 414642c838703c9084058e1204192ec1cbb1e0a3
2024-04-15 08:04:51 +00:00
Eric Mc Sween
ab17eb150d
Merge pull request #17745 from overleaf/em-promisify-snapshot-manager
...
Promisify SnapshotManager
GitOrigin-RevId: 1fa7124da3aa3e0be5db372e68e286d63f496a97
2024-04-15 08:04:46 +00:00
Alexandre Bourdin
5f8db6ee23
Merge pull request #17799 from overleaf/ab-account-deletion-audit-log
...
[web] Add audit log when user account is deleted or recovered
GitOrigin-RevId: 3d5f99705fbd6192ccae430e040be4b7fcb3f740
2024-04-15 08:04:42 +00:00
Antoine Clausse
491bc2628d
Merge pull request #17899 from overleaf/revert-17700-ac-tear-down-compile-timeout-tests
...
Revert "[web] Remove split-tests `compile-backend-class*` and `compile-timeout-20s*`"
GitOrigin-RevId: d5070ced06adbd435e782a44b7ef767e395bd6a0
2024-04-15 08:04:37 +00:00
Antoine Clausse
2dd10c7fee
[web] Remove split-tests compile-backend-class* and compile-timeout-20s* ( #17700 )
...
* Remove split-tests of `compile-timeout-20s` and `compile-timeout-20s-existing-users`
* Remove `NEW_COMPILE_TIMEOUT_ENFORCED_CUTOFF` variables
* Revert timeout override `60` -> `20`
* Update settings.overrides.saas.js: `compileTimeout: 20`
* Remove `compile-backend-class-n2d`
* Remove `force_new_compile_timeout`
* Remove `showNewCompileTimeoutUI`
* Remove `compileTimeChanging`
* Simplify code by removing segmentation object
* Remove `CompileTimeoutChangingSoon`
* Remove `user.features.compileTimeout = '20 (with 10s prompt)'`
* Remove `CompileTimeWarning`
* Remove `TimeoutUpgradePrompt` (old)
* Remove `compile-backend-class`
* Remove unused translations
* Update tests
* Fix: Show `CompileTimeout` even if `!window.ExposedSettings.enableSubscriptions`
* Create script to migrate users to 20s compileTimeout
* migration script: exclude `compileTimeout: 20` from the match
* migration script: use `batchedUpdate`
* Remove `showFasterCompilesFeedbackUI` and `FasterCompilesFeedback`
Helped-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Remove `_getCompileBackendClassDetails`, simplify definition of `limits` object
* Remove `Settings.apis.clsi.defaultBackendClass`
* Remove unnecessary second scan of the whole user collection in dry mode
* Override `timeout` to 20 for users having `compileGroup === 'standard' && compileTimeout <= 60`
* Remove second `logCount`: re-run the script in dry-mode if you want to see that count
* Use secondary readPreference when counting users
* Fix script setup and exit 0
* Fix: Remove `user.` from query path!
* Add acceptance test on script migration_compile_timeout_60s_to_20s.js
GitOrigin-RevId: 3cb65130e6d7fbd9c54005f4c213066d0473e9d8
2024-04-15 08:04:24 +00:00
roo hutton
03fb015f8f
Merge pull request #17856 from overleaf/rh-deletion-email-update
...
[web] Use securityAlert template for user deletion email
GitOrigin-RevId: 60dfef18946710f5d5df17daca1a0bdc9800519b
2024-04-12 08:06:40 +00:00
roo hutton
754609f379
Merge pull request #17830 from overleaf/rh-reduce-staff-access-session
...
[web] Reduce size of staffAccess field in session
GitOrigin-RevId: 7745dc595e8096caef04fd140b47532f0775f165
2024-04-12 08:06:35 +00:00
Jessica Lawshe
f5ac5b0ed3
Merge pull request #17878 from overleaf/mj-keyboard-navigation-firefox-115
...
[web] Use getAttribute rather than accessing Element.role
GitOrigin-RevId: a6732180d945ccc4ac0300af07e52228e9f2c928
2024-04-12 08:06:27 +00:00
Jessica Lawshe
955c860b64
Merge pull request #17841 from overleaf/jel-lint-populate
...
[web] Add linting rule for mongoose `populate`
GitOrigin-RevId: 625b2b5f9db4e88ce0d629752f083b8be71c7766
2024-04-12 08:06:18 +00:00
Jessica Lawshe
11b3c60f60
Merge pull request #17739 from overleaf/jel-remove-group-beta-badge
...
[web] Remove beta badge from group SSO settings page
GitOrigin-RevId: b580515c58cfbe40a50a14c365d2541fc818d53e
2024-04-12 08:06:13 +00:00
Jessica Lawshe
0cfcdf5e4d
Merge pull request #17822 from overleaf/jel-dash-usersBestSubscription
...
[web] Limit data sent to dash for best subscription when group
GitOrigin-RevId: d52101bec69cbb7931e9702e085b4aeb65d9d603
2024-04-12 08:06:09 +00:00
Jessica Lawshe
751e079105
Merge pull request #17817 from overleaf/jel-group-subscription-page
...
[web] Only send necesssary group subscription data to frontened
GitOrigin-RevId: bf49245e573bb9a1ec4bafc85cc6d0b7fd5f3e6f
2024-04-12 08:06:04 +00:00
M Fahru
510bb062ee
Merge pull request #17845 from overleaf/mf-add-icon-error-login-home
...
[web][website-redesign] Add notification icon and make the notification text to be left-justified
GitOrigin-RevId: 8a678f05fbd3467be87198aca2a631ff31d1fb7d
2024-04-12 08:05:52 +00:00
Eric Mc Sween
d12a0b5f07
Merge pull request #17735 from overleaf/em-promisify-web-api-manager
...
Promisify WebApiManager
GitOrigin-RevId: 95addc9442845252aa51c353676486b2dbce0662
2024-04-12 08:05:39 +00:00
Eric Mc Sween
3b555ac9e6
Merge pull request #17731 from overleaf/em-promisify-error-recorder
...
Promisify ErrorRecorder
GitOrigin-RevId: 3736567272a09b4e3b9075118460392c1f66f0d7
2024-04-12 08:05:34 +00:00
Eric Mc Sween
f03e3fd51e
Merge pull request #17729 from overleaf/em-promisify-sync-manager
...
Promisify SyncManager
GitOrigin-RevId: 134770d812a493e39410debb370ed4a58ffff4bf
2024-04-12 08:05:29 +00:00
Jakob Ackermann
c9373c25f4
Merge pull request #17873 from overleaf/jpa-await-user-login
...
[web] await promisified user login in ProjectStructureTests
GitOrigin-RevId: 68df8931a5c7c3843367c6fd34a66278c212ff5b
2024-04-12 08:05:20 +00:00
Jakob Ackermann
ea0a99253c
Merge pull request #17864 from overleaf/jpa-fix-redirect
...
[web] fix navigation flow after try premium page when using skip button
GitOrigin-RevId: 1ae7ccdb14f7125919bc97746761a21c6896938f
2024-04-12 08:05:15 +00:00
Tim Down
a345eb42c2
Merge pull request #17712 from overleaf/td-bs5-feature-flag
...
Add feature flag check and per-page opt-in for Bootstrap 5
GitOrigin-RevId: 111474c19f0202efc4e701eef597c7653f8e8b61
2024-04-12 08:05:10 +00:00
Tim Down
d0344c482c
Merge pull request #17670 from overleaf/td-bs5-green-50
...
Update green-50 in Bootstrap 5 styles
GitOrigin-RevId: a2b29abed9e4f16ddb77e5784e842700966d3712
2024-04-12 08:05:05 +00:00
Jakob Ackermann
9351c03c3b
Merge pull request #17874 from overleaf/jpa-ol-project-id-in-env
...
[clsi] expose Overleaf project id to LaTeX compilation via env var
GitOrigin-RevId: cf8be6f8d83351a587d9ac7940f61a046a14035e
2024-04-12 08:04:56 +00:00
Jakob Ackermann
a6fb983afc
Merge pull request #17871 from overleaf/jpa-bind-v4-v6
...
[misc] align the host for binding and requesting in tests
GitOrigin-RevId: 916521c56928329ff2cbf2817f3a0a27aeaf8c3d
2024-04-12 08:04:51 +00:00
CloudBuild
d6b1577393
auto update translation
...
GitOrigin-RevId: f0d1233b2dedcfe71ca28a637c7685129260df52
2024-04-11 08:04:37 +00:00
M Fahru
71bd4ecb22
Merge pull request #17835 from overleaf/mf-fix-mono-font
...
[web][website-redesign] Fix all mono text in website redesign pages.
GitOrigin-RevId: b1b2698f621b8dc4e8c56126915ddbbe538d308e
2024-04-11 08:04:26 +00:00
David
ce5d190c4a
Merge pull request #17833 from overleaf/dp-add-secondary-prompt
...
Update primary email check form to match new designs
GitOrigin-RevId: b740255e3615bd7807845c533472aabb263d69ea
2024-04-11 08:04:20 +00:00
Andrew Rumble
b053e73e76
Merge pull request #17815 from overleaf/ar-allow-labels-to-be-added-in-label-list
...
Allow labels to be added from label list
GitOrigin-RevId: 61abbc74aff1901f4adb16575b02148f8dbf99e2
2024-04-11 08:03:43 +00:00
Antoine Clausse
8e0e2041a7
Move "reducing_compile_timeout" notice to the bottom of the box ( #17840 )
...
GitOrigin-RevId: 6dc28cb41af28947c4e43ab57d26518c0c0a3245
2024-04-11 08:03:29 +00:00
CloudBuild
038b460e24
auto update translation
...
GitOrigin-RevId: b895b490e84566d64e1186ceed4796a59ce09b78
2024-04-10 08:04:27 +00:00
roo hutton
bf7a18db8b
Merge pull request #17730 from overleaf/rh-acct-delete-email
...
[web] Send email notification on account deletion
GitOrigin-RevId: 03c0effba0ee3b829f5b4fe377fe67d05776ba3f
2024-04-10 08:04:12 +00:00
Domagoj Kriskovic
8bde496da4
Send operations to project-history when resolving/unresolving comments ( #17540 )
...
* Send operations to project-history when resolving/unresolving comments
* small fixes
* added doc_id in web unit test
* Revert "added doc_id in web unit test"
This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.
* fix mocked dependency in test
* wip: web unit tests
* document updater, reopen test
* document-updater tests
* format fix
* fix typo
* fix callsArgWith
* fix reopenThread calls in doc updater tests
* fix typos
* log error if chat api resolve failes
* log error when reopening thread
* sendStatus calls done() in tests
* using OError instead of logging
* removed timers
* preserve legacy endpoints
* update after merge
* Remove timer check in HttpControllerTest
* prettier
* added "legacy" in log
* remove metrics.timer
* fix promisify issues
* remove unused cb
GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
2024-04-10 08:04:08 +00:00
Domagoj Kriskovic
1557338775
[project-history] fix convertToDiffUpdates when track delete is moved by previous op ( #17681 )
...
* [project-history] fix convertToDiffUpdates
* fix test
* preserve source ranges for applyRetain
* use sourceRanges for applyDelete
* use cursor difference for offset
* move statement to closer to original
* handle deletion before tracked delete
* Revert "handle deletion before tracked delete"
This reverts commit 6f2570f22473bd64516c166b29a34639ec701230.
* using resultCursor and sourceCursor
* refactor, use scanCursor
* skip track delete properly
* prettier
* remove .sort() in applyRetain
* small test fixes
GitOrigin-RevId: 94755c219c90d6fedcdc64284d71137cf56d2442
2024-04-10 08:04:03 +00:00
CloudBuild
af037ddb43
auto update translation
...
GitOrigin-RevId: ec414f46c10ae1d8b0af22360184ece3e5c2433c
2024-04-09 08:04:49 +00:00
Eric Mc Sween
5d2aed3b1c
Merge pull request #17713 from overleaf/em-resync-include-ranges
...
Add ranges to resync doc update
GitOrigin-RevId: 6998b952028a154c21c8f476e0504496019aea9c
2024-04-09 08:04:44 +00:00
