github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
22438 commits 3 branches 7 tags 206 MiB
Commit graph

428 commits

Author SHA1 Message Date
Alf Eaton
c1c098e2f9 Allow files to be dragged from the file tree into the editor (#15028) 
GitOrigin-RevId: f926666c032d1398a0e3f72a298116a3c7a9cd75
 2024-05-09 08:04:46 +00:00
Alf Eaton
cb297e342a [visual] Improve handling of pasted lists (#14912) 
GitOrigin-RevId: 15e91ef6807433c5fb0a9bedbd5fea42ac35a5f0
 2024-05-09 08:04:42 +00:00
Alf Eaton
a2ff44d7d4 Merge pull request #18214 from overleaf/ae-visual-underline 
[visual] Set text-underline-offset for links

GitOrigin-RevId: c65a92cada0e219bdb72e10d8987dbd5da7cd629
 2024-05-09 08:04:38 +00:00
Jimmy Domagala-Tang
72b53fe8db Merge pull request #18173 from overleaf/jdt-container-utils 
[Web] Add container based hide utils to our util css

GitOrigin-RevId: 193abf1242ec4a816299fabf486754b3bcbae147
 2024-05-08 08:03:51 +00:00
Antoine Clausse
2f99e3ccf1 Add autoComplete="off" to React-controlled checkboxes (#18212) 
Fixes https://github.com/overleaf/internal/issues/18144

Browsers use a [bfcache](https://web.dev/articles/bfcache) (Back/forward cache) which restores form data on navigation. Unfortunately, it causes checkbox appearances not to respect our React states.

Setting `autoComplete="off"` on checkboxes mitigates this problem. (From https://stackoverflow.com/questions/299811/why-does-the-checkbox-stay-checked-when-reloading-the-page)

Another solution could be to set a `Cache-Control: no-store` header, but this might additionnal undesired consequences.

GitOrigin-RevId: 7d3cceb1c818ad70de7e806ea6d714ffc8bffb4a
 2024-05-06 08:04:39 +00:00
David
0c20c86878 Merge pull request #18178 from overleaf/dp-insert-figure-translations 
Add translations for insert figure dropdown

GitOrigin-RevId: 6ffbf0229f7ac222619271688517bc50339c10f6
 2024-05-06 08:04:16 +00:00
Alf Eaton
ab5495023a [visual] Add support for description list environments (#13460) 
GitOrigin-RevId: d1ddfeed4ba453afa348e57d75fdb3e12d29f5fc
 2024-05-03 08:04:53 +00:00
Antoine Clausse
6a6f155029 [web] Use React hooks to get split-test variants instead of getSplitTestVariant (getMeta) (#18133) 
* Fix split-tests loading in React component: use `useSplitTestContext` instead of `getSplitTestVariant`

* Replace use of `isSplitTestEnabled` by `useSplitTestContext`

* Add SplitTestProvider to roots, and fix tests

* Create `useFeatureFlag` hook

* Use `useFeatureFlag` where applicable

GitOrigin-RevId: 9ff7bb3975d50bc4d07d74d93c482d56dc96f615
 2024-05-01 08:04:55 +00:00
Alf Eaton
9d4340e24a Reapply "Avoid vertical border between editor switch and empty space (#18029)" (#18072) 
This reverts commit 9a071e1d02f27bbcaf1d61a9cca577cc6c889abc.

GitOrigin-RevId: 72380a15ccbc4e8d7fddcfdf0a9a48209152b8b9
 2024-04-24 08:04:22 +00:00
Alf Eaton
45ee8aca93 [visual] Handle Enter in an empty list item at the end of a nested list (#18034) 
GitOrigin-RevId: 4b3f24c7cf18837ba87859340991d9bb2532560a
 2024-04-24 08:04:17 +00:00
Jimmy Domagala-Tang
e1ec856650 Merge pull request #18066 from overleaf/ae-revert-toolbar 
Revert "Avoid vertical border between editor switch and empty space"

GitOrigin-RevId: eda4deba8eb384cddf2ea9c90edee080ceb6330c
 2024-04-23 08:05:45 +00:00
Alf Eaton
92d6966f69 Only display bulk actions for tracked changes when permitted (#18038) 
GitOrigin-RevId: a2f4df9c26866aab3eea62c92ce6e1a211e08294
 2024-04-23 08:05:31 +00:00
Alf Eaton
315b511666 Avoid vertical border between editor switch and empty space (#18029) 
GitOrigin-RevId: 516098061a4d329daf55bb42bcf47a5a412595c1
 2024-04-23 08:05:26 +00:00
Jessica Lawshe
f5ac5b0ed3 Merge pull request #17878 from overleaf/mj-keyboard-navigation-firefox-115 
[web] Use getAttribute rather than accessing Element.role

GitOrigin-RevId: a6732180d945ccc4ac0300af07e52228e9f2c928
 2024-04-12 08:06:27 +00:00
Domagoj Kriskovic
8bde496da4 Send operations to project-history when resolving/unresolving comments (#17540) 
* Send operations to project-history when resolving/unresolving comments

* small fixes

* added doc_id in web unit test

* Revert "added doc_id in web unit test"

This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.

* fix mocked dependency in test

* wip: web unit tests

* document updater, reopen test

* document-updater tests

* format fix

* fix typo

* fix callsArgWith

* fix reopenThread calls in doc updater tests

* fix typos

* log error if chat api resolve failes

* log error when reopening thread

* sendStatus calls done() in tests

* using OError instead of logging

* removed timers

* preserve legacy endpoints

* update after merge

* Remove timer check in HttpControllerTest

* prettier

* added "legacy" in log

* remove metrics.timer

* fix promisify issues

* remove unused cb

GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
 2024-04-10 08:04:08 +00:00
Andrew Rumble
9fda813e20 Merge pull request #17786 from overleaf/ar-select-caption-in-inserted-figures 
Select caption text when new figure inserted

GitOrigin-RevId: 443594ff03c5a5cd316623e60b231a6af4390d3c
 2024-04-09 08:04:36 +00:00
Miguel Serrano
d7d63e0f51 Merge pull request #17693 from overleaf/msm-hide-grammarly-sp 
Prevent grammarly ad from rendering in CE/SP

GitOrigin-RevId: 3ef191f282f2ce682236710df9ca32a087271c4c
 2024-04-09 08:03:59 +00:00
Antoine Clausse
92a58c8f3b [web] Paywall CTA split-test (#17555) 
* Fix `{splitTest.requiredCohortSize && (...)}` can display `0`

* Get `paywall-cta` assignment in ProjectController.js

* CTA change: "Get Dropbox Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286026

* CTA change: "Get GitHub Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get Git integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286283

* CTA change: "Add more collaborators"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763884855

* CTA change: "Get track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764030761

* Update wording and position: "Already subscribed? Try refreshing the page."

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764366969

* Casing update: "Upgrade to track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764209961

* CTA changes: "Get Mendeley integration" + "Get Zotero integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547424

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547269

* CTA change: "Get full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762005

* Casing update: "full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762280

* CTA change: "Get more compile time" in timeout-upgrade-prompt-new.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get more compile time" in compile-timeout-warning.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762726

* CTA change: "Get advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969087

* Update casing and wording: "advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969412

* CTA change: "Get Symbol Palette"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765128906

* Update title: "Subscribe to find the symbols you need faster"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765289664

* Revert use of `satisfies`: it doesn't work with our version of prettier (https://github.com/prettier/prettier/issues/13516)

* CTA change: "Get more compile time" in compile-timeout-changing-soon.tsx

⚠️ not in miro

* Rename `paywallCtaAssignment`, remove useless export and comment

Addressing Fahru's review

* Add alternative texts in `/registration/try-premium` page

* CTA change: "Get more compile time" in timeout-upgrade-prompt.jsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get GitHub Sync" in import-project-from-github-modal-content.tsx

Not in Miro, but related to: https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get more compile time" in compile-time-warning.tsx

Not in Miro, but related to others

* Fix compile-time-warning style (spacings, overflows out of window)

* `npm run format:fix`

GitOrigin-RevId: 0d8d1808b5901c2761d35494c49713d26721bcfd
 2024-04-03 08:04:16 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier 
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
 2024-03-26 09:04:05 +00:00
Alf Eaton
aeb20340c8 Reduce review panel calls to Trans (#17385) 
GitOrigin-RevId: fdc7b3c2cd2506c810a785462fcd120a3a05da78
 2024-03-07 16:30:36 +00:00
Alf Eaton
5df35093ea Remove hidden comment button from editor toolbar (#17386) 
GitOrigin-RevId: 61b3725a7b2112c6e5abca0349b1be910e97266a
 2024-03-07 16:30:28 +00:00
Alf Eaton
749660e168 Refactor review panel context (#17383) 
GitOrigin-RevId: 23e7ff8632172ebd0bc544a2297d1d4179010832
 2024-03-07 16:30:25 +00:00
Alf Eaton
bd2c3a61f3 Merge pull request #17381 from overleaf/ae-firefox-change-callout 
Hide comment/change callout line in Firefox

GitOrigin-RevId: fe0803c71beb1073cf6715ff91a68ed39f578af2
 2024-03-07 16:30:22 +00:00
Alf Eaton
55da43a6ce Ensure that ol_extensions_writefull Sentry tag is defined (#17366) 
GitOrigin-RevId: c1261f780e439852b9a59d8d8a2022c30ff354e1
 2024-03-07 16:30:15 +00:00
Miguel Serrano
ac48d81987 Merge pull request #17373 from overleaf/jpa-figure-modal-options 
[web] hide figure modal import options as configured server side

GitOrigin-RevId: f8907a33d413fcac238b00328eaba14d64f2f31b
 2024-03-06 17:27:32 +00:00
roo hutton
790fc5513b Merge pull request #17392 from overleaf/rh-friendly-readonly 
Don't show 'add comment' button if isRestrictedTokenMember

GitOrigin-RevId: da236a4f2fbe0e66a7e5999bd70f7145fd60df20
 2024-03-06 09:03:13 +00:00
Mathias Jakobsen
60d38285ea Merge pull request #17393 from overleaf/mj-tikzcd 
[cm6] Don't decorate tikzcd environments

GitOrigin-RevId: bf499432d67cefe12576fc135f4564b97a1b2c13
 2024-03-05 09:03:31 +00:00
Alf Eaton
3e11ee6e5a Ensure that the editor state is preserved when switching views (#17238) 
GitOrigin-RevId: 946b82cb633afbea13a72e30a9ce432aa1a8196d
 2024-02-23 09:03:06 +00:00
Alf Eaton
3f29aa2195 Ensure that each editor theme is only created once (#17095) 
GitOrigin-RevId: 3551e02fab44fae7fcab5cb12886d45969e3990f
 2024-02-16 09:05:03 +00:00
Alf Eaton
00d043cc72 Ensure that the selection layer updates when the review panel is toggled (#17021) 
GitOrigin-RevId: e5418ae642e0c46f12c633fc71323bb86018c42a
 2024-02-16 09:04:31 +00:00
Alf Eaton
7b3ffb9fae Standardise types for ranges (#16927) 
GitOrigin-RevId: 28dd0eb67e1684e6bd0e452d15315ce1f9e3481a
 2024-02-09 09:06:51 +00:00
Tim Down
3a88a60e23 Merge pull request #16700 from overleaf/td-scroll-comment-input-into-view 
Scroll comment textarea into view after autofocus

GitOrigin-RevId: c8542f40d25772a14e7511702c0e47b7001be275
 2024-02-05 09:04:21 +00:00
Alf Eaton
cac1ab1259 Add tags to Sentry error reports (#16465) 
GitOrigin-RevId: 1d014e8cc9f87d249a285b247c35f12465ecb93a
 2024-02-02 09:03:23 +00:00
Alf Eaton
614d1d05cc Maintain the current scroll position when applying remote changes (#16777) 
GitOrigin-RevId: 5d2d0fd5aaefcc6b1e7f4dbd2ce29287cf8dbbdb
 2024-02-02 09:03:20 +00:00
Alf Eaton
373c4736e8 Wrap the useCodeMirrorMeasurement state setter in a timeout (#16818) 
GitOrigin-RevId: 9f7c12f679ab3947724cc52c63fcee198c73ae87
 2024-02-02 09:03:11 +00:00
Alf Eaton
0cde5be165 Merge pull request #14709 from overleaf/ae-context-typescript 
Convert React context providers to TypeScript [don't squash!]

GitOrigin-RevId: d92a91798286978410956ab791d73c17c5086d86
 2024-01-29 09:03:04 +00:00
Alf Eaton
5871978272 Use renderMessage (#16628) 
GitOrigin-RevId: 9f627a31d0f8ffce841f04f5a9bfa09f6abcd0a3
 2024-01-24 09:04:08 +00:00
Alf Eaton
5e3deba9fe Dispatch 'UNSTABLE_editor:extensions' event on 'editor:extension-loaded' (#16611) 
GitOrigin-RevId: a1d93330a7633c6d5870e2c368ab45a4a586db35
 2024-01-24 09:03:28 +00:00
ilkin-overleaf
fa314fe5b0 Merge pull request #16509 from overleaf/ii-rp-update-entry-positions 
[web] Review panel entry positions and long user names

GitOrigin-RevId: 3a596bd90bab2c87b2efae5eb812ffc5e5a1580f
 2024-01-19 09:05:28 +00:00
Alf Eaton
612c7c28b0 Merge pull request #16511 from overleaf/ae-upgrade-uppy 
Upgrade Uppy to v3

GitOrigin-RevId: ca3e366a20ac651a98aafe12bf319b1968ac6ec1
 2024-01-19 09:05:05 +00:00
Alf Eaton
4bca3de8d2 Add estimated height to some block widget decorations (#16485) 
GitOrigin-RevId: f59da18228e038b1295ccc0128a33acd2de4f9f9
 2024-01-19 09:05:01 +00:00
Alf Eaton
22b5828b3d Move Writefull toolbar loading/initialisation into a React component (#16546) 
GitOrigin-RevId: 1cb6efa7cab2babb33800fef9469fca3addbdaf5
 2024-01-19 09:04:52 +00:00
Mathias Jakobsen
7c3c3047fe Merge pull request #16588 from overleaf/mj-usepackage-fix 
[web] Copy single backslash in column width modal

GitOrigin-RevId: ee3e3eadac067dac1d955adc04709e8ab3121a59
 2024-01-19 09:04:37 +00:00
Mathias Jakobsen
8d7fbf5a47 Merge pull request #16522 from overleaf/mj-table-generator-cypress-tests 
[web] Add cypress tests for table generator

GitOrigin-RevId: c77454763cfc83e4869e75ba247369e6255a0553
 2024-01-19 09:04:33 +00:00
Mathias Jakobsen
80a6424343 Merge pull request #16048 from overleaf/mj-table-column-width 
[visual] Allow setting column widths in table generator

GitOrigin-RevId: 3bd4bb05dd3b29d0bd62fbc41da45eda282fecf4
 2024-01-19 09:04:28 +00:00
David
29bfdae57d Merge pull request #16523 from overleaf/dp-editable-file-extensions-2 
Make cfg, ltx, Rnw and inc files editable in the editor

GitOrigin-RevId: 1999c29ea451aa3f362ffa09f6f4d5889beaf404
 2024-01-17 09:03:53 +00:00
Thomas
e1c58c2aaf Merge pull request #15710 from overleaf/tm-no-constant-binary-expressions 
Add no-constant-binary-expression, fix existing expressions that have no effect

GitOrigin-RevId: 6691e87181331ecbb5dabfda0be89839a0a4884b
 2024-01-16 09:04:09 +00:00
Domagoj Kriskovic
21a4e0b6b3 [visual] Skip moving cursor inside argument if there is no decoration (#16365) 
* [visual] Skip moving cursor inside argument if there is no decoration

* Refactor skipAtomicRanges function

* rangeSet outside the loop, continue rather than return

* use rangeSet.between

* prettier

GitOrigin-RevId: 85ef817e09ea7eb854cec43cb7866f61b4bfbc21
 2024-01-16 09:03:59 +00:00
ilkin-overleaf
f67e19f6d2 Merge pull request #16453 from overleaf/ii-review-panel-dismiss-bulk-actions 
[web] Fix bulk actions in review panel

GitOrigin-RevId: c78c99b0a3b005a0a4490ce393eb5d540f23ebc2
 2024-01-15 09:04:31 +00:00
Alf Eaton
4a7a24b44d Update the CodeMirror language when the current file is renamed (#16342) 
GitOrigin-RevId: 8b51df0d1acfeeb8b0323cebf6de78572c8cb95c
 2024-01-15 09:04:27 +00:00