github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
22877 commits 3 branches 7 tags 206 MiB
Commit graph

22877 commits

This branch
This branch
All branches
Author SHA1 Message Date
Eric Mc Sween
e4cc2a0816 Fix history diffs when deleting over many tracked deletes (#19193) 
* Fix history diffs when deleting over many tracked deletes

As we are looping through tracked deletes, the offset between the result
positions and the source positions must be kept constant. Otherwise, the
tracked deletes are translated as we delete text and move the source
cursor.

GitOrigin-RevId: b2417a75219aaa16bf5c61e0ebcb0586cae6aef2
 2024-07-01 08:04:25 +00:00
Thomas
6a65644778 Merge pull request #19185 from overleaf/tm-validate-can-invite-editor-2 
Update inviteToProject to check if editor slots are available

GitOrigin-RevId: bb67ae6329130573ba43e9524a3084bf5551ebde
 2024-07-01 08:04:21 +00:00
Thomas
a047388b08 Add serverside checks for changing the user access level after link sharing changes (#19168) 
* Add getEditInviteCount to count only edit collaborators

* Add getInvitedEditCollaboratorCount to count joined editors

* Add canAddXEditCollaborators to determine if owner can add more editors

* Update setCollaboratorInfo to check if editor slots are available

GitOrigin-RevId: a88707f102dfbde39322f5a7bbc79d47b6e810d5
 2024-07-01 08:04:16 +00:00
Thomas
2ce71b0b4d Async/awaitify LimitationsManager for link sharing changes (#19110) 
* Move functions to top level

* Async/awaitify LimitationsManager methods

* Promisify LimitationsManagerTests

GitOrigin-RevId: ece7d2ea5160aa95924840044e2f225e1f2848e7
 2024-07-01 08:04:12 +00:00
ilkin-overleaf
687b56f18e Merge pull request #19141 from overleaf/ii-add-email-account-settings 
[web] Reset recaptcha every time

GitOrigin-RevId: 6db3571ad6dad3611c748a2d92dce47002a16a77
 2024-07-01 08:04:07 +00:00
roo hutton
268291b52d Merge pull request #19181 from overleaf/rh-share-modal-collab-view 
[web] Styling tweaks in new share modal

GitOrigin-RevId: 2b69612aff518ae0cb4f08851adc73971e5ac983
 2024-06-28 08:05:13 +00:00
roo hutton
853c1153e1 Merge pull request #18891 from overleaf/rh-share-modal-when-over-limit 
[web]: Show share modal when over collaborator limit

GitOrigin-RevId: 6f5594310f21e481d5837ff8d7f098668ecd2957
 2024-06-28 08:05:09 +00:00
Eric Mc Sween
67dbf743e1 Merge pull request #19192 from overleaf/em-project-history-avoid-crash 
Prevent project-history crashes when generating a diff

GitOrigin-RevId: 513fb846f0884a68d4550783497ae436e1cba00f
 2024-06-28 08:05:05 +00:00
Jimmy Domagala-Tang
d7863bec37 Merge pull request #19108 from overleaf/jdt-ai-rm-alpha-reqs 
Remove Alpha bypass for AI Error Correction

GitOrigin-RevId: d6b93bc2071dbeeb3d67d48197e61abf4d920944
 2024-06-28 08:04:57 +00:00
roo hutton
d16fee1afe Merge pull request #18910 from overleaf/rh-editor-warning-over-limit 
[web] Show warning modal to editors opening a project over collaborator limit

GitOrigin-RevId: d9868c021d0aaf04bffd8afbd8c1c96fbf548755
 2024-06-28 08:04:53 +00:00
Domagoj Kriskovic
cbda6b0bcc [web] Rename "Revert file" to "Restore this version" (#19069) 
* rename revert file to restore file

* rename file/function name

* rename split test

* fix formatting

* do not rename split test name

* fix typo

GitOrigin-RevId: e4e2eae622a270b3b6483348f441ddd424623f81
 2024-06-28 08:04:49 +00:00
Domagoj Kriskovic
c3c97d9fb9 [web] return file type in revertFile (#18995) 
* [web] return file type in revertFile

* fix revertFile unit test

* fix formatting

GitOrigin-RevId: e4ac0500ff6c72c7f7fa23a5f61b09ed31a28da0
 2024-06-28 08:04:45 +00:00
Miguel Serrano
b7b40e6057 Merge pull request #19178 from overleaf/msm-frog-test-reliability 
[CE] make JPG rendering test more robust

GitOrigin-RevId: f0f6b0119ed59e7f3fa8af70d69915a4d9ccda3f
 2024-06-28 08:04:41 +00:00
Jakob Ackermann
9075c82b88 Merge pull request #19170 from overleaf/jpa-server-ce-re-run-before 
[server-ce] make tests more robust

GitOrigin-RevId: f070b8bbbf87842a69d88ca56cecf5dd0f3a286c
 2024-06-28 08:04:33 +00:00
Antoine Clausse
ebec84540f Add waitForDb in scripts/resync_subscriptions.js (#19154) 
GitOrigin-RevId: 608bce2654d2b6dbeb662ad0da8bb5c5ce3d68f3
 2024-06-28 08:04:29 +00:00
Antoine Clausse
01188589f8 Add some JSDoc types to @overleaf/logger (#19153) 
* Add some JSDoc types to `@overleaf/logger`

* Update `logger.error` calls

* Fixup `logger.err` JSDoc

* Update `logger.err` calls

* Fix `args` type

* Remove "Error message" description

* Replace `arguments` by actual arguments of the method

* Fix: "ESLint: Unnecessary '.apply()'.(no-useless-call)"

* Add JSDoc params to `debug` `info` `warn`

* Remove extra `args` param in JSDoc so developers aren't invited to use it

Not sure if this is the best thing to do because it creates a warning in the IDE: "Parameter args is not described in JSDoc"

* Add comment about serialization of `err` `req` `res`

* Allow strings as first param in `debug` `info` `warn`

* Fix syntax for optional parameters in JSDoc

* Add 2 signatures, to avoid "string, string" params

* Fix `@signature` names copy-pastes

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Revert the double `@param attributes`. It doesn't work

---------

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 086dee8bbf30d577c5e1f844a9df5e518c46aca7
 2024-06-28 08:04:25 +00:00
Antoine Clausse
1dbbe5af9d [web] Promisify TemplatesController (#18849) 
* Promisify TemplatesController

* Update TemplatesControllerTests

* Fix `templateVersionId` in `getV1Template` (!!)

GitOrigin-RevId: bdaa59ed3cff81d919a8b3d19d5be555a2790f55
 2024-06-28 08:04:17 +00:00
Jakob Ackermann
0ecb266e32 Merge pull request #19165 from overleaf/jpa-test-history-download 
[server-ce] add tests for downloading a project zip from the history

GitOrigin-RevId: 95b0047e7d4cce7f6708d116bf2065d634a76ae4
 2024-06-27 08:05:01 +00:00
Jessica Lawshe
0ed123aebd Merge pull request #19085 from overleaf/jel-light-touch-table-updates 
[web] Update background color CSS for light touch redesign

GitOrigin-RevId: 574f813a9964a272742507817732c1b45bbdc2fe
 2024-06-27 08:04:56 +00:00
Jessica Lawshe
07d1f26731 Merge pull request #19084 from overleaf/jel-light-touch-rename-css 
[web] Rename CSS variables for light touch redesign

GitOrigin-RevId: c84eb75a45af8270895795ceffef944696037881
 2024-06-27 08:04:52 +00:00
Jessica Lawshe
90d7925a02 Merge pull request #18961 from overleaf/jel-new-plans-spacing 
[web] Update main container spacing for new plans page

GitOrigin-RevId: b6c8fa852ba2025c78f6daa22146854fc6a13789
 2024-06-27 08:04:48 +00:00
Jessica Lawshe
fbc9a557c7 Merge pull request #18959 from overleaf/jel-faq-tabs 
[web] New tab and accordion more reusable

GitOrigin-RevId: ed8340bc4b6312c4270edf1edf53c74a067aaccf
 2024-06-27 08:04:44 +00:00
Jimmy Domagala-Tang
c04fea0fd3 Merge pull request #19162 from overleaf/jpa-flaky-admin-test 
[web] refresh system message cache after creating/deleting message

GitOrigin-RevId: f7155e94a8bf08b527e7ae69d9d6a41e54c01282
 2024-06-27 08:04:39 +00:00
Jimmy Domagala-Tang
2e1dcee22b Merge pull request #19128 from overleaf/jdt-latex-2024-release 
updating to remove alpha only and release 2024 latex

GitOrigin-RevId: 4333b5d4331213206d273a6cbb0cb790ad2778f6
 2024-06-27 08:04:35 +00:00
Mathias Jakobsen
abaf07a8bb Merge pull request #19158 from overleaf/mj-commands-autocomplete-optional-args 
[web] Avoid double counting optional arguments for autocomplete

GitOrigin-RevId: 7abdc73657791b945bd5a7a9e29f5cd127c7882b
 2024-06-27 08:04:31 +00:00
David
1844603a2d Merge pull request #19124 from overleaf/dp-light-hover-bug 
Refactor pdf toolbar button styles to fix bug with hovering over active logs button

GitOrigin-RevId: f8034c9daade32cda7c4f08ccd292c86ef6b8454
 2024-06-27 08:04:27 +00:00
David
74b1ebac02 Merge pull request #19064 from overleaf/dp-create-project-dropdown-ui 
Add spacing above create-new-project-dropdown and make thinner

GitOrigin-RevId: a1f3a27512e04ec6e4383493d5ceaf39e5ad9eee
 2024-06-27 08:04:22 +00:00
Jakob Ackermann
0b6a8dc093 Merge pull request #19160 from overleaf/jpa-jammy-1-0-4 
[server-ce] bump base image to jammy-1.0.4

GitOrigin-RevId: 79cc27e4c628e50fb226a32278be1768001f343b
 2024-06-26 11:12:47 +00:00
Thomas
94be372b24 Add new interstitial 'Join project' consent page for existing link sharing editors when opening a project (#19066) 
* Add helpers for checking and removing user readwrite token membership

* Add sharing-updates page and handlers

* Redirect read write token members to sharing-updates on project load

GitOrigin-RevId: d552a2cd74a9843c6103923b03f137131a48877a
 2024-06-26 11:12:42 +00:00
Thomas
260fdf1307 Add read write token join interstitial variation for link sharing changes (#19060) 
* Add read write join interstitial variation for link sharing changes

GitOrigin-RevId: 41661f43f4ab0f18f6ada5bec0b6af2407f65f07
 2024-06-26 11:12:37 +00:00
Thomas
70bf7b2aab Merge pull request #19109 from overleaf/tm-project-joined-add-project-id 
Add projectId to project-joined event

GitOrigin-RevId: 222e0acc8764592344e384d1a6a5a2327d4161f5
 2024-06-26 11:12:33 +00:00
Mathias Jakobsen
d21da7d084 Merge pull request #19157 from overleaf/mj-separate-unknowncommands 
[lezer] Separate unknown commands for definition fragments

GitOrigin-RevId: 21ce8d03e68f4af13c3937b4b5fd6f7ed0e50995
 2024-06-26 11:11:53 +00:00
Mathias Jakobsen
3b5af94404 Merge pull request #19119 from overleaf/mj-lezer-definition-unknown-commands 
[lezer] Parse unknown commands in definitions

GitOrigin-RevId: 586bf9e0de8e1d9e7903dd2fad8638cb2624ed9e
 2024-06-26 11:11:48 +00:00
Alf Eaton
26d7524c93 Updates to the AI error assistant (#19107) 
GitOrigin-RevId: 7ffc1e32d331fa8bab1ea25919e706bf8b59800f
 2024-06-26 11:11:44 +00:00
Alf Eaton
dfaed70297 Replace symbol palette tabs with a custom tablist (#19034) 
GitOrigin-RevId: 69d8a8dd8980e287b484b915b1f92e57af5324cb
 2024-06-26 11:11:35 +00:00
Antoine Clausse
de959fb7b9 Fix institution metrics sendAll cron (#19127) 
* Don't send status 200 in the beginning: we may throw later

This was causing `Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client`
https://cloudlogging.app.goo.gl/Bchegw2iCYLxhPNk8

* Continue when failing to send one email, but log the error

* Revert "Don't send status 200...", log error instead

This reverts commit 3e13559704f822e330a18a68567f46491649f222.

* Fix `logger.error` params

* Fixup: good syntax for `logger.error`

* Remove useless `OError` import

* Update services/web/modules/metrics/app/src/MetricsEmailController.js

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Update services/web/modules/metrics/app/src/MetricsEmailController.js

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Update services/web/modules/metrics/app/src/MetricsEmailController.js

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Update services/web/scripts/recurly/collect_paypal_past_due_invoice.js

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

---------

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: c68bc677326729fc6c39b7c2f027e35ebb776bd2
 2024-06-26 08:05:11 +00:00
Antoine Clausse
fc34b41b5b [web] Promisify two-factor-authentication (#19004) 
* Fixup typos

* Promisify `getPendingUser`

* Promisify `getPendingUserWithExpectations`

* Add promises to `AccessTokenEncryptor`

* Promisify `TwoFactorAuthenticationHandler`

* Promisify/Expressify `TwoFactorAuthenticationController`

* Centralise `unprocessableEntity` error handling into a function

* Fixup: entralise `unprocessableEntity` error handling into a function

Avoid "responding to the query twice"

* Remove unnecessary try/catch

* Fixup: Add `async` to AccessTokenEncryptor promises

* Add tests on `AccessTokenEncryptor.promises`

* Revert "Fixup: entralise `unprocessableEntity` error handling into a function"

This reverts commit 23bd9d73260733062908b98961846733c61171e9.

* Revert "Centralise `unprocessableEntity` error handling into a function"

This reverts commit 197ca3da02412d5224d411b29df1d7b9e5327d01.

GitOrigin-RevId: 1a2864d28e87fd5e48cd3723a3da8047b79a1596
 2024-06-26 08:05:06 +00:00
CloudBuild
375ff968c5 auto update translation 
GitOrigin-RevId: c597b7ebda7a250220e7227211d7f3cd64816b90
 2024-06-26 08:05:02 +00:00
Jimmy Domagala-Tang
50b19c7793 Merge pull request #18850 from overleaf/ac-promisify-resync-subscriptions 
Promisify resync_subscriptions

GitOrigin-RevId: c23a99683a22104815525b179d4e46d3ad568f94
 2024-06-26 08:04:57 +00:00
Jimmy Domagala-Tang
86e2abc90b Merge pull request #19106 from overleaf/jdt-center-labels 
vertically align text within spans

GitOrigin-RevId: 820313b179751a1a7c538712cf9dfd6b9ce0ff3d
 2024-06-26 08:04:52 +00:00
Jimmy Domagala-Tang
b0344ec550 Merge pull request #19132 from overleaf/jdt-ai-policy-migration 
feat: add migration for adding new policy to all existing groupPolicies
GitOrigin-RevId: ea3188b6059c2e96afd0058a191d18b26d68adbd
 2024-06-26 08:04:48 +00:00
roo hutton
e0c879bd9a Merge pull request #19120 from overleaf/rh-link-share-styles 
[web] Fix share modal styling regressions

GitOrigin-RevId: efeffa3d6451ed47137106e0ad296c518a5c0608
 2024-06-26 08:04:43 +00:00
roo hutton
bf90932f40 Merge pull request #18936 from overleaf/rh-viewer-no-comment 
[web] Remove access to commenting/chat for collaborators with Viewer permission

GitOrigin-RevId: 03957cb8c04866318a4b94bdb72843e7d7a5a003
 2024-06-26 08:04:38 +00:00
Jakob Ackermann
ce9b531892 Merge pull request #19098 from overleaf/jpa-graceful-shutdown-tests 
[server-ce] add test for graceful shutdown

GitOrigin-RevId: 5e72e0073169009d2e3ece5a79cbd62051f6ad5b
 2024-06-25 11:12:43 +00:00
Tim Down
956aad7e43 Merge pull request #18764 from overleaf/td-bs5-dashboard-feature-flag 
Create new feature flag for BS5 project dashboard page

GitOrigin-RevId: a523bd7df94c411805ac2f5234135bc7a56d25bb
 2024-06-25 11:12:35 +00:00
Tim Down
8897e439ae Merge pull request #18928 from overleaf/td-bs5-nav-admin-missing-href 
Bootstrap 5: add missing href to nav admin link

GitOrigin-RevId: 5339fa2ef465a6319d87cba6201e682dea1a98a6
 2024-06-25 11:12:31 +00:00
David
62c432b997 Merge pull request #19101 from overleaf/dp-presentation-additional-keys 
Add PageUp/PageDown/Backspace options for presentation page navigation

GitOrigin-RevId: 59b8c3b22ff205c8fe1009c120358c913db3cbe5
 2024-06-25 11:12:27 +00:00
David
b2e3002992 Merge pull request #19103 from overleaf/dp-presentation-events 
Add event for entering presentation mode

GitOrigin-RevId: 6d9006005264f69d1a37baa363b338caf0d29c6c
 2024-06-25 11:12:23 +00:00
Mathias Jakobsen
ddfdafd54c Merge pull request #19050 from overleaf/mj-lezer-parse-comments-in-unknown-commands 
[lezer] Introduce hasMoreArguments token for argument parsing

GitOrigin-RevId: a5898a2be01c19a39de15c784f184fe61140799a
 2024-06-25 11:12:18 +00:00
Mathias Jakobsen
46a160f127 Merge pull request #19072 from overleaf/mj-known-commands-reuse 
[web] Parse known commands in math mode

GitOrigin-RevId: e7937fc46320f13c716d1612eca36aa67c8fb967
 2024-06-25 11:12:14 +00:00