Commit graph

61 commits

Author SHA1 Message Date
Eric Mc Sween
e365a6cbaf Merge pull request #8346 from overleaf/em-halt-on-error-logs-2
Stop on first error: logs pane prompts

GitOrigin-RevId: a246a7e5d302ad3104e15f7fd78344992b4e011b
2022-06-10 08:03:55 +00:00
Eric Mc Sween
cb657d1f1c Merge pull request #8297 from overleaf/em-halt-on-error-logs
Stop on first error info box in logs pane

GitOrigin-RevId: cf11f65d582d98bea93c6506393940d9a6144c0d
2022-06-08 08:03:12 +00:00
Timothée Alby
5731463d32 Merge pull request #7956 from overleaf/ii-refactor-toolitp-usage
Tooltip usage refactoring

GitOrigin-RevId: f4b2d4d57722172141a081dd60e4394ff7fff332
2022-05-19 08:04:07 +00:00
Alf Eaton
9f969d07e0 Delete unused PDF-related code (#6334)
* Remove new logs UI code
* Remove unused preview components
* Move metrics file
* Remove Angular PDF controllers
* Move the service worker util functions
* Remove the ide/pdfng folder
* Remove vendored pdf.js
* Remove showNewPdfPreview
* Use mockCompile
* Remove split test code

GitOrigin-RevId: 723b7440c62cda51f6ad8bb9c691900882166d21
2022-03-16 09:03:04 +00:00
Alf Eaton
f065a7a909 Improve the Icon component (#6245)
GitOrigin-RevId: fbb23b32c47edbe5a22badc627318accbd09e82a
2022-01-20 09:03:58 +00:00
Alf Eaton
50df230846 [web] Upgrade Prettier to match version in monorepo root (#6231)
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
2022-01-11 09:03:23 +00:00
Miguel Serrano
7de1e6f979 Update log error ordering and wording on tips (#5873)
* Show bibtex errors with compile errors
* Update wording on error log tips

GitOrigin-RevId: 0e25a05418b241526958016f1b525334d33ad741
2021-11-26 09:03:07 +00:00
Jakob Ackermann
a6f05109a3 Merge pull request #5352 from overleaf/jpa-no-var
[misc] fix eslint violations for `no-var`

GitOrigin-RevId: c52e82f3a8a993b8662cc5aa56e7b95ca3c55832
2021-10-27 08:03:00 +00:00
Alf Eaton
89dfcaf528 Finish migrating to PdfLogEntry component (#5483)
GitOrigin-RevId: 93f1da35dbc80b317964133e0437373dd0af7933
2021-10-18 08:04:12 +00:00
Alf Eaton
e26d47cb41 Add hybrid toolbar to migrated PDF preview (#5414)
GitOrigin-RevId: 6266028091229c819aee3c8d4bd3bff2e2417125
2021-10-13 08:03:01 +00:00
Miguel Serrano
8766c45362 Add log limit and info notice to PDF Preview log view (#5390)
GitOrigin-RevId: 14764d109dbe13d7e4fb4f79f098c74d4b57d59d
2021-10-11 08:03:13 +00:00
June Kelly
94773e898e Merge pull request #5280 from overleaf/hb-max-log-entries-display
Display only a max of 100 log entries

GitOrigin-RevId: 7a9a9d6824eda72dd6c19024d1e0ff6d25bebf49
2021-10-07 08:03:37 +00:00
Alf Eaton
c5c727f552 Move useResizeObserver into features/preview (#5188)
GitOrigin-RevId: c12dfc30b07e4a214990b7e80ce11364edb6137a
2021-09-24 08:04:28 +00:00
Hugh O'Brien
f7900b474b Merge pull request #4799 from overleaf/hb-eslint-rules
Re-enable some eslint rules

GitOrigin-RevId: 16153adb839bb61784bb40fbc8e43da281fe090d
2021-09-15 08:03:43 +00:00
Paulo Jorge Reis
51c6d90c17 Handle PDF rendering errors in the new logs UI (#4280)
* Handle PDF rendering errors in the new logs UI

* Remove new logs UI specific code from the PDFController

* Only change view with errors and validation issues in the new logs UI

GitOrigin-RevId: 0761ac224db39fdacbb61692c1aa35c3da82a76b
2021-07-07 02:05:48 +00:00
Paulo Jorge Reis
0ee18df3e4 Revert "Revert "Improve copy for single errors or warnings""
This reverts commit f01e0726b9a0119bc7f8bda3a98c2c0df5026e51.

GitOrigin-RevId: fc44d227e50c46260fbedb8c80fdca24092f81eb
2021-07-07 02:05:40 +00:00
Paulo Jorge Reis
db8173011e Revert "Revert "Handle PDF failure error case""
This reverts commit 946838e51feaff28025c4a4d733e0dd89a29e890.

GitOrigin-RevId: 63f130c8cfecfb512ec97bda62c6ea1cad2c8fed
2021-07-07 02:05:36 +00:00
Alf Eaton
55ca4783fb Remove React memo from preview pane
GitOrigin-RevId: 27c953ff7727a7898587d9e43e18c6cc9295c23b
2021-06-29 02:06:00 +00:00
Paulo Jorge Reis
4e384e0c3b Revert "Handle PDF failure error case"
This reverts commit 902a97f6f454f09345ba4017b50623fd46e57110.

GitOrigin-RevId: 946838e51feaff28025c4a4d733e0dd89a29e890
2021-06-29 02:05:56 +00:00
Paulo Jorge Reis
f4822e4407 Revert "Improve copy for single errors or warnings"
This reverts commit 1fdd270d4148abd0385e4258bb634cf769cce8c5.

GitOrigin-RevId: f01e0726b9a0119bc7f8bda3a98c2c0df5026e51
2021-06-29 02:05:52 +00:00
Paulo Reis
7b7c6eb1b4 Improve copy for single errors or warnings
GitOrigin-RevId: 1fdd270d4148abd0385e4258bb634cf769cce8c5
2021-06-25 02:06:20 +00:00
Paulo Reis
07f44b99f4 Handle PDF failure error case
GitOrigin-RevId: 902a97f6f454f09345ba4017b50623fd46e57110
2021-06-25 02:06:16 +00:00
Alf Eaton
7c97f8ab6e Switch to new JSX runtime (#4225)
* Use new JSX runtime and update Babel Node target
* Update .eslintrc
* Remove React imports

GitOrigin-RevId: 559de0267f8f2934c56a860ea8701bb522aa861a
2021-06-24 02:06:59 +00:00
Alf Eaton
eebeffc1c5 Merge pull request #4188 from overleaf/ae-memo
Improve React performance by memoizing components and values

GitOrigin-RevId: 805278b8b7ac04c3dc4b078fa53cc0e3770d261b
2021-06-22 02:07:08 +00:00
Alf Eaton
1760d93fc4 Upgrade React to v17 (#4201)
* Upgrade react and react-dom
* Fix test
* Ensure that the "history:toggle" event is broadcast when switching in or out of history view
* Add ControlledDropdown
* Remove DropdownButton stories

GitOrigin-RevId: 3810f6986bb60e59af31f960f431c31be16554f5
2021-06-19 02:08:29 +00:00
Alf Eaton
8b40e760ca Merge pull request #4133 from overleaf/ae-project-too-large
Display project-too-large error

GitOrigin-RevId: 9078b4f24d3380a4554f9fd91fe0254524763830
2021-06-11 02:06:51 +00:00
Jakob Ackermann
b4d80de408 Merge pull request #4111 from overleaf/jpa-fix-re-compile-react
[frontend] fix re-compile button in react sending an event as options

GitOrigin-RevId: 69dcebc3c74c89189f18715d5adf0e6329eb1ef6
2021-06-01 02:05:30 +00:00
Alf Eaton
dbdc56f2c0 Merge pull request #4056 from overleaf/pr-fix-compile-ui-tooltip-bug
Avoid trying to render a non-existent tooltip

GitOrigin-RevId: 46591823a3479d0570051e317659de88c7b98159
2021-05-26 02:05:20 +00:00
Timothée Alby
70952906c9 Merge pull request #4043 from overleaf/as-clean-up-exposed-settings
Remove `exposedSettings` from `ApplicationContext`

GitOrigin-RevId: 02acd3a7cf36d184560ff6df13acff515da908fa
2021-05-20 02:05:05 +00:00
Alf Eaton
8c3578e74b Merge pull request #4041 from overleaf/ae-use-ref-with-autofocus
Rename hooks files and move to shared folder

GitOrigin-RevId: 9659247b5e767197c3e11acc9a3922ecaab49162
2021-05-19 02:05:50 +00:00
Alf Eaton
01c8a8a04d Merge pull request #4025 from overleaf/ae-timeout-upgrade
Only show upgrade message on timeout if not already premium

GitOrigin-RevId: 1378b0a98c6b511d63f2ce1192d3fdca16e8db26
2021-05-15 02:10:09 +00:00
Miguel Serrano
bb88af80cf Merge pull request #3947 from overleaf/msm-reenable-eslint-rules
Reenable `eslint` rules

GitOrigin-RevId: a0aa5f941ba1bc49ff758b5256f91d696f442c6d
2021-05-14 02:09:45 +00:00
Alf Eaton
e832c9ed70 Add StartFreeTrialButton
GitOrigin-RevId: dd9ab4bb12e8b9071b2a869e2d452945b49d9cd7
2021-05-08 02:09:50 +00:00
Miguel Serrano
f9871103bf Merge pull request #3949 from overleaf/msm-reenable-eslint-const-rule
Reenable eslint `prefer-const` rule

GitOrigin-RevId: 4f3825be8b8dff381095209085a36eaab76260d5
2021-05-06 02:09:14 +00:00
Alf Eaton
1be43911b4 Merge pull request #3942 from overleaf/prettier-trailing-comma
Set Prettier's "trailingComma" setting to "es5"

GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00
Paulo Jorge Reis
98e631a9c7 New logs UI out of beta + fixes (#3868)
* Update new logs pane: remove beta icons, add specific surveys

* Remove unneeded reset of log entries

* Remove unneeded reset of the autocompile linting error flag

* Lower compile event sampling rate ahead of prod release

* Never send logs UI subvariant when user is getting the existing UI

GitOrigin-RevId: ab726761ba372c6806e56fc0cf841099cc30df50
2021-04-13 02:05:54 +00:00
Paulo Jorge Reis
3f0e897e32 Logs UI variant without popup (#3794)
* Add logs UI without pop-up variant

* Implement frontend for logs UI without pop-up

* Add logs UI variants to admin panel and front user info

* Fix existing UI subvariant window global

GitOrigin-RevId: 075db56032354d782e489b5235925f55b1a67e0b
2021-03-24 03:04:41 +00:00
Paulo Jorge Reis
15f49994bd New compile UI autocompile (#3762)
* Animate recompile button when autocompile is waiting

* Add code-check failed notice to the new compile UI

GitOrigin-RevId: 83b62f41438e8e5b94bd893c222bec37745c0f57
2021-03-19 03:04:50 +00:00
Paulo Jorge Reis
326c63e2af Compile UI improvements for beta release (#3644)
* Increase errors cap in the new compile UI to 99

* Improve messaging for stopped compiles

GitOrigin-RevId: d34973e9ef71562d64cfc8018634753e47e4dee8
2021-02-18 03:05:29 +00:00
Miguel Serrano
77c35e3715 Merge pull request #3633 from overleaf/msm-react-context-validation
Added PropTypes validation to react context

GitOrigin-RevId: 86950bdacf366035d1cfd923c7e7674d543b380f
2021-02-11 03:04:33 +00:00
Eric Mc Sween
78b7c8de9b Merge pull request #3558 from overleaf/pr-logs-ui-beta-icon
Logs UI beta icons

GitOrigin-RevId: 2d22dea3625ed24b87a1ae9e48cbbe77ad8a1827
2021-01-22 03:04:55 +00:00
Paulo Jorge Reis
11e58b5844 Add timeout upgrade prompt to the new compile UI (#3528)
* Uncouple account-upgrade and exposted-settings from Angular

* Mock socket shim with the correct methods

* Extract timeout upgrade prompt to a component

GitOrigin-RevId: ee8058b38bf5e20924a21f40d32c5bb0ee06c555
2021-01-15 03:05:48 +00:00
Jakob Ackermann
9d47b05486 Merge pull request #3549 from overleaf/jpa-disable-downloads-before-clearing-cache
[frontend] PdfController: disable download buttons before clearing cache

GitOrigin-RevId: e685411c12c9962732a5ab88fcb7466b0f6df7ce
2021-01-13 03:04:11 +00:00
Timothée Alby
0040c31b1f Merge pull request #3474 from overleaf/hb-show-log-type
Show log type in react log entry UI

GitOrigin-RevId: 4e600b7d763b357d86f1b99d56aca01f62dc30bf
2021-01-06 03:07:50 +00:00
Alf Eaton
2ff1cf43d6 Merge pull request #3470 from overleaf/eslint
Upgrade and configure ESLint

GitOrigin-RevId: ad5aeaf85e72c847a125ff3a9db99a12855e38aa
2020-12-16 03:08:28 +00:00
Paulo Jorge Reis
4e74fb2694 Log pane improvements (#3418)
* Ordering of log entries in the new errors UI

* Don't show the expand-collapse widget when not needed; smaller font size in the raw log output

* Expose log actions in the log pane.

* Use "This project" instead of "Your project" in the new errors UI

* Better handling of long log messages; left-ellipsize the file/line number button

* Make log location more button-like; add tooltip when needed.

* Add a PDF expand button to the toolbar.

* Add a stop compilation button to the new compile UI

* Use aria-label for button accessible text; improve handling of long filenames in the log location button

* Set max-height correctly for the logs pane dropdown

* Avoid changing raw logs sizing when expanded and collapsed

* Add comment on the solution for right-to-left text and ellipsis

* Improve logs pane actions

GitOrigin-RevId: 4098d77a9ee6d333644906876b9ff27035b79319
2020-12-03 03:04:28 +00:00
Jessica Lawshe
d7f32179e4 Update download dropdown style (#3399)
* Update translation

* Move dropdown header to top of list

* Do not wrap header in download dropdown

GitOrigin-RevId: 326428272592fc54f9915d5946877e59a60f967e
2020-11-27 03:04:44 +00:00
Paulo Jorge Reis
081f4212a8 Add error and validation issues (#3400)
* Remove references to the duplicatePaths validation

* Make the log entries more generic, to support validation and CLSI errors

* Add validation issues to the new logs UI

* Add CLSI errors to the new logs UI

* Update tests; accessibility fixes

* Disable PDF viewing when compile fails; address PR feedback.

* Add accessible description for error and validation failed compiles

GitOrigin-RevId: 8b0597af8857712d47c20e4915470e8e745bb315
2020-11-27 03:04:38 +00:00
Paulo Jorge Reis
01cc057f6b Add raw logs to new errors UI (#3378)
* Add raw logs to new compile UI

* Address feedback

* Update test/frontend/features/preview/components/preview-logs-pane.test.js

Co-authored-by: John Lees-Miller <jdleesmiller@gmail.com>

Co-authored-by: John Lees-Miller <jdleesmiller@gmail.com>
GitOrigin-RevId: af9c653e13d93434467b122f4c388493e786212c
2020-11-17 03:04:16 +00:00
Paulo Jorge Reis
619ec15309 Add first error popup (#3369)
* Add first error popup

* Address PR feedback

GitOrigin-RevId: e924b3e6096584de6f363aae70a62328cd3de83d
2020-11-17 03:04:11 +00:00