github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
22304 commits 3 branches 7 tags 206 MiB
Commit graph

725 commits

Author SHA1 Message Date
Antoine Clausse
b2ef7a935f [web] Use localized number formatting for currencies (#17622) 
* Add a unit test on `SubscriptionFormatters.formatPrice`

* Add JSDoc to `formatPrice`

Also: Name the functions before exporting:
This fixes my IDE (WebStorm) navigation

* Make `'USD'` the default param instead of reassigning

* Create `formatCurrency` function

* Use `formatCurrency` in SubscriptionFormatters

* Use an `isNoCentsCurrency` logic for `CLP` `JPY` `KRW` `VND`

And remove custom `CLP` logic and locale

* Add `locale` param to `formatPrice`

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Update scripts/plan-prices/plans.js to generate numbers instead of localized amounts

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Remove generation of `plans.json`

As /services/web/frontend/js/main/plans.js was removed in https://github.com/overleaf/internal/pull/12593

* Sort currencies in alphabetical order in scripts/plan-prices/plans.js

* Generate `groups.json` and `localizedPlanPricing.json`

```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```

* Use `formatCurrency` in price-summary.tsx

* Use `formatCurrency` in Subscription Pug files

* Fix unit tests SubscriptionHelperTests.js

* Remove unused `currencySymbol`

* Change to `formatCurrency` in other React components

* Add `CurrencyCode` JSDoc types

* Duplicate `formatCurrency` into services/web/app/src/util

* Wrap tests in a top-level describe block

* Use `narrowSymbol`

* Fix tests with `narrowSymbol` expects

* Revert deletion of old `formatPrice` in SubscriptionFormatters.js

* Rename `formatCurrency` -> `formatCurrencyLocalized`

* Revert deletion of `CurrencySymbol`

* Add split-test in SubscriptionController.js

* Add split-test in SubscriptionViewModelBuilder.js

* Add split-test in plans

* Add split-test in subscription-dashboard-context.tsx

* Add split-test in 4 more components

* Update tests

* Show currency and payment methods in interstitial page

* Fix `–` being printed. Use `–` instead

* Fix test with NOK

* Storybook: Fix missing `SplitTestProvider`

* Storybook: Revert "Remove unused `currencySymbol`"

This reverts commit e55387d4753f97bbf8e39e0fdc3ad17312122aaa.

* Replace `getSplitTestVariant` by `useSplitTestContext`

* Use parameterize currencyFormat in `generateInitialLocalizedGroupPrice`

* Fixup import paths of `formatCurrencyLocalized`

* Replace `% 1 === 0` by `Number.isInteger`

* Add comment explaining that any combinations of languages/currencies could happen

* Fixup after rebase: import `useSplitTestContext`

* Revert "Remove SplitTestProvider from subscription root"

This reverts commit be9f378fda715b86589ab0759737581c72321d87.

* Revert "Remove split test provider from some tests"

This reverts commit 985522932b550cfd38fa6a4f4c3d2ebaee6ff7df.

GitOrigin-RevId: 59a83cbbe0f7cc7e45f189c654e23fcf9bfa37af
 2024-04-19 08:03:54 +00:00
Thomas
52e6ceef67 Merge pull request #17898 from overleaf/tm-remove-twitter-login 
Remove twitter login code and uninstall passport-twitter

GitOrigin-RevId: 928c877ef2a42d5881652cad7f9d563c7766fd36
 2024-04-18 08:04:16 +00:00
Antoine Clausse
491bc2628d Merge pull request #17899 from overleaf/revert-17700-ac-tear-down-compile-timeout-tests 
Revert "[web] Remove split-tests `compile-backend-class*` and `compile-timeout-20s*`"

GitOrigin-RevId: d5070ced06adbd435e782a44b7ef767e395bd6a0
 2024-04-15 08:04:37 +00:00
Antoine Clausse
2dd10c7fee [web] Remove split-tests compile-backend-class* and compile-timeout-20s* (#17700) 
* Remove split-tests of `compile-timeout-20s` and `compile-timeout-20s-existing-users`

* Remove `NEW_COMPILE_TIMEOUT_ENFORCED_CUTOFF` variables

* Revert timeout override `60` -> `20`

* Update settings.overrides.saas.js: `compileTimeout: 20`

* Remove `compile-backend-class-n2d`

* Remove `force_new_compile_timeout`

* Remove `showNewCompileTimeoutUI`

* Remove `compileTimeChanging`

* Simplify code by removing segmentation object

* Remove `CompileTimeoutChangingSoon`

* Remove `user.features.compileTimeout = '20 (with 10s prompt)'`

* Remove `CompileTimeWarning`

* Remove `TimeoutUpgradePrompt` (old)

* Remove `compile-backend-class`

* Remove unused translations

* Update tests

* Fix: Show `CompileTimeout` even if `!window.ExposedSettings.enableSubscriptions`

* Create script to migrate users to 20s compileTimeout

* migration script: exclude `compileTimeout: 20` from the match

* migration script: use `batchedUpdate`

* Remove `showFasterCompilesFeedbackUI` and `FasterCompilesFeedback`

Helped-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Remove `_getCompileBackendClassDetails`, simplify definition of `limits` object

* Remove `Settings.apis.clsi.defaultBackendClass`

* Remove unnecessary second scan of the whole user collection in dry mode

* Override `timeout` to 20 for users having `compileGroup === 'standard' && compileTimeout <= 60`

* Remove second `logCount`: re-run the script in dry-mode if you want to see that count

* Use secondary readPreference when counting users

* Fix script setup and exit 0

* Fix: Remove `user.` from query path!

* Add acceptance test on script migration_compile_timeout_60s_to_20s.js

GitOrigin-RevId: 3cb65130e6d7fbd9c54005f4c213066d0473e9d8
 2024-04-15 08:04:24 +00:00
Andrew Rumble
b053e73e76 Merge pull request #17815 from overleaf/ar-allow-labels-to-be-added-in-label-list 
Allow labels to be added from label list

GitOrigin-RevId: 61abbc74aff1901f4adb16575b02148f8dbf99e2
 2024-04-11 08:03:43 +00:00
Andrew Rumble
9fda813e20 Merge pull request #17786 from overleaf/ar-select-caption-in-inserted-figures 
Select caption text when new figure inserted

GitOrigin-RevId: 443594ff03c5a5cd316623e60b231a6af4390d3c
 2024-04-09 08:04:36 +00:00
Andrew Rumble
1c1b48edab Merge pull request #17707 from overleaf/AR-modal-close-consistency-fixes 
Modal "Close" button consistency fixes

GitOrigin-RevId: 55e5178c9e820fffd220f0010906546f0baa2065
 2024-04-05 08:04:13 +00:00
Jessica Lawshe
5fcc7f63cd Merge pull request #17728 from overleaf/jel-fix-member-view-update 
[web] Fix user view on frontend after unlinking group SSO member

GitOrigin-RevId: 375b798d23ed622453465661ced604c7068c1986
 2024-04-05 08:04:00 +00:00
Jessica Lawshe
d8f870555c Merge pull request #17683 from overleaf/jel-unlink 
[web] Unlink group SSO member

GitOrigin-RevId: ac3498fc72538fd0eef639c783dc7675ac593b94
 2024-04-04 08:04:45 +00:00
Jessica Lawshe
b4b4fe7a1c Merge pull request #17648 from overleaf/jel-member-list-alerts 
[web] Rename managed user alert variables

GitOrigin-RevId: 6a6a446d7fda4ad0b4b63ef380d9710c2b545295
 2024-03-28 09:04:41 +00:00
Alf Eaton
1ad2be35b5 Merge pull request #17626 from overleaf/ae-eslint-window-localstorage 
Add ESLint rule that prevents direct use of window.localStorage

GitOrigin-RevId: 30abcd96ef31690a482c5368ff2a6d11024f5126
 2024-03-27 09:04:15 +00:00
Alf Eaton
b2fbc39930 Improve tests for layout components (#17518) 
GitOrigin-RevId: 1d08224a5282482dcf153a2ebcff69a08be2eb58
 2024-03-26 09:04:24 +00:00
Alf Eaton
d319fe72a9 Add Suspense to test element container (#17520) 
GitOrigin-RevId: 0d7702289870a1074cdf4bd907b55fa6f32b8457
 2024-03-26 09:04:20 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier 
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
 2024-03-26 09:04:05 +00:00
Jimmy Domagala-Tang
5701a1cccd Merge pull request #17369 from overleaf/jdt-rm-old-wf-prj-list-ad 
removing old writefull ad from project list and removing uneeded spli…

GitOrigin-RevId: 84722949c4972ba0b7c8e0bf6d2884608e26a613
 2024-03-13 09:03:26 +00:00
Jessica Lawshe
d65bba566c Merge pull request #17315 from overleaf/ab-accounts-settings-sso-status 
[web] Show Group SSO linking status on the account settings page

GitOrigin-RevId: ae45e1bd7a90a672c5fb023e7f3e603a00e364e5
 2024-03-12 09:03:43 +00:00
Miguel Serrano
cf227e2d08 Merge pull request #17450 from overleaf/msm-fix-sp-welcome-page 
[web] Make wiki and template links configurable in welcome page

GitOrigin-RevId: fab1b8a11f518c5907a5bfa9365ff8e8a130b7c6
 2024-03-07 16:30:42 +00:00
Jakob Ackermann
1a6ac06bed Merge pull request #17432 from overleaf/jpa-wf-switch-split-test 
[web] fully adopt writefull-oauth-promotion split-test

GitOrigin-RevId: b37491bc18e7cc65ec2fc8e8ced140df9f8a6048
 2024-03-06 17:27:52 +00:00
Miguel Serrano
ac48d81987 Merge pull request #17373 from overleaf/jpa-figure-modal-options 
[web] hide figure modal import options as configured server side

GitOrigin-RevId: f8907a33d413fcac238b00328eaba14d64f2f31b
 2024-03-06 17:27:32 +00:00
M Fahru
dc9b0aa8a5 Merge pull request #17230 from overleaf/mf-tear-down-inr-2 
[web] Tear down INR split test

GitOrigin-RevId: 90c6ab4666d9281e804b279d697d6c14ffd682d2
 2024-02-22 09:05:02 +00:00
ilkin-overleaf
6e95e230e8 Merge pull request #17192 from overleaf/ii-dictionary-modal 
[web] Remove dictionary word only if request is successful

GitOrigin-RevId: 43ffd0dac3ca9729213cf7901f39094c54806412
 2024-02-21 09:03:33 +00:00
Jessica Lawshe
f8094bbdb6 Merge pull request #17060 from overleaf/jel-password-linked-group-sso 
[web] Prevent updating password for managed users linked to group SSO

GitOrigin-RevId: f40bba47575cfac1b1e42d3138112c0db4f7865c
 2024-02-20 09:06:06 +00:00
Jessica Lawshe
d5639794c2 Merge pull request #17166 from overleaf/ab-fix-group-settings-label 
[web] Cleanup managed users env var and fix group settings label

GitOrigin-RevId: 817ed86a6c94c03adb41e8c10115d6404180142e
 2024-02-20 09:05:54 +00:00
Tim Down
bbb5804c39 Merge pull request #16815 from overleaf/td-uuid-frontend-upgrade 
Upgrade uuid in web front end

GitOrigin-RevId: 1928848fdf879c270effca12cd390a223007ea79
 2024-02-13 09:03:45 +00:00
Jessica Lawshe
03aaee84a3 Merge pull request #16945 from overleaf/ab-fix-sso-managed-users-enrollment 
[web] Fix managed users enrollment clearing out SSO linking status

GitOrigin-RevId: b2083b48df1782c426794f16e2cdd767b217256c
 2024-02-09 09:06:03 +00:00
Jakob Ackermann
63520c7076 Merge pull request #16859 from overleaf/jpa-sharelatex-cleanup 
[misc] ShareLaTeX cleanup - high impact

GitOrigin-RevId: 6dcce9b0f15e30f7afcf6d69c3df36a369f38120
 2024-02-09 09:04:11 +00:00
ilkin-overleaf
2f803292b4 Merge pull request #16857 from overleaf/ii-share-modal-click 
[web] Clickable share modal buttons

GitOrigin-RevId: db6bef9b63e98007741d88b291a282d6ea4a68c5
 2024-02-06 09:03:40 +00:00
Alf Eaton
6dc7ced2df Upgrade react-dnd (#16753) 
GitOrigin-RevId: 5a62bed823b716a6e0d6d3aa57ee187d161f3346
 2024-02-06 09:03:31 +00:00
Jakob Ackermann
621301618f Merge pull request #16893 from overleaf/jpa-download-pdf-dashboard-for-all 
[web] enable button for downloading PDFs from dashboard for all users

GitOrigin-RevId: bd46675bc75a7772824081e3e5e3043f282594a1
 2024-02-06 09:03:16 +00:00
Alexandre Bourdin
2765991fec Merge pull request #16802 from overleaf/ab-show-certificate-status 
[web] Show group SSO certificate status in config

GitOrigin-RevId: e0ffe3fad99ef70a752bdd2ca7be1d7d9bcba73c
 2024-02-05 09:03:49 +00:00
Alf Eaton
7f9d105d8c Ensure FileTreeProvider stubbed props don't change in Cypress tests (#16758) 
GitOrigin-RevId: 01c7fefdef8b28af0b52007209785b478e5d8600
 2024-01-30 16:49:27 +00:00
Jessica Lawshe
71ca6f05b7 Merge pull request #16737 from overleaf/jel-sso-file 
[web] Get SSO import data from File rather than FileReader

GitOrigin-RevId: 89de9c614024ab6a310a6226f59c5aa8c82c64e4
 2024-01-30 09:04:15 +00:00
Alf Eaton
bb0da73a36 [ide-react] Preserve scope value update watchers on watcher add (#16729) 
GitOrigin-RevId: 1168577364fef6e13a58d7d96afdf4ba685fc342
 2024-01-29 09:03:20 +00:00
Alf Eaton
0cde5be165 Merge pull request #14709 from overleaf/ae-context-typescript 
Convert React context providers to TypeScript [don't squash!]

GitOrigin-RevId: d92a91798286978410956ab791d73c17c5086d86
 2024-01-29 09:03:04 +00:00
ilkin-overleaf
a44a6a22dc Merge pull request #16662 from overleaf/ii-share-modal-click-2 
[web] Share modal select contact

GitOrigin-RevId: e43575cd97ad8e4bca249967bdf0cfc587213cc4
 2024-01-26 09:03:42 +00:00
Jessica Lawshe
2d3b7c5846 Merge pull request #16620 from overleaf/jel-sso-modal-notifications 
[web] SSO form notifications

GitOrigin-RevId: 3b9ced2430434adb3a4fa093ad04c56648e95c43
 2024-01-24 09:04:24 +00:00
Alf Eaton
612c7c28b0 Merge pull request #16511 from overleaf/ae-upgrade-uppy 
Upgrade Uppy to v3

GitOrigin-RevId: ca3e366a20ac651a98aafe12bf319b1968ac6ec1
 2024-01-19 09:05:05 +00:00
Mathias Jakobsen
8d7fbf5a47 Merge pull request #16522 from overleaf/mj-table-generator-cypress-tests 
[web] Add cypress tests for table generator

GitOrigin-RevId: c77454763cfc83e4869e75ba247369e6255a0553
 2024-01-19 09:04:33 +00:00
Mathias Jakobsen
80a6424343 Merge pull request #16048 from overleaf/mj-table-column-width 
[visual] Allow setting column widths in table generator

GitOrigin-RevId: 3bd4bb05dd3b29d0bd62fbc41da45eda282fecf4
 2024-01-19 09:04:28 +00:00
David
29bfdae57d Merge pull request #16523 from overleaf/dp-editable-file-extensions-2 
Make cfg, ltx, Rnw and inc files editable in the editor

GitOrigin-RevId: 1999c29ea451aa3f362ffa09f6f4d5889beaf404
 2024-01-17 09:03:53 +00:00
David
888a0f9c72 Merge pull request #16520 from overleaf/dp-revert-file-extension-work 
Revert "Merge pull request #16495 from overleaf/dp-editable-file-extensions"

GitOrigin-RevId: deb3dd882869031fb0489ffbfb32b6f0772be87b
 2024-01-16 09:04:38 +00:00
David
8971357dce Merge pull request #16495 from overleaf/dp-editable-file-extensions 
Mark cfg, rnw, ltx and inc files as text so that they are editable

GitOrigin-RevId: 486365486f46beebbb13cad3e0cc45711e1809e4
 2024-01-16 09:04:25 +00:00
Alf Eaton
84ebb1c8f2 Merge pull request #16378 from overleaf/ae-upgrade-codemirror-3 
Upgrade `@codemirror` dependencies

GitOrigin-RevId: 242b1dbcf2878869957f40a5522dabcbcc181b5b
 2024-01-08 09:05:02 +00:00
Mathias Jakobsen
d7a4061486 Merge pull request #16397 from overleaf/mj-logparser-missed-error 
[web] Stop wrapping potential errors into previous log lines

GitOrigin-RevId: 892fc19e2e7886afa3dc011315879fa992f94877
 2024-01-08 09:04:35 +00:00
Mathias Jakobsen
45274d9dff Merge pull request #16380 from overleaf/mj-select-keyboard 
[web] Allow keyboard interactions with custom select component

GitOrigin-RevId: 81adea8e456bd6ce2483dfa17a352c24c36e5768
 2024-01-08 09:04:30 +00:00
Rebeka Dekany
34debffd20 Merge pull request #16358 from overleaf/rd-tear-down-welcome-page 
[web] Tear down welcome-page-redesign split test

GitOrigin-RevId: 769aeae75eac6ac0b5880dca4ec1d36fbc39cea2
 2024-01-05 09:03:45 +00:00
Jimmy Domagala-Tang
5fc2535842 Merge pull request #16325 from overleaf/jdt-writefull-split-test-overrides 
users with writefull already enabled dont care about split tests

GitOrigin-RevId: aa986cc42fb9aecf8004b55e5e233c319040748f
 2023-12-21 09:03:13 +00:00
Jimmy Domagala-Tang
948d7638dc Merge pull request #16310 from overleaf/jdt-remove-writefull-promo-delay 
Remove one day delay on Writefull project list advert

GitOrigin-RevId: 43c07ed58d1eddb33655ccfbe2284b764fa766ff
 2023-12-21 09:03:05 +00:00
Mathias Jakobsen
1a6f3fc256 Merge pull request #16253 from overleaf/mj-human-readable-logs-fixes 
[web] Fix incorrect error log parsing and imprecise package recommendations

GitOrigin-RevId: a0b9c6c51ebf680bb77be88167ab6d35eaa8fa70
 2023-12-19 09:04:07 +00:00
Alf Eaton
c2b553e915 [ide-react] Improve file tree and outline components in the editor sidebar (#16225) 
* Upgrade react-resizable-panels
* Add FileTreeOpenProvider
* Add OutlineProvider and OutlineContainer
* Convert Outline tests to Cypress

GitOrigin-RevId: afd9ae8190edf37642e36a4ffb331f1182c8982d
 2023-12-18 09:03:53 +00:00