github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-10-17 21:05:04 -04:00
Code Issues Projects Releases Packages Wiki Activity
23473 commits 3 branches 7 tags 201 MiB
Commit graph

72 commits

Author SHA1 Message Date
Alf Eaton
c6633632d6 Move CodeMirror contexts into a separate file (#20643) 
GitOrigin-RevId: 8425454a75ff8160a03fda1be5bda2242b41f6cd
 2024-09-30 08:04:48 +00:00
Alf Eaton
2304536844 Add review panel context providers and components (#19490) 
* Tidy up review panel components

* Add ReviewPanel providers

* [web] new design for review panel track change (#19544)

* [web] new design for review panel track change

* fixed mini view

* mini icon style change

* fix icon size

* format date

* useRangesUserContext hook

* remove useRangesUserContext hook

* using full class names

* fix action icons hover

* change wording for tooltips

* added ReviewPanelChangeUser component

* Update header in new review panel

* Extract ReviewPanelTrackChangesMenuButton as a separate component

* Remove wrapper div

* Replace h2 with div for review panel label

* Rename ReviewPanelTools to ReviewPanelHeader

* Rename trackChangesExpanded -> trackChangesMenuExpanded

* Dont break memoisation of ReviewPanelTrackChangesMenuButton

* Fix the width of the track changes arrow icon

* Update how prop types are declared

* Remove new empty state from old review panel

* Add empty state to new review panel

* Add project members and owner to ChangesUsers context (#19624)

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

* Redesign comment entry in review panel (#19678)

* Redesign comment entry in review panel

* ReviewPanelCommentOptions component

* remove unused prop

* Tidying

* Add conditional import

* Optional changeManager

* Add more split test compatibility

* More split test compatibility

* Fixes

* Improve overview scrolling

* Fix overview scrolling

* Fix & simplify track changes toggle

* Fix overview scrolling

* Fix current file container

* ExpandableContent component for messages in review panel (#19738)

* ExpandableContent component for messages in review panel

* remove isExpanded dependancy

* Delete comment option for new review panel (#19772)

* Delete comment option for new review panel

* dont show thread warning if there are no replies

* fix hasReplies issue

* Implement initial collapsing overview files

* Fix positioning of overview panel

* Small styling changes

* Add count of unresolved comments and tracked chanegs

* More style adjustments

* Move review-panel-overview styles into css file

* Remove unused var

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
Co-authored-by: David Powell <david.powell@overleaf.com>
Co-authored-by: David <33458145+davidmcpowell@users.noreply.github.com>
GitOrigin-RevId: e67463443d541f88445a86eed5e2b6ec6040f9c7
 2024-08-13 08:04:20 +00:00
David
4b708613b6 Merge pull request #19381 from overleaf/dp--review-panel-css-clean-up 
Clean up some old review panel css

GitOrigin-RevId: eb88bfbfa6679787d06f6c2a7d28b9fafb846195
 2024-07-15 09:32:50 +00:00
David
0c7a32b4f2 Merge pull request #19346 from overleaf/dp-review-panel-empty-state 
Add empty state to review panel

GitOrigin-RevId: 47d7b676e9868942567fc02db234b0827ac86ba3
 2024-07-15 09:04:27 +00:00
Alf Eaton
c24ace801b Remove Angular (#17534) 
GitOrigin-RevId: 7a0d45e17d9905fa75569e2d19ca59caa4a41565
 2024-06-06 08:04:09 +00:00
Antoine Clausse
2f99e3ccf1 Add autoComplete="off" to React-controlled checkboxes (#18212) 
Fixes https://github.com/overleaf/internal/issues/18144

Browsers use a [bfcache](https://web.dev/articles/bfcache) (Back/forward cache) which restores form data on navigation. Unfortunately, it causes checkbox appearances not to respect our React states.

Setting `autoComplete="off"` on checkboxes mitigates this problem. (From https://stackoverflow.com/questions/299811/why-does-the-checkbox-stay-checked-when-reloading-the-page)

Another solution could be to set a `Cache-Control: no-store` header, but this might additionnal undesired consequences.

GitOrigin-RevId: 7d3cceb1c818ad70de7e806ea6d714ffc8bffb4a
 2024-05-06 08:04:39 +00:00
Antoine Clausse
6a6f155029 [web] Use React hooks to get split-test variants instead of getSplitTestVariant (getMeta) (#18133) 
* Fix split-tests loading in React component: use `useSplitTestContext` instead of `getSplitTestVariant`

* Replace use of `isSplitTestEnabled` by `useSplitTestContext`

* Add SplitTestProvider to roots, and fix tests

* Create `useFeatureFlag` hook

* Use `useFeatureFlag` where applicable

GitOrigin-RevId: 9ff7bb3975d50bc4d07d74d93c482d56dc96f615
 2024-05-01 08:04:55 +00:00
Alf Eaton
92d6966f69 Only display bulk actions for tracked changes when permitted (#18038) 
GitOrigin-RevId: a2f4df9c26866aab3eea62c92ce6e1a211e08294
 2024-04-23 08:05:31 +00:00
Domagoj Kriskovic
8bde496da4 Send operations to project-history when resolving/unresolving comments (#17540) 
* Send operations to project-history when resolving/unresolving comments

* small fixes

* added doc_id in web unit test

* Revert "added doc_id in web unit test"

This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.

* fix mocked dependency in test

* wip: web unit tests

* document updater, reopen test

* document-updater tests

* format fix

* fix typo

* fix callsArgWith

* fix reopenThread calls in doc updater tests

* fix typos

* log error if chat api resolve failes

* log error when reopening thread

* sendStatus calls done() in tests

* using OError instead of logging

* removed timers

* preserve legacy endpoints

* update after merge

* Remove timer check in HttpControllerTest

* prettier

* added "legacy" in log

* remove metrics.timer

* fix promisify issues

* remove unused cb

GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
 2024-04-10 08:04:08 +00:00
Antoine Clausse
92a58c8f3b [web] Paywall CTA split-test (#17555) 
* Fix `{splitTest.requiredCohortSize && (...)}` can display `0`

* Get `paywall-cta` assignment in ProjectController.js

* CTA change: "Get Dropbox Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286026

* CTA change: "Get GitHub Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get Git integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286283

* CTA change: "Add more collaborators"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763884855

* CTA change: "Get track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764030761

* Update wording and position: "Already subscribed? Try refreshing the page."

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764366969

* Casing update: "Upgrade to track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764209961

* CTA changes: "Get Mendeley integration" + "Get Zotero integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547424

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547269

* CTA change: "Get full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762005

* Casing update: "full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762280

* CTA change: "Get more compile time" in timeout-upgrade-prompt-new.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get more compile time" in compile-timeout-warning.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762726

* CTA change: "Get advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969087

* Update casing and wording: "advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969412

* CTA change: "Get Symbol Palette"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765128906

* Update title: "Subscribe to find the symbols you need faster"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765289664

* Revert use of `satisfies`: it doesn't work with our version of prettier (https://github.com/prettier/prettier/issues/13516)

* CTA change: "Get more compile time" in compile-timeout-changing-soon.tsx

⚠️ not in miro

* Rename `paywallCtaAssignment`, remove useless export and comment

Addressing Fahru's review

* Add alternative texts in `/registration/try-premium` page

* CTA change: "Get more compile time" in timeout-upgrade-prompt.jsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get GitHub Sync" in import-project-from-github-modal-content.tsx

Not in Miro, but related to: https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get more compile time" in compile-time-warning.tsx

Not in Miro, but related to others

* Fix compile-time-warning style (spacings, overflows out of window)

* `npm run format:fix`

GitOrigin-RevId: 0d8d1808b5901c2761d35494c49713d26721bcfd
 2024-04-03 08:04:16 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier 
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
 2024-03-26 09:04:05 +00:00
Alf Eaton
aeb20340c8 Reduce review panel calls to Trans (#17385) 
GitOrigin-RevId: fdc7b3c2cd2506c810a785462fcd120a3a05da78
 2024-03-07 16:30:36 +00:00
Alf Eaton
749660e168 Refactor review panel context (#17383) 
GitOrigin-RevId: 23e7ff8632172ebd0bc544a2297d1d4179010832
 2024-03-07 16:30:25 +00:00
roo hutton
790fc5513b Merge pull request #17392 from overleaf/rh-friendly-readonly 
Don't show 'add comment' button if isRestrictedTokenMember

GitOrigin-RevId: da236a4f2fbe0e66a7e5999bd70f7145fd60df20
 2024-03-06 09:03:13 +00:00
Tim Down
3a88a60e23 Merge pull request #16700 from overleaf/td-scroll-comment-input-into-view 
Scroll comment textarea into view after autofocus

GitOrigin-RevId: c8542f40d25772a14e7511702c0e47b7001be275
 2024-02-05 09:04:21 +00:00
Alf Eaton
0cde5be165 Merge pull request #14709 from overleaf/ae-context-typescript 
Convert React context providers to TypeScript [don't squash!]

GitOrigin-RevId: d92a91798286978410956ab791d73c17c5086d86
 2024-01-29 09:03:04 +00:00
ilkin-overleaf
fa314fe5b0 Merge pull request #16509 from overleaf/ii-rp-update-entry-positions 
[web] Review panel entry positions and long user names

GitOrigin-RevId: 3a596bd90bab2c87b2efae5eb812ffc5e5a1580f
 2024-01-19 09:05:28 +00:00
ilkin-overleaf
20485b886f Merge pull request #16278 from overleaf/ii-ide-page-prototype-review-panel-entry-hover 
[web] Remove entry hover from review panel

GitOrigin-RevId: 6bcfb28e20d7a8826301c34499340b6a7d2745db
 2024-01-04 09:03:14 +00:00
ilkin-overleaf
fbed0cb943 Merge pull request #16268 from overleaf/ii-ide-page-prototype-review-panel-layout-to-left 
[web] Review panel popovers

GitOrigin-RevId: 4424abab97b197013063679bd8efcac001f458ad
 2023-12-18 09:04:18 +00:00
ilkin-overleaf
5e7665e322 Merge pull request #16162 from overleaf/ii-ide-page-prototype-review-panel-issues-1 
[web] Review panel editor widgets fix

GitOrigin-RevId: a762ce3983fd7a3a99b8be5647baea4f8a0bb76c
 2023-12-18 09:03:49 +00:00
Alf Eaton
a074054cc9 Add memo to some components (#16094) 
GitOrigin-RevId: e4bea140d872ac3f8b2aca7833e658af684a1438
 2023-12-15 09:03:22 +00:00
ilkin-overleaf
456d831eab Merge pull request #16188 from overleaf/ii-rp-collapse-height 
[web] Review panel comment container fix

GitOrigin-RevId: 0577949e711046303d25ba7e724564227d4a1bc7
 2023-12-14 09:03:30 +00:00
ilkin-overleaf
989bd87785 Merge pull request #16104 from overleaf/ii-rp-add-comment-when-large-selection-is-made 
[web] Review panel add comment when large selection is made

GitOrigin-RevId: 9c73668d6420575a3f2630541ba0c57ff713141a
 2023-12-11 09:03:24 +00:00
ilkin-overleaf
b715cb3b16 Merge pull request #16152 from overleaf/ii-ide-page-prototype-review-panel-mini 
[web] React ide page mini review panel

GitOrigin-RevId: 4c4ee8095446a2f72371024b93a07dbd1dbd2a63
 2023-12-11 09:03:21 +00:00
ilkin-overleaf
e450b702e8 Merge pull request #16120 from overleaf/ii-rp-track-changes-indicators 
[web] Review panel track changes indicators

GitOrigin-RevId: 8911ca1774648ecdde6f0ee173b06f20b1de4e9a
 2023-12-08 09:04:24 +00:00
ilkin-overleaf
c3689ca6f3 Merge pull request #16138 from overleaf/ii-ide-page-prototype-review-panel-overview-loading 
[web] React ide page overview switch

GitOrigin-RevId: 9a24a8ba9ed8e86d486a12a65259d25c1352c864
 2023-12-08 09:04:19 +00:00
ilkin-overleaf
8035241cc0 Merge pull request #16065 from overleaf/ii-ide-page-prototype-review-panel-add-comment 
[web] React ide page add comment

GitOrigin-RevId: 4c2442ccc77760d4a27268551c9dd2d73fcdba84
 2023-12-05 09:04:06 +00:00
ilkin-overleaf
a75b44a6fc Merge pull request #15861 from overleaf/ii-ide-page-prototype-review-panel-delete-thread 
[web] React ide page delete thread

GitOrigin-RevId: 46e93d67d597a2277c771bda2a4837a871339224
 2023-11-27 09:04:19 +00:00
ilkin-overleaf
e4f5afc0c0 Merge pull request #15829 from overleaf/ii-ide-page-prototype-permissions 
[web] React ide page permissions

GitOrigin-RevId: 727d33e0654d4bfefe5e710e553895f793cacb82
 2023-11-24 09:04:27 +00:00
Tim Down
9f80dd48e8 Merge pull request #15814 from overleaf/td-review-panel-indicator-hover 
Fix review panel comment hover bug

GitOrigin-RevId: ddd6f8f073a2af189c990c8942a388cae412f8c6
 2023-11-22 09:04:48 +00:00
Tim Down
4f13470345 Merge pull request #15819 from overleaf/td-review-panel-comment-selection 
Prevent selection within review panel entry being immediately cleared

GitOrigin-RevId: cca7206a6620bed8cae1bb55a064102204a00751
 2023-11-22 09:04:35 +00:00
Tim Down
86c06d8c99 Merge pull request #15815 from overleaf/td-persist-unsaved-comment 
Persist unsaved comment in the front end after not submitting

GitOrigin-RevId: a7ffee6f5fbfb7151a2ef7233ba4412d0db33e19
 2023-11-22 09:04:21 +00:00
Alf Eaton
bf6257af80 Exclude "add-comment" and "bulk-entries" from overview entry count (#15718) 
GitOrigin-RevId: 0aae510a36aa717b601795eb51d8c97f9309ada2
 2023-11-20 09:03:30 +00:00
ilkin-overleaf
7db5d761ea Merge pull request #15557 from overleaf/ii-ide-page-prototype-review-panel-track-changes 
Review panel track changes for React IDE page

GitOrigin-RevId: d061596581ff10bd897b286dcd5c280ce79a6384
 2023-11-17 09:03:02 +00:00
Tim Down
6f34a84ebd Merge pull request #15684 from overleaf/td-ide-page-main-doc-left-menu 
Add docs to FileTreeDataContext to replace 'docs' scope value in React code

GitOrigin-RevId: 430f795eb0cd17f0f4fab9c61e46fb04ff3030b3
 2023-11-14 09:04:40 +00:00
ilkin-overleaf
0c403bf8e3 Merge pull request #15397 from overleaf/ii-ide-page-prototype-review-panel 
Init review panel for React IDE page

GitOrigin-RevId: fc23201055ae892c5c1d5cb88e472a0bb0cd6c25
 2023-11-03 09:00:02 +00:00
Alf Eaton
221d16f4e4 Disable transSupportBasicHtmlNodes in react-i18next config (#15430) 
* Set transSupportBasicHtmlNodes to false
* Update ESLint rule
* Convert Trans to t
* Convert shouldUnescape={true}
* Convert some arrays to objects
* Update translations

GitOrigin-RevId: 64a50318388abcada408f72d949de148129a9f63
 2023-10-31 09:04:04 +00:00
Alf Eaton
9868ce46ec Fix "add new comment" keyboard shortcut (#15404) 
GitOrigin-RevId: d675abbf0977d5c60f332136e98c55a765cf87e9
 2023-10-25 08:04:37 +00:00
Domagoj Kriskovic
20f49ae325 send comment over sharejs after thread is created (#14807) 
* send comment over sharejs after thread is created

* only react version

* loading gif

GitOrigin-RevId: a6b16a8cae66faa3219f1c9141ee04e303d9f11b
 2023-09-21 08:04:05 +00:00
Mathias Jakobsen
96ba8a92f4 Merge pull request #14757 from overleaf/td-review-panel-auto-expand-textarea-cursor 
React review panel: place cursor at the end when autofocussing textarea

GitOrigin-RevId: c277e949dadc16bef2ed1a9ace69285e99ba29ad
 2023-09-14 08:04:00 +00:00
Tim Down
1dc3d12c1d Merge pull request #14746 from overleaf/td-review-panel-empty-comment-edit 
React review panel: populate comment box when editing

GitOrigin-RevId: ba284bd419dd507eef17847b5f4c55b8fd8338f5
 2023-09-11 08:05:31 +00:00
Tim Down
5748ee4496 Merge pull request #14230 from overleaf/td-review-panel-add-comment-reappear 
React review panel: ensure that "Add comment" entry reappears after clicking away then back

GitOrigin-RevId: fc1b656304d71876d8a4728648b73e1d3f873817
 2023-09-06 08:06:41 +00:00
Tim Down
5cce9683fa Merge pull request #14628 from overleaf/td-review-panel-scroll-jump 
Fix scroll jump and improvements to React review panel layout and performance

GitOrigin-RevId: 3123f90abeb1bf9712ba4025a272e13990aebbd9
 2023-09-06 08:06:32 +00:00
ilkin-overleaf
fc9d3755c2 Merge pull request #14361 from overleaf/ii-add-comment-review-panel 
[web] Open current file view mode when adding comment through editor widget

GitOrigin-RevId: 7028ab2a2b6369064712d456c8ae1d33498b8002
 2023-08-18 12:11:11 +00:00
ilkin-overleaf
231278d1ca Merge pull request #14076 from overleaf/ii-indicator-ref-type-improvement 
[web] Make the indicator ref type dynamic

GitOrigin-RevId: b66aa0f5ffc5c8071462e7e082ece21ef292b4fa
 2023-08-01 08:04:27 +00:00
Tim Down
ac919ed21a Merge pull request #14046 from overleaf/td-review-panel-scrolled-down-layout 
React review panel: fix bug that prevented entries appearing when editor starts off scrolled down

GitOrigin-RevId: 61c5b5523e82cf5334c4de30d6849f45d5bc321a
 2023-07-28 08:04:02 +00:00
Tim Down
6384163793 Merge pull request #14025 from overleaf/td-review-panel-hover-scroll 
Review panel migration: end entry indicator hover on editor scroll

GitOrigin-RevId: fb895d9e4960b1c038c48fefd187f8af415db1da
 2023-07-28 08:03:59 +00:00
Tim Down
f2b5ac23f8 Merge pull request #13997 from overleaf/td-review-panel-mini-hover 
React review panel: make hovering an entry in the mini review panel display correctly

GitOrigin-RevId: 41a40e4047b89d2a8db15b2e12baf04c11b78e21
 2023-07-25 08:03:55 +00:00
Tim Down
752ad8870d Merge pull request #13923 from overleaf/td-review-panel-non-sticky-toolbar-nav 
Make toolbar and nav non-sticky in React review panel overview mode

GitOrigin-RevId: feb2950698512120a676a597f0edfa7ba615f934
 2023-07-21 08:04:57 +00:00
Tim Down
0d3af56efa Merge pull request #13911 from overleaf/td-review-panel-performance 
Review panel: memoize entry views for performance

GitOrigin-RevId: 3c305845ad0914a7ffeb595e7235d7dceb4c780a
 2023-07-21 08:04:49 +00:00