Commit graph

415 commits

Author SHA1 Message Date
Jessica Lawshe
f5ac5b0ed3 Merge pull request #17878 from overleaf/mj-keyboard-navigation-firefox-115
[web] Use getAttribute rather than accessing Element.role

GitOrigin-RevId: a6732180d945ccc4ac0300af07e52228e9f2c928
2024-04-12 08:06:27 +00:00
Domagoj Kriskovic
8bde496da4 Send operations to project-history when resolving/unresolving comments (#17540)
* Send operations to project-history when resolving/unresolving comments

* small fixes

* added doc_id in web unit test

* Revert "added doc_id in web unit test"

This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.

* fix mocked dependency in test

* wip: web unit tests

* document updater, reopen test

* document-updater tests

* format fix

* fix typo

* fix callsArgWith

* fix reopenThread calls in doc updater tests

* fix typos

* log error if chat api resolve failes

* log error when reopening thread

* sendStatus calls done() in tests

* using OError instead of logging

* removed timers

* preserve legacy endpoints

* update after merge

* Remove timer check in HttpControllerTest

* prettier

* added "legacy" in log

* remove metrics.timer

* fix promisify issues

* remove unused cb

GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
2024-04-10 08:04:08 +00:00
Andrew Rumble
9fda813e20 Merge pull request #17786 from overleaf/ar-select-caption-in-inserted-figures
Select caption text when new figure inserted

GitOrigin-RevId: 443594ff03c5a5cd316623e60b231a6af4390d3c
2024-04-09 08:04:36 +00:00
Miguel Serrano
d7d63e0f51 Merge pull request #17693 from overleaf/msm-hide-grammarly-sp
Prevent grammarly ad from rendering in CE/SP

GitOrigin-RevId: 3ef191f282f2ce682236710df9ca32a087271c4c
2024-04-09 08:03:59 +00:00
Antoine Clausse
92a58c8f3b [web] Paywall CTA split-test (#17555)
* Fix `{splitTest.requiredCohortSize && (...)}` can display `0`

* Get `paywall-cta` assignment in ProjectController.js

* CTA change: "Get Dropbox Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286026

* CTA change: "Get GitHub Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get Git integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286283

* CTA change: "Add more collaborators"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763884855

* CTA change: "Get track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764030761

* Update wording and position: "Already subscribed? Try refreshing the page."

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764366969

* Casing update: "Upgrade to track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764209961

* CTA changes: "Get Mendeley integration" + "Get Zotero integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547424

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547269

* CTA change: "Get full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762005

* Casing update: "full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762280

* CTA change: "Get more compile time" in timeout-upgrade-prompt-new.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get more compile time" in compile-timeout-warning.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762726

* CTA change: "Get advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969087

* Update casing and wording: "advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969412

* CTA change: "Get Symbol Palette"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765128906

* Update title: "Subscribe to find the symbols you need faster"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765289664

* Revert use of `satisfies`: it doesn't work with our version of prettier (https://github.com/prettier/prettier/issues/13516)

* CTA change: "Get more compile time" in compile-timeout-changing-soon.tsx

⚠️ not in miro

* Rename `paywallCtaAssignment`, remove useless export and comment

Addressing Fahru's review

* Add alternative texts in `/registration/try-premium` page

* CTA change: "Get more compile time" in timeout-upgrade-prompt.jsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get GitHub Sync" in import-project-from-github-modal-content.tsx

Not in Miro, but related to: https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get more compile time" in compile-time-warning.tsx

Not in Miro, but related to others

* Fix compile-time-warning style (spacings, overflows out of window)

* `npm run format:fix`

GitOrigin-RevId: 0d8d1808b5901c2761d35494c49713d26721bcfd
2024-04-03 08:04:16 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
2024-03-26 09:04:05 +00:00
Alf Eaton
aeb20340c8 Reduce review panel calls to Trans (#17385)
GitOrigin-RevId: fdc7b3c2cd2506c810a785462fcd120a3a05da78
2024-03-07 16:30:36 +00:00
Alf Eaton
5df35093ea Remove hidden comment button from editor toolbar (#17386)
GitOrigin-RevId: 61b3725a7b2112c6e5abca0349b1be910e97266a
2024-03-07 16:30:28 +00:00
Alf Eaton
749660e168 Refactor review panel context (#17383)
GitOrigin-RevId: 23e7ff8632172ebd0bc544a2297d1d4179010832
2024-03-07 16:30:25 +00:00
Alf Eaton
bd2c3a61f3 Merge pull request #17381 from overleaf/ae-firefox-change-callout
Hide comment/change callout line in Firefox

GitOrigin-RevId: fe0803c71beb1073cf6715ff91a68ed39f578af2
2024-03-07 16:30:22 +00:00
Alf Eaton
55da43a6ce Ensure that ol_extensions_writefull Sentry tag is defined (#17366)
GitOrigin-RevId: c1261f780e439852b9a59d8d8a2022c30ff354e1
2024-03-07 16:30:15 +00:00
Miguel Serrano
ac48d81987 Merge pull request #17373 from overleaf/jpa-figure-modal-options
[web] hide figure modal import options as configured server side

GitOrigin-RevId: f8907a33d413fcac238b00328eaba14d64f2f31b
2024-03-06 17:27:32 +00:00
roo hutton
790fc5513b Merge pull request #17392 from overleaf/rh-friendly-readonly
Don't show 'add comment' button if isRestrictedTokenMember

GitOrigin-RevId: da236a4f2fbe0e66a7e5999bd70f7145fd60df20
2024-03-06 09:03:13 +00:00
Mathias Jakobsen
60d38285ea Merge pull request #17393 from overleaf/mj-tikzcd
[cm6] Don't decorate tikzcd environments

GitOrigin-RevId: bf499432d67cefe12576fc135f4564b97a1b2c13
2024-03-05 09:03:31 +00:00
Alf Eaton
3e11ee6e5a Ensure that the editor state is preserved when switching views (#17238)
GitOrigin-RevId: 946b82cb633afbea13a72e30a9ce432aa1a8196d
2024-02-23 09:03:06 +00:00
Alf Eaton
3f29aa2195 Ensure that each editor theme is only created once (#17095)
GitOrigin-RevId: 3551e02fab44fae7fcab5cb12886d45969e3990f
2024-02-16 09:05:03 +00:00
Alf Eaton
00d043cc72 Ensure that the selection layer updates when the review panel is toggled (#17021)
GitOrigin-RevId: e5418ae642e0c46f12c633fc71323bb86018c42a
2024-02-16 09:04:31 +00:00
Alf Eaton
7b3ffb9fae Standardise types for ranges (#16927)
GitOrigin-RevId: 28dd0eb67e1684e6bd0e452d15315ce1f9e3481a
2024-02-09 09:06:51 +00:00
Tim Down
3a88a60e23 Merge pull request #16700 from overleaf/td-scroll-comment-input-into-view
Scroll comment textarea into view after autofocus

GitOrigin-RevId: c8542f40d25772a14e7511702c0e47b7001be275
2024-02-05 09:04:21 +00:00
Alf Eaton
cac1ab1259 Add tags to Sentry error reports (#16465)
GitOrigin-RevId: 1d014e8cc9f87d249a285b247c35f12465ecb93a
2024-02-02 09:03:23 +00:00
Alf Eaton
614d1d05cc Maintain the current scroll position when applying remote changes (#16777)
GitOrigin-RevId: 5d2d0fd5aaefcc6b1e7f4dbd2ce29287cf8dbbdb
2024-02-02 09:03:20 +00:00
Alf Eaton
373c4736e8 Wrap the useCodeMirrorMeasurement state setter in a timeout (#16818)
GitOrigin-RevId: 9f7c12f679ab3947724cc52c63fcee198c73ae87
2024-02-02 09:03:11 +00:00
Alf Eaton
0cde5be165 Merge pull request #14709 from overleaf/ae-context-typescript
Convert React context providers to TypeScript [don't squash!]

GitOrigin-RevId: d92a91798286978410956ab791d73c17c5086d86
2024-01-29 09:03:04 +00:00
Alf Eaton
5871978272 Use renderMessage (#16628)
GitOrigin-RevId: 9f627a31d0f8ffce841f04f5a9bfa09f6abcd0a3
2024-01-24 09:04:08 +00:00
Alf Eaton
5e3deba9fe Dispatch 'UNSTABLE_editor:extensions' event on 'editor:extension-loaded' (#16611)
GitOrigin-RevId: a1d93330a7633c6d5870e2c368ab45a4a586db35
2024-01-24 09:03:28 +00:00
ilkin-overleaf
fa314fe5b0 Merge pull request #16509 from overleaf/ii-rp-update-entry-positions
[web] Review panel entry positions and long user names

GitOrigin-RevId: 3a596bd90bab2c87b2efae5eb812ffc5e5a1580f
2024-01-19 09:05:28 +00:00
Alf Eaton
612c7c28b0 Merge pull request #16511 from overleaf/ae-upgrade-uppy
Upgrade Uppy to v3

GitOrigin-RevId: ca3e366a20ac651a98aafe12bf319b1968ac6ec1
2024-01-19 09:05:05 +00:00
Alf Eaton
4bca3de8d2 Add estimated height to some block widget decorations (#16485)
GitOrigin-RevId: f59da18228e038b1295ccc0128a33acd2de4f9f9
2024-01-19 09:05:01 +00:00
Alf Eaton
22b5828b3d Move Writefull toolbar loading/initialisation into a React component (#16546)
GitOrigin-RevId: 1cb6efa7cab2babb33800fef9469fca3addbdaf5
2024-01-19 09:04:52 +00:00
Mathias Jakobsen
7c3c3047fe Merge pull request #16588 from overleaf/mj-usepackage-fix
[web] Copy single backslash in column width modal

GitOrigin-RevId: ee3e3eadac067dac1d955adc04709e8ab3121a59
2024-01-19 09:04:37 +00:00
Mathias Jakobsen
8d7fbf5a47 Merge pull request #16522 from overleaf/mj-table-generator-cypress-tests
[web] Add cypress tests for table generator

GitOrigin-RevId: c77454763cfc83e4869e75ba247369e6255a0553
2024-01-19 09:04:33 +00:00
Mathias Jakobsen
80a6424343 Merge pull request #16048 from overleaf/mj-table-column-width
[visual] Allow setting column widths in table generator

GitOrigin-RevId: 3bd4bb05dd3b29d0bd62fbc41da45eda282fecf4
2024-01-19 09:04:28 +00:00
David
29bfdae57d Merge pull request #16523 from overleaf/dp-editable-file-extensions-2
Make cfg, ltx, Rnw and inc files editable in the editor

GitOrigin-RevId: 1999c29ea451aa3f362ffa09f6f4d5889beaf404
2024-01-17 09:03:53 +00:00
Thomas
e1c58c2aaf Merge pull request #15710 from overleaf/tm-no-constant-binary-expressions
Add no-constant-binary-expression, fix existing expressions that have no effect

GitOrigin-RevId: 6691e87181331ecbb5dabfda0be89839a0a4884b
2024-01-16 09:04:09 +00:00
Domagoj Kriskovic
21a4e0b6b3 [visual] Skip moving cursor inside argument if there is no decoration (#16365)
* [visual] Skip moving cursor inside argument if there is no decoration

* Refactor skipAtomicRanges function

* rangeSet outside the loop, continue rather than return

* use rangeSet.between

* prettier

GitOrigin-RevId: 85ef817e09ea7eb854cec43cb7866f61b4bfbc21
2024-01-16 09:03:59 +00:00
ilkin-overleaf
f67e19f6d2 Merge pull request #16453 from overleaf/ii-review-panel-dismiss-bulk-actions
[web] Fix bulk actions in review panel

GitOrigin-RevId: c78c99b0a3b005a0a4490ce393eb5d540f23ebc2
2024-01-15 09:04:31 +00:00
Alf Eaton
4a7a24b44d Update the CodeMirror language when the current file is renamed (#16342)
GitOrigin-RevId: 8b51df0d1acfeeb8b0323cebf6de78572c8cb95c
2024-01-15 09:04:27 +00:00
Alf Eaton
ace673b95a [visual] Decorate \ce command (#16459)
GitOrigin-RevId: 0eab030489f97e43874e41d6d4895dc4de46521a
2024-01-15 09:04:08 +00:00
David
a2da947a1f Merge pull request #16437 from overleaf/dp-remove-visual-editor-feedback-icon
Remove visual editor feedback badge

GitOrigin-RevId: c84cc7b6630642853848fad46695bff6ae2a990a
2024-01-12 09:03:19 +00:00
Alf Eaton
fc8892e4fb Expose ScopeValueStore via window.overleaf.unstable.store (#16404)
GitOrigin-RevId: 4b251639296405c0a9487f063e8b049687860004
2024-01-09 09:03:46 +00:00
Domagoj Kriskovic
e27abe56b8 Show argument completions even if it has more than 245 chars (#16352)
* Show argument completions even if it has more than 255 chars

* use tokenBefore for existingKeys

* use 'ShortArg' token so braces are escaped

* refactor argument completion logic

* remove extra filter

* Add makeMultipleArgumentCompletionSource for arguments with multiple keys

* revert makeArgumentCompletionSource

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: f5aa70fe5e58e04efe0c4e8668957f61a7fa7911
2024-01-09 09:03:40 +00:00
Jimmy Domagala-Tang
3617196760 Merge pull request #16419 from overleaf/jdt-fix-grammarly-offer-link
fix the grammarly offer id

GitOrigin-RevId: 996501ebb50b64bd8f9bd46305ba47baa37fee88
2024-01-08 09:05:45 +00:00
Jimmy Domagala-Tang
5f38a930a5 Merge pull request #16319 from overleaf/jdt-grammarly-ad-redesign
Grammarly Ad redesign

GitOrigin-RevId: 28d0ae871b6303b31aadb59abc80b625d529cc9b
2024-01-08 09:05:40 +00:00
Alf Eaton
cf0e260a36 Recalculate toolbar overflow when buttons change (#16350)
GitOrigin-RevId: 70ab356172bc57630b6032a6400fb08e8fd33464
2024-01-08 09:05:17 +00:00
Alf Eaton
84898dca5d Remove margin from table grid popover (#16337)
Co-authored-by: Mathias Jakobsen <mathias.jakobsen@overleaf.com>
GitOrigin-RevId: 71673d7d9a18baf44027e82cc34058e3db052591
2024-01-08 09:05:12 +00:00
Alf Eaton
84ebb1c8f2 Merge pull request #16378 from overleaf/ae-upgrade-codemirror-3
Upgrade `@codemirror` dependencies

GitOrigin-RevId: 242b1dbcf2878869957f40a5522dabcbcc181b5b
2024-01-08 09:05:02 +00:00
Jimmy Domagala-Tang
21dd23d0e4 Merge pull request #16318 from overleaf/jdt-fix-multiple-popups
Show only one editor notification at a time

GitOrigin-RevId: 88a0309da121e9545136cd718ed24710a9d25363
2024-01-04 09:03:40 +00:00
Alf Eaton
4f5ca6624e Move responsibility for parsing and validating table data out of the tabular widget (#15152)
GitOrigin-RevId: bba823ca036501a527f08746cffb155641d3becf
2024-01-04 09:03:29 +00:00
Alf Eaton
621bae03ca Use collapsePreambleEffect (#15866)
GitOrigin-RevId: e07a48ba5a7ca2ce30aa6933030f8eae970a65b5
2024-01-04 09:03:26 +00:00
Alf Eaton
c84e45bc06 [cm6] Only rebuild changed line indentation decorations (#16126)
GitOrigin-RevId: ba1f29125ab0f40742c57cfb5eae82315ab8629b
2024-01-04 09:03:23 +00:00