Commit graph

19 commits

Author SHA1 Message Date
Alf Eaton
00d043cc72 Ensure that the selection layer updates when the review panel is toggled (#17021)
GitOrigin-RevId: e5418ae642e0c46f12c633fc71323bb86018c42a
2024-02-16 09:04:31 +00:00
Alf Eaton
7b3ffb9fae Standardise types for ranges (#16927)
GitOrigin-RevId: 28dd0eb67e1684e6bd0e452d15315ce1f9e3481a
2024-02-09 09:06:51 +00:00
ilkin-overleaf
f67e19f6d2 Merge pull request #16453 from overleaf/ii-review-panel-dismiss-bulk-actions
[web] Fix bulk actions in review panel

GitOrigin-RevId: c78c99b0a3b005a0a4490ce393eb5d540f23ebc2
2024-01-15 09:04:31 +00:00
ilkin-overleaf
de945a432d Merge pull request #15999 from overleaf/ii-ide-page-prototype-review-panel-accept-reject-changes
[web] React ide page accept/reject changes

GitOrigin-RevId: 0bb8e3759c7edbef16be04b2f200ae3686c3a53c
2023-11-30 09:03:43 +00:00
Alf Eaton
d40de2018c Remove Angular/Pug review panel code (#15935)
GitOrigin-RevId: de782d4b47d987f6434a34bea487568b269e8d85
2023-11-29 09:04:13 +00:00
Alf Eaton
9875e55a27 Remove Ace (#14299)
GitOrigin-RevId: ec8788fdbc8aea73ca33ec2810f4e588fe9476b5
2023-11-29 09:04:08 +00:00
Alf Eaton
604b4e5fdb Ensure that submitOps is called in a timeout (#15840)
GitOrigin-RevId: f4b5f9649a18e5e0ea2332b6e8c90426d7c055d6
2023-11-23 09:03:00 +00:00
Tim Down
5cce9683fa Merge pull request #14628 from overleaf/td-review-panel-scroll-jump
Fix scroll jump and improvements to React review panel layout and performance

GitOrigin-RevId: 3123f90abeb1bf9712ba4025a272e13990aebbd9
2023-09-06 08:06:32 +00:00
Tim Down
98a847ae75 Merge pull request #14059 from overleaf/td-review-panel-smoother-chrome
React review panel: fix regression that made animation jerky on Chrome

GitOrigin-RevId: c1d9fa00d478fa71d94ff705ddfcc12bab0b2767
2023-07-28 08:04:10 +00:00
Tim Down
ac919ed21a Merge pull request #14046 from overleaf/td-review-panel-scrolled-down-layout
React review panel: fix bug that prevented entries appearing when editor starts off scrolled down

GitOrigin-RevId: 61c5b5523e82cf5334c4de30d6849f45d5bc321a
2023-07-28 08:04:02 +00:00
Tim Down
f2b5ac23f8 Merge pull request #13997 from overleaf/td-review-panel-mini-hover
React review panel: make hovering an entry in the mini review panel display correctly

GitOrigin-RevId: 41a40e4047b89d2a8db15b2e12baf04c11b78e21
2023-07-25 08:03:55 +00:00
Tim Down
a88589b7b7 Merge pull request #13951 from overleaf/td-review-panel-dismiss-bulk-actions
Review panel: make "Reject all" and "Accept all" buttons disappear after use

GitOrigin-RevId: 99534b65ec812fb0e6efd443ca126e71a0a09ae5
2023-07-21 08:04:53 +00:00
Alf Eaton
9f719c572d [cm6] Add offset to review panel entry positions when needed (#13912)
* Add offset to review panel entry positions when needed
* Fix useResizeObserver usage

GitOrigin-RevId: e220ce94e13c3a2347fc72654de747356eb1e658
2023-07-19 08:04:40 +00:00
Tim Down
38c673d057 Merge pull request #13720 from overleaf/td-review-panel-entry-pos
React review panel entry positioning

GitOrigin-RevId: c22617b1d3243b7d54b093426358aeb291421b9e
2023-07-19 08:03:52 +00:00
Alf Eaton
a4d1ac2f13 Merge pull request #13477 from overleaf/ae-bottom-padding
[cm6] Improve bottom padding calculations

GitOrigin-RevId: 91fff97ebf6675cddffdd89118fd06f003321143
2023-07-17 10:36:00 +00:00
Alf Eaton
08ccdb79d3 [cm6] Improve alignment of review panel elements (#12710)
* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity

GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
2023-04-25 08:05:02 +00:00
Alf Eaton
acf6abb0fb [cm6] Use a block widget for padding at the top of the editor (#12705)
GitOrigin-RevId: 000ce9c90ea6b2ca72ab969704354a19fcea7a87
2023-04-25 08:04:53 +00:00
Alf Eaton
a8ed6b65e1 [cm6] Improve "vertical overflow" handling (#12405)
* Avoid setting style on the editor view whenever overflowPaddingState changes
* Round values in recalculateScreenPositions
* Refactor ignoreGeometryChangesUntil slightly
* Restore the original value

GitOrigin-RevId: 75c57be21dd16a748c0d9b14058386849a80b831
2023-04-17 08:04:18 +00:00
Tim Down
7f37ba737c Move source editor out of module (#12457)
* Update Copybara options in preparation for open-sourcing the source editor

* Move files

* Update paths

* Remove source-editor module and checks for its existence

* Explicitly mention CM6 license in files that contain code adapted from CM6

GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
2023-04-13 08:40:56 +00:00