Miguel Serrano
b7b40e6057
Merge pull request #19178 from overleaf/msm-frog-test-reliability
...
[CE] make JPG rendering test more robust
GitOrigin-RevId: f0f6b0119ed59e7f3fa8af70d69915a4d9ccda3f
2024-06-28 08:04:41 +00:00
Jakob Ackermann
9075c82b88
Merge pull request #19170 from overleaf/jpa-server-ce-re-run-before
...
[server-ce] make tests more robust
GitOrigin-RevId: f070b8bbbf87842a69d88ca56cecf5dd0f3a286c
2024-06-28 08:04:33 +00:00
Antoine Clausse
ebec84540f
Add waitForDb in scripts/resync_subscriptions.js ( #19154 )
...
GitOrigin-RevId: 608bce2654d2b6dbeb662ad0da8bb5c5ce3d68f3
2024-06-28 08:04:29 +00:00
Antoine Clausse
01188589f8
Add some JSDoc types to @overleaf/logger ( #19153 )
...
* Add some JSDoc types to `@overleaf/logger`
* Update `logger.error` calls
* Fixup `logger.err` JSDoc
* Update `logger.err` calls
* Fix `args` type
* Remove "Error message" description
* Replace `arguments` by actual arguments of the method
* Fix: "ESLint: Unnecessary '.apply()'.(no-useless-call)"
* Add JSDoc params to `debug` `info` `warn`
* Remove extra `args` param in JSDoc so developers aren't invited to use it
Not sure if this is the best thing to do because it creates a warning in the IDE: "Parameter args is not described in JSDoc"
* Add comment about serialization of `err` `req` `res`
* Allow strings as first param in `debug` `info` `warn`
* Fix syntax for optional parameters in JSDoc
* Add 2 signatures, to avoid "string, string" params
* Fix `@signature` names copy-pastes
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Revert the double `@param attributes`. It doesn't work
---------
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 086dee8bbf30d577c5e1f844a9df5e518c46aca7
2024-06-28 08:04:25 +00:00
Antoine Clausse
1dbbe5af9d
[web] Promisify TemplatesController ( #18849 )
...
* Promisify TemplatesController
* Update TemplatesControllerTests
* Fix `templateVersionId` in `getV1Template` (!!)
GitOrigin-RevId: bdaa59ed3cff81d919a8b3d19d5be555a2790f55
2024-06-28 08:04:17 +00:00
Jakob Ackermann
0ecb266e32
Merge pull request #19165 from overleaf/jpa-test-history-download
...
[server-ce] add tests for downloading a project zip from the history
GitOrigin-RevId: 95b0047e7d4cce7f6708d116bf2065d634a76ae4
2024-06-27 08:05:01 +00:00
Jessica Lawshe
0ed123aebd
Merge pull request #19085 from overleaf/jel-light-touch-table-updates
...
[web] Update background color CSS for light touch redesign
GitOrigin-RevId: 574f813a9964a272742507817732c1b45bbdc2fe
2024-06-27 08:04:56 +00:00
Jessica Lawshe
07d1f26731
Merge pull request #19084 from overleaf/jel-light-touch-rename-css
...
[web] Rename CSS variables for light touch redesign
GitOrigin-RevId: c84eb75a45af8270895795ceffef944696037881
2024-06-27 08:04:52 +00:00
Jessica Lawshe
90d7925a02
Merge pull request #18961 from overleaf/jel-new-plans-spacing
...
[web] Update main container spacing for new plans page
GitOrigin-RevId: b6c8fa852ba2025c78f6daa22146854fc6a13789
2024-06-27 08:04:48 +00:00
Jessica Lawshe
fbc9a557c7
Merge pull request #18959 from overleaf/jel-faq-tabs
...
[web] New tab and accordion more reusable
GitOrigin-RevId: ed8340bc4b6312c4270edf1edf53c74a067aaccf
2024-06-27 08:04:44 +00:00
Jimmy Domagala-Tang
c04fea0fd3
Merge pull request #19162 from overleaf/jpa-flaky-admin-test
...
[web] refresh system message cache after creating/deleting message
GitOrigin-RevId: f7155e94a8bf08b527e7ae69d9d6a41e54c01282
2024-06-27 08:04:39 +00:00
Jimmy Domagala-Tang
2e1dcee22b
Merge pull request #19128 from overleaf/jdt-latex-2024-release
...
updating to remove alpha only and release 2024 latex
GitOrigin-RevId: 4333b5d4331213206d273a6cbb0cb790ad2778f6
2024-06-27 08:04:35 +00:00
Mathias Jakobsen
abaf07a8bb
Merge pull request #19158 from overleaf/mj-commands-autocomplete-optional-args
...
[web] Avoid double counting optional arguments for autocomplete
GitOrigin-RevId: 7abdc73657791b945bd5a7a9e29f5cd127c7882b
2024-06-27 08:04:31 +00:00
David
1844603a2d
Merge pull request #19124 from overleaf/dp-light-hover-bug
...
Refactor pdf toolbar button styles to fix bug with hovering over active logs button
GitOrigin-RevId: f8034c9daade32cda7c4f08ccd292c86ef6b8454
2024-06-27 08:04:27 +00:00
David
74b1ebac02
Merge pull request #19064 from overleaf/dp-create-project-dropdown-ui
...
Add spacing above create-new-project-dropdown and make thinner
GitOrigin-RevId: a1f3a27512e04ec6e4383493d5ceaf39e5ad9eee
2024-06-27 08:04:22 +00:00
Jakob Ackermann
0b6a8dc093
Merge pull request #19160 from overleaf/jpa-jammy-1-0-4
...
[server-ce] bump base image to jammy-1.0.4
GitOrigin-RevId: 79cc27e4c628e50fb226a32278be1768001f343b
2024-06-26 11:12:47 +00:00
Thomas
94be372b24
Add new interstitial 'Join project' consent page for existing link sharing editors when opening a project ( #19066 )
...
* Add helpers for checking and removing user readwrite token membership
* Add sharing-updates page and handlers
* Redirect read write token members to sharing-updates on project load
GitOrigin-RevId: d552a2cd74a9843c6103923b03f137131a48877a
2024-06-26 11:12:42 +00:00
Thomas
260fdf1307
Add read write token join interstitial variation for link sharing changes ( #19060 )
...
* Add read write join interstitial variation for link sharing changes
GitOrigin-RevId: 41661f43f4ab0f18f6ada5bec0b6af2407f65f07
2024-06-26 11:12:37 +00:00
Thomas
70bf7b2aab
Merge pull request #19109 from overleaf/tm-project-joined-add-project-id
...
Add projectId to project-joined event
GitOrigin-RevId: 222e0acc8764592344e384d1a6a5a2327d4161f5
2024-06-26 11:12:33 +00:00
Mathias Jakobsen
d21da7d084
Merge pull request #19157 from overleaf/mj-separate-unknowncommands
...
[lezer] Separate unknown commands for definition fragments
GitOrigin-RevId: 21ce8d03e68f4af13c3937b4b5fd6f7ed0e50995
2024-06-26 11:11:53 +00:00
Mathias Jakobsen
3b5af94404
Merge pull request #19119 from overleaf/mj-lezer-definition-unknown-commands
...
[lezer] Parse unknown commands in definitions
GitOrigin-RevId: 586bf9e0de8e1d9e7903dd2fad8638cb2624ed9e
2024-06-26 11:11:48 +00:00
Alf Eaton
26d7524c93
Updates to the AI error assistant ( #19107 )
...
GitOrigin-RevId: 7ffc1e32d331fa8bab1ea25919e706bf8b59800f
2024-06-26 11:11:44 +00:00
Alf Eaton
dfaed70297
Replace symbol palette tabs with a custom tablist ( #19034 )
...
GitOrigin-RevId: 69d8a8dd8980e287b484b915b1f92e57af5324cb
2024-06-26 11:11:35 +00:00
Antoine Clausse
de959fb7b9
Fix institution metrics sendAll cron ( #19127 )
...
* Don't send status 200 in the beginning: we may throw later
This was causing `Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client`
https://cloudlogging.app.goo.gl/Bchegw2iCYLxhPNk8
* Continue when failing to send one email, but log the error
* Revert "Don't send status 200...", log error instead
This reverts commit 3e13559704f822e330a18a68567f46491649f222.
* Fix `logger.error` params
* Fixup: good syntax for `logger.error`
* Remove useless `OError` import
* Update services/web/modules/metrics/app/src/MetricsEmailController.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Update services/web/modules/metrics/app/src/MetricsEmailController.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Update services/web/modules/metrics/app/src/MetricsEmailController.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Update services/web/scripts/recurly/collect_paypal_past_due_invoice.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
---------
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: c68bc677326729fc6c39b7c2f027e35ebb776bd2
2024-06-26 08:05:11 +00:00
Antoine Clausse
fc34b41b5b
[web] Promisify two-factor-authentication ( #19004 )
...
* Fixup typos
* Promisify `getPendingUser`
* Promisify `getPendingUserWithExpectations`
* Add promises to `AccessTokenEncryptor`
* Promisify `TwoFactorAuthenticationHandler`
* Promisify/Expressify `TwoFactorAuthenticationController`
* Centralise `unprocessableEntity` error handling into a function
* Fixup: entralise `unprocessableEntity` error handling into a function
Avoid "responding to the query twice"
* Remove unnecessary try/catch
* Fixup: Add `async` to AccessTokenEncryptor promises
* Add tests on `AccessTokenEncryptor.promises`
* Revert "Fixup: entralise `unprocessableEntity` error handling into a function"
This reverts commit 23bd9d73260733062908b98961846733c61171e9.
* Revert "Centralise `unprocessableEntity` error handling into a function"
This reverts commit 197ca3da02412d5224d411b29df1d7b9e5327d01.
GitOrigin-RevId: 1a2864d28e87fd5e48cd3723a3da8047b79a1596
2024-06-26 08:05:06 +00:00
CloudBuild
375ff968c5
auto update translation
...
GitOrigin-RevId: c597b7ebda7a250220e7227211d7f3cd64816b90
2024-06-26 08:05:02 +00:00
Jimmy Domagala-Tang
50b19c7793
Merge pull request #18850 from overleaf/ac-promisify-resync-subscriptions
...
Promisify resync_subscriptions
GitOrigin-RevId: c23a99683a22104815525b179d4e46d3ad568f94
2024-06-26 08:04:57 +00:00
Jimmy Domagala-Tang
86e2abc90b
Merge pull request #19106 from overleaf/jdt-center-labels
...
vertically align text within spans
GitOrigin-RevId: 820313b179751a1a7c538712cf9dfd6b9ce0ff3d
2024-06-26 08:04:52 +00:00
Jimmy Domagala-Tang
b0344ec550
Merge pull request #19132 from overleaf/jdt-ai-policy-migration
...
feat: add migration for adding new policy to all existing groupPolicies
GitOrigin-RevId: ea3188b6059c2e96afd0058a191d18b26d68adbd
2024-06-26 08:04:48 +00:00
roo hutton
e0c879bd9a
Merge pull request #19120 from overleaf/rh-link-share-styles
...
[web] Fix share modal styling regressions
GitOrigin-RevId: efeffa3d6451ed47137106e0ad296c518a5c0608
2024-06-26 08:04:43 +00:00
roo hutton
bf90932f40
Merge pull request #18936 from overleaf/rh-viewer-no-comment
...
[web] Remove access to commenting/chat for collaborators with Viewer permission
GitOrigin-RevId: 03957cb8c04866318a4b94bdb72843e7d7a5a003
2024-06-26 08:04:38 +00:00
Jakob Ackermann
ce9b531892
Merge pull request #19098 from overleaf/jpa-graceful-shutdown-tests
...
[server-ce] add test for graceful shutdown
GitOrigin-RevId: 5e72e0073169009d2e3ece5a79cbd62051f6ad5b
2024-06-25 11:12:43 +00:00
Tim Down
956aad7e43
Merge pull request #18764 from overleaf/td-bs5-dashboard-feature-flag
...
Create new feature flag for BS5 project dashboard page
GitOrigin-RevId: a523bd7df94c411805ac2f5234135bc7a56d25bb
2024-06-25 11:12:35 +00:00
Tim Down
8897e439ae
Merge pull request #18928 from overleaf/td-bs5-nav-admin-missing-href
...
Bootstrap 5: add missing href to nav admin link
GitOrigin-RevId: 5339fa2ef465a6319d87cba6201e682dea1a98a6
2024-06-25 11:12:31 +00:00
David
62c432b997
Merge pull request #19101 from overleaf/dp-presentation-additional-keys
...
Add PageUp/PageDown/Backspace options for presentation page navigation
GitOrigin-RevId: 59b8c3b22ff205c8fe1009c120358c913db3cbe5
2024-06-25 11:12:27 +00:00
David
b2e3002992
Merge pull request #19103 from overleaf/dp-presentation-events
...
Add event for entering presentation mode
GitOrigin-RevId: 6d9006005264f69d1a37baa363b338caf0d29c6c
2024-06-25 11:12:23 +00:00
Mathias Jakobsen
ddfdafd54c
Merge pull request #19050 from overleaf/mj-lezer-parse-comments-in-unknown-commands
...
[lezer] Introduce hasMoreArguments token for argument parsing
GitOrigin-RevId: a5898a2be01c19a39de15c784f184fe61140799a
2024-06-25 11:12:18 +00:00
Mathias Jakobsen
46a160f127
Merge pull request #19072 from overleaf/mj-known-commands-reuse
...
[web] Parse known commands in math mode
GitOrigin-RevId: e7937fc46320f13c716d1612eca36aa67c8fb967
2024-06-25 11:12:14 +00:00
Mathias Jakobsen
283c972842
Merge pull request #19032 from overleaf/mj-lezer-mathdelim
...
[lezer] Remove custom tokeniser for MathDelimiter
GitOrigin-RevId: acbbbe439d51a8a9d5b30b91c55c8f8ef8c3b9fb
2024-06-25 11:12:10 +00:00
Mathias Jakobsen
884eebd82d
Merge pull request #19102 from overleaf/mj-more-cite-ref
...
[lezer] Add more cite and ref command variants
GitOrigin-RevId: e402f92d9948eba857dbe0851f039f4d7313df81
2024-06-25 11:12:06 +00:00
Mathias Jakobsen
e48e4293a6
Merge pull request #19090 from overleaf/mj-web-metadata
...
[web] Ignore commented content when parsing metadata
GitOrigin-RevId: 78f9b0d6549e60fca4ba8929beb677341d885655
2024-06-25 11:12:02 +00:00
roo hutton
64d9792fe3
Merge pull request #18861 from overleaf/rh-editor-limit-exceeded
...
[web]: Handle exceeded editor limit in share modal
GitOrigin-RevId: 23a15805ca98327ae4a7fc731bbca3982c90bad5
2024-06-25 08:04:46 +00:00
Jimmy Domagala-Tang
04432478e1
Merge pull request #19053 from overleaf/ab-split-tests-first-time-assignments
...
[web] Return isFirstTimeAssignment flag with split test assignments
GitOrigin-RevId: 70954470fbd9430749d83d8d1e08a3969d4a09e6
2024-06-25 08:04:37 +00:00
Alf Eaton
6db455d63e
Show modal for error renaming project ( #19040 )
...
GitOrigin-RevId: 229e64775897d646ed8c13f12d3bcc9400f2a3b9
2024-06-24 12:05:59 +00:00
Alf Eaton
bee698c01d
Updates to the AI error assistant ( #19065 )
...
* Only show the AI error assistant to users with write permission on the project
* Fix line number in searchDocLines
* Abort the request after 60 seconds
* Move comment
* Jump to file + line when suggestion line number is clicked
* Set tool_choice: 'required'
* Fix handling of suggestLineChange
* Tidy up getDocLines
* Avoid showing Suggest Fix button in gutter marker for typesetting warnings
* Log request errors
* Fix prefixed function name
* Update tool description
* Tweak the prompt in an attempt to improve the line number
* Reject if the total message content is too large
* Change the structure of the suggested change
* Reduce line highlight
* Fix change highlighting on deletion
GitOrigin-RevId: afde096e547050b8518195ef51b68983bc3b0be3
2024-06-24 12:05:51 +00:00
Miguel Serrano
1697087425
Merge pull request #18970 from overleaf/msm-clean-features-templates
...
[web] Cleanup `features.templates`
GitOrigin-RevId: 7c9f7bc827700e4255a5ba8a46de70318afdaae4
2024-06-24 12:05:43 +00:00
David
8d2b006d60
Merge pull request #19070 from overleaf/dp-remove-useWaitForGrammarlyCheck
...
Remove grammarly check in writefull promo
GitOrigin-RevId: 30994c1960232afe3bede1fd6649606e191dd3d4
2024-06-24 12:05:35 +00:00
Davinder Singh
c70e676cbc
Merge pull request #19035 from overleaf/plans-list-mobile
...
[web] Begin configured features list for new plans page mobile view
GitOrigin-RevId: ba09f1a2e24f3a2eec4b20e55a0afada9e359264
2024-06-24 12:05:30 +00:00
Mathias Jakobsen
23a7e19e8e
Merge pull request #18991 from overleaf/mj-table-generator-promotion-teardown
...
[web] Tear down table generator promotion
GitOrigin-RevId: 361215bdd792042ae68762fa20ae60286db5bab3
2024-06-24 12:05:18 +00:00
Mathias Jakobsen
bc9bb05c8f
Merge pull request #19033 from overleaf/mj-lezer-unused-rule
...
[lezer] Remove unused rule
GitOrigin-RevId: 53402a3004d0ca781b29f16eaf4e7eae086450d3
2024-06-24 12:05:14 +00:00
