Commit graph

53 commits

Author SHA1 Message Date
ilkin-overleaf
5c3d9117c5 Merge pull request #21240 from overleaf/ii-bs5-review-panel-old
[web] BS5 review panel old

GitOrigin-RevId: da018b8f2946afb21ab63da0003453e20781f04c
2024-10-24 08:05:41 +00:00
Alf Eaton
2304536844 Add review panel context providers and components (#19490)
* Tidy up review panel components

* Add ReviewPanel providers

* [web] new design for review panel track change (#19544)

* [web] new design for review panel track change

* fixed mini view

* mini icon style change

* fix icon size

* format date

* useRangesUserContext hook

* remove useRangesUserContext hook

* using full class names

* fix action icons hover

* change wording for tooltips

* added ReviewPanelChangeUser component

* Update header in new review panel

* Extract ReviewPanelTrackChangesMenuButton as a separate component

* Remove wrapper div

* Replace h2 with div for review panel label

* Rename ReviewPanelTools to ReviewPanelHeader

* Rename trackChangesExpanded -> trackChangesMenuExpanded

* Dont break memoisation of ReviewPanelTrackChangesMenuButton

* Fix the width of the track changes arrow icon

* Update how prop types are declared

* Remove new empty state from old review panel

* Add empty state to new review panel

* Add project members and owner to ChangesUsers context (#19624)

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

* Redesign comment entry in review panel (#19678)

* Redesign comment entry in review panel

* ReviewPanelCommentOptions component

* remove unused prop

* Tidying

* Add conditional import

* Optional changeManager

* Add more split test compatibility

* More split test compatibility

* Fixes

* Improve overview scrolling

* Fix overview scrolling

* Fix & simplify track changes toggle

* Fix overview scrolling

* Fix current file container

* ExpandableContent component for messages in review panel (#19738)

* ExpandableContent component for messages in review panel

* remove isExpanded dependancy

* Delete comment option for new review panel (#19772)

* Delete comment option for new review panel

* dont show thread warning if there are no replies

* fix hasReplies issue

* Implement initial collapsing overview files

* Fix positioning of overview panel

* Small styling changes

* Add count of unresolved comments and tracked chanegs

* More style adjustments

* Move review-panel-overview styles into css file

* Remove unused var

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
Co-authored-by: David Powell <david.powell@overleaf.com>
Co-authored-by: David <33458145+davidmcpowell@users.noreply.github.com>
GitOrigin-RevId: e67463443d541f88445a86eed5e2b6ec6040f9c7
2024-08-13 08:04:20 +00:00
David
4b708613b6 Merge pull request #19381 from overleaf/dp--review-panel-css-clean-up
Clean up some old review panel css

GitOrigin-RevId: eb88bfbfa6679787d06f6c2a7d28b9fafb846195
2024-07-15 09:32:50 +00:00
David
0c7a32b4f2 Merge pull request #19346 from overleaf/dp-review-panel-empty-state
Add empty state to review panel

GitOrigin-RevId: 47d7b676e9868942567fc02db234b0827ac86ba3
2024-07-15 09:04:27 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
2024-03-26 09:04:05 +00:00
ilkin-overleaf
fa314fe5b0 Merge pull request #16509 from overleaf/ii-rp-update-entry-positions
[web] Review panel entry positions and long user names

GitOrigin-RevId: 3a596bd90bab2c87b2efae5eb812ffc5e5a1580f
2024-01-19 09:05:28 +00:00
David
5412b9b923 Merge pull request #16439 from overleaf/dp-resolved-comments-button-contrast
Add explicit background color for resolved-comments-toggle to fix contrast on safari

GitOrigin-RevId: 19876b85be29604af73c4e90c8a91f3cf8c98228
2024-01-12 09:03:13 +00:00
ilkin-overleaf
5e7665e322 Merge pull request #16162 from overleaf/ii-ide-page-prototype-review-panel-issues-1
[web] Review panel editor widgets fix

GitOrigin-RevId: a762ce3983fd7a3a99b8be5647baea4f8a0bb76c
2023-12-18 09:03:49 +00:00
ilkin-overleaf
456d831eab Merge pull request #16188 from overleaf/ii-rp-collapse-height
[web] Review panel comment container fix

GitOrigin-RevId: 0577949e711046303d25ba7e724564227d4a1bc7
2023-12-14 09:03:30 +00:00
Alf Eaton
9875e55a27 Remove Ace (#14299)
GitOrigin-RevId: ec8788fdbc8aea73ca33ec2810f4e588fe9476b5
2023-11-29 09:04:08 +00:00
Tim Down
9f80dd48e8 Merge pull request #15814 from overleaf/td-review-panel-indicator-hover
Fix review panel comment hover bug

GitOrigin-RevId: ddd6f8f073a2af189c990c8942a388cae412f8c6
2023-11-22 09:04:48 +00:00
Tim Down
5cce9683fa Merge pull request #14628 from overleaf/td-review-panel-scroll-jump
Fix scroll jump and improvements to React review panel layout and performance

GitOrigin-RevId: 3123f90abeb1bf9712ba4025a272e13990aebbd9
2023-09-06 08:06:32 +00:00
Alf Eaton
c8f0885316 Remove CM5 Rich Text module (#11776)
GitOrigin-RevId: 812d3b5f1df7e769c8be732ccb31653e8e9a8aa3
2023-08-16 08:03:35 +00:00
Tim Down
e7479c789f Merge pull request #14055 from overleaf/td-review-panel-editor-horizontal-scroll
React review panel: prevent horizontal scrollbar

GitOrigin-RevId: b79b03e6a69b26bda58d8585adc14b351b2e6f86
2023-07-28 08:04:06 +00:00
Tim Down
ac919ed21a Merge pull request #14046 from overleaf/td-review-panel-scrolled-down-layout
React review panel: fix bug that prevented entries appearing when editor starts off scrolled down

GitOrigin-RevId: 61c5b5523e82cf5334c4de30d6849f45d5bc321a
2023-07-28 08:04:02 +00:00
Tim Down
48ee03bcb3 Merge pull request #13995 from overleaf/ii-rp-editor-widgets-top-position-fix
[web] Review panel editor widgets placement fix

GitOrigin-RevId: d3f4b79518c0cfac7ce70f75f9f0b40c6b6d3db9
2023-07-25 08:04:03 +00:00
Tim Down
f2b5ac23f8 Merge pull request #13997 from overleaf/td-review-panel-mini-hover
React review panel: make hovering an entry in the mini review panel display correctly

GitOrigin-RevId: 41a40e4047b89d2a8db15b2e12baf04c11b78e21
2023-07-25 08:03:55 +00:00
Tim Down
752ad8870d Merge pull request #13923 from overleaf/td-review-panel-non-sticky-toolbar-nav
Make toolbar and nav non-sticky in React review panel overview mode

GitOrigin-RevId: feb2950698512120a676a597f0edfa7ba615f934
2023-07-21 08:04:57 +00:00
Tim Down
0d3af56efa Merge pull request #13911 from overleaf/td-review-panel-performance
Review panel: memoize entry views for performance

GitOrigin-RevId: 3c305845ad0914a7ffeb595e7235d7dceb4c780a
2023-07-21 08:04:49 +00:00
Tim Down
38c673d057 Merge pull request #13720 from overleaf/td-review-panel-entry-pos
React review panel entry positioning

GitOrigin-RevId: c22617b1d3243b7d54b093426358aeb291421b9e
2023-07-19 08:03:52 +00:00
Tim Down
be7fd54257 Merge pull request #13856 from overleaf/td-review-panel-hide-empty
Prevent review panel toggler appearing when React review panel is hidden

GitOrigin-RevId: 740494a973f5ac221d484fb2be6b2ddd9b4833be
2023-07-17 11:08:42 +00:00
ilkin-overleaf
84bbdf9772 Merge pull request #13767 from overleaf/ii-review-panel-migration-in-editor-widgets
[web] Create in editor widgets

GitOrigin-RevId: 53dfb9935ee59bbdedc353aad5e5b19f389a513c
2023-07-17 11:07:06 +00:00
Alf Eaton
5236cb0ca1 Fix review panel position with new toolbar (#13759)
GitOrigin-RevId: d601ca23953b56b928b5050064100440c1335bba
2023-07-17 11:03:07 +00:00
Mathias Jakobsen
4ed5e01deb Merge pull request #13680 from overleaf/td-review-panel-right-pos
Remove gap on right-hand side of editor with React review panel

GitOrigin-RevId: 50d4af9419fcaa95aabf609d36ecaeea0ce45bbe
2023-07-17 10:57:32 +00:00
ilkin-overleaf
936ab81b65 Merge pull request #13641 from overleaf/ii-review-panel-migration-overview-view
[web] Create overview view shell for review panel

GitOrigin-RevId: 21cc8a744253aec53f089ec6e6c1221d7153f3a4
2023-07-17 10:50:58 +00:00
ilkin-overleaf
9e8be31bdf Merge pull request #13573 from overleaf/ii-review-panel-migration-comment-entry
[web] Create comment entries

GitOrigin-RevId: 7f3fbe672d18d57a0f5e683e5456ea79ed295e2d
2023-07-17 10:45:32 +00:00
ilkin-overleaf
b61ee4c4d3 Merge pull request #13528 from overleaf/ii-review-panel-migration-current-file-view
[web] Create initial current file container

GitOrigin-RevId: 81635922bb10b97637af296d987f28d43cf61262
2023-07-17 10:42:51 +00:00
ilkin-overleaf
423f2604db Merge pull request #13500 from overleaf/ii-review-panel-migration-nav
[web] Create review panel navigation

GitOrigin-RevId: abed4171e9fd52de2f137a6cf7456791bc2ca161
2023-07-17 10:39:20 +00:00
ilkin-overleaf
15f4e2e5cc Merge pull request #13487 from overleaf/ii-review-panel-migration-create-panel-toggler
[web] Create review panel toggler

GitOrigin-RevId: f50422b99dbd8bbc2f1fbf323419ee13403c9ba6
2023-07-17 10:36:11 +00:00
ilkin-overleaf
e514e97305 Merge pull request #13438 from overleaf/ii-review-panel-toolbar-shell
[web] Create review panel toolbar shell

GitOrigin-RevId: 561fb18e1239c9b96b52944716a83cf3b8606677
2023-07-17 10:34:04 +00:00
ilkin-overleaf
9b930d2849 Merge pull request #13414 from overleaf/ii-review-panel-migration-create-context-api-fix
[web] Create context api for review panel FIX

GitOrigin-RevId: fc6d8adf18d07e71b529a28deab4d49d62c43587
2023-07-17 10:32:07 +00:00
Alf Eaton
480ec139ab Merge pull request #13408 from overleaf/ae-revert-resolve-comment
Revert "create context api for review panel"

GitOrigin-RevId: 3be70d7afbe4f238a27149ab2de38175cf1bf029
2023-07-17 10:30:27 +00:00
ilkin-overleaf
1918ef3767 Merge pull request #13378 from overleaf/ii-review-panel-migration-create-context-api
[web] Create context api for review panel

GitOrigin-RevId: 3d550e2f3c14ecd0586d088f4ecb75acd44aa782
2023-07-17 10:29:53 +00:00
ilkin-overleaf
2fceaa6085 Merge pull request #13343 from overleaf/ii-review-panel-migration-create-feature-flag
[web] Create feature flag for review panel

GitOrigin-RevId: e7e83729a536dce1824f604fb66afe1785f4be25
2023-07-17 10:26:04 +00:00
Alf Eaton
85fbded781 Improve the Rich Text toolbar (#11616)
GitOrigin-RevId: d1999be629ac048058ffd82004865728796a3feb
2023-02-07 09:04:39 +00:00
Alf Eaton
cf8051dcad Advertise CM6 Rich Text in the CM5 track changes panel (#11361)
GitOrigin-RevId: 3d2e43263528c64292a01afb3d032e11a6cbbfb9
2023-01-24 09:04:13 +00:00
Tim Down
cbc3aef728 Merge pull request #10109 from overleaf/ds-switch-component
Modifying the Switch

GitOrigin-RevId: 93b8483aa4aa164ea0be5fc2b4ccc5cfb17eae3c
2022-11-02 09:04:07 +00:00
Tim Down
fef395f431 Fix layout shift by nearly always applying overflow-y hidden on review panel (#8174)
* Always hide vertical overflow on the review panel, not just when it's expanded, which prevents it scrolling slightly when scrolling the PDF in some circumstances
* Fix layout shift by always applying overflow-y hidden on review panel and make entry visible in minimized review panel by making the overflow visible while hovering over the entry

GitOrigin-RevId: 854ee47a762ee2cf78fbbb5856afddb3b723d679
2022-06-13 08:03:37 +00:00
Tim Down
c0292d96a1 Add vertical padding to CM6 editor content to deal with overflowing entries in the review panel (#8321)
GitOrigin-RevId: 9f8265dba773008ba8f97053ce66f23dc4b7121f
2022-06-13 08:03:32 +00:00
Alf Eaton
bdc503600c Move layout-left comment indicators above the review panel toggle bar (#8031)
GitOrigin-RevId: b6902c6d1a3f519aedbdc487801f114c2f57340c
2022-05-23 08:03:49 +00:00
Alf Eaton
69a2283984 Upgrade to webpack v5 (#7249)
GitOrigin-RevId: 69dc5f9aad3e045cc6904e3663e9965094eced76
2022-04-07 08:03:46 +00:00
M Fahru
7ee6b477e1 Merge pull request #7064 from overleaf/mf-comment-on-hover-not-visible
[web] fix comment is not visible while hovering the bubble icon on the project editor minimized review panel

GitOrigin-RevId: 8f20078fc554a4e2d4aae49174a7e1ab71dea592
2022-03-16 09:03:01 +00:00
M Fahru
7560404d93 Merge pull request #7045 from overleaf/mf-overflow-hidden-comment-editor
[web] Hide extra scrollbar on comment editor

GitOrigin-RevId: 63f751031c07330add8563a20cfe2ee1ddf8fb1f
2022-03-14 09:04:15 +00:00
M Fahru
0819b02e73 Merge pull request #6967 from overleaf/mf-limit-comment-reply-textarea-max-height
[web] fix over-scrolling behaviour on editor under certain circumstances

GitOrigin-RevId: 640fd79c95fc38a3a373a3ea116d07b9256e5c6f
2022-03-10 09:03:44 +00:00
Timothée Alby
8ca159b4b9 Merge pull request #5797 from overleaf/ta-pdf-detach
PDF Detach

GitOrigin-RevId: f69d8a87d1ba2115ad496a719106dfc7707a6ed5
2021-11-16 09:02:57 +00:00
Alexandre Bourdin
57cd6b4754 Merge pull request #3843 from overleaf/ab-comment-linebreak
Add CSS property to display line-breaks in review comments

GitOrigin-RevId: aa499556c0c50d042450e0421a55d51c9a097a29
2021-03-31 02:05:01 +00:00
Alexandre Bourdin
cb19041b7f Merge pull request #3736 from overleaf/ab-review-icon-light
Invert review icon color when selected

GitOrigin-RevId: e6e0d76c969d52e1632ea486042c353a0c77d0b4
2021-03-11 03:05:18 +00:00
Alf Eaton
2ff1cf43d6 Merge pull request #3470 from overleaf/eslint
Upgrade and configure ESLint

GitOrigin-RevId: ad5aeaf85e72c847a125ff3a9db99a12855e38aa
2020-12-16 03:08:28 +00:00
Jessica Lawshe
76cbf9949f Merge pull request #3396 from overleaf/jel-match-grays
Improve editor color contrast and remove light theme blue-gray colors

GitOrigin-RevId: acc5659c41201fce47e9ff03531cb51bfbf590bc
2020-12-01 03:04:34 +00:00
Paulo Jorge Reis
619ec15309 Add first error popup (#3369)
* Add first error popup

* Address PR feedback

GitOrigin-RevId: e924b3e6096584de6f363aae70a62328cd3de83d
2020-11-17 03:04:11 +00:00