Commit graph

17 commits

Author SHA1 Message Date
David
7c613cdceb Merge pull request #21438 from overleaf/dp-edit-comment-popover
Dont select entry from textarea when review panel is mini

GitOrigin-RevId: 5900ae11ec01bb40100e19497557469e6dac1615
2024-10-29 09:05:53 +00:00
David
9d62c620fd Merge pull request #21410 from overleaf/dp-mini-panel-click
Prevent clicking on mini review panel entry popovers from opening the full panel

GitOrigin-RevId: a81ed154307750a756931d9fe5e893cd30d40c55
2024-10-29 09:04:56 +00:00
Domagoj Kriskovic
29c5bc8206 Focused and selected states for ReviewPanelEntry (#21354)
GitOrigin-RevId: 41e5ed1110d71eae51cbbde1e874dda133d666c8
2024-10-28 09:05:34 +00:00
Domagoj Kriskovic
332e2a38c9 Fix review panel entry focus handler (#21075)
* Fix review panel entry focus handler

* dont check position

* remove event.target checks

* Revert "remove event.target checks"

This reverts commit 3f511e47b6922260666c6952b692f6f0a29d5912.

GitOrigin-RevId: 9271df9cdb36a040d59a97c88f21d6e923ac0404
2024-10-22 08:05:33 +00:00
Domagoj Kriskovic
e00831761a Fix "update in progress" error when removing highlight ranges (#21024)
GitOrigin-RevId: 025e69f10b6010fe978ac57838ae17c113358633
2024-10-14 11:10:09 +00:00
Domagoj Kriskovic
4a3eed35d6 Fix accept changes request for new review panel (#20956)
* Fix accept changes request for new review panel

* Implement pessimistic UI updates for new review panel (#20986)

* Implement pessimistic UI updates for new review panel

* deleteThread, reopenThread handlers

* use finally

* handleSubmit in useCallback

GitOrigin-RevId: 358181a6b5601ad1b3579e001564dfa4da67a81d
2024-10-14 11:08:44 +00:00
David
42a199043a Skip ReviewPanelEntry focus event if target is anchor element (#20928)
GitOrigin-RevId: e6ad0ca7c03de2ef176b6328c27dd0afa10bd102
2024-10-14 11:08:39 +00:00
David
d9211998de Merge pull request #20887 from overleaf/dp-rp-entry-buttons
Don't focus entry if clicking on a button/link

GitOrigin-RevId: 0c37ce76134358ef7d3fd5b0c897ffab8e4d7db1
2024-10-14 11:05:48 +00:00
David
a40fb42fed Merge pull request #20712 from overleaf/dp-click-mini-panel
Clicking on an entry in the mini review panel opens the full panel

GitOrigin-RevId: 4c925435a09f56ae5b02c53951185c67eb0413a2
2024-10-14 11:02:44 +00:00
David
4480a986a3 Merge pull request #20785 from overleaf/dp-sticky-highlights
Clear op highlight on review-panel-entry dismount

GitOrigin-RevId: 9892df75f35fcb0440bd19bcfbaa276a3db033a1
2024-10-14 11:02:35 +00:00
David
2117bfe29d Merge pull request #20541 from overleaf/dk-delete-widgets
Handle highlight/focus effects for track deletes in new review panel

GitOrigin-RevId: 102eed9e8af04599823c1bcf0598a0328901bdba
2024-10-14 10:59:47 +00:00
Alf Eaton
c6633632d6 Move CodeMirror contexts into a separate file (#20643)
GitOrigin-RevId: 8425454a75ff8160a03fda1be5bda2242b41f6cd
2024-09-30 08:04:48 +00:00
David
2801b3baad Merge pull request #20583 from overleaf/dk-review-gotoposition
Goto position when clicking on review entry in Overview tab

GitOrigin-RevId: 17c9cefed339537afa994778ffbc01cfb294bf46
2024-09-27 08:04:34 +00:00
David
af6ffdcf7c Merge pull request #20409 from overleaf/dk-selectLineOnFocus-fix
Fix scroll issue when focusing a change in new review panel

GitOrigin-RevId: 55784de415f65935ad9b1a8cd3ad82ea3ddac3c1
2024-09-20 08:05:17 +00:00
David
22e4c2de2c Merge pull request #20411 from overleaf/dk-highlight-focus-ranges
Highlight and focus ranges in editor for new review panel

GitOrigin-RevId: 4fef31a8c9e6dc974519d925c7478665e0c8cc29
2024-09-20 08:05:13 +00:00
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
Domagoj Kriskovic
ad7abee39a Remove extra padding for off-screen review panel entries (#19841)
* Remove extra padding for off-screen review panel entries

* use document.activeElement

* cleanup editor padding cases

* using isSelectionWithinOp

* fix formatting

* focusHandler function

* 1px border for focused entry

* use constants

* using isFirstEntry

GitOrigin-RevId: 4509f803b6cb907b40f1745a6fc7f3b1edfe145c
2024-08-16 08:04:22 +00:00