Commit graph

319 commits

Author SHA1 Message Date
Eric Mc Sween
6061e09ab9 Merge pull request #7180 from overleaf/em-missing-pdf-download-domain
Handle missing PDF_DOWNLOAD_DOMAIN setting

GitOrigin-RevId: 3f022ec1637f7f38ca98503b1ab08748f6bbf87d
2022-03-24 09:03:57 +00:00
Timothée Alby
ac3eb878d6 Merge pull request #7172 from overleaf/ta-pdf-viewer-backdrop-hide
Fix Logo Backdrop in PDF Viewer

GitOrigin-RevId: ae9eb98dc8a51a882354b6ddea095df2bed51346
2022-03-24 09:03:44 +00:00
ilkin-overleaf
57e60c05ca Merge pull request #7066 from overleaf/ta-synctex-disable-multi
Disable Synctex Controls for Docs and Multiselections

GitOrigin-RevId: 9f14e68228f9aa13a4188918930fc8cdb5eefabf
2022-03-22 09:03:21 +00:00
Alf Eaton
65e71714b8 Upgrade pdf.js via split test framework (#7053)
GitOrigin-RevId: dffe1f5bec07cba0914e3bd18ff5332dfe204f33
2022-03-21 09:03:16 +00:00
Alf Eaton
9d9bf8b9d0 Import Promise.allSettled from core-js (#7099)
GitOrigin-RevId: e7c1da844c3c7e8caec386b06f3b8393ea79529c
2022-03-21 09:03:07 +00:00
June Kelly
1fc13e6549 Merge pull request #7036 from overleaf/ta-go-to-pdf-hide-logs
Hide Logs When Highlighting PDF Location

GitOrigin-RevId: cdf22393b1dde5eb842cf0f8b2d7d8c408bc8eca
2022-03-16 09:03:11 +00:00
Alf Eaton
9f969d07e0 Delete unused PDF-related code (#6334)
* Remove new logs UI code
* Remove unused preview components
* Move metrics file
* Remove Angular PDF controllers
* Move the service worker util functions
* Remove the ide/pdfng folder
* Remove vendored pdf.js
* Remove showNewPdfPreview
* Use mockCompile
* Remove split test code

GitOrigin-RevId: 723b7440c62cda51f6ad8bb9c691900882166d21
2022-03-16 09:03:04 +00:00
Timothée Alby
9ba3f04491 Merge pull request #7002 from overleaf/ta-compile-dropdown-button-not-disabled
Don't Disable Dropdown Button When Compiling

GitOrigin-RevId: 099ddae07c7601016103514168eef80712ccc57f
2022-03-07 09:03:01 +00:00
Timothée Alby
5ba970b81e Merge pull request #6986 from overleaf/ta-compile-button-disabled
Disable Compile Button when Compiling

GitOrigin-RevId: c25cbaab3547695919ba62385cffef2a44665fec
2022-03-04 09:03:37 +00:00
Miguel Serrano
a3b01659a4 Fix isRequired error in GoToCodeButton.propTypes (#6646)
Skip `PdfSynctexControls` rendering until `position` is set

GitOrigin-RevId: ea40c7f98ea3bbdf3d8689175658d2c014b68436
2022-02-16 11:38:02 +00:00
Alf Eaton
f065a7a909 Improve the Icon component (#6245)
GitOrigin-RevId: fbb23b32c47edbe5a22badc627318accbd09e82a
2022-01-20 09:03:58 +00:00
Alf Eaton
1dd62570a6 Merge pull request #6390 from overleaf/ae-is-visible-binary
[web] Only run updateOnResize when the PDF viewer is visible

GitOrigin-RevId: 90b5632f45406b66af7710c6e8346cf73ffbebea
2022-01-20 09:03:28 +00:00
Jakob Ackermann
5a7698ddef [web] refactor updating of scroll position in pdf view
Co-Authored-By: Timothée Alby <tim.alby@overleaf.com>
GitOrigin-RevId: 932c880bcd41e68d231928bdcbbaeb06c60f6fd5
2022-01-14 09:03:28 +00:00
Miguel Serrano
56d826f255 Force Promise.allSettled polyfill (#6192)
* Force `Promise.allSettled` polyfill

`Promise.allSettled` is required by `pdf.js`, but the polyfill is not available in the bundle. This forces babel to include the polyfill without having to process `pdf.js` with webpack/babel, which causes issues loading documents.

* Updated core.js version for test config

GitOrigin-RevId: 981da187352ffc8c59cb77ba55a0a9643bd7cc9a
2022-01-12 09:04:06 +00:00
Miguel Serrano
35396ab61a Add limit to log parsing for react log viewer (#6213)
* Add limit to log parsing for react log viewer

GitOrigin-RevId: e2e5ffd6eaf1c207cc4f49fb5c637457990c328e
2022-01-12 09:03:59 +00:00
Thomas
3f05f7f283 Merge pull request #6294 from overleaf/ta-synctex-detach-icon
Remove Arrows from Synctex Button in Detach Mode

GitOrigin-RevId: 0b96ed29fd43308383c1db658f1d8d5143e3dd23
2022-01-12 09:03:28 +00:00
Timothée Alby
6319455e91 Merge pull request #6236 from overleaf/ta-project-context-strict
Strict Project Context

GitOrigin-RevId: a0f7f2b3dcb29fbd0102dcb920cf5424a921d583
2022-01-11 09:05:03 +00:00
Timothée Alby
55829a3382 Merge pull request #6199 from overleaf/ta-pdf-detach-sync-to-entry
Make syncToEntry a Detach Action

GitOrigin-RevId: 92e92b770c4e2be5b001c083d2d490231a7fddfb
2022-01-11 09:04:33 +00:00
Alf Eaton
341d012cea Remove paywall-prompt event tracking from compile controller (#6241)
GitOrigin-RevId: cab36fd1f2a79166c39b801a29155f1ef64edc00
2022-01-11 09:04:07 +00:00
Alf Eaton
5b560ad8ab Only store/restore PDF scroll position when visible (#6218)
GitOrigin-RevId: c2023b5173fe4668f52da3e096c3dfc0124a7248
2022-01-11 09:03:55 +00:00
Alf Eaton
50df230846 [web] Upgrade Prettier to match version in monorepo root (#6231)
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
2022-01-11 09:03:23 +00:00
Timothée Alby
b11d4b002c Merge pull request #6056 from overleaf/msm-remove-unnecessary-pdf-event-tracking
Cleanup PDF Preview event tracking

GitOrigin-RevId: 8fadaee2759f60e70e27ac417593d35cc73e8b68
2021-12-22 09:03:27 +00:00
Timothée Alby
44eca312ff Merge pull request #6053 from overleaf/ta-pdf-detach-tests
PDF Detach Misc Tests

GitOrigin-RevId: 9615c8fdfd8964a9c63d7c91e4596d397a1d35dc
2021-12-15 09:04:46 +00:00
Timothée Alby
c1c0f1fe4a Merge pull request #6039 from overleaf/ta-synctex-cursor-position-init
Fix Cursor Position Tracking for Synctex

GitOrigin-RevId: 6df703812f3efa2163b953aab82f32e174919179
2021-12-15 09:04:33 +00:00
Miguel Serrano
48233cd593 Merge pull request #6027 from overleaf/ae-disabled-download-pdf-tooltip
Fix tooltip on disabled download PDF button

GitOrigin-RevId: d1814e75886d8a530331c3ded01499dcad8a4289
2021-12-08 09:03:16 +00:00
Miguel Serrano
9ce9b0e8d7 Merge pull request #6021 from overleaf/ae-pdf-preview-horizontal-scroll
[web] Store left offset of PDF position

GitOrigin-RevId: 77d6b52a8485a427bb59618bf42b5f4a300c260a
2021-12-08 09:03:05 +00:00
Miguel Serrano
e8c645bf28 Using uuid for compilation logs (#6003)
GitOrigin-RevId: 96646870da597881a6e8b26564be4dee26385bb8
2021-12-08 09:03:02 +00:00
Jessica Lawshe
994b34bb2d Merge pull request #5981 from overleaf/jel-synctex-bug
Fix postMessage error for PDF detach SyncTeX

GitOrigin-RevId: 701e92ca3d6bc20a6069d5290ee52d9d2d8f63b4
2021-12-03 09:04:15 +00:00
Alf Eaton
d7efa156f9 [web] Account for page border when restoring scroll position in PDF preview (#5955)
GitOrigin-RevId: a5c74151e085db2e413ff27b46c67bff8c28487f
2021-12-03 09:03:50 +00:00
Timothée Alby
f6fc3d468c Merge pull request #5854 from overleaf/ta-pdf-detach-v2
PDF Detach Updates

GitOrigin-RevId: c09c4fe37a922b041cfa1376e110a264a88177c8
2021-12-01 09:03:41 +00:00
Alf Eaton
2e3f56c0d4 Check for the presence of window.ResizeObserver (#5924)
GitOrigin-RevId: d072c9313967b52370a870fc2d30b50c498d8d1d
2021-11-30 09:03:05 +00:00
Alf Eaton
bab4d5d58f Extend AUTO_COMPILE_DEBOUNCE to allow for increased SINGLE_USER_FLUSH_DELAY (#5883)
GitOrigin-RevId: f65113b2dea901fb757dafb08acc32c770960bf2
2021-11-26 09:03:21 +00:00
Miguel Serrano
9ce51f9f2f Prevent compilation request from being ignored in compiler.js (#5818)
GitOrigin-RevId: 1442ad0890b73134e6f563a1b474e4bc9e8a6ecd
2021-11-26 09:03:14 +00:00
Miguel Serrano
7de1e6f979 Update log error ordering and wording on tips (#5873)
* Show bibtex errors with compile errors
* Update wording on error log tips

GitOrigin-RevId: 0e25a05418b241526958016f1b525334d33ad741
2021-11-26 09:03:07 +00:00
Miguel Serrano
ec065147fb Ignore bib parse errors (#5874)
GitOrigin-RevId: 05c214762585b4d3d35ed055e1764d472b9cc861
2021-11-26 09:03:01 +00:00
Timothée Alby
8ca159b4b9 Merge pull request #5797 from overleaf/ta-pdf-detach
PDF Detach

GitOrigin-RevId: f69d8a87d1ba2115ad496a719106dfc7707a6ed5
2021-11-16 09:02:57 +00:00
Alf Eaton
3feca1ffc6 Move symbol palette to module and add overlay (#5396)
GitOrigin-RevId: 649dd56aaecd60662bd2bf534bda323ee541874f
2021-11-11 09:03:05 +00:00
Miguel Serrano
83e0a0c29b Fix scrollIntoView for PDF highlights (#5723)
GitOrigin-RevId: c2196ca3e3eed14a48b827a27a13f13232bb4c00
2021-11-09 09:03:55 +00:00
Miguel Serrano
26eb5d7cdc Cleanup compile results on compilation error (#5663)
- pdfUrl, pdfDownloadUrl and log entries are now cleared up after a compilation error.

- Added a new hook, useScopeValueSetterOnly that limits how changes in React components are propagated to Angular. Since the compilation process happens entirely within compile-context it make sense that compilation results are solely managed by compile-context itself.

GitOrigin-RevId: 2003be03bab6753bb9a88194c7a6163cfd36f9c2
2021-11-04 09:04:05 +00:00
Miguel Serrano
a5fd363938 Protect pdf-js-wrapper from NPE error (#5658)
GitOrigin-RevId: 55bdc27afb7dd9ea55751ae0bd89a2498f9f2ce6
2021-11-04 09:03:58 +00:00
Alf Eaton
913a62fbc8 Migrate synctex controls to React (#5503)
GitOrigin-RevId: 80362a00ae6b73616a6fa9b3193b9b9974b5fd35
2021-10-22 08:03:43 +00:00
Alf Eaton
684efaaf5f Use pdfDownloadDomain when fetching certain files in the new PDF preview (#5524)
GitOrigin-RevId: d8796d9f86ba87824438f4bd7dcb1a79643654c3
2021-10-22 08:03:36 +00:00
Alf Eaton
2bf422b76d Merge pull request #5522 from overleaf/ae-compile-feature-flag
Only use the React compiler when showNewPdfPreview is set

GitOrigin-RevId: 24bf8dc6a830e670ee8dc30b8e0329127de1a1a8
2021-10-22 08:03:31 +00:00
Alf Eaton
dd5bcd6098 Merge pull request #5521 from overleaf/ae-remove-stop-compile-button
Remove "Stop compiling" action from Recompile button in new PDF preview toolbar

GitOrigin-RevId: a4c90ec7d6213c49e11f13f045354ce66f2e9a8b
2021-10-22 08:03:28 +00:00
Alf Eaton
bd3d0d124d Merge pull request #5520 from overleaf/ae-log-entry-height
Fix log entry height in new PDF preview

GitOrigin-RevId: a9b7cae352da87f391c66720b109e3d9fd00fe52
2021-10-22 08:03:24 +00:00
June Kelly
4f29ca5cbd Merge pull request #5395 from overleaf/msm-pdf-metrics
Added PdfJsMetrics to React PDF Viewer

GitOrigin-RevId: ff749d67baec243ca2c8e51409754716f4cef62c
2021-10-21 08:03:07 +00:00
Alf Eaton
89dfcaf528 Finish migrating to PdfLogEntry component (#5483)
GitOrigin-RevId: 93f1da35dbc80b317964133e0437373dd0af7933
2021-10-18 08:04:12 +00:00
Alf Eaton
9ffe28649c Improve rendering of errors from pdf.js (#5448)
GitOrigin-RevId: 69836ba213b124e2442b2d0083531dd95be2bf4e
2021-10-18 08:04:06 +00:00
Alf Eaton
7f5200da8c Report filtered pdf.js errors to Sentry (#5438)
GitOrigin-RevId: 7ab5a6fd61d271037ee33bbeadfad00b389812d6
2021-10-18 08:03:59 +00:00
Alf Eaton
4c25dcfb2b Disable overflow: scroll on the outer pdf.js element (#5446)
GitOrigin-RevId: 77485d0dd2af3e4dc6f86f322816e00beee9dfa9
2021-10-18 08:03:52 +00:00
Alf Eaton
61f466afc0 Ignore invalid synctex highlights (#5476)
GitOrigin-RevId: 9123a09502f17c1251995b2e7133b345db885107
2021-10-18 08:03:41 +00:00
Alf Eaton
09f3962ded Ensure that the TimeoutUpgradePrompt component returns null (#5482)
GitOrigin-RevId: 95e58537c82d9bedd055839cfb916a06c1ef96df
2021-10-18 08:03:34 +00:00
Alf Eaton
12eab99990 Migrate log entry component to new PDF preview (#5478)
* Migrate log entry component to new PDF preview
* Add a test for expandable log content

GitOrigin-RevId: 3e2154983c1ea03b5db44c87822e7043c4aa2cfe
2021-10-18 08:03:30 +00:00
Alf Eaton
f7ef2532e0 Handle PDF preview on toggle between split and full-width views (#5470)
* Only hide the compile logs pane when toggled off
* Handle PDF preview on toggle between split and full-width views

GitOrigin-RevId: 9ceca8a06a22abfa78f245e1ae5d24af98215906
2021-10-18 08:03:26 +00:00
Alf Eaton
2f835144c8 Upgrade pdfjs-dist to v2.10.377 (#5436)
* Upgrade pdfjs-dist
* Explicitly disable XFA in PDF.js

GitOrigin-RevId: 6987fe6e6f87a05d8f71d83a8b09b33caeade712
2021-10-13 08:03:45 +00:00
Alf Eaton
9c0b6f0fa7 Remove clsiserverid query parameter from compile request (#5408)
* Remove clsiserverid query parameter from compile request

* Rename buildQueryParams to buildPostCompileParams

GitOrigin-RevId: 4448179e910eeb664cece2b9384f8e7197f3185c
2021-10-13 08:03:14 +00:00
Alf Eaton
ce3b304ec8 Remove chktex fetching and parsing from migrated PDF preview (#5409)
GitOrigin-RevId: 3c6721a1272d809679ec1e2f2fcd1a7251e1321b
2021-10-13 08:03:08 +00:00
Alf Eaton
e26d47cb41 Add hybrid toolbar to migrated PDF preview (#5414)
GitOrigin-RevId: 6266028091229c819aee3c8d4bd3bff2e2417125
2021-10-13 08:03:01 +00:00
Alf Eaton
adf8828860 Fix a few minor test issues (#5415)
* Remove signal.abort()
* Fix usage of .toString
* Fix requests for files
* Fix story

GitOrigin-RevId: 37ab4be34a8975881aed2329d4b67f8df74837d8
2021-10-12 08:03:58 +00:00
Alf Eaton
845b2fbc04 Move useScopeValue hook to shared hooks folder and wrap setValue in a function (#5386)
GitOrigin-RevId: b1a6a4e871af3b52fb3d100a83b479c834cb75ca
2021-10-11 08:03:29 +00:00
Alf Eaton
165520a6f2 Refactor scoped layout values into LayoutContext (#5356)
GitOrigin-RevId: b0b07ddd078bfc5acd944cac14bc00dc83d09d21
2021-10-11 08:03:17 +00:00
Miguel Serrano
8766c45362 Add log limit and info notice to PDF Preview log view (#5390)
GitOrigin-RevId: 14764d109dbe13d7e4fb4f79f098c74d4b57d59d
2021-10-11 08:03:13 +00:00
Alf Eaton
ffc72416ff Move clsiServerId and compileGroup from ide to ide.$scope.pdf (#5314)
GitOrigin-RevId: 6050898614b4fc9dee52e893149acfda17c324a0
2021-10-11 08:03:10 +00:00
Miguel Serrano
07ca18cdbb Added keyboard shortcuts for zoom (#5334)
GitOrigin-RevId: b284f923e9b4aba7837430239b09e05bb0308d09
2021-10-11 08:03:07 +00:00
Alf Eaton
b902bd9265 Refactor compile-related code from PDF preview context provider into a separate class (#5341)
GitOrigin-RevId: 96b8bb527fa3d60a5fb84eee2b8f4fabc1726875
2021-10-11 08:02:56 +00:00
June Kelly
03e1daa038 Merge pull request #5201 from overleaf/msm-pdf-viewer-error-boundaries
Error boundaries for React PDF viewer

GitOrigin-RevId: 90052fc183f7ece8125ecfb0410a529cf905c13b
2021-10-07 08:03:43 +00:00
June Kelly
1e7dbeeb94 Merge pull request #5180 from overleaf/msm-pdf-js-viewer-tests
Unit Tests for `pdf-js-viewer.js`

GitOrigin-RevId: 4bd38cf98c598e2ea30791052b9c24568d92c6b8
2021-10-07 08:03:30 +00:00
Alf Eaton
73bc3418a2 Add React version of the PDF preview pane (#5135)
GitOrigin-RevId: fcc88a362c3e97c9fddf85d47c3a83a0a0b89432
2021-10-01 08:03:12 +00:00
Alf Eaton
deafe456b4 Merge pull request #4913 from overleaf/ae-pdf-preview-feature-flag
Add feature flag for React PDF preview pane

GitOrigin-RevId: ac1e7329d13117e72de6f6cf060cd16be81cbbaa
2021-09-06 08:02:52 +00:00