Commit graph

319 commits

Author SHA1 Message Date
Alf Eaton
12af54069c Merge pull request #10787 from overleaf/ae-pdfjs-3
Start upgrading pdf.js to the latest version

GitOrigin-RevId: e7d8c6dedb0fe58ba31626408df81fd42ba1ca3b
2022-12-09 09:03:53 +00:00
Davinder Singh
4adfca52bf Merge pull request #10682 from overleaf/ds-btn-default-to-secondary-in-editor-part-2
Replacing btn-default with btn-secondary in the editor Part-2

GitOrigin-RevId: 708aa29070bb3049afbc8ee1a282eaa1018594a8
2022-12-08 09:03:42 +00:00
Davinder Singh
d6b39c4bb3 Merge pull request #10653 from overleaf/ds-btn-default-to-secondary-in-editor
Replacing `btn-default` with `btn-secondary` in the editor

GitOrigin-RevId: 46aa8c92c9981eb2f253828ee65424bfb7217fb2
2022-12-08 09:03:35 +00:00
Alf Eaton
65b0fd73ea Improve "compile" keyboard shortcut handling (#10624)
* Improve "compile" keypress handling
* Remove "compile" keypress handling from PDF preview
* Remove compile shortcuts from CM6
* Use an event for Vim keybindings
* Remove event handlers from Angular/Ace
* Move useCompileTriggers into DetachCompileProvider

GitOrigin-RevId: 7f0e667b5106a849458e06ebb0f7a413d5d63430
2022-11-29 09:04:04 +00:00
Davinder Singh
c6f8b17647 Merge pull request #10286 from overleaf/jel-ds-toggle
Fix toggle and  `Switch to PDF` aligment

GitOrigin-RevId: d3c77ff34829af875d2b8b9e3797e0e7db867631
2022-11-16 09:04:26 +00:00
Alf Eaton
28414b118d Merge pull request #10383 from overleaf/jpa-pdf-caching-avoid-cache-for-range-request
[web] pdf-caching: avoid browser cache for range requests on output.pdf

GitOrigin-RevId: 546380cfb24094db0af7de0f47f5a69c60b0586d
2022-11-10 09:04:06 +00:00
Jakob Ackermann
f803563673 Merge pull request #10376 from overleaf/jpa-pdf-caching-disable-first-error
[web] pdf-caching: disable pdf-caching after the first non-404 error

GitOrigin-RevId: f022e75acd9d5140ae02041b60af9819baa25e62
2022-11-09 09:04:03 +00:00
Jakob Ackermann
aeade59677 Merge pull request #10371 from overleaf/jpa-pdf-caching-disable-in-opera
[web] pdf-caching: disable pdf-caching in Opera browser

GitOrigin-RevId: 8c0cefc4fa4fccd74c58649c000be14643788514
2022-11-09 09:03:57 +00:00
Miguel Serrano
9e50ab8d1e Merge pull request #10350 from overleaf/jpa-pdf-caching-debug-context
[web] pdf-caching: more debug context

GitOrigin-RevId: ef9b20ef8d9a3b0c6b1b8c200eead1c0f8cf6bde
2022-11-09 09:03:00 +00:00
Jakob Ackermann
665ab24cbd Merge pull request #10337 from overleaf/jpa-localized-network-error-messages
[web] pdf-caching: handle localize network error messages

GitOrigin-RevId: 41b0b9e87818d87d08c4cf24991751779243ae32
2022-11-08 09:04:18 +00:00
Jakob Ackermann
3db03ef678 Merge pull request #10313 from overleaf/jpa-pdf-caching-ranges-in-sentry
[web] pdf-caching: display ranges in sentry debug context

GitOrigin-RevId: d58e9c5292b1202e629c3b0706ade067c15e08a0
2022-11-08 09:04:11 +00:00
Jakob Ackermann
e9bc195483 Merge pull request #10301 from overleaf/jpa-pdf-caching-ignore-errors-for-stale-output
[web] pdf-caching: flag more errors as expected

GitOrigin-RevId: a5351db16d268bb8d9d67a86c34698c8b04f4f1a
2022-11-08 09:04:04 +00:00
Jakob Ackermann
111cce4ca4 Merge pull request #10299 from overleaf/jpa-nicer-warning-message-for-missing-pdf
[web] show a nicer warning message for missing pdf exceptions

GitOrigin-RevId: f519ec145d7ff4fe725241742fb66a1defdd257e
2022-11-08 09:03:57 +00:00
Miguel Serrano
4a3fb3344b Merge pull request #10323 from overleaf/ae-pdf-dblclick-page
Ensure only one dblclick listener is attached to a PDF page

GitOrigin-RevId: cadaa2f3bbaba8c496a6ece698b2ba7f12f340c4
2022-11-08 09:03:38 +00:00
Brian Gough
db15c83c35 Merge pull request #10244 from overleaf/ii-jump-to-error
[web] Jump to error on files with double slash

GitOrigin-RevId: eec2ac6ba7a34d32f757f5e3a088e92d0d494422
2022-11-07 09:03:31 +00:00
Mathias Jakobsen
aac9e6616e Merge pull request #10285 from overleaf/jpa-pdf-caching-ignore-404-from-fallback
[web] pdf-caching: double down on ignoring 404 from output.pdf requests

GitOrigin-RevId: 6b489180c221a29758b862884dae4ed6ed954a23
2022-11-04 09:04:53 +00:00
Jakob Ackermann
986d52b8d4 Merge pull request #10274 from overleaf/jpa-pdf-caching-check-response-size
[web] pdf-caching: bailout early on unexpectedly large response size

GitOrigin-RevId: b2b1cf0abf2367ec7a7f0f5ca7a9f67a03e2fa0d
2022-11-04 09:04:02 +00:00
Jakob Ackermann
28c1cc2ea9 Merge pull request #10218 from overleaf/jpa-adjust-prefetching
[web] pdf-caching: try to prefetch other smaller chunks

GitOrigin-RevId: 2bf1d33d48c2026ec3794baaaef8346dc9104db3
2022-11-02 09:05:04 +00:00
Jakob Ackermann
6f00659865 Merge pull request #10246 from overleaf/jpa-pdf-caching-object-id-back-fill
[web] pdf-caching: double down on back-filling of object-id

GitOrigin-RevId: 751392dc5ed59eb621eca3813040c7b92ef1369e
2022-11-02 09:04:57 +00:00
Jakob Ackermann
85547ffe40 Merge pull request #10234 from overleaf/jpa-pdf-caching-ignore-404
[web] pdf-caching: stop counting 404s on the output.pdf as failure

GitOrigin-RevId: eb76570fdce3dd79b8e0ea961722e428446672ac
2022-11-02 09:04:21 +00:00
Jakob Ackermann
79e6fecc4a Merge pull request #10231 from overleaf/jpa-pdf-caching-bounds-debug
[web] pdf-caching: debug bounds when reassembling the range from chunks

GitOrigin-RevId: 11871241d07880ebd2659cc5d0feb1f2c29014b6
2022-11-01 09:04:12 +00:00
Jakob Ackermann
a0c180d133 Merge pull request #10156 from overleaf/jpa-web-disable-prefetch
[web] pdf-caching: double down on disabling of prefetching

GitOrigin-RevId: 60ccea883786bad306a747b5a182982bc648bbbd
2022-10-26 08:04:13 +00:00
Jakob Ackermann
956cacaef7 Merge pull request #10139 from overleaf/jpa-split-test-min-chunk-size
[misc] add split test for a per request pdfCachingMinChunkSize

GitOrigin-RevId: 6a8a3c6267501789f2047a67b03db6ac6df427c3
2022-10-26 08:03:39 +00:00
Jakob Ackermann
abaecac268 Merge pull request #10007 from overleaf/jpa-pdf-caching-latency-compute
[web] collect latencyCompute metric from pdf-caching

GitOrigin-RevId: f20fa2b54078a7106b2413432c4f47375878a5d6
2022-10-26 08:03:31 +00:00
Alf Eaton
57fb1545e4 Merge pull request #9980 from overleaf/mj-recompile-button-colour
[web] use bsStyle primary for recompile button group

GitOrigin-RevId: 6876f2bbfae6270d059f15c8b25af866b54d1e61
2022-10-19 08:03:45 +00:00
Timothée Alby
4af5ed24ad Merge pull request #9866 from overleaf/ta-pdf-detach-safari-no-warnings
Remove PDF Detach Safari Warning

GitOrigin-RevId: 80f17660d81dc3812fab74c5e2ea4ff23cd7f1d0
2022-10-18 08:03:20 +00:00
Timothée Alby
1ae3061f16 Merge pull request #9972 from overleaf/jpa-fix-rate-limited-output-download
[server-ce] serve output files via nginx

GitOrigin-RevId: 0ba3b27f85f928b1d95646e663dfa42a22a9f832
2022-10-18 08:03:09 +00:00
Timothée Alby
e699f3ca35 Merge pull request #9007 from overleaf/ta-recompile-event-body
Listen for Recompile Shortcut on Body

GitOrigin-RevId: 1ded1d620b35d25f1dffe27b78d8c866e2bfa1bd
2022-10-18 08:02:57 +00:00
Tim Down
de7eb43f51 Merge pull request #9792 from overleaf/ds-jpa-remove-stoponfirsterror-split-test
Split Test removal - removed stop-on-first-error split test code

GitOrigin-RevId: 4a5663397d0a967e0fa957453b36d466aa530630
2022-10-04 08:03:24 +00:00
Alf Eaton
c6f198b3a2 Merge pull request #9605 from overleaf/ae-9585-remove-rich-text-survey
Remove Rich Text survey

GitOrigin-RevId: 97003dfb70b8f9cc9118be3f291c7d56d2508f63
2022-09-15 08:04:10 +00:00
Alf Eaton
25725bd79f Add Rich Text survey message in PDF preview pane (#9423)
GitOrigin-RevId: e190ae569d5e2390e8bcf52672757cc7f269ea56
2022-09-02 08:04:41 +00:00
Alf Eaton
c2b4a2d3ea Merge pull request #9375 from overleaf/mj-timeout-link
[web] Add missing link to compile timeout message

GitOrigin-RevId: 46af17a4fe0620ccf6dc29a27edfbf3ac79e856d
2022-08-25 08:03:40 +00:00
Alf Eaton
4843288b50 Merge pull request #9312 from overleaf/ds-remove-keyShortCut
Remove keyShortCut from compile function options

GitOrigin-RevId: 31b13be5fd6742419d4147b89ef281b1b30227fb
2022-08-22 08:03:49 +00:00
Alf Eaton
4250c4030f Merge pull request #9266 from overleaf/ae-pdf-preview-sentry
Use captureException for recording errors in pdf preview

GitOrigin-RevId: ab3cf0a9d5579ea78c09ad10ec1b7e209d408519
2022-08-19 08:04:05 +00:00
Alf Eaton
e741eb0cb8 Remove PDF detach split test (#9275)
GitOrigin-RevId: 9e227fe45d874e01c4282ebbe489d7bd6d2250ac
2022-08-19 08:03:47 +00:00
Jakob Ackermann
f2b0b77907 [web] bring back compileTimeServerE2E in client side compile metrics (#9203)
GitOrigin-RevId: f10ee837869b102aab25695c676d0e6adafa80c1
2022-08-12 08:05:35 +00:00
Alf Eaton
36fae7c8ea Merge pull request #8961 from overleaf/ae-prevent-compile-on-load
Allow "compile on load" to be disabled (for tests)

GitOrigin-RevId: f36b4a5c10c4bd68832e27d6472346f77afdb9c2
2022-08-10 08:03:58 +00:00
Alf Eaton
d905863002 Merge pull request #8747 from overleaf/ae-error-boundary-fallback
Create a generic ErrorBoundaryFallback component

GitOrigin-RevId: 0c9200ddef2be3b90030a32eb8c36a59047cf2b4
2022-08-10 08:03:51 +00:00
ilkin-overleaf
73f2811a7b Merge pull request #9095 from overleaf/ii-pdf-set-zoom-fix
[web] Pdf zoom throws an error

GitOrigin-RevId: bcb3cde05ca9c65c1cca554b26ea9c7d0fe8d995
2022-08-05 08:04:02 +00:00
ilkin-overleaf
bec4827c3f Merge pull request #9085 from overleaf/ii-pdf-click-position-fix
[web] PDF preview click position error fix

GitOrigin-RevId: f2ac73f2a4050b707402c373193ae7a0ecd8ac53
2022-08-05 08:03:49 +00:00
Jakob Ackermann
ed66b43979 Merge pull request #8883 from overleaf/jpa-optimize-pdf-caching
[web] optimize pdf caching

GitOrigin-RevId: 85f8b8425ca0052b0d5229cec651e1d5080f1da4
2022-08-02 08:04:15 +00:00
Jakob Ackermann
f1487714b4 Merge pull request #9058 from overleaf/jpa-error-handling-2nd-page
[web] improve error handling for pdf-caching

GitOrigin-RevId: ddd65f2813fb08eb4493967071ee62d9742930cc
2022-08-02 08:04:07 +00:00
Jakob Ackermann
315414de1b Merge pull request #9011 from overleaf/jpa-better-render-error-message
[web] provide helpful error message when pdf rendering fails

GitOrigin-RevId: abbe6f362fa362fadee197527463ee675760e581
2022-07-29 08:04:48 +00:00
Jakob Ackermann
6485731c98 Merge pull request #9010 from overleaf/jpa-ignore-404
[web] do not consider a 404 on the main pdf url as pdf caching failure

GitOrigin-RevId: 2d57ee92b79227baa58f2e71edbcf63a4848435d
2022-07-29 08:04:41 +00:00
Jakob Ackermann
b795579ca0 Merge pull request #9006 from overleaf/jpa-sentry-error-context
[web] send OError info and OError tags/cause tracebacks to sentry

GitOrigin-RevId: 0544768ca16fcafb63ec6116a573e83302cdbdd3
2022-07-29 08:04:35 +00:00
Timothée Alby
8841c8c874 Merge pull request #9008 from overleaf/jpa-disable-pdf-caching-edge-legacy
[web] disable pdf caching feature in legacy Edge browser

GitOrigin-RevId: f57ca3385337b5516e27a701646f2ed92325bf8d
2022-07-29 08:04:10 +00:00
Alf Eaton
8f343be843 Merge pull request #8975 from overleaf/ae-pdfjs-standard-fonts
Add standardFontDataUrl to PDF.js config

GitOrigin-RevId: a9304da6d8a9115056240fc3ed4897415bf6e159
2022-07-27 12:17:53 +00:00
Alexandre Bourdin
4f340b0ed7 Merge pull request #8894 from overleaf/ab-cleanup-start-free-trial-button
[web] Cleanup StartFreeTrialButton component

GitOrigin-RevId: 67538882ff5a3389d2134ec6e4833431aa43f8e6
2022-07-26 08:04:21 +00:00
Timothée Alby
7b8d277437 Merge pull request #8898 from overleaf/ta-change-redundant-controls
Change Redundant Layout Controls

GitOrigin-RevId: b50d71b1f75d202334442b3f6cb5037ed0d8a411
2022-07-21 08:04:25 +00:00
Jakob Ackermann
3c0bb25249 Merge pull request #8886 from overleaf/jpa-pdf-caching-alpha
[web] prepare alpha release of pdf caching

GitOrigin-RevId: 5617dd443da57b7077db793c2bc39be35ec44ef1
2022-07-21 08:03:10 +00:00
Jakob Ackermann
1a9487d5fd Merge pull request #8931 from overleaf/jpa-pdf-caching-fixes
[web] fixes/improvements for pdf caching

GitOrigin-RevId: 2ba0ed4798fd4dfb57f2dfca8be92ae1a769934f
2022-07-21 08:03:06 +00:00
Jakob Ackermann
0409676c41 Merge pull request #8911 from overleaf/jpa-pdf-detach-pdf-caching-metrics
[web] fix forwarding of pdf caching metrics in pdf-detach mode

GitOrigin-RevId: c4a65190102ca4abfb7970186bc5ee785bff14c6
2022-07-21 08:03:03 +00:00
Jakob Ackermann
985ad8ff5b Merge pull request #8879 from overleaf/jpa-fix-pdf-detach-delivery-latency
[web] collect fetch and render latency in the scope of the viewer

GitOrigin-RevId: 3bf6c5ffc01df705605c873a130f0a645fdc66c4
2022-07-19 08:03:34 +00:00
Jakob Ackermann
3c8a9d9863 Merge pull request #8853 from overleaf/jpa-no-pdf-download-in-editor-only-mode
[web] do not download the pdf in editor only view mode

GitOrigin-RevId: 4d8936964540c0820f72abb8c858e86e2e7196e2
2022-07-19 08:03:28 +00:00
Alexandre Bourdin
a62fb305c9 Merge pull request #8851 from overleaf/ab-fix-compile-time-warning-redisplay
Fix the compile time warning being displayed again after dismiss

GitOrigin-RevId: 4b3d80cfa7664e13154418aa510cb9265e282525
2022-07-14 08:04:52 +00:00
Alexandre Bourdin
9d9630e972 Merge pull request #8841 from overleaf/jpa-fix-detach-state-propagation
[web] fix de-sync of pdfFile vs pdfUrl vs pdfDownloadUrl

GitOrigin-RevId: 1c30f372580b7d247d005c4e4cd623996449c212
2022-07-14 08:04:32 +00:00
Alexandre Bourdin
6a6b6a0c88 Merge pull request #8846 from overleaf/ab-compile-time-tracking
[web] Add event and time since display segmentation for compile time warning

GitOrigin-RevId: 5a1ca75231e4ffd7a0812674b8600b62c4cddf11
2022-07-14 08:04:25 +00:00
Alexandre Bourdin
d501bc4820 [web] Compile time warning split test (#8813)
* Implement compile time warning split test

* Add i18n for compile time warning

* Memoize CompileTimeWarning component

* Reuse startFreeTrial() function from account-upgrade

* Improve usage of react bootstrap native properties

* Cleanup compile-time-warning

* Move all logic into CompileTimeWarning component

* Only show compile time warning to project owners

* Handle compile time warning in detached mode and while switching layout

GitOrigin-RevId: 4fc40acfc113f91c81a6744c14c0f8b3ef766e39
2022-07-14 08:03:50 +00:00
Jakob Ackermann
f11e1a83cd Merge pull request #8776 from overleaf/jpa-drop-service-worker
[web] goodbye service worker

GitOrigin-RevId: ce85d4850faba15c5877ce1f3e78026de30c6eae
2022-07-11 08:03:57 +00:00
Jakob Ackermann
db83832485 Merge pull request #8774 from overleaf/jpa-fix-pdf-metrics
[web] fix collection of pdf.js timing metrics

GitOrigin-RevId: ee4cd29cc737a740e367e8be1a00e688aa684462
2022-07-11 08:03:50 +00:00
Timothée Alby
c92278a8e5 Merge pull request #8609 from overleaf/ta-preview-error-message-copy
Update Preview Errors Copy

GitOrigin-RevId: 0e7f7a4237a80c3fa2efc8ae87fc2011f4bc879d
2022-07-07 08:03:48 +00:00
Jakob Ackermann
64184a7f56 Merge pull request #8730 from overleaf/jpa-refactor-pdf-caching
[web] refactor pdf caching

GitOrigin-RevId: af6b871fad652f757d8c465085b33a79b955cd6b
2022-07-07 08:03:28 +00:00
Eric Mc Sween
cc9b490ef6 Merge pull request #8651 from overleaf/em-transient-warnings
Stop on first error: filter out transient warnings

GitOrigin-RevId: ec17a24e05ec28106fdc11f3d3a9e243ae191547
2022-07-05 08:03:50 +00:00
Eric Mc Sween
7837af0afd Merge pull request #8511 from overleaf/em-stop-on-first-error-info-badge
Replace stop-on-first-error beta badge with info badge

GitOrigin-RevId: d0f8d1c6e960646bd257aeaf5efc21b23615242b
2022-06-22 08:05:27 +00:00
Jakob Ackermann
bfad0841a4 Merge pull request #8483 from overleaf/jpa-faster-compiles-feedback-ui
[web] faster compiles feedback UI

GitOrigin-RevId: 9feea47503aa6bddf51adb73b8c9fbef394fda14
2022-06-22 08:05:14 +00:00
John Lees-Miller
092ef7925c Handle no splitTestVariants metadata
GitOrigin-RevId: c59262c51cffc92a38e40c1e3f08a92e5fa030b0
2022-06-22 08:05:02 +00:00
John Lees-Miller
fcf9c92160 Split test for log parser changes
GitOrigin-RevId: efe9fb29c5ae56889b686692f8533ae0ae4a3b1d
2022-06-22 08:04:55 +00:00
Alf Eaton
bd64a167f4 [cm6] Wrap compile log annotations in a lint source (#8451)
GitOrigin-RevId: d404560313cbb99c7a06453bc3b7d2374e86598a
2022-06-22 08:03:47 +00:00
Eric Mc Sween
aa60c0846d Merge pull request #8405 from overleaf/em-halt-on-error-beta-survey
Stop on first error beta badges

GitOrigin-RevId: 1f5609518a81d12eb81fd4d1ca51ef432e039548
2022-06-15 08:05:30 +00:00
Eric Mc Sween
a2532ef968 Merge pull request #8354 from overleaf/em-halt-on-error-animation
Animation when setting "Stop on first error"

GitOrigin-RevId: 9639e2c815d1eaf57f3392131f9a484a6a1a0a9e
2022-06-14 08:02:32 +00:00
Eric Mc Sween
3d0f464637 Merge pull request #8361 from overleaf/em-halt-on-error-events
Analytics events for "Stop on first error"

GitOrigin-RevId: cbdb054cdf031f0364390c36cc1c1865169f2cd4
2022-06-14 08:02:30 +00:00
Eric Mc Sween
e365a6cbaf Merge pull request #8346 from overleaf/em-halt-on-error-logs-2
Stop on first error: logs pane prompts

GitOrigin-RevId: a246a7e5d302ad3104e15f7fd78344992b4e011b
2022-06-10 08:03:55 +00:00
Timothée Alby
ae207f7559 Merge pull request #8326 from overleaf/ta-pdf-detach-redundant-controls
Bring Back Redundant Layout Controls

GitOrigin-RevId: a725e8742ab41612b285bcab23054ba9da15b60f
2022-06-09 08:02:34 +00:00
Eric Mc Sween
cb657d1f1c Merge pull request #8297 from overleaf/em-halt-on-error-logs
Stop on first error info box in logs pane

GitOrigin-RevId: cf11f65d582d98bea93c6506393940d9a6144c0d
2022-06-08 08:03:12 +00:00
Eric Mc Sween
baaf4d4240 Merge pull request #8286 from overleaf/em-halt-on-error-backend
Stop on first error backend implementation

GitOrigin-RevId: 497b1ed2c13f544760d8ad8d029359db75275389
2022-06-07 08:02:21 +00:00
Eric Mc Sween
2ab5189771 Merge pull request #8237 from overleaf/em-halt-on-error
Stop on first error dropdown UI

GitOrigin-RevId: 5191a37f6c227ff5a91c10ce965832e1702c3931
2022-06-03 08:03:39 +00:00
Jakob Ackermann
6f95859981 Merge pull request #8222 from overleaf/jpa-fix-download-no-build-id
[web] download output files without a build id via web

GitOrigin-RevId: 97bb994e29eea6c90f9d885335dc93027bc186bd
2022-06-02 08:02:50 +00:00
Thomas
d9753dcb22 Merge pull request #8246 from overleaf/tm-remove-logs-pane-info-notice
Remove PdfLogsPaneInfoNotice

GitOrigin-RevId: 0b4e611c081fe5fed8842c2967b47fc6f6556264
2022-06-02 08:02:47 +00:00
Timothée Alby
af5543f119 Merge pull request #8224 from overleaf/ta-pdf-detach-wait-i18n
PDF Detach: Wait for i18n

GitOrigin-RevId: d1774c917ba903eab9980c90dc8b1e41eaf5e935
2022-06-01 08:03:59 +00:00
Timothée Alby
32741c07e0 Merge pull request #8218 from overleaf/ta-pdf-detach-safari-warnings
PDF Detach Safari Warning

GitOrigin-RevId: e6f8942d8c8c141d887c44921a09716c4e4c85ae
2022-05-31 08:04:36 +00:00
Alf Eaton
9253dac12f Merge pull request #8010 from overleaf/ta-synctex-unmount
Unmount Default Synctex Controls in Detacher Mode

GitOrigin-RevId: bc754fb172aba7430003f7a61eddb4450b175025
2022-05-24 08:04:11 +00:00
Alf Eaton
1770cdc8fc Handle pdf.js loading errors (#7824)
GitOrigin-RevId: a4893dd66ceb9e9f8266cf720ab2b3507bf6aef1
2022-05-24 08:04:05 +00:00
ilkin-overleaf
1e22d17520 Merge pull request #8066 from overleaf/ii-refactor-tooltip-usage-fix-2
Fix expand button tooltip text

GitOrigin-RevId: db19ce6c21bf1a83f38a60014bd0aa92e220ce40
2022-05-23 08:04:13 +00:00
Alf Eaton
bce320f4bc Merge pull request #8037 from overleaf/ii-refactor-tooltip-usage-fix
Place the download PDF tooltip to the bottom

GitOrigin-RevId: e2171c4417de66f2143be66dc76ca7c450c43234
2022-05-20 08:04:20 +00:00
Timothée Alby
5731463d32 Merge pull request #7956 from overleaf/ii-refactor-toolitp-usage
Tooltip usage refactoring

GitOrigin-RevId: f4b2d4d57722172141a081dd60e4394ff7fff332
2022-05-19 08:04:07 +00:00
Alf Eaton
a3459a1842 Merge pull request #8009 from overleaf/jpa-sync-pdf-url-update
[web] update clsiServerId and pdfUrl in the same update cycle

GitOrigin-RevId: 6791627c12c16aa71ad393edbf19d7fed00491a0
2022-05-19 08:03:36 +00:00
Alf Eaton
e14363246d Handle compile shortcuts in all layouts (#7969)
GitOrigin-RevId: cbfb24a7328d499ca96caa8683b8e4b1e6858372
2022-05-19 08:03:14 +00:00
Alf Eaton
0eb99b2eff Switch pdf.js default version to 213 (#7952)
GitOrigin-RevId: 476c37c14e665ecc07394a0fadebca5b79487d78
2022-05-17 08:04:19 +00:00
Jakob Ackermann
52073a13a9 Merge pull request #7867 from overleaf/jpa-compile-group
[web] pass compileGroup to clsi-lb

GitOrigin-RevId: c15adbff27e702b3e0f29be5b57f7a9520d8d02f
2022-05-16 08:03:36 +00:00
Alf Eaton
37218bce59 Attach PDF highlights to the viewer element (#7728)
GitOrigin-RevId: 918dfd8c43dfea4e64fbb5a1437ea8532cbac7ec
2022-04-28 08:03:35 +00:00
Alf Eaton
24a317a836 Catch navigator.serviceWorker.getRegistrations() Promise rejection (#7708)
GitOrigin-RevId: 4c68e4272ea9618503ad655dd6c24841486601b2
2022-04-28 08:03:31 +00:00
Alf Eaton
ff44afb74c Only show compile shortcut when editor is visible (#7773)
GitOrigin-RevId: 0b6d25d7012e82a676e3a782730fb6ca481cd1e8
2022-04-28 08:03:19 +00:00
Timothée Alby
a110c4d7bd Merge pull request #7323 from overleaf/ta-synctex-disable-multi-one-way
Don't Disable Synctex PDF-to-Code Button

GitOrigin-RevId: 90328e0fea8cb5358217ce866839f5e1a4a73b94
2022-04-13 08:03:36 +00:00
Alf Eaton
aca889a3e0 Sync cursor position to PDF when double-clicking on a heading in the file outline (#7314)
GitOrigin-RevId: ef98f5d20e99bfc03c91cbf4027d277e738ab176
2022-04-11 08:03:14 +00:00
June Kelly
dc6f480843 Merge pull request #7275 from overleaf/ds-shared-loading-spinner-2
Changed LoadingSpinner default delay

GitOrigin-RevId: 2bf499585e3394e5c6b8ed9583add7ef6f678fc1
2022-04-07 09:56:57 +00:00
Alf Eaton
69a2283984 Upgrade to webpack v5 (#7249)
GitOrigin-RevId: 69dc5f9aad3e045cc6904e3663e9965094eced76
2022-04-07 08:03:46 +00:00
Timothée Alby
3c01402bbd Merge pull request #7034 from overleaf/ta-pdf-detach-full
PDF Detach v2

GitOrigin-RevId: 3deb76474185f9176cde23ab32ef51b90df6e8e9
2022-04-05 12:19:23 +00:00
Alf Eaton
935dc9be7c Remove unused code and translation keys (#7140)
GitOrigin-RevId: 15ce5d22a40ebe56cae76c78703c1547f2ab0552
2022-03-28 08:04:07 +00:00
Alf Eaton
439ba17bd5 [web] Fetch and parse compile log files asynchronously (#6220)
GitOrigin-RevId: 91b4c3551b705e7c07205b1bced3ae4768b10edb
2022-03-28 08:04:01 +00:00
Alf Eaton
74b76c853d Increase the maximum size of the pdf.js canvas (#7207)
GitOrigin-RevId: 699c4ded7a783e37f655e05452943de7443f1012
2022-03-28 08:03:51 +00:00
Eric Mc Sween
6061e09ab9 Merge pull request #7180 from overleaf/em-missing-pdf-download-domain
Handle missing PDF_DOWNLOAD_DOMAIN setting

GitOrigin-RevId: 3f022ec1637f7f38ca98503b1ab08748f6bbf87d
2022-03-24 09:03:57 +00:00
Timothée Alby
ac3eb878d6 Merge pull request #7172 from overleaf/ta-pdf-viewer-backdrop-hide
Fix Logo Backdrop in PDF Viewer

GitOrigin-RevId: ae9eb98dc8a51a882354b6ddea095df2bed51346
2022-03-24 09:03:44 +00:00
ilkin-overleaf
57e60c05ca Merge pull request #7066 from overleaf/ta-synctex-disable-multi
Disable Synctex Controls for Docs and Multiselections

GitOrigin-RevId: 9f14e68228f9aa13a4188918930fc8cdb5eefabf
2022-03-22 09:03:21 +00:00
Alf Eaton
65e71714b8 Upgrade pdf.js via split test framework (#7053)
GitOrigin-RevId: dffe1f5bec07cba0914e3bd18ff5332dfe204f33
2022-03-21 09:03:16 +00:00
Alf Eaton
9d9bf8b9d0 Import Promise.allSettled from core-js (#7099)
GitOrigin-RevId: e7c1da844c3c7e8caec386b06f3b8393ea79529c
2022-03-21 09:03:07 +00:00
June Kelly
1fc13e6549 Merge pull request #7036 from overleaf/ta-go-to-pdf-hide-logs
Hide Logs When Highlighting PDF Location

GitOrigin-RevId: cdf22393b1dde5eb842cf0f8b2d7d8c408bc8eca
2022-03-16 09:03:11 +00:00
Alf Eaton
9f969d07e0 Delete unused PDF-related code (#6334)
* Remove new logs UI code
* Remove unused preview components
* Move metrics file
* Remove Angular PDF controllers
* Move the service worker util functions
* Remove the ide/pdfng folder
* Remove vendored pdf.js
* Remove showNewPdfPreview
* Use mockCompile
* Remove split test code

GitOrigin-RevId: 723b7440c62cda51f6ad8bb9c691900882166d21
2022-03-16 09:03:04 +00:00
Timothée Alby
9ba3f04491 Merge pull request #7002 from overleaf/ta-compile-dropdown-button-not-disabled
Don't Disable Dropdown Button When Compiling

GitOrigin-RevId: 099ddae07c7601016103514168eef80712ccc57f
2022-03-07 09:03:01 +00:00
Timothée Alby
5ba970b81e Merge pull request #6986 from overleaf/ta-compile-button-disabled
Disable Compile Button when Compiling

GitOrigin-RevId: c25cbaab3547695919ba62385cffef2a44665fec
2022-03-04 09:03:37 +00:00
Miguel Serrano
a3b01659a4 Fix isRequired error in GoToCodeButton.propTypes (#6646)
Skip `PdfSynctexControls` rendering until `position` is set

GitOrigin-RevId: ea40c7f98ea3bbdf3d8689175658d2c014b68436
2022-02-16 11:38:02 +00:00
Alf Eaton
f065a7a909 Improve the Icon component (#6245)
GitOrigin-RevId: fbb23b32c47edbe5a22badc627318accbd09e82a
2022-01-20 09:03:58 +00:00
Alf Eaton
1dd62570a6 Merge pull request #6390 from overleaf/ae-is-visible-binary
[web] Only run updateOnResize when the PDF viewer is visible

GitOrigin-RevId: 90b5632f45406b66af7710c6e8346cf73ffbebea
2022-01-20 09:03:28 +00:00
Jakob Ackermann
5a7698ddef [web] refactor updating of scroll position in pdf view
Co-Authored-By: Timothée Alby <tim.alby@overleaf.com>
GitOrigin-RevId: 932c880bcd41e68d231928bdcbbaeb06c60f6fd5
2022-01-14 09:03:28 +00:00
Miguel Serrano
56d826f255 Force Promise.allSettled polyfill (#6192)
* Force `Promise.allSettled` polyfill

`Promise.allSettled` is required by `pdf.js`, but the polyfill is not available in the bundle. This forces babel to include the polyfill without having to process `pdf.js` with webpack/babel, which causes issues loading documents.

* Updated core.js version for test config

GitOrigin-RevId: 981da187352ffc8c59cb77ba55a0a9643bd7cc9a
2022-01-12 09:04:06 +00:00
Miguel Serrano
35396ab61a Add limit to log parsing for react log viewer (#6213)
* Add limit to log parsing for react log viewer

GitOrigin-RevId: e2e5ffd6eaf1c207cc4f49fb5c637457990c328e
2022-01-12 09:03:59 +00:00
Thomas
3f05f7f283 Merge pull request #6294 from overleaf/ta-synctex-detach-icon
Remove Arrows from Synctex Button in Detach Mode

GitOrigin-RevId: 0b96ed29fd43308383c1db658f1d8d5143e3dd23
2022-01-12 09:03:28 +00:00
Timothée Alby
6319455e91 Merge pull request #6236 from overleaf/ta-project-context-strict
Strict Project Context

GitOrigin-RevId: a0f7f2b3dcb29fbd0102dcb920cf5424a921d583
2022-01-11 09:05:03 +00:00
Timothée Alby
55829a3382 Merge pull request #6199 from overleaf/ta-pdf-detach-sync-to-entry
Make syncToEntry a Detach Action

GitOrigin-RevId: 92e92b770c4e2be5b001c083d2d490231a7fddfb
2022-01-11 09:04:33 +00:00
Alf Eaton
341d012cea Remove paywall-prompt event tracking from compile controller (#6241)
GitOrigin-RevId: cab36fd1f2a79166c39b801a29155f1ef64edc00
2022-01-11 09:04:07 +00:00
Alf Eaton
5b560ad8ab Only store/restore PDF scroll position when visible (#6218)
GitOrigin-RevId: c2023b5173fe4668f52da3e096c3dfc0124a7248
2022-01-11 09:03:55 +00:00
Alf Eaton
50df230846 [web] Upgrade Prettier to match version in monorepo root (#6231)
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
2022-01-11 09:03:23 +00:00
Timothée Alby
b11d4b002c Merge pull request #6056 from overleaf/msm-remove-unnecessary-pdf-event-tracking
Cleanup PDF Preview event tracking

GitOrigin-RevId: 8fadaee2759f60e70e27ac417593d35cc73e8b68
2021-12-22 09:03:27 +00:00
Timothée Alby
44eca312ff Merge pull request #6053 from overleaf/ta-pdf-detach-tests
PDF Detach Misc Tests

GitOrigin-RevId: 9615c8fdfd8964a9c63d7c91e4596d397a1d35dc
2021-12-15 09:04:46 +00:00
Timothée Alby
c1c0f1fe4a Merge pull request #6039 from overleaf/ta-synctex-cursor-position-init
Fix Cursor Position Tracking for Synctex

GitOrigin-RevId: 6df703812f3efa2163b953aab82f32e174919179
2021-12-15 09:04:33 +00:00
Miguel Serrano
48233cd593 Merge pull request #6027 from overleaf/ae-disabled-download-pdf-tooltip
Fix tooltip on disabled download PDF button

GitOrigin-RevId: d1814e75886d8a530331c3ded01499dcad8a4289
2021-12-08 09:03:16 +00:00
Miguel Serrano
9ce9b0e8d7 Merge pull request #6021 from overleaf/ae-pdf-preview-horizontal-scroll
[web] Store left offset of PDF position

GitOrigin-RevId: 77d6b52a8485a427bb59618bf42b5f4a300c260a
2021-12-08 09:03:05 +00:00
Miguel Serrano
e8c645bf28 Using uuid for compilation logs (#6003)
GitOrigin-RevId: 96646870da597881a6e8b26564be4dee26385bb8
2021-12-08 09:03:02 +00:00
Jessica Lawshe
994b34bb2d Merge pull request #5981 from overleaf/jel-synctex-bug
Fix postMessage error for PDF detach SyncTeX

GitOrigin-RevId: 701e92ca3d6bc20a6069d5290ee52d9d2d8f63b4
2021-12-03 09:04:15 +00:00
Alf Eaton
d7efa156f9 [web] Account for page border when restoring scroll position in PDF preview (#5955)
GitOrigin-RevId: a5c74151e085db2e413ff27b46c67bff8c28487f
2021-12-03 09:03:50 +00:00
Timothée Alby
f6fc3d468c Merge pull request #5854 from overleaf/ta-pdf-detach-v2
PDF Detach Updates

GitOrigin-RevId: c09c4fe37a922b041cfa1376e110a264a88177c8
2021-12-01 09:03:41 +00:00
Alf Eaton
2e3f56c0d4 Check for the presence of window.ResizeObserver (#5924)
GitOrigin-RevId: d072c9313967b52370a870fc2d30b50c498d8d1d
2021-11-30 09:03:05 +00:00
Alf Eaton
bab4d5d58f Extend AUTO_COMPILE_DEBOUNCE to allow for increased SINGLE_USER_FLUSH_DELAY (#5883)
GitOrigin-RevId: f65113b2dea901fb757dafb08acc32c770960bf2
2021-11-26 09:03:21 +00:00
Miguel Serrano
9ce51f9f2f Prevent compilation request from being ignored in compiler.js (#5818)
GitOrigin-RevId: 1442ad0890b73134e6f563a1b474e4bc9e8a6ecd
2021-11-26 09:03:14 +00:00
Miguel Serrano
7de1e6f979 Update log error ordering and wording on tips (#5873)
* Show bibtex errors with compile errors
* Update wording on error log tips

GitOrigin-RevId: 0e25a05418b241526958016f1b525334d33ad741
2021-11-26 09:03:07 +00:00
Miguel Serrano
ec065147fb Ignore bib parse errors (#5874)
GitOrigin-RevId: 05c214762585b4d3d35ed055e1764d472b9cc861
2021-11-26 09:03:01 +00:00
Timothée Alby
8ca159b4b9 Merge pull request #5797 from overleaf/ta-pdf-detach
PDF Detach

GitOrigin-RevId: f69d8a87d1ba2115ad496a719106dfc7707a6ed5
2021-11-16 09:02:57 +00:00
Alf Eaton
3feca1ffc6 Move symbol palette to module and add overlay (#5396)
GitOrigin-RevId: 649dd56aaecd60662bd2bf534bda323ee541874f
2021-11-11 09:03:05 +00:00
Miguel Serrano
83e0a0c29b Fix scrollIntoView for PDF highlights (#5723)
GitOrigin-RevId: c2196ca3e3eed14a48b827a27a13f13232bb4c00
2021-11-09 09:03:55 +00:00
Miguel Serrano
26eb5d7cdc Cleanup compile results on compilation error (#5663)
- pdfUrl, pdfDownloadUrl and log entries are now cleared up after a compilation error.

- Added a new hook, useScopeValueSetterOnly that limits how changes in React components are propagated to Angular. Since the compilation process happens entirely within compile-context it make sense that compilation results are solely managed by compile-context itself.

GitOrigin-RevId: 2003be03bab6753bb9a88194c7a6163cfd36f9c2
2021-11-04 09:04:05 +00:00
Miguel Serrano
a5fd363938 Protect pdf-js-wrapper from NPE error (#5658)
GitOrigin-RevId: 55bdc27afb7dd9ea55751ae0bd89a2498f9f2ce6
2021-11-04 09:03:58 +00:00
Alf Eaton
913a62fbc8 Migrate synctex controls to React (#5503)
GitOrigin-RevId: 80362a00ae6b73616a6fa9b3193b9b9974b5fd35
2021-10-22 08:03:43 +00:00
Alf Eaton
684efaaf5f Use pdfDownloadDomain when fetching certain files in the new PDF preview (#5524)
GitOrigin-RevId: d8796d9f86ba87824438f4bd7dcb1a79643654c3
2021-10-22 08:03:36 +00:00
Alf Eaton
2bf422b76d Merge pull request #5522 from overleaf/ae-compile-feature-flag
Only use the React compiler when showNewPdfPreview is set

GitOrigin-RevId: 24bf8dc6a830e670ee8dc30b8e0329127de1a1a8
2021-10-22 08:03:31 +00:00
Alf Eaton
dd5bcd6098 Merge pull request #5521 from overleaf/ae-remove-stop-compile-button
Remove "Stop compiling" action from Recompile button in new PDF preview toolbar

GitOrigin-RevId: a4c90ec7d6213c49e11f13f045354ce66f2e9a8b
2021-10-22 08:03:28 +00:00
Alf Eaton
bd3d0d124d Merge pull request #5520 from overleaf/ae-log-entry-height
Fix log entry height in new PDF preview

GitOrigin-RevId: a9b7cae352da87f391c66720b109e3d9fd00fe52
2021-10-22 08:03:24 +00:00
June Kelly
4f29ca5cbd Merge pull request #5395 from overleaf/msm-pdf-metrics
Added PdfJsMetrics to React PDF Viewer

GitOrigin-RevId: ff749d67baec243ca2c8e51409754716f4cef62c
2021-10-21 08:03:07 +00:00
Alf Eaton
89dfcaf528 Finish migrating to PdfLogEntry component (#5483)
GitOrigin-RevId: 93f1da35dbc80b317964133e0437373dd0af7933
2021-10-18 08:04:12 +00:00
Alf Eaton
9ffe28649c Improve rendering of errors from pdf.js (#5448)
GitOrigin-RevId: 69836ba213b124e2442b2d0083531dd95be2bf4e
2021-10-18 08:04:06 +00:00
Alf Eaton
7f5200da8c Report filtered pdf.js errors to Sentry (#5438)
GitOrigin-RevId: 7ab5a6fd61d271037ee33bbeadfad00b389812d6
2021-10-18 08:03:59 +00:00
Alf Eaton
4c25dcfb2b Disable overflow: scroll on the outer pdf.js element (#5446)
GitOrigin-RevId: 77485d0dd2af3e4dc6f86f322816e00beee9dfa9
2021-10-18 08:03:52 +00:00
Alf Eaton
61f466afc0 Ignore invalid synctex highlights (#5476)
GitOrigin-RevId: 9123a09502f17c1251995b2e7133b345db885107
2021-10-18 08:03:41 +00:00
Alf Eaton
09f3962ded Ensure that the TimeoutUpgradePrompt component returns null (#5482)
GitOrigin-RevId: 95e58537c82d9bedd055839cfb916a06c1ef96df
2021-10-18 08:03:34 +00:00
Alf Eaton
12eab99990 Migrate log entry component to new PDF preview (#5478)
* Migrate log entry component to new PDF preview
* Add a test for expandable log content

GitOrigin-RevId: 3e2154983c1ea03b5db44c87822e7043c4aa2cfe
2021-10-18 08:03:30 +00:00
Alf Eaton
f7ef2532e0 Handle PDF preview on toggle between split and full-width views (#5470)
* Only hide the compile logs pane when toggled off
* Handle PDF preview on toggle between split and full-width views

GitOrigin-RevId: 9ceca8a06a22abfa78f245e1ae5d24af98215906
2021-10-18 08:03:26 +00:00
Alf Eaton
2f835144c8 Upgrade pdfjs-dist to v2.10.377 (#5436)
* Upgrade pdfjs-dist
* Explicitly disable XFA in PDF.js

GitOrigin-RevId: 6987fe6e6f87a05d8f71d83a8b09b33caeade712
2021-10-13 08:03:45 +00:00
Alf Eaton
9c0b6f0fa7 Remove clsiserverid query parameter from compile request (#5408)
* Remove clsiserverid query parameter from compile request

* Rename buildQueryParams to buildPostCompileParams

GitOrigin-RevId: 4448179e910eeb664cece2b9384f8e7197f3185c
2021-10-13 08:03:14 +00:00
Alf Eaton
ce3b304ec8 Remove chktex fetching and parsing from migrated PDF preview (#5409)
GitOrigin-RevId: 3c6721a1272d809679ec1e2f2fcd1a7251e1321b
2021-10-13 08:03:08 +00:00
Alf Eaton
e26d47cb41 Add hybrid toolbar to migrated PDF preview (#5414)
GitOrigin-RevId: 6266028091229c819aee3c8d4bd3bff2e2417125
2021-10-13 08:03:01 +00:00
Alf Eaton
adf8828860 Fix a few minor test issues (#5415)
* Remove signal.abort()
* Fix usage of .toString
* Fix requests for files
* Fix story

GitOrigin-RevId: 37ab4be34a8975881aed2329d4b67f8df74837d8
2021-10-12 08:03:58 +00:00
Alf Eaton
845b2fbc04 Move useScopeValue hook to shared hooks folder and wrap setValue in a function (#5386)
GitOrigin-RevId: b1a6a4e871af3b52fb3d100a83b479c834cb75ca
2021-10-11 08:03:29 +00:00
Alf Eaton
165520a6f2 Refactor scoped layout values into LayoutContext (#5356)
GitOrigin-RevId: b0b07ddd078bfc5acd944cac14bc00dc83d09d21
2021-10-11 08:03:17 +00:00
Miguel Serrano
8766c45362 Add log limit and info notice to PDF Preview log view (#5390)
GitOrigin-RevId: 14764d109dbe13d7e4fb4f79f098c74d4b57d59d
2021-10-11 08:03:13 +00:00
Alf Eaton
ffc72416ff Move clsiServerId and compileGroup from ide to ide.$scope.pdf (#5314)
GitOrigin-RevId: 6050898614b4fc9dee52e893149acfda17c324a0
2021-10-11 08:03:10 +00:00
Miguel Serrano
07ca18cdbb Added keyboard shortcuts for zoom (#5334)
GitOrigin-RevId: b284f923e9b4aba7837430239b09e05bb0308d09
2021-10-11 08:03:07 +00:00
Alf Eaton
b902bd9265 Refactor compile-related code from PDF preview context provider into a separate class (#5341)
GitOrigin-RevId: 96b8bb527fa3d60a5fb84eee2b8f4fabc1726875
2021-10-11 08:02:56 +00:00
June Kelly
03e1daa038 Merge pull request #5201 from overleaf/msm-pdf-viewer-error-boundaries
Error boundaries for React PDF viewer

GitOrigin-RevId: 90052fc183f7ece8125ecfb0410a529cf905c13b
2021-10-07 08:03:43 +00:00
June Kelly
1e7dbeeb94 Merge pull request #5180 from overleaf/msm-pdf-js-viewer-tests
Unit Tests for `pdf-js-viewer.js`

GitOrigin-RevId: 4bd38cf98c598e2ea30791052b9c24568d92c6b8
2021-10-07 08:03:30 +00:00
Alf Eaton
73bc3418a2 Add React version of the PDF preview pane (#5135)
GitOrigin-RevId: fcc88a362c3e97c9fddf85d47c3a83a0a0b89432
2021-10-01 08:03:12 +00:00
Alf Eaton
deafe456b4 Merge pull request #4913 from overleaf/ae-pdf-preview-feature-flag
Add feature flag for React PDF preview pane

GitOrigin-RevId: ac1e7329d13117e72de6f6cf060cd16be81cbbaa
2021-09-06 08:02:52 +00:00