Commit graph

23582 commits

Author SHA1 Message Date
Eric Mc Sween
9648c6711c Merge pull request #20592 from overleaf/em-mj-load-history-version
Load a specific version in the admin history debugging panel

GitOrigin-RevId: 302832b981688a6697c21122372230c285911d24
2024-09-25 08:06:24 +00:00
Jessica Lawshe
e4b3ee8988 Merge pull request #20508 from overleaf/as-cms-bs5-link-colours
[web] Adjust link behaviour for Website Redesign in BS5

GitOrigin-RevId: d09831de1f51c4e2a9bc06b0c9fd9f4a1909d7f0
2024-09-25 08:06:19 +00:00
Jessica Lawshe
e8f602db9b Merge pull request #20545 from overleaf/jel-remove-comment
[web] Remove commented out CSS code

GitOrigin-RevId: 8d6c392735eb2637a3c7bbc4cd4d17d5dc92d1e4
2024-09-25 08:06:11 +00:00
Jessica Lawshe
ecb0655241 Merge pull request #20572 from overleaf/jel-cms-styled-list
[web] Render styled lists on `Element | Content`

GitOrigin-RevId: 9d951e2339a85cc89b14991bbde2bc4d4316852a
2024-09-25 08:06:06 +00:00
Jessica Lawshe
d43efc2d7c Merge pull request #20523 from overleaf/jel-cms-padding-fix
[web] CMS BS5 - Fix mobile top padding when columns reversed, apply `max-width` to rows as cards

GitOrigin-RevId: 0c8745c171dc8e24389b2e54e4d6fd605c30e145
2024-09-25 08:06:01 +00:00
Jessica Lawshe
705035a972 Merge pull request #20544 from overleaf/jel-cms-bs5-fonts
[web] Font size overrides for CMS BS5 pages

GitOrigin-RevId: 0803b3b76b3a1c60a26bf56d94a27d67270b7313
2024-09-25 08:05:55 +00:00
Davinder Singh
ba0f95aaf0 BS5 Migration - Blog post cards migration to BS5 (#20539)
* copying blog-posts.less into blog-posts.scss, will not compile yet

* making variable changes in the file

* adding card-body under blog-post

* adding spacing-09 to the list

* format:fix

* rendering bs5 for blog/blog_post

* adding card-body for blog post page card

* fixing some linting errors

* adding neutral-40 as a replacement of ol-blue-gray-2

* selecting the closest spacing

* removing margin

GitOrigin-RevId: e0cad15cec2adccb41d773e38feb99d9fd9f5e07
2024-09-25 08:05:38 +00:00
Davinder Singh
4c2425fe25 Premium Badge - BS5 migration (#20496)
* migrating premium badge to BS5 and changing the unit test

* fixing unit test

* using badge badge-prepend classes for the premium badge

* fixing unit test

* adding font-weight variable

* removing unused CSS

* adding aria-hidden

GitOrigin-RevId: a1ab2eeedd95ee500c21607abd09a0a8a07289f0
2024-09-25 08:05:33 +00:00
Davinder Singh
248fc3699a CMS Bootstrap 5 migration - Tabs using bootstrap 5 classes (#20478)
* adding classes according to bootstrap 5 tabs

* adding JS for tabs handeling in BS5

* adding styling for tabs to match the redesign styling

* making sure tabs are being highlighted when active

* adding a scroll-margin-top to have some extra space

* removing extra import, it is not needed here because we already import it in bootstrap-x.js files

* using the media-breakpoint-down for a media query styling

* introducing .nav-tabs-container to make the tab triggers horizontally scrollable

* creating a mixin box-shadow-button-input under scss for bootstrap-5

* moving border-width-base to tabs.scss

* aligning tabs to the left under screen size of 768px

* removing focus-style mixin from scss files becuase it was a duplicate

GitOrigin-RevId: 45780c62681fc9b61961f5436d2d55de66a976b6
2024-09-25 08:05:21 +00:00
Liangjun Song
7a4ddd1570 Merge pull request #20473 from overleaf/ls-clean-up-password-authentication-removal
clean up pw auth deprecation gradual rollout

GitOrigin-RevId: 0d74031e4d1381cd9a9a49f7e3cea72ad2aa1fe7
2024-09-25 08:05:16 +00:00
Liangjun Song
180718678c Merge pull request #20498 from overleaf/ls-remove-pw-grant-logic
remove password grant logic

GitOrigin-RevId: ba42deea5824e6f91affceaa19c4d523ec73ce4c
2024-09-25 08:05:11 +00:00
David
7002d1e4bf Merge pull request #20511 from overleaf/dp-review-panel-footer
Update UI for new review panel footer

GitOrigin-RevId: 8beb554f78fa5876d5349981d96b44a16ab5567c
2024-09-25 08:05:07 +00:00
David
ab43a44b76 Merge pull request #20526 from overleaf/dp-mini-review-panel
Styling updates for mini review panel

GitOrigin-RevId: 1bbf7f1d2e02f5d6f3f50937d2b7b9cdc5a0878f
2024-09-25 08:05:02 +00:00
David
9d3841a46d Merge pull request #20517 from overleaf/dp-overview-edit-actions
Don't allow tracked changes to be edited in the overview tab in new review panel

GitOrigin-RevId: 132771c4105096034bf58bc3d4a7ba23c3d088b7
2024-09-25 08:04:57 +00:00
andrew rumble
35afb713a3 Upgrade mongodb-legacy and mongoose to latest
GitOrigin-RevId: a581ebca5a3c0108ad37a6ea55b7772a065793d9
2024-09-24 08:06:36 +00:00
andrew rumble
0c428e149f Update mongoose count usages to countDocuments
count was removed see:
https://mongoosejs.com/docs/migrating_to_8.html#removed-count.

GitOrigin-RevId: 308c8f4b681269c29669c45b5f2022404b3af463
2024-09-24 08:06:32 +00:00
andrew rumble
5f699ac5ef Fix findOneAnd* usages
findOneAnd* now returns either a document or null rather than a result
set (unless the result set is requested explicitly). See
https://www.mongodb.com/blog/post/behavioral-changes-find-one-family-apis-node-js-driver-6-0-0.

GitOrigin-RevId: 93dc64cbcc663217f914cf9e9821e2b9642154db
2024-09-24 08:06:28 +00:00
andrew rumble
5b1c0c5008 Fix use of fake ObjectIds in tests
12 character strings are no longer valid see:
https://github.com/mongodb/js-bson/releases/tag/v6.0.0 (Strings of
length 12 can no longer make an ObjectId)

GitOrigin-RevId: 2590c10915c50b951f991b2cf161d80235e445ca
2024-09-24 08:06:23 +00:00
Alf Eaton
9180d85c87 Replace bson import with mongodb
GitOrigin-RevId: f353eb6f76bac55f576c932d868e26322e2e3967
2024-09-24 08:06:15 +00:00
Alf Eaton
907195931d Fix BSON usage
GitOrigin-RevId: ce495bca0a82c9bb973d5b755abdd22894840290
2024-09-24 08:06:11 +00:00
Alf Eaton
da020196b3 Upgrade bson
GitOrigin-RevId: 8acce817daab7a2b791e73cbc81ef88ac3a91fbc
2024-09-24 08:06:03 +00:00
Jakob Ackermann
baaac44172 Merge pull request #20302 from overleaf/jpa-object-persistor-metrics
[object-persistor] add more metrics to getObjectStream and sendStream

GitOrigin-RevId: 9fe6b9d205de6ad27838f91d92d2b3a3d6c2f129
2024-09-24 08:05:54 +00:00
Jakob Ackermann
8fa676082e Merge pull request #20299 from overleaf/jpa-object-persistor-metrics-dep
[object-persistor] depend on @overleaf/metrics directly

GitOrigin-RevId: eb0c07af8101d44def14154abb552bc77254e074
2024-09-24 08:05:50 +00:00
Jakob Ackermann
3ba3ffe56d Merge pull request #20277 from overleaf/jpa-ro-mirror-chunk
[misc] use Chunk for read-only mirror in frontend

GitOrigin-RevId: b97e520c7a63015179792542310d18f346752e92
2024-09-24 08:05:42 +00:00
Jakob Ackermann
18a052f224 Merge pull request #20551 from overleaf/jpa-docker-cleanup
[misc] fix deprecated syntax for ENV entries in all the Dockerfiles

GitOrigin-RevId: 1def5a4666435e7649b8b09557a445d016f3ef5a
2024-09-24 08:05:37 +00:00
andrew rumble
bb12dd33ee Capture more logging information for output.zip errors
GitOrigin-RevId: a2f15d05100dfdba06778a1a795c8eabefd2666d
2024-09-24 08:05:33 +00:00
andrew rumble
d4911ea246 Stop waiting for finalize
Finalize promise will only resolve when the archive is closed. We want
to stream as soon as we have the data so this does not suit us. We want
to log errors that are thrown due to finalize, these should be
propogated by archiver to the response already.

GitOrigin-RevId: 4f9d727a00ead1be3caee62e1e0adba069a545c7
2024-09-24 08:05:28 +00:00
andrew rumble
d4824b9c5f Get full path only when adding file to archive
This allows us to:
* Get files that are in subdirectories (not known to happen but might as
well support)
* Removes need to sanitise missing_files output

GitOrigin-RevId: 4b27b7f1b506578a6d713ea23979aa9370dfdcb0
2024-09-24 08:05:24 +00:00
andrew rumble
60a75d12b0 Rename files to reflect refactoring elsewhere
GitOrigin-RevId: 335f876913b7868cf69dcd55dd156261edd98945
2024-09-24 08:05:19 +00:00
andrew rumble
487d9125a2 Improve stream error safety
GitOrigin-RevId: de4c512a62d304b3eeb2a1521aac173fa93d8411
2024-09-24 08:05:15 +00:00
andrew rumble
1409e32010 Move logging into ArchiveManager
GitOrigin-RevId: 71a28a0215c5f1a6975c9e2fcdcd476513df1cbc
2024-09-24 08:05:10 +00:00
andrew rumble
c387e60a28 Remove unnecessary symlink check
GitOrigin-RevId: 08d7295403a258818276b9fbd7666a20fbc2e00f
2024-09-24 08:05:06 +00:00
andrew rumble
3fa35ef03a Share ignore logic between web and clsi
GitOrigin-RevId: c4ae306413efb71989d2db410c3859cb69b3d5de
2024-09-24 08:05:01 +00:00
andrew rumble
d627a0bee9 Remove files param from output.zip endpoint
GitOrigin-RevId: 300cd870578237ad8e61be4e9e41991f884aa754
2024-09-24 08:04:57 +00:00
andrew rumble
c764566148 Allow all files to be in zip (in same directory)
GitOrigin-RevId: 14645a0c3db88faf00e2718b9574b5892ac3efcb
2024-09-24 08:04:53 +00:00
Antoine Clausse
2179d62d74 Merge pull request #20549 from overleaf/revert-20165-ac-update-node-fetch
Revert "Upgrade node-fetch to 2.7.0"

GitOrigin-RevId: 928df97c6fbc81f21097aaf9c331b0c70eeac002
2024-09-24 08:04:44 +00:00
Antoine Clausse
da3553d800 Upgrade node-fetch to 2.7.0 (#20165)
* Set `node-fetch` to `^2.7.0`

* Update package-lock.json

```
# root
bin/npm update node-fetch
bin/npm update cross-fetch

# in other path in docker
npm update node-fetch
```

* Update node-fetch patch

* [fetch-utils] Skip the test: destroys the request body if it doesn't get consumed

```
  1) fetch-utils
       fetchJson
         destroys the request body if it doesn't get consumed:
     FetchError: Invalid response body while trying to fetch http://example.com:30001/json/ignore-request: write EPIPE
      at PassThrough.<anonymous> (/overleaf/node_modules/node-fetch/lib/index.js:400:12)
      at PassThrough.emit (node:events:529:35)
      at emitErrorNT (node:internal/streams/destroy:151:8)
      at emitErrorCloseNT (node:internal/streams/destroy:116:3)
      at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
```

* [fetch-utils] Delete the test: destroys the request body if it doesn't get consumed

* Remove the `setTimeout` in the node-fetch patch

Fixes a test and doesn't break filestore acceptance tests

* Update node-fetch patch again: bring changes from https://github.com/node-fetch/node-fetch/blob/e87b093/src/index.js

* Update node-fetch patch again: bring changes from https://github.com/node-fetch/node-fetch/blob/e87b093/src/index.js

* Update node-fetch patches back to single lines

Per https://github.com/overleaf/internal/pull/20165#discussion_r1739035513

GitOrigin-RevId: 945e5a12e838673b7bc87b588b7aca1bcd9109e2
2024-09-24 08:04:39 +00:00
Alf Eaton
2976fd0b44 Fix Dockerfile FromAsCasing warnings (#20388)
GitOrigin-RevId: 6d6be3ba17eec695907dde25da2dbe98818fae10
2024-09-23 08:04:52 +00:00
Eric Mc Sween
250acbf33c Merge pull request #20520 from overleaf/em-ts-import
Use new import JSDoc syntax for Typescript annotations

GitOrigin-RevId: 782456d637fc8f2de6163b5d70fabf06c1d74964
2024-09-23 08:04:47 +00:00
Antoine Clausse
6972186161 [latexqc] Disable cross-origin-*-policy (#20529)
* [latexqc] Disable `crossOriginEmbedderPolicy`

* [latexqc] Disable `crossOriginOpenerPolicy` and `crossOriginResourcePolicy`

* [latexqc] Update to helmet v7

* [latexqc] Disable `xPermittedCrossDomainPolicies`

GitOrigin-RevId: 36e4138b4ecb29fb8692f174e4f192f6eb554dc9
2024-09-23 08:04:42 +00:00
Antoine Clausse
3c459e2032 [latexqc] Update frontend dependencies (#20310)
* Add `LaTeX Quality Control` to the readme

* Update dependencies

* Match `web` version
* Update to modern packages
* Update to modern versions

* Import `Link` from `react-router-dom`

* Import Helmet correctly

* Remove `react-router-redux`

It seems that we're not actually getting anything from it (?)

* Update component containers/App

* Revert unecessary changes to containers/App

* Update component containers/Upload

* Revert unnecessary changes to container/Upload

* Fix links

* Add `withNavigation` HOC
* Fix link to `/upload`
* Remove unneeded `navigate` props

* SSR: Use `StaticRouterProvider`

* CSR: Use `createBrowserRouter`

* SSR: Simplify since we don't need to perform queries

* Add `data-testid`s to components

* Update tests (`enzyme` -> `@testing-library`)

* Remove unneeded "before" in tests

* Revert "Remove unneeded "before" in tests"

(actually necessary)

* Rename `devToolsExtension` to `__REDUX_DEVTOOLS_EXTENSION__`

Per https://github.com/zalmoxisus/redux-devtools-extension/issues/220

* Return 404 on invalid paths

* Remove unuseds dependencies

* Re-implement react-router `onUpdate` with `RouteChangedHandler`

It appears that `onUpdate` was removed from react-router
https://github.com/remix-run/react-router/issues/4278

* Update package-lock

* Remove debug log

GitOrigin-RevId: 3244b4266b53ac57a92ed4adc7c0e00b93a6b361
2024-09-20 08:06:00 +00:00
MoxAmber
2c53687ea1 Merge pull request #20477 from overleaf/as-jel-cms-bs5-quotes
[web] Use Bootstrap 5 for CMS Quotes

GitOrigin-RevId: 9f3699cd4588412176466ebfea1ddfa160da1535
2024-09-20 08:05:55 +00:00
MoxAmber
4b281becdd Merge pull request #20468 from overleaf/jel-cms-bs5-top-padding
[web] Update top padding on CMS BS5 pages

GitOrigin-RevId: c663886a9f28992a7056ac3f568980d1a5603699
2024-09-20 08:05:50 +00:00
MoxAmber
68eaec6d8e Merge pull request #20485 from overleaf/jel-cms-bs5-mobile-breakpoint
[web] Update mobile breakpoint for CMS pages using BS5

GitOrigin-RevId: b855faf378b03788caff8574747d88b96706de2a
2024-09-20 08:05:46 +00:00
MoxAmber
d9e5411ef3 Merge pull request #20444 from overleaf/td-bs5-add-non-react-types
Add types for Bootstrap 5 vanilla JavaScript

GitOrigin-RevId: 94efb0ba8fb0cea65f8a0993940bf76cd197c61e
2024-09-20 08:05:41 +00:00
MoxAmber
2a2ba46fc6 Merge pull request #20291 from overleaf/as-update-favicons
Update favicons and improve PWA icon support

GitOrigin-RevId: 972aae6b3791ba61a58787414eb6507f95ee8744
2024-09-20 08:05:36 +00:00
MoxAmber
d7a482966f Merge pull request #20463 from overleaf/as-jel-cms-text-align
[web] Option on CMS pages to center text only on destkop or mobile devices

GitOrigin-RevId: fd5006e4b46c53627cdc39cc41ea75f016411003
2024-09-20 08:05:31 +00:00
Eric Mc Sween
889fa1a3c3 Merge pull request #20317 from overleaf/em-github-sync-errors
Replace alerts with notifications in the github-sync modal

GitOrigin-RevId: 772add41b2d525353dc0c0362ebc64c4a023e2c3
2024-09-20 08:05:26 +00:00
David
af6ffdcf7c Merge pull request #20409 from overleaf/dk-selectLineOnFocus-fix
Fix scroll issue when focusing a change in new review panel

GitOrigin-RevId: 55784de415f65935ad9b1a8cd3ad82ea3ddac3c1
2024-09-20 08:05:17 +00:00
David
22e4c2de2c Merge pull request #20411 from overleaf/dk-highlight-focus-ranges
Highlight and focus ranges in editor for new review panel

GitOrigin-RevId: 4fef31a8c9e6dc974519d925c7478665e0c8cc29
2024-09-20 08:05:13 +00:00