Commit graph

37 commits

Author SHA1 Message Date
Alf Eaton
2304536844 Add review panel context providers and components (#19490)
* Tidy up review panel components

* Add ReviewPanel providers

* [web] new design for review panel track change (#19544)

* [web] new design for review panel track change

* fixed mini view

* mini icon style change

* fix icon size

* format date

* useRangesUserContext hook

* remove useRangesUserContext hook

* using full class names

* fix action icons hover

* change wording for tooltips

* added ReviewPanelChangeUser component

* Update header in new review panel

* Extract ReviewPanelTrackChangesMenuButton as a separate component

* Remove wrapper div

* Replace h2 with div for review panel label

* Rename ReviewPanelTools to ReviewPanelHeader

* Rename trackChangesExpanded -> trackChangesMenuExpanded

* Dont break memoisation of ReviewPanelTrackChangesMenuButton

* Fix the width of the track changes arrow icon

* Update how prop types are declared

* Remove new empty state from old review panel

* Add empty state to new review panel

* Add project members and owner to ChangesUsers context (#19624)

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

* Redesign comment entry in review panel (#19678)

* Redesign comment entry in review panel

* ReviewPanelCommentOptions component

* remove unused prop

* Tidying

* Add conditional import

* Optional changeManager

* Add more split test compatibility

* More split test compatibility

* Fixes

* Improve overview scrolling

* Fix overview scrolling

* Fix & simplify track changes toggle

* Fix overview scrolling

* Fix current file container

* ExpandableContent component for messages in review panel (#19738)

* ExpandableContent component for messages in review panel

* remove isExpanded dependancy

* Delete comment option for new review panel (#19772)

* Delete comment option for new review panel

* dont show thread warning if there are no replies

* fix hasReplies issue

* Implement initial collapsing overview files

* Fix positioning of overview panel

* Small styling changes

* Add count of unresolved comments and tracked chanegs

* More style adjustments

* Move review-panel-overview styles into css file

* Remove unused var

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
Co-authored-by: David Powell <david.powell@overleaf.com>
Co-authored-by: David <33458145+davidmcpowell@users.noreply.github.com>
GitOrigin-RevId: e67463443d541f88445a86eed5e2b6ec6040f9c7
2024-08-13 08:04:20 +00:00
Jakob Ackermann
d2464abc7c Merge pull request #19816 from overleaf/jpa-type-tweaks
[web] minor typescript tweaks

GitOrigin-RevId: df459d2c00652a3d183cae123f39a01dd17c7ec6
2024-08-07 08:05:08 +00:00
Alf Eaton
c24ace801b Remove Angular (#17534)
GitOrigin-RevId: 7a0d45e17d9905fa75569e2d19ca59caa4a41565
2024-06-06 08:04:09 +00:00
Domagoj Kriskovic
8bde496da4 Send operations to project-history when resolving/unresolving comments (#17540)
* Send operations to project-history when resolving/unresolving comments

* small fixes

* added doc_id in web unit test

* Revert "added doc_id in web unit test"

This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.

* fix mocked dependency in test

* wip: web unit tests

* document updater, reopen test

* document-updater tests

* format fix

* fix typo

* fix callsArgWith

* fix reopenThread calls in doc updater tests

* fix typos

* log error if chat api resolve failes

* log error when reopening thread

* sendStatus calls done() in tests

* using OError instead of logging

* removed timers

* preserve legacy endpoints

* update after merge

* Remove timer check in HttpControllerTest

* prettier

* added "legacy" in log

* remove metrics.timer

* fix promisify issues

* remove unused cb

GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
2024-04-10 08:04:08 +00:00
Alf Eaton
749660e168 Refactor review panel context (#17383)
GitOrigin-RevId: 23e7ff8632172ebd0bc544a2297d1d4179010832
2024-03-07 16:30:25 +00:00
ilkin-overleaf
20485b886f Merge pull request #16278 from overleaf/ii-ide-page-prototype-review-panel-entry-hover
[web] Remove entry hover from review panel

GitOrigin-RevId: 6bcfb28e20d7a8826301c34499340b6a7d2745db
2024-01-04 09:03:14 +00:00
ilkin-overleaf
fbed0cb943 Merge pull request #16268 from overleaf/ii-ide-page-prototype-review-panel-layout-to-left
[web] Review panel popovers

GitOrigin-RevId: 4424abab97b197013063679bd8efcac001f458ad
2023-12-18 09:04:18 +00:00
ilkin-overleaf
c3689ca6f3 Merge pull request #16138 from overleaf/ii-ide-page-prototype-review-panel-overview-loading
[web] React ide page overview switch

GitOrigin-RevId: 9a24a8ba9ed8e86d486a12a65259d25c1352c864
2023-12-08 09:04:19 +00:00
ilkin-overleaf
8035241cc0 Merge pull request #16065 from overleaf/ii-ide-page-prototype-review-panel-add-comment
[web] React ide page add comment

GitOrigin-RevId: 4c2442ccc77760d4a27268551c9dd2d73fcdba84
2023-12-05 09:04:06 +00:00
ilkin-overleaf
de945a432d Merge pull request #15999 from overleaf/ii-ide-page-prototype-review-panel-accept-reject-changes
[web] React ide page accept/reject changes

GitOrigin-RevId: 0bb8e3759c7edbef16be04b2f200ae3686c3a53c
2023-11-30 09:03:43 +00:00
ilkin-overleaf
81f5a1308e Merge pull request #15909 from overleaf/ii-ide-page-prototype-review-panel-refresh-ranges
[web] React ide page refresh ranges

GitOrigin-RevId: 7f79b8f63869ee39fef9a101e6dcc56c39af8df7
2023-11-27 09:04:26 +00:00
ilkin-overleaf
a75b44a6fc Merge pull request #15861 from overleaf/ii-ide-page-prototype-review-panel-delete-thread
[web] React ide page delete thread

GitOrigin-RevId: 46e93d67d597a2277c771bda2a4837a871339224
2023-11-27 09:04:19 +00:00
ilkin-overleaf
e4f5afc0c0 Merge pull request #15829 from overleaf/ii-ide-page-prototype-permissions
[web] React ide page permissions

GitOrigin-RevId: 727d33e0654d4bfefe5e710e553895f793cacb82
2023-11-24 09:04:27 +00:00
Tim Down
86c06d8c99 Merge pull request #15815 from overleaf/td-persist-unsaved-comment
Persist unsaved comment in the front end after not submitting

GitOrigin-RevId: a7ffee6f5fbfb7151a2ef7233ba4412d0db33e19
2023-11-22 09:04:21 +00:00
ilkin-overleaf
7db5d761ea Merge pull request #15557 from overleaf/ii-ide-page-prototype-review-panel-track-changes
Review panel track changes for React IDE page

GitOrigin-RevId: d061596581ff10bd897b286dcd5c280ce79a6384
2023-11-17 09:03:02 +00:00
Tim Down
6f34a84ebd Merge pull request #15684 from overleaf/td-ide-page-main-doc-left-menu
Add docs to FileTreeDataContext to replace 'docs' scope value in React code

GitOrigin-RevId: 430f795eb0cd17f0f4fab9c61e46fb04ff3030b3
2023-11-14 09:04:40 +00:00
ilkin-overleaf
0c403bf8e3 Merge pull request #15397 from overleaf/ii-ide-page-prototype-review-panel
Init review panel for React IDE page

GitOrigin-RevId: fc23201055ae892c5c1d5cb88e472a0bb0cd6c25
2023-11-03 09:00:02 +00:00
Domagoj Kriskovic
20f49ae325 send comment over sharejs after thread is created (#14807)
* send comment over sharejs after thread is created

* only react version

* loading gif

GitOrigin-RevId: a6b16a8cae66faa3219f1c9141ee04e303d9f11b
2023-09-21 08:04:05 +00:00
Tim Down
5cce9683fa Merge pull request #14628 from overleaf/td-review-panel-scroll-jump
Fix scroll jump and improvements to React review panel layout and performance

GitOrigin-RevId: 3123f90abeb1bf9712ba4025a272e13990aebbd9
2023-09-06 08:06:32 +00:00
Tim Down
f2b5ac23f8 Merge pull request #13997 from overleaf/td-review-panel-mini-hover
React review panel: make hovering an entry in the mini review panel display correctly

GitOrigin-RevId: 41a40e4047b89d2a8db15b2e12baf04c11b78e21
2023-07-25 08:03:55 +00:00
Tim Down
0d3af56efa Merge pull request #13911 from overleaf/td-review-panel-performance
Review panel: memoize entry views for performance

GitOrigin-RevId: 3c305845ad0914a7ffeb595e7235d7dceb4c780a
2023-07-21 08:04:49 +00:00
Tim Down
38c673d057 Merge pull request #13720 from overleaf/td-review-panel-entry-pos
React review panel entry positioning

GitOrigin-RevId: c22617b1d3243b7d54b093426358aeb291421b9e
2023-07-19 08:03:52 +00:00
ilkin-overleaf
dbef201e3f Merge pull request #13801 from overleaf/ii-review-panel-migration-upgrade-track-changes-modal
[web] Create upgrade track changes modal

GitOrigin-RevId: 704ddef862ea9a2f8ca2bf63880da6e88f783724
2023-07-17 11:07:16 +00:00
ilkin-overleaf
84bbdf9772 Merge pull request #13767 from overleaf/ii-review-panel-migration-in-editor-widgets
[web] Create in editor widgets

GitOrigin-RevId: 53dfb9935ee59bbdedc353aad5e5b19f389a513c
2023-07-17 11:07:06 +00:00
ilkin-overleaf
13a7e752d5 Merge pull request #13710 from overleaf/ii-review-panel-migration-bulk-actions-entry
[web] Create bulk actions entry and bulk actions modal

GitOrigin-RevId: c88ce6213304a110ee7410529813310b863178c1
2023-07-17 10:59:19 +00:00
ilkin-overleaf
225de683c7 Merge pull request #13687 from overleaf/ii-review-panel-migration-add-comment-entry
[web] Create add comment entry

GitOrigin-RevId: 019f508eeb3982fce082df153e56d6c3c3e3bae5
2023-07-17 10:56:42 +00:00
Davinder Singh
b1f246b9ba Merge pull request #13658 from overleaf/ii-review-panel-migration-change-entry
[web] Create change entries

GitOrigin-RevId: 4d49f8b02b9bfcfe470f6db21f5347080ff47562
2023-07-17 10:53:56 +00:00
ilkin-overleaf
936ab81b65 Merge pull request #13641 from overleaf/ii-review-panel-migration-overview-view
[web] Create overview view shell for review panel

GitOrigin-RevId: 21cc8a744253aec53f089ec6e6c1221d7153f3a4
2023-07-17 10:50:58 +00:00
ilkin-overleaf
e5d6777211 Merge pull request #13628 from overleaf/ii-review-panel-migration-resolved-comments-entry
[web] Add resolved comments entries functionality

GitOrigin-RevId: f0a8365b00c0861be12347aeaf486f7c02faf8e5
2023-07-17 10:47:41 +00:00
ilkin-overleaf
9e8be31bdf Merge pull request #13573 from overleaf/ii-review-panel-migration-comment-entry
[web] Create comment entries

GitOrigin-RevId: 7f3fbe672d18d57a0f5e683e5456ea79ed295e2d
2023-07-17 10:45:32 +00:00
ilkin-overleaf
b61ee4c4d3 Merge pull request #13528 from overleaf/ii-review-panel-migration-current-file-view
[web] Create initial current file container

GitOrigin-RevId: 81635922bb10b97637af296d987f28d43cf61262
2023-07-17 10:42:51 +00:00
ilkin-overleaf
423f2604db Merge pull request #13500 from overleaf/ii-review-panel-migration-nav
[web] Create review panel navigation

GitOrigin-RevId: abed4171e9fd52de2f137a6cf7456791bc2ca161
2023-07-17 10:39:20 +00:00
ilkin-overleaf
15f4e2e5cc Merge pull request #13487 from overleaf/ii-review-panel-migration-create-panel-toggler
[web] Create review panel toggler

GitOrigin-RevId: f50422b99dbd8bbc2f1fbf323419ee13403c9ba6
2023-07-17 10:36:11 +00:00
ilkin-overleaf
e514e97305 Merge pull request #13438 from overleaf/ii-review-panel-toolbar-shell
[web] Create review panel toolbar shell

GitOrigin-RevId: 561fb18e1239c9b96b52944716a83cf3b8606677
2023-07-17 10:34:04 +00:00
ilkin-overleaf
9b930d2849 Merge pull request #13414 from overleaf/ii-review-panel-migration-create-context-api-fix
[web] Create context api for review panel FIX

GitOrigin-RevId: fc6d8adf18d07e71b529a28deab4d49d62c43587
2023-07-17 10:32:07 +00:00
Alf Eaton
480ec139ab Merge pull request #13408 from overleaf/ae-revert-resolve-comment
Revert "create context api for review panel"

GitOrigin-RevId: 3be70d7afbe4f238a27149ab2de38175cf1bf029
2023-07-17 10:30:27 +00:00
ilkin-overleaf
1918ef3767 Merge pull request #13378 from overleaf/ii-review-panel-migration-create-context-api
[web] Create context api for review panel

GitOrigin-RevId: 3d550e2f3c14ecd0586d088f4ecb75acd44aa782
2023-07-17 10:29:53 +00:00