Commit graph

997 commits

Author SHA1 Message Date
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
Tim Down
d93bd9d4c8 Merge pull request #20327 from overleaf/td-bs5-project-notification-space
BS5 project dashboard: remove space contributed by empty notifications container

GitOrigin-RevId: 77469e8ff3eb2bdc1c6af12307c55d75dedca9b5
2024-09-10 08:05:09 +00:00
ilkin-overleaf
8b3ffe58fa Merge pull request #20231 from overleaf/ii-bs5-ide-header-light
[web] BS5 IDE light header

GitOrigin-RevId: 39403afae76f267228fb286492ad50e8e88e31be
2024-09-09 08:05:10 +00:00
Mathias Jakobsen
7d80d22e96 Merge pull request #20233 from overleaf/mj-restore-promo
[web] Add promotion for file/project reverting

GitOrigin-RevId: 9f8e66ab2ad945274576800253d288bca5986562
2024-09-09 08:05:01 +00:00
Mathias Jakobsen
abc1aff3a1 Merge pull request #20300 from overleaf/mj-synctex-button-cursor
[web] Fix synctex buttons cursor

GitOrigin-RevId: 87fc77801fa1bf09652823225974567bee5cd2bc
2024-09-06 08:05:39 +00:00
Mathias Jakobsen
663e2304f6 Merge pull request #20272 from overleaf/revert-20268-revert-19885-mj-resizeable-panels
[web] Upgrade react-resizable-panels (2nd attempt)

GitOrigin-RevId: 643a90044dac0daf39245fa29267b16550fd6e69
2024-09-06 08:05:28 +00:00
M Fahru
eb75c6e627 Fix sticky header is terminated earlier than it should because of the margin in the header element (#20275)
GitOrigin-RevId: 35e9e9c5a0212019b27d5090627c20cec1e7575a
2024-09-06 08:05:20 +00:00
Davinder Singh
88c8e2bdfa Plans page - Fixes the accessibility issues on the plans page (#20258)
* adding the li within ul to fix the accessibility issue from axe dev tools

* adding aria-label on the button

* adding a translation

GitOrigin-RevId: de46c7f1a71d7921b7ab88299441c50ef666cae2
2024-09-06 08:04:56 +00:00
M Fahru
9ed8b82acc Reduce font-size and line-height for interstitial page mobile table price (for light-design variant)
GitOrigin-RevId: f227346c6a45bb7352caa9aa15d16788bc115df0
2024-09-05 08:06:07 +00:00
Davinder Singh
56b69a743b Plans page redesign - [light-design] Use the new "request overleaf common" UI on the student tab (#20199)
* making the university info section in students tab to follow the new design.

* adding the left alignment of the button

* adding light keyword for the classes that are being used in the light design version for this university info card

* removing text-capitalize class

* deleting the comment

GitOrigin-RevId: 641613cf6ab73edef57b917b58ebf10b698572d3
2024-09-05 08:05:52 +00:00
Davinder Singh
f8f111d023 Merge pull request #20154 from overleaf/ds-plans-annual-monthly-toggle-switch-gap
Plans page - Annual/Monthly toggle switch gap removal

GitOrigin-RevId: e14b1a595b127e7b22dc3fa6f5d679629ead3e0b
2024-09-05 08:05:48 +00:00
ilkin-overleaf
86689a6269 Merge pull request #20205 from overleaf/ii-bs5-ide-header
[web] BS5 ide page header

GitOrigin-RevId: b7aad221d458d8403d60ff9950129394c74af856
2024-09-04 08:06:00 +00:00
Rebeka Dekany
39b6b8baed Merge pull request #20172 from overleaf/rd-ide-fileoutline
[web] Migrate the file outline styling from LESS to SCSS

GitOrigin-RevId: 5e485b13a7358e5dcab2c75ee7d36a07e1401e26
2024-09-04 08:05:12 +00:00
Alf Eaton
27e558b484 Fix image upload modal dropzone overflow (#20102)
GitOrigin-RevId: 8caf4e631056ed00b167cff8a6cccea0e0ff8ae7
2024-09-04 08:05:02 +00:00
Alf Eaton
284a8256d4 Fix tag name overflow in projects list (#20120)
GitOrigin-RevId: 9fc317dbebd8115ab8af97f4753350f5ee79c1cd
2024-09-04 08:04:57 +00:00
roo hutton
31bb5939a1 Merge pull request #20156 from overleaf/rh-share-modal-dropdown-fix
[web] Add explicit width to share modal permission dropdown

GitOrigin-RevId: df20cedfffffb2ba8291dcae128845a03b2897ba
2024-09-04 08:04:39 +00:00
Jessica Lawshe
feddc2158f Merge pull request #20186 from overleaf/jel-discount-color
[web] Increase color contrast on new plans page discount badge

GitOrigin-RevId: 3230a2debdf1c23a0b18b32b8062d5108f7e32ce
2024-09-02 08:05:35 +00:00
Jessica Lawshe
f8b10a41dc Merge pull request #20183 from overleaf/jel-plans-discount-line-height
[web] Fix line height on new plans discount badge

GitOrigin-RevId: e253c6f3fc66988d4eb978fc46002f1b9ad31ed1
2024-09-02 08:05:30 +00:00
Jessica Lawshe
27b4dfbd79 Merge pull request #20174 from overleaf/jel-plans-page-query-param-part-3
[web] New plans page elements that are dependent on plan period type

GitOrigin-RevId: 677d4df1544aa901dd5c57d61c395f3045c1c024
2024-08-30 08:04:55 +00:00
Jessica Lawshe
3b864d4345 Merge pull request #20155 from overleaf/jel-plans-page-query-param-part-2
[web] Render initial plans tab on server

GitOrigin-RevId: cb4d59274c0fd2a40fd35b5301d0bd387e738a98
2024-08-30 08:04:50 +00:00
Jessica Lawshe
3c86912f61 Merge pull request #20072 from overleaf/jel-plans-period-toggle
[web] Put plans period toggle within tabs that use it

GitOrigin-RevId: ccc2594467b3b31dd3fda82dd23e058911d0ec82
2024-08-30 08:04:34 +00:00
Rebeka Dekany
f6213de83b Merge pull request #20140 from overleaf/rd-footer-react
[web] Migrate the footer to React

GitOrigin-RevId: 9571d7b3ef9a267fb8250956f821b1ee34ce07c7
2024-08-30 08:04:29 +00:00
M Fahru
250514b28e Merge pull request #20143 from overleaf/mf-fix-plan-features-mobile-header-text
[web] Change "Collaborator" text to "Standard" in individual tab plans (plans page and interstitial page new design)

GitOrigin-RevId: 064bb59b3fb84f1fb413035acc40e7f6b368b1f8
2024-08-29 08:04:56 +00:00
ilkin-overleaf
6437059783 Merge pull request #20063 from overleaf/ii-bs5-system-notifications
[web] BS5 system notifications

GitOrigin-RevId: a5a17a418193e325c0f561708c99240191cff8e7
2024-08-28 11:35:13 +00:00
Jimmy Domagala-Tang
f64b7a56c4 Merge pull request #19965 from overleaf/jdt-fake-door-cleanup
feat: clean up uneeded fake door pages and routes
GitOrigin-RevId: 1d7ad3d43fda0f7852e3e5abbe5a8287d73d910d
2024-08-27 08:05:01 +00:00
roo hutton
2dcf87e3f6 [web] Share modal shows downgraded editors (#20015)
* add hasBeenDowngraded prop for EditMember

* reduce padding on share modal collab row, add prompt to hasBeenDowngraded Select

* share modal select styling tweaks to allow for inline warning icon

* always show editor limit subtitle when in downgraded state

* add AccessLevelsChanged warning, tweak owner row styling

* conditionally set hasBeenDowngraded prop. make invited member row styling more consistent between warning/enforcement

* add an info state for access level changed notification

* add notification for lost edit access on collaborator share modal, TSify SendInvitesNotice

* fix member privilege alignment in collaborator share modal

* show blue upgrade CTA when some pending editors have been resolved

* automatically show share modal to owners when has pending editors or is over collab limit

* only show lost edit access warning in read-only share modal to pending editors

---------

Co-authored-by: Thomas <thomas-@users.noreply.github.com>
GitOrigin-RevId: e3b88052a48b8f598299ffc55b7c24cb793da151
2024-08-27 08:04:49 +00:00
Liangjun Song
3f1edfc1c9 Merge pull request #19954 from overleaf/ls-access-token-gradual-rollout-cleanup
Update git bridge modal for pw auth deprecation

GitOrigin-RevId: 2e764922bf350ddcba29bf9f3baa220ed1f48e40
2024-08-26 08:05:15 +00:00
Davinder Singh
e19e5ae29a Interstitial Page - Adding geo banners for India and latin america (#20046)
* adding geo banners on interstitial page

* adding a new class .interstitial-new-design-content-spacing to match the spacing of 13

GitOrigin-RevId: 0b72f321356a899f02efcf4bd2719d7762e7b524
2024-08-26 08:04:22 +00:00
Alexandre Bourdin
4997b7f1ee Merge pull request #20062 from overleaf/ab-saas-authentication-module-renaming
[web] Rename overleaf-integration module to saas-authentication

GitOrigin-RevId: 7d69e06a19da9855fa9a0962114ad97b45ad8875
2024-08-23 08:04:43 +00:00
ilkin-overleaf
0e71084600 Merge pull request #19840 from overleaf/ii-bs5-project-tools
[web] BS5 project tools

GitOrigin-RevId: 3181c62985b6db4051292b484f53178a0736fa75
2024-08-22 14:01:43 +00:00
Alf Eaton
18ee2bc87a Delete unused Bootstrap LESS files (#19849)
GitOrigin-RevId: 80f802c67164f317ab68c13ef4e4e7dcf6fbc7ea
2024-08-22 14:01:21 +00:00
Alf Eaton
e61eb1b220 Merge pull request #20008 from overleaf/ae-review-panel-empty-state
Improve calculations of empty state, mini state and sizes variables in review panel

GitOrigin-RevId: 41bcb3b67c9f0019c11b4de0e4590b0407e04e66
2024-08-22 14:01:16 +00:00
Jessica Lawshe
493bdc92d5 Merge pull request #20048 from overleaf/jel-plans-light-touch
[web] Plans page light touch redesign updates

GitOrigin-RevId: 71bb1a594e1767fe406bb63334534fd73b3d368a
2024-08-22 08:05:53 +00:00
Jessica Lawshe
8d63d56a6f Merge pull request #19992 from overleaf/jel-cms-quote
[web] Add new quote option to CMS

GitOrigin-RevId: 5c66620eb755fc9af9c8ba22d64ff969c5c140ca
2024-08-22 08:05:30 +00:00
Jessica Lawshe
130a04e9c2 Merge pull request #19990 from overleaf/jel-cms-pattern-cards
[web] Add new card options to CMS

GitOrigin-RevId: ca19f155a3b4da120f3e3a78800a0b0e5154468e
2024-08-22 08:05:25 +00:00
Tim Down
d5643d53b3 Merge pull request #18996 from overleaf/td-bs5-nav-react
Main navigation React component

GitOrigin-RevId: c99a4b4a2f6fd02618689f829681118b2b64aa8d
2024-08-22 08:05:03 +00:00
M Fahru
8e602b6ec6 Merge pull request #20027 from overleaf/mf-fix-mobile-group-cta
[web][new plans page] Fix mobile group CTA href

GitOrigin-RevId: ce4893d6a11b570cf7186909a23bc9c0e0c7e175
2024-08-21 08:05:32 +00:00
Davinder Singh
54f0c24633 Tear Down - Tearing down of registration and login pages redesign tests (#19750)
* tearing down the test for registration page

* deleting files that were used in delete register.pug file

* removing usage of websiteRedesignAssignmentVariant from remaining files

* deleting files for login page except ligh version

* removing the usage of websiteRedesignAssignmentVariant in remaining files

* moving light design to views folder because app was breaking, also renaming the file to login.pug and moving the two related files to views folder

* running make cleanup_unused_locales

* updating the acceptance test to reflect the change

* tested the deleted register files and rmeoved the classes that were only being used in the deleted register files

* adding delete comments on classes for these files _registration_user_password _registration_sso

* combining the two .login-register-form-focus into one within website-redesign

* fixing the positioning of the validation message

* moving register files out of website-redesign

* adding back AnalyticsManager for view events

GitOrigin-RevId: 028bd65824c4d09cc6ad9950159a404af55ff97e
2024-08-21 08:05:03 +00:00
David
9416e69647 Merge pull request #19985 from overleaf/dp-resolved-threads
Implement redesigned resolved threads popover

GitOrigin-RevId: 4e462eb26a2f2f3194fca89c39d5f9d08ea2e33c
2024-08-20 08:04:35 +00:00
David
93ba9fa28a Merge pull request #20001 from overleaf/dp-math-preview-split-test-badge
Add split test badge to math preview tooltip

GitOrigin-RevId: 9dfd30502f4b023bc7f640660904b0d3e7f4ce62
2024-08-20 08:04:31 +00:00
M Fahru
1184df03cc Merge pull request #19983 from overleaf/ds-features-table-header-fix
Plans page - fixing the features table header padding

GitOrigin-RevId: 6dd64493a0ad2b7e6c2778f82f79357b3bb65df4
2024-08-16 08:05:02 +00:00
M Fahru
ac91544752 Merge pull request #19958 from overleaf/jel-mobile-member-dropdown
[web] Fix "Contact Sales" link placement in license dropdown on mobile

GitOrigin-RevId: bd8363ed3fe8ee0ff239b0113fd560aab669f337
2024-08-16 08:04:58 +00:00
ilkin-overleaf
5f85e13033 Merge pull request #19899 from overleaf/ii-bs5-loading-page
[web] BS5 projects page loading screen

GitOrigin-RevId: d204c05b7245393b0d9e10fa885e844e4ce43e62
2024-08-16 08:04:48 +00:00
M Fahru
02adb4077d Merge pull request #19889 from overleaf/mf-group-member-dropdown-update-all
[web][new plans page] Synchronize all group member picker elements with the same plan type

GitOrigin-RevId: 33956784474c25383c66465da8a1025f3fe6131c
2024-08-16 08:04:31 +00:00
Domagoj Kriskovic
ad7abee39a Remove extra padding for off-screen review panel entries (#19841)
* Remove extra padding for off-screen review panel entries

* use document.activeElement

* cleanup editor padding cases

* using isSelectionWithinOp

* fix formatting

* focusHandler function

* 1px border for focused entry

* use constants

* using isFirstEntry

GitOrigin-RevId: 4509f803b6cb907b40f1745a6fc7f3b1edfe145c
2024-08-16 08:04:22 +00:00
M Fahru
5065bb78ea Merge pull request #19904 from overleaf/ds-plans-page-new-design-adding-geo-banners
Plans page new design - Implement geo banner for India and latin america users

GitOrigin-RevId: 4b0ca2e6e290672c5ae1f41cde904a4d48197a33
2024-08-15 08:05:58 +00:00
M Fahru
50b11da587 Merge pull request #19855 from overleaf/mf-interstitial-new-plans-page-redesign
[web] Implement plans table for the new interstitial payment page

GitOrigin-RevId: 28b6a0c8c42d709d5be067d79f7f852fe188a3cf
2024-08-15 08:05:54 +00:00
Jessica Lawshe
692b3c0a2b Merge pull request #19909 from overleaf/jel-link-icon
[web] Add options for styling `Element | Link`

GitOrigin-RevId: 23db6df3b994f8106872771328b0b674a8fe381c
2024-08-15 08:05:33 +00:00
Jessica Lawshe
4b6872b737 Merge pull request #19935 from overleaf/jel-faq-plans
[web] Remove padding on inline buttons

GitOrigin-RevId: bb2f458b47d4ee48b93048490b1e60a8ff5f1ac0
2024-08-15 08:05:28 +00:00
Jessica Lawshe
ac06b0530c Merge pull request #19937 from overleaf/jel-new-period-toggle
[web] Add space between options in new plans period toggle

GitOrigin-RevId: fee13d4e933a5f2d16f14bbd1fd0b9b130a0084e
2024-08-15 08:05:24 +00:00