Commit graph

2808 commits

Author SHA1 Message Date
M Fahru
862fb9f2ae Merge pull request #21268 from overleaf/mf-new-gallery-search-result-badge
[web] Standardize `.badge` styling and HTML structure for both gallery-search and blog post page

GitOrigin-RevId: edfaceb61900897178654a920995e5c857fe7107
2024-10-28 09:05:55 +00:00
Domagoj Kriskovic
0329a18875 Show "add comment" tooltip below cursor if near viewport top (#21348)
* Scroll selection anchor into view when adding new comment

* check if cursor is near viewport edge

* Show "add comment" tooltip below cursor if near viewport top

GitOrigin-RevId: 0dc2234bc03b1d88a3719ba01a4a865f218b9bfa
2024-10-28 09:05:47 +00:00
David
44b2ca1830 Manually force blur on submitting an edited message (#21333)
* Return focus to parent entry element after message is edited

* Revert "Return focus to parent entry element after message is edited"

This reverts commit 96234a666e7e7c17b99a23a8a92ea030efe6083f.

* Manually force blur on submitting an edited message

* Show review panel entry header when editing comment (#21397)

* Show review panel entry header when editing comment

* edit comment spacing

* hide comment options when editing

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 66a8d1ed772cf91ea0f086bd08cdabaeb7456956
2024-10-28 09:05:43 +00:00
Domagoj Kriskovic
29c5bc8206 Focused and selected states for ReviewPanelEntry (#21354)
GitOrigin-RevId: 41e5ed1110d71eae51cbbde1e874dda133d666c8
2024-10-28 09:05:34 +00:00
Domagoj Kriskovic
db23262611 Scroll selection anchor into view when adding new comment (#21328)
* Scroll selection anchor into view when adding new comment

* check if cursor is near viewport edge

GitOrigin-RevId: 57d4195f7ce1513a56249365b45b3959b4ea813f
2024-10-28 09:05:29 +00:00
Domagoj Kriskovic
4bcc7c9602 Update review panel entries on layout resize (#21323)
GitOrigin-RevId: db9b01609a2425952671e30fc20c16de4d3b36a8
2024-10-28 09:05:25 +00:00
Alf Eaton
34c3647244 Ignore a frequent unhandled promise rejection (#21383)
GitOrigin-RevId: 3c1360d6f4be1367aa77893ad8ef60760d6f9351
2024-10-28 09:05:21 +00:00
Alf Eaton
c0d6a9c5f0 Use noSpellCheckProp NodeProp to exclude node types from spell check (#21335)
GitOrigin-RevId: 91ba72285b0f01c3c00fdb1a64c30e9ff67f72f5
2024-10-28 09:05:16 +00:00
Alf Eaton
516a7abc2a Wrap view.dispatch in setTimeout (#21365)
GitOrigin-RevId: 61c19e10f9529b4d7913f01c57281931533153d2
2024-10-28 09:05:12 +00:00
Tim Down
30eb5416f3 Merge pull request #21353 from overleaf/td-search-panel-focus
Pass main-field attribute through to form control in BS3

GitOrigin-RevId: 58ac2f4a18e098b35e4d4b14aa18eb013e4898e4
2024-10-25 08:05:32 +00:00
ilkin-overleaf
ed8fc2747a Merge pull request #21281 from overleaf/ii-bs5-toolbar-items-border-radius
[web] BS5 toolbar buttons border radius

GitOrigin-RevId: b07a7bb16ab7a933dfa714a128f88f2ee006cf04
2024-10-25 08:05:27 +00:00
Mathias Jakobsen
4bc5a0f1d9 Merge pull request #21319 from overleaf/mj-select-controlled-null
[web] Allow Select to be controlled with no selection

GitOrigin-RevId: 15e5b643e30205124f8e807379ab7e540e2145d1
2024-10-25 08:05:23 +00:00
Alf Eaton
4bbde479a5 Avoid creating duplicate spell check marks on the edited line (#21331)
GitOrigin-RevId: 12726b47450be23f5a412a4c50cc2420af6f425f
2024-10-25 08:05:10 +00:00
Alf Eaton
5ec52e2e5b Avoid calling destroy on the PDF.js loading task (#21277)
GitOrigin-RevId: b315e78ff739d301583f2139109f3244abceade8
2024-10-25 08:05:05 +00:00
Tim Down
1b2385dfce Merge pull request #21259 from overleaf/td-bs5-editor-search
[BS5] Migrate Editor search panel

GitOrigin-RevId: 37605845d4efc27d6c0c3a11de12387e8e3262f4
2024-10-24 08:05:58 +00:00
ilkin-overleaf
2646fefce4 Merge pull request #21289 from overleaf/ii-bs5-figure-modal-improvements
[web] BS5 fix form text colour

GitOrigin-RevId: 8ff03f41cc3490eff0ea4c65a376ac572003fb9c
2024-10-24 08:05:54 +00:00
ilkin-overleaf
5c3d9117c5 Merge pull request #21240 from overleaf/ii-bs5-review-panel-old
[web] BS5 review panel old

GitOrigin-RevId: da018b8f2946afb21ab63da0003453e20781f04c
2024-10-24 08:05:41 +00:00
David
d74981775c Merge pull request #21283 from overleaf/dp-keyboard-shortcuts
Add missing keyboard shortcuts to new review panel

GitOrigin-RevId: 78e3a63284b62c90e8a3803bd81fdf273f1a2ec9
2024-10-24 08:05:17 +00:00
David
c872d97295 Merge pull request #21250 from overleaf/dp-resolved-comments-ui
UI tweaks for resolved comments menu

GitOrigin-RevId: 23df6f9f0374277c315d2fb9c9940dd92ec19f4e
2024-10-24 08:05:12 +00:00
David
1c5f5950fa Merge pull request #21208 from overleaf/dp-accept-reject-all-changes
Add options to accept/reject all changes to review tooltip

GitOrigin-RevId: 1cea76926d59d0354c8abaa6ba69b7e99c02fbe0
2024-10-24 08:05:08 +00:00
Domagoj Kriskovic
c4b23b4d39 Add "usingNewReviewPanel" flag in store (#21279)
* Revert "Add isUsingNewReviewPanel flag for writefull (#21111)"

This reverts commit 3491e93ca70fa1db0c751872e233dfebdbe81423.

* add usingNewReviewPanel in store

* fix lint error

GitOrigin-RevId: 56d90a428a2cc45708b8b483dc60a62aae233a85
2024-10-24 08:05:03 +00:00
Antoine Clausse
b2e7477467 [web] Migrate AI Error Assistant to BS5 (#21129)
* [storybook] Rerender story when switching BS3/BS5

* [storybook] Add SCSS loader to storybook

* [storybook] Add some AI error assistant stories

* Rename ai-error-assistant.less to .scss

* Update less variables to sass

* Remove duplicated selector

* Replace react-bootstrap components by `OL...`

* Update Checkboxes after BS5 update

* Add IDs so clicking on labels work
* Add BS5 class name in SCSS

Note: `answer-not-detailed` is used twice in the Radios. I think it's a mistake: there should be another name for the "ai_feedback_the_suggestion_wasnt_the_best_fix_available" radio

* Rename ID `answer-not-detailed` -> `answer-not-best-fix`

* Pass name and value to BS3Radio/BS3Checkbox

* [storybook] Add delay before AI suggestion (shows the animation)

* Add a number after the checkbox/radio IDs, to allow multiple forms to be displayed

Without this, clicks on second form are updating the first form!

Another solution could be to wrap the input in the label, but it comes with other problems. See https://css-tricks.com/html-inputs-and-labels-a-love-story/

* [storybook] Update `LabsAiPromoBanner`

* Use CSS variables instead of hardcoded values

* Make radio input flex

* Replace `blue-10` by `bg-info-03`

* Fix `SuggestFixButton`

* Fix `AiErrorAssistantCopyCode`

* Fix button loading in BS5

* Use OLBadge

* Fix Button variants

* Update `suggestFixAction`

* Migrate Tooltip and Button to BS5 in LabsExperimentWidget

* Update BS3/BS5 button classname in AiErrorAssistantCopyCode

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>

* [storybook] Allow to choose props of `LabsExperimentWidget`

* Fixup `OLTooltip`: Display the tooltip on disabled button in BS5

* Update Tooltips to BS5

---------

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
GitOrigin-RevId: 08d594e772c0a3b6db1c6081337cc2d079f478a5
2024-10-23 08:06:36 +00:00
Antoine Clausse
30860ae9f9 [web] Migrate PDF Logs to BS5 (#21062)
* [web] Migrate Logs components JSX to Bootstrap 5

* [web] Migrate logs.less to logs.scss

* [web] Remove unused class names

* [storybook] Define default Bootstrap version in Storybook

This prevents some warning in the console

* [storybook] Update pdf-preview.stories.jsx

* [storybook] Add pdf-log-entry.stories.tsx

* [storybook] Force re-renders when switching BS version

* [web] Keep files dropdown menu in bounds

* [web] Make files dropdown items not bold in BS5

* [web] Revert unrelated change

* [web] Fixup PreviewLogsPaneMaxEntries

* [web] Add style for log-entry-content-link

* [web] Replace log-entry by OLNotification in `PdfCodeCheckFailedNotice`

* [web] Use `BootstrapVersionSwitcher` instead of `isBootstrap5`

* [web] Rename `DropdownBS3` to `BS3Dropdown`

* [web] Reuse variables for `toolbar-height` and `toolbar-small-height`

* [web] Set `id` on `DropdownToggle` not `Dropdown`

* [web] Set `log-entry-btn-expand-collapse` in BS3 only

* [web] Remove `block: true` from StartFreeTrialButton in BS3

* [web] Remove unnecessary CSS in `.log-entry-header-link`

* [web] Use semantic color names

* Migrate the downloadable pdf file list to Bootstrap 5

* Remove nested BootstrapVersionSwitcher, fix "key" prop

* Update roles to: `<li role="menuitem">` `<a role="link">`

* Update `log-entry-header-link`: variant ghost and fix colors

---------

Co-authored-by: Rebeka <o.dekany@gmail.com>
GitOrigin-RevId: 89848970ab5d8a8c135335386caf24363f69a34c
2024-10-23 08:06:32 +00:00
Antoine Clausse
d77ca18b0b [web] Remove dead code: history-content & history-root (#20959)
They are duplicated by:
* services/web/frontend/js/features/ide-react/components/history.tsx
* services/web/frontend/js/features/ide-react/components/history-root.tsx

GitOrigin-RevId: c3f13ea9016530182ae623b06e91a9fdb2be7a87
2024-10-23 08:06:27 +00:00
Rebeka Dekany
200e7a75f0 Merge pull request #21226 from overleaf/rd-history-filetree
Migrate the history file tree to Bootstrap 5

GitOrigin-RevId: bb5443d91992ff7241ed5c8bb467fa553e55bb0f
2024-10-23 08:05:31 +00:00
Alf Eaton
d0b5c2f307 Avoid sending ide-open-view-null-once event (#21247)
GitOrigin-RevId: 2f46fe26561bfa2eca36ad605cdd217514aba09d
2024-10-23 08:05:23 +00:00
Alf Eaton
98bf2ac055 Disable spell check setting when doc is read-only (#21253)
GitOrigin-RevId: 1053fefd953d4f60b1c2aef4170f99c6885c265d
2024-10-23 08:05:18 +00:00
Alf Eaton
baed6cc291 Reapply "Remove spell check languages that are only available on the server (#21056)" (#21257)
* Reapply "Remove spell check languages that are only available on the server (#21056)"

This reverts commit a2273a5ff2eeb5660ae992c41e67b7b936dc4e26.

GitOrigin-RevId: 2dfdf87acdf17db894e921fe754c1520df6f01c1
2024-10-23 08:05:14 +00:00
Alf Eaton
508ed8ad1d Merge pull request #21251 from overleaf/ae-revert-no-session
Revert "Remove spell check languages that are only available on the server (#21056)"

GitOrigin-RevId: 6f77aa92f1b7d7181cec7d470c8e6604b1e90fe3
2024-10-22 08:06:45 +00:00
Alf Eaton
9fdbd5cfb5 Add state.Prec to editor:extensions export (#21222)
GitOrigin-RevId: b8680926a9885f19ebc9227de678674da1765158
2024-10-22 08:06:29 +00:00
Alf Eaton
6c4fac68ca Use Intl.Segmenter when available for identifying words to spell check (#21225)
GitOrigin-RevId: f261ae331e0b1f87f4e88a512b25c8798f0b02c6
2024-10-22 08:06:25 +00:00
Alf Eaton
04dbb7d2f2 Remove spell check languages that are only available on the server (#21056)
GitOrigin-RevId: cfe10a18af8149327754b3a2e62883c7ebc04bfc
2024-10-22 08:06:20 +00:00
David
c7eafd69c2 Merge pull request #21014 from overleaf/dk-review-panel-tc-widget
Add "Track changes is On" button when review panel is closed

GitOrigin-RevId: a165201f611860ba531f2eeb3d89f83a695cd017
2024-10-22 08:05:50 +00:00
Domagoj Kriskovic
64460681b8 Fix delete comment/thread in the new review panel (#21199)
GitOrigin-RevId: 95d4db64d2f837322d84a81cbd129ec02ee135a2
2024-10-22 08:05:46 +00:00
Domagoj Kriskovic
1e16de13bc Fix change and insert range decorations background color (#21131)
GitOrigin-RevId: 4bbc7abdc4c52ea31e26ea3fd8cf43d8c9620d47
2024-10-22 08:05:42 +00:00
Domagoj Kriskovic
c606f04cce Sort track changes and comments in overview mode (#21099)
GitOrigin-RevId: 795d30b56e57970363512170f504ab51bd104c93
2024-10-22 08:05:37 +00:00
Domagoj Kriskovic
332e2a38c9 Fix review panel entry focus handler (#21075)
* Fix review panel entry focus handler

* dont check position

* remove event.target checks

* Revert "remove event.target checks"

This reverts commit 3f511e47b6922260666c6952b692f6f0a29d5912.

GitOrigin-RevId: 9271df9cdb36a040d59a97c88f21d6e923ac0404
2024-10-22 08:05:33 +00:00
Domagoj Kriskovic
42eea0017d Update track change decoration to be cursor-like (#21047)
* Update track change decoration to be cursor-like

* use red-50 color

GitOrigin-RevId: 8c8a2cb9c6abc99aa1d2dace705dba3feeda07fa
2024-10-22 08:05:24 +00:00
David
87f714f7c3 Merge pull request #21164 from overleaf/dp-add-comment-keyboard-shortcut
Add keyboard shortcut (cmd+shift+c) for adding a new comment

GitOrigin-RevId: 20359426f45e90b09cbc887bac3096adf1b3141a
2024-10-22 08:05:15 +00:00
David
31154bb9f5 Merge pull request #21065 from overleaf/dp-limit-track-change
Truncate text in a tracked change

GitOrigin-RevId: a3c070f0ca2f51545151934d25a26a10c99b7465
2024-10-22 08:05:11 +00:00
David
efa376f4f4 Merge pull request #21120 from overleaf/dp-overview-entry-gap
Adjust size of gap between review panel entries to 4px

GitOrigin-RevId: a09a6fde0e8eb15e0c753e436a1c09434581d6d8
2024-10-22 08:05:07 +00:00
David
af7e388c41 Merge pull request #21122 from overleaf/dp-rp-hide-edit
Hide edit option for other user's comments

GitOrigin-RevId: 317fa57402dfbe2e949fa7b196cbbe246f88257d
2024-10-22 08:05:02 +00:00
David
a2ea76f19f Merge pull request #21201 from overleaf/dp-toolbar-ui
Style adjustments for add comment tooltip

GitOrigin-RevId: 7fdc008fea4a191ff8bacca9a77e23cd55faac5a
2024-10-22 08:04:57 +00:00
ilkin-overleaf
8bc374c916 Merge pull request #21115 from overleaf/ii-bs5-review-panel
[web] BS5 review panel new

GitOrigin-RevId: c65d17d0053858bd74984ba746a620b89d900606
2024-10-21 08:04:37 +00:00
Eric Mc Sween
b2d991d74a Merge pull request #21212 from overleaf/revert-20969-ac-subscription-layout-react
Revert "[web] Set Subscription pages to have `layout-react`"

GitOrigin-RevId: eaf3a651160e278adcb103864c5ea81ea3e35aa7
2024-10-18 08:06:05 +00:00
Antoine Clausse
2c7530a6cf [web] Set Subscription pages to have layout-react (#20969)
* [web] Set Subscription pages to have `layout-react`

* [web] import `header-footer-react` in Subscription pages (!!)

* [web] Add `ol-user` meta tag to the subscription pages (!!)

⚠️ invite_logged_out.pug should be updated instead of setting the user as `{}`

* [web] Fix unit test

* [web] Update User types to handle a logged out user, add `LOGGED_OUT_USER` const

* [web] Add type `User` to `getSessionUser`

* [web] Remove `LOGGED_OUT_USER` const

* [web] Just pass `{ id: null }` as the user

* [web] Remove comment in pugs, it breaks things

* [web] Don't pass the full user to the frontend!!!

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

---------

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 1768f1f13de924a18be43c1a08614000500dcbec
2024-10-18 08:05:53 +00:00
Alf Eaton
1b2f5af1c0 Display current spell check language and option to change it (#21138)
GitOrigin-RevId: 87cf140a7e3e719125eb6d2df23d6c6bd6631fe8
2024-10-18 08:05:48 +00:00
Alf Eaton
b5015b82c2 Move Hotjar to the editor page (#21132)
GitOrigin-RevId: efb2c7841af76084566341b6c5f0afac9a965331
2024-10-18 08:05:43 +00:00
Alf Eaton
620f31d6a6 Restore singleton pdfCachingTransportFactory (#21194)
GitOrigin-RevId: 3c1d71ba4fdd07f0774534fbe3a99b2d47dfa962
2024-10-18 08:05:39 +00:00
Alf Eaton
978ef6bd92 Enable remaining client-side dictionaries (#21192)
GitOrigin-RevId: da45ae4a93e99a0bb720e09a37c8e291c057cab9
2024-10-18 08:05:29 +00:00