Commit graph

134 commits

Author SHA1 Message Date
Domagoj Kriskovic
da2f7ff153 Store editor selection on a per-user rather than per-project basis (#16246)
* Store editor selection on a per-user rather than per-project basis

* set code editor if rich_text=false

* format fix

GitOrigin-RevId: 8efc33b682de211162e674839e6b891ec04e542e
2023-12-19 09:04:31 +00:00
Alf Eaton
9875e55a27 Remove Ace (#14299)
GitOrigin-RevId: ec8788fdbc8aea73ca33ec2810f4e588fe9476b5
2023-11-29 09:04:08 +00:00
Jakob Ackermann
6b2daed903 Merge pull request #15843 from overleaf/jpa-download-events
[web] add additional event tracking

GitOrigin-RevId: 877f92db41efff017db370ec75b8d1f861eed4f2
2023-11-21 09:04:28 +00:00
Mathias Jakobsen
1a92e1b664 Merge pull request #15248 from overleaf/mj-eslint-angular-components
[web] Add eslint rules for angularjs components

GitOrigin-RevId: 1343d584368faeb912f04c5879228bcbd07a042a
2023-10-18 08:03:57 +00:00
Jakob Ackermann
e959529828 Merge pull request #15129 from overleaf/mj-jpa-angular-parameters
[web] Explicitly name angular parameters

GitOrigin-RevId: 91beae68989d6c8122132b531a4338b116d87424
2023-10-16 08:04:25 +00:00
Jakob Ackermann
1213709578 Merge pull request #14980 from overleaf/jpa-debug-console
[web] migrate frontend logging to debugConsole

GitOrigin-RevId: b03ff9030b03fff059738d2270bc4b4912e79f16
2023-09-28 08:04:12 +00:00
Alf Eaton
e54a1d1a43 [cm6] Remove Galileo code (#14336)
GitOrigin-RevId: 878faff8eea90f508aa94e4471990c31d5d3f0e5
2023-08-18 12:11:28 +00:00
Alf Eaton
c8f0885316 Remove CM5 Rich Text module (#11776)
GitOrigin-RevId: 812d3b5f1df7e769c8be732ccb31653e8e9a8aa3
2023-08-16 08:03:35 +00:00
Alf Eaton
253f2c53d5 [visual] Show tooltip with target for linkable nodes (#13636)
GitOrigin-RevId: c236caff7560d8d3e4f53667c7abe27b57f7711d
2023-08-14 08:05:09 +00:00
Mathias Jakobsen
462837b44d Merge pull request #12701 from overleaf/dk-cm6-autocomplete-item-space
[cm6] Add space after item autocomplete

GitOrigin-RevId: 6fff77c0c0563530af981bbac73b1d88e02bb759
2023-04-21 08:03:08 +00:00
Tim Down
7f37ba737c Move source editor out of module (#12457)
* Update Copybara options in preparation for open-sourcing the source editor

* Move files

* Update paths

* Remove source-editor module and checks for its existence

* Explicitly mention CM6 license in files that contain code adapted from CM6

GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
2023-04-13 08:40:56 +00:00
Alf Eaton
9c78422efa Jump to line after the stored scroll position has been restored (#12324)
GitOrigin-RevId: 82265c6b0cab1ed3a34343efc5d47648e72dc41e
2023-03-30 08:03:25 +00:00
M Fahru
b62cb86bf8 Create new SplitMenu component and implement it for the pdf compile button (detached & non-detached) (#11772)
* Create a new shared `SplitMenu` component.

* Refactor the pdf compile button & detached compile button:
    - Rename `detach-compile-button` to `detach-compile-button-wrapper`
    - Rename `pdf-compile-button-inner` to `detach-compile-button`
    - Move some of the logic from `detach-compile-button-wrapper` to `detach-compile-button`
    - Create a new `compile-button.less` to centralize all of the compile button (detached/non-detached) custom styles rule.
    - Extract the animated striped CSS definition to the dedicated CSS file, change the class from `btn-recompile-group-has-changes` to `btn-striped-animated`
    - Refactor other className(s) appropriately according to the new component name
    - Delete the unused `changes-to-autocompile` css rule since it has not been used anywhere

* Implement the new pdf compile button with the new `SplitMenu` component.

GitOrigin-RevId: d1d055bffd311923fc47b4681605ce8ba8e26f25
2023-02-22 09:04:42 +00:00
Miguel Serrano
55bdcf7664 Merge pull request #11583 from overleaf/msm-ace-ce
[web] Force ACE when `modules/source-editor` not available

GitOrigin-RevId: 2b43a048e882d99aa52ee8ead6c67152d4080eb2
2023-02-02 09:03:30 +00:00
Tim Down
a05438d9c7 Merge pull request #11332 from overleaf/td-remove-ace-split-test
Add handling for source-editor-legacy split test

GitOrigin-RevId: 9575087c34bc3f2e8b490846984bc97641c560aa
2023-01-25 09:06:26 +00:00
Mathias Jakobsen
fce0a45128 Merge pull request #11234 from overleaf/ae-editor-type-rich-text
Record `cm6-rich-text` editorType in editing session pings

GitOrigin-RevId: 32d8cb60361348123bf5825961eb7e8b6e740ce8
2023-01-17 09:05:05 +00:00
Alf Eaton
017f0b49a0 [rich-text] Add "rich-text" split test (#11180)
GitOrigin-RevId: 8df79f3c70020c8dba0793c8b548fd1f1e1fbf76
2023-01-13 09:04:31 +00:00
Alf Eaton
9f1f62b9be Add rich-text mode to CM6 (#10775)
Co-Authored-By: Mathias Jakobsen <3295293+hrjakobsen@users.noreply.github.com>
GitOrigin-RevId: 00e015cb216bb8a52d083e71b34dbe91a7cd6cc5
2022-12-13 09:03:54 +00:00
Tim Down
08567c290e Add second CM6 switch-away survey (#10789)
Restart CM6 switch-away survey

GitOrigin-RevId: 1d62aaf27834cb3919f6ca30c269a1ef3c2e9a5e
2022-12-07 09:04:35 +00:00
Tim Down
fd2863bf7a Merge pull request #10747 from overleaf/as-ace-perf-measurement
Add perf measurement of Ace editor

GitOrigin-RevId: b33eeac9f7c7f85355a9e8f34833aa94bee2f70a
2022-12-07 09:04:21 +00:00
Alf Eaton
65b0fd73ea Improve "compile" keyboard shortcut handling (#10624)
* Improve "compile" keypress handling
* Remove "compile" keypress handling from PDF preview
* Remove compile shortcuts from CM6
* Use an event for Vim keybindings
* Remove event handlers from Angular/Ace
* Move useCompileTriggers into DetachCompileProvider

GitOrigin-RevId: 7f0e667b5106a849458e06ebb0f7a413d5d63430
2022-11-29 09:04:04 +00:00
M Fahru
ff944917a6 Don't force user to cm6 if they have ace as editor preference
GitOrigin-RevId: 78390fe420eb28b5731cb1cc719a0b53913509e1
2022-11-10 09:04:40 +00:00
M Fahru
19dd2f67e2 Implement "switch away survey" when users switching back to ace from cm6 (#10201)
Implement legacy source editor survey:

* Force user to switch to cm6 if they haven't seen switch away survey

* Only show user switch away survey if they open ace from another editor

* We need to wait 3 seconds until the survey is being shown

* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users

* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey

* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that

* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses

GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
2022-11-04 09:05:50 +00:00
Mathias Jakobsen
bcad89fd28 Merge pull request #10273 from overleaf/ae-docname-apply
Add a `$scope.$applyAsync` wrapper around the "open a new document" code

GitOrigin-RevId: 7c63338379053d20bd86f10d9db6855cb5c23fc3
2022-11-04 09:05:25 +00:00
Mathias Jakobsen
a54b633726 Merge pull request #10111 from overleaf/mj-lezer-file-outline
[web] Parser backed file outline

GitOrigin-RevId: 0825f4887ba4dae24a14dd1880d07b791d0b4cd9
2022-11-04 09:04:33 +00:00
Alf Eaton
5b9261e13e Dispatch doc:changed and doc:saved events in a debounced timeout (#10024)
GitOrigin-RevId: a55602b448d8b97f224c658fee0a97d2473f8cd1
2022-11-01 09:04:45 +00:00
Eric Mc Sween
7d099acfdd Merge pull request #9150 from overleaf/em-share-ranges-tracker
Move RangesTracker to shared lib

GitOrigin-RevId: 62da7208f0b453dd7272c06873c7e415ed887817
2022-10-05 13:26:01 +00:00
Tim Down
8388d808a5 Merge pull request #9678 from overleaf/ta-td-galileo-week6
Galileo Integration Banch Week 6

GitOrigin-RevId: 78fffeefdf350042a4c2400823fb2a668ee0f592
2022-09-22 08:03:55 +00:00
Timothée Alby
ac3bc987d9 Merge pull request #9297 from overleaf/ta-galileo-module
Create Galileo Module

GitOrigin-RevId: 0d9dfeebc150bd6a0d828f55be47f9d9f1a70d66
2022-08-19 08:04:56 +00:00
Jessica Lawshe
e3758f2060 Merge pull request #8804 from overleaf/jel-rich-text-pos
[web] Fix stored rich text position

GitOrigin-RevId: 7ef916919220d63d88f66ee261f91a5af08dcefb
2022-07-28 08:03:30 +00:00
Timothée Alby
7b8d277437 Merge pull request #8898 from overleaf/ta-change-redundant-controls
Change Redundant Layout Controls

GitOrigin-RevId: b50d71b1f75d202334442b3f6cb5037ed0d8a411
2022-07-21 08:04:25 +00:00
ilkin-overleaf
41c715c40d Merge pull request #8378 from overleaf/ii-cm6-three-way-toggle
[cm6] Make cm6 as the default source editor

GitOrigin-RevId: b56724d2c147792c55ce01cf272fbcce16f87916
2022-06-15 08:05:18 +00:00
Timothée Alby
ae207f7559 Merge pull request #8326 from overleaf/ta-pdf-detach-redundant-controls
Bring Back Redundant Layout Controls

GitOrigin-RevId: a725e8742ab41612b285bcab23054ba9da15b60f
2022-06-09 08:02:34 +00:00
Miguel Serrano
430b7528b2 Merge pull request #8073 from overleaf/ta-td-dictionary
Add UI to Remove Words from Dictionary

GitOrigin-RevId: a28d865e3c968d6fff113237fcf4143b77af046e
2022-05-25 08:09:45 +00:00
Timothée Alby
5a1ff8149d Merge pull request #8001 from overleaf/ta-td-refactor-learned-words
Refactor Learned Words Class

GitOrigin-RevId: eae6558b5d4eb03b95df511d1cd9ba35b22bb344
2022-05-24 08:04:54 +00:00
Jakob Ackermann
f0bd6dda23 Merge pull request #7986 from overleaf/jpa-eslint-8
[misc] upgrade eslint packages to the latest version everywhere

GitOrigin-RevId: f1480d4a171acef82fb26c4aa54be3a6088b0ab3
2022-05-17 08:05:59 +00:00
Alf Eaton
b70e63e893 Focus the editor after restoring a stored cursor position (#7628)
GitOrigin-RevId: d4564f14503957a0fc8a02cef21064777e2e961d
2022-04-25 08:03:56 +00:00
Timothée Alby
a110c4d7bd Merge pull request #7323 from overleaf/ta-synctex-disable-multi-one-way
Don't Disable Synctex PDF-to-Code Button

GitOrigin-RevId: 90328e0fea8cb5358217ce866839f5e1a4a73b94
2022-04-13 08:03:36 +00:00
Alf Eaton
69a2283984 Upgrade to webpack v5 (#7249)
GitOrigin-RevId: 69dc5f9aad3e045cc6904e3663e9965094eced76
2022-04-07 08:03:46 +00:00
Jakob Ackermann
862ff734c6 Merge pull request #7278 from overleaf/jpa-block-track-changes-access
[web] block restricted token users from accessing track-changes details

GitOrigin-RevId: f2e734b48aaa1d1cae6d5db0e0312a78d42165de
2022-04-05 12:21:09 +00:00
ilkin-overleaf
ea729ca2af Merge pull request #7075 from overleaf/ta-mutli-selection-ui-fix
Bring Multi-Selection UI Back

GitOrigin-RevId: a0e086da98bb1de88cb2e96ddc2acfd5240a01a7
2022-03-22 09:03:40 +00:00
June Kelly
9702346edc Merge pull request #6628 from overleaf/jk-heartbeat-editor-type-metadata
Add editor metadata to editing-session pings

GitOrigin-RevId: f42be772c13f71380d59bae7c447645fe0e16a17
2022-03-02 09:02:34 +00:00
Brian Gough
fde4f72adf Merge pull request #6779 from overleaf/ae-cm-editor-switch
[web] [cm6] Add a three-way switch for editor choice

GitOrigin-RevId: fff788ddad8d10488e8446de7f1503702da0985f
2022-02-22 09:03:05 +00:00
Timothée Alby
4a70dfa921 Merge pull request #6705 from overleaf/ta-ms-doc-too-long-modal
Improve handling of "Document Too Long" Errors

GitOrigin-RevId: 6a5e200014609e2a94f896840757487564d41176
2022-02-16 11:40:16 +00:00
Brian Gough
f23cc433a4 Merge pull request #6742 from overleaf/bg-cm6-chaos-monkey
[web] extend chaosmonkey for cm6

GitOrigin-RevId: d030952c9f0c8d3441321354f1ae61e5a6bc4d53
2022-02-16 11:38:54 +00:00
Alf Eaton
753be43c53 [web] [cm6] Add a source editor toggle (#6674)
* Add a source editor toggle
* Only show the toggle if in split test variant (or query param override)
* Change labels
* Add check for this.editor
* Update toolbar.pug

GitOrigin-RevId: ee00e31db334fc562b00d28a8c2de5d03456f749
2022-02-16 11:37:33 +00:00
Jakob Ackermann
f5a74a014f Merge pull request #6663 from overleaf/jk-cm6-spelling-ignore-words-dedupe
[web] Spelling: de-duplicate ignored-misspellings list

GitOrigin-RevId: 9888c35dde01fb733247fba38846c07b43a3e924
2022-02-16 11:33:54 +00:00
June Kelly
926f69d331 Merge pull request #6630 from overleaf/bg-spelling-tex-related-words
[web] add TeX-related words to IGNORED_MISSPELLINGS

GitOrigin-RevId: 10471b1e45e9b4f054871eb11b27410ccbacb59d
2022-02-16 11:32:39 +00:00
June Kelly
ab5135957a Merge pull request #6633 from overleaf/jk-cm6-spelling-ignore-commands
[web] Ace/CM6 Spelling: don't send commands to backend

GitOrigin-RevId: 7fbd14240facb71b6d110eb95e271b07fced76b1
2022-02-16 11:32:26 +00:00
June Kelly
ef4e137676 Merge pull request #6610 from overleaf/jk-better-editing-heartbeat
[web] CM6: improvements to editor heartbeat

GitOrigin-RevId: b0e5379d221cba76c91d6d21863ca8355749d18e
2022-02-16 11:32:19 +00:00