Antoine Clausse
9bc1085566
[fetch-utils] Tests updates ( #20280 )
...
* [fetch-utils] Check when `aborted` is thrown
* [fetch-utils] Rename `AbortError` to `abortErrorMessage`
* [fetch-utils] Don't test `caughtAbortedErr`
Partially reverts 87604105c4fd66e548d917d6d93f1603977689be
GitOrigin-RevId: fd91f952793d6727e3efcbb58867c95642d04983
2024-09-06 08:05:44 +00:00
Antoine Clausse
5afa892981
[fetch-utils] Fix unit tests ( #20210 )
...
* [fetch-utils] Fix FetchUtilsTests.js tests
* Cleanup between tests
* Define `AbortError`
* [fetch-utils] Add `expectConnectionCount` showcasing that the connection stays on when the stream is destroyed
* Revert "[fetch-utils] Add `expectConnectionCount` showcasing that the connection stays on when the stream is destroyed"
This reverts commit b10da7b3fc06a7345df8fd70f27fad70a478bbb4.
* [fetch-utils] Fix `supports abort signals` test
* [fetch-utils] Add tests "aborts the request when the request body is destroyed during transfer"
* [fetch-utils] Add extra waiting step before `expectRequestAborted`
* [fetch-utils] Add `while (!req?.destroyed) await wait(10)`
Unfortunately I couldn't find a better event to await.
To try with this to test flakiness
```
for i in {1..100}; do npm run test:unit || break; echo "Run $i completed"; done
```
* [fetch-utils] Replace arbitrary `wait(10)` by `this.server.waitForEvent('request-received')`
* [fetch-utils] Improve tests per PR comments
See https://github.com/overleaf/internal/pull/20210
1. Replace `waitForEvent` with `once`
2. Replace `waitForRequestAborted` by `expectRequestAborted`
3. Add comment in `expectRequestAborted` empty catch block
Non-flakiness rechecked with `for i in {1..100}; do npm run test:unit || break; echo "Run $i completed"; done`
* [fetch-utils] Add small wait before checking `lastReq === undefined`
Per https://github.com/overleaf/internal/pull/20210#discussion_r1743329462
GitOrigin-RevId: 5fe542e0a8e6011307e03237e2f81404d9a0e674
2024-09-05 08:05:57 +00:00
Mathias Jakobsen
496a63cf23
Merge pull request #20058 from overleaf/mj-promisify-tpr
...
[third-party-references] Promisify third-party-references
GitOrigin-RevId: cfc462abaca95ed10798b3d1756950f2997a5947
2024-09-02 08:04:55 +00:00
Eric Mc Sween
3a1560894a
Merge pull request #18516 from overleaf/em-web-resolved-comment-ids
...
Reintroduce resolved comment ids in getDocument()
GitOrigin-RevId: 591589efc643c815c40df440d1297158901f7a79
2024-05-28 08:04:01 +00:00
Eric Mc Sween
ea8f8d0651
Merge pull request #18506 from overleaf/em-revert-web-resolved-comment-ids
...
Revert #18398 - return resolved commentIds with getDocument()
GitOrigin-RevId: c5d2dd91d02d88029eb2702d73ac37cb8dbca32c
2024-05-27 10:24:25 +00:00
Eric Mc Sween
83e1452991
Merge pull request #18398 from overleaf/em-web-resolved-comment-ids
...
Return resolved comment ids with getDocument()
GitOrigin-RevId: 30234f72d52b90b313821290b6c63aa6cc6cb243
2024-05-27 10:24:13 +00:00
Andrew Rumble
71187a51ba
Merge pull request #18289 from overleaf/ac-ar-eslint-return-await
...
Add ESLint rule @typescript-eslint/return-await to backend services
GitOrigin-RevId: 75e3e32597827fcc852e69d479515fc72e8f45e4
2024-05-27 10:22:49 +00:00
Brian Gough
6680bedf6c
Merge pull request #16728 from overleaf/bg-clsi-timeout-fetchutils-connect-timeout
...
add connect timeout to fetch-utils using custom agents
GitOrigin-RevId: 877dbc1311197461cf1e9bfee74196bd5d3e42dc
2024-05-16 08:04:41 +00:00
Eric Mc Sween
e87df4a791
Merge pull request #18167 from overleaf/em-simpler-typescript-backend
...
Simpler Typescript setup in the backend
GitOrigin-RevId: 3a90f26a5ac8029d14203faa98008375ce933e7d
2024-05-07 08:04:00 +00:00
Jakob Ackermann
a540754f6e
Merge pull request #18116 from overleaf/jpa-bulk-replace-localhost
...
[misc] bulk replace localhost with 127.0.0.1
GitOrigin-RevId: d238f3635302e8ff5500d611108c4d1bef216726
2024-04-26 08:04:39 +00:00
roo hutton
2469c93da4
Merge pull request #17870 from overleaf/bg-node-upgrade-18-20-2
...
upgrade node to 18.20.2
GitOrigin-RevId: e4ac30c740ced3885353f1472cf690eb5ec0ece1
2024-04-24 08:05:16 +00:00
roo hutton
d75024a7a1
Merge pull request #17974 from overleaf/rh-express-4192
...
Upgrade express to 4.19.2
GitOrigin-RevId: 383877c39670093033d802af0fae54ec578ba327
2024-04-23 08:05:01 +00:00
Brian Gough
a9d1ddcb22
Merge pull request #17748 from overleaf/bg-node-security-upgrade-2024-04-05
...
upgrade node version to 18.20.1
GitOrigin-RevId: 28f8f7c7f63285f7b7355e65713d9ed2dbda8a0e
2024-04-08 08:04:41 +00:00
Jakob Ackermann
39189978ac
Merge pull request #17170 from overleaf/jpa-node-18-19-1
...
[misc] upgrade Node.js to 18.19.1
GitOrigin-RevId: 1bd2008682b585c3fccc65f74c90ba7fc9edc023
2024-02-20 09:04:55 +00:00
Eric Mc Sween
5c517a56c3
Merge pull request #16661 from overleaf/em-fix-tsconfig
...
Small backend Typescript config fixes
GitOrigin-RevId: d600c1f3fa9ef88e9a06aaa5743d454a620c122d
2024-01-24 09:05:09 +00:00
Eric Mc Sween
b92d1a0251
Merge pull request #16524 from overleaf/em-fix-typescript-backend
...
Fix typescript config in the backend
GitOrigin-RevId: fb292968bc14da6d7c17bee1da00803a74901899
2024-01-17 09:03:42 +00:00
Eric Mc Sween
d227dfba0c
Merge pull request #16393 from overleaf/em-typescript-libraries
...
Add type checking to libraries
GitOrigin-RevId: bed79f5123081773d6ac6e27698246726184c5e6
2024-01-12 09:03:25 +00:00
Mathias Jakobsen
4763cfd59e
Merge pull request #16058 from overleaf/jpa-faster-restart
...
[misc] faster service shutdown in dev-env
GitOrigin-RevId: c5589844aefe3ca097756b188e02354ab518b94d
2023-12-08 09:04:01 +00:00
Jakob Ackermann
7a87bf4288
Merge pull request #15895 from overleaf/jpa-latexqc-fetch-backend
...
[latexqc] migrate backend from axios to fetch
GitOrigin-RevId: 6dc1a9ca0aa96da01229fec96d3c4b34750f4aa2
2023-11-28 09:05:06 +00:00
Jakob Ackermann
3b36bfdba4
Merge pull request #15956 from overleaf/jpa-tweak-test
...
[fetch-utils] tests: fix test for handling of errors in fetchString
GitOrigin-RevId: 8c3b33113ce93fe087258efb68346c8e86b23096
2023-11-28 09:04:40 +00:00
Jakob Ackermann
f061a4add4
Merge pull request #15506 from overleaf/jpa-node-18-18-2
...
[misc] upgrade Node.js from 18.18.0 to 18.18.2
GitOrigin-RevId: 747783fcb9c2a09d79a82268531f612d1ad157be
2023-11-01 09:02:48 +00:00
Jakob Ackermann
efb36b7193
Merge pull request #14698 from overleaf/bg-sg-use-node-watch
...
[misc] replace nodemon with "node --watch"
GitOrigin-RevId: 8b34861887b39ffe1c64d9e4679f8ebef09302bd
2023-10-03 08:04:36 +00:00
Jakob Ackermann
a2cf7b459c
Merge pull request #14902 from overleaf/jpa-node-18-18-0
...
[misc] upgrade Node.js to latest LTS 18.18.0
GitOrigin-RevId: 96c7171065ceb8797c28efa4ab331d86a84868d2
2023-09-25 08:04:25 +00:00
Davinder Singh
3490f6a58e
History UI changes- Extracting compare outside dropdown menu
...
GitOrigin-RevId: 67f51428debefdafe2c9bb746de5da8fc0ac5385
2023-08-18 08:05:23 +00:00
Jakob Ackermann
5e9498c528
Merge pull request #14280 from overleaf/jpa-latest-node-18
...
[misc] upgrade Node.js to latest version of 18, 18.17.1
GitOrigin-RevId: 58328bbd630686877c0db6266593ef186851bcc5
2023-08-15 08:03:33 +00:00
Jakob Ackermann
a797fb2be7
Merge pull request #14138 from overleaf/bg-em-jpa-mj-node-18
...
Upgrade all services to Node 18
GitOrigin-RevId: c53cd1aaab2fe99b51186911bb068f9fe31a9469
2023-08-03 08:03:56 +00:00
Christopher Hoskin
1d1a64783e
Merge pull request #14029 from overleaf/bg-csh-kustomize-spelling-2
...
kustomize spelling
GitOrigin-RevId: 5b5203c5de92c3443741cabc081df7afe1063e71
2023-07-26 08:04:39 +00:00