Commit graph

66 commits

Author SHA1 Message Date
Jakob Ackermann
97da586877 Merge pull request #4326 from overleaf/pr-avoid-double-stringify-compile-events
Remove controller-level `stringify` for compile events

GitOrigin-RevId: 1b33b5204a846dc4f25dcfbad02c1edc1e010e9f
2021-07-20 11:33:33 +00:00
Paulo Jorge Reis
51c6d90c17 Handle PDF rendering errors in the new logs UI (#4280)
* Handle PDF rendering errors in the new logs UI

* Remove new logs UI specific code from the PDFController

* Only change view with errors and validation issues in the new logs UI

GitOrigin-RevId: 0761ac224db39fdacbb61692c1aa35c3da82a76b
2021-07-07 02:05:48 +00:00
Paulo Jorge Reis
db8173011e Revert "Revert "Handle PDF failure error case""
This reverts commit 946838e51feaff28025c4a4d733e0dd89a29e890.

GitOrigin-RevId: 63f130c8cfecfb512ec97bda62c6ea1cad2c8fed
2021-07-07 02:05:36 +00:00
Alf Eaton
34ba76aa76 Merge pull request #4286 from overleaf/jpa-clear-clsi-unavailable-state
[frontend] PdfController: clear clsiUnavailable state for new responses

GitOrigin-RevId: 7a89a24db6c8f0e62e775befcb4148e749ce8b4e
2021-07-06 02:05:46 +00:00
Jakob Ackermann
343ab44172 Merge pull request #4279 from overleaf/bg-revert-async-apply-in-pdfcontroller
revert async apply in PdfController

GitOrigin-RevId: 20628ca8c9ba06528271e1323ba062d6b563e08e
2021-07-01 12:29:45 +00:00
Paulo Jorge Reis
4e384e0c3b Revert "Handle PDF failure error case"
This reverts commit 902a97f6f454f09345ba4017b50623fd46e57110.

GitOrigin-RevId: 946838e51feaff28025c4a4d733e0dd89a29e890
2021-06-29 02:05:56 +00:00
Paulo Reis
07f44b99f4 Handle PDF failure error case
GitOrigin-RevId: 902a97f6f454f09345ba4017b50623fd46e57110
2021-06-25 02:06:16 +00:00
Alf Eaton
9b9d6f679e Wrap recompile response handlers in $applyAsync (#4253)
GitOrigin-RevId: 80e5652b88ba70b3ea1aef2cf24430597574353e
2021-06-24 02:07:19 +00:00
Jakob Ackermann
b2bc589ad1 Merge pull request #4236 from overleaf/jpa-cleanup-metrics
[PdfJsMetrics] drop unused metrics

GitOrigin-RevId: 377cb4c97746bb81b9cf90e1d48e0050a8d05893
2021-06-23 02:05:52 +00:00
Jakob Ackermann
a6cce9d2f6 Merge pull request #4210 from overleaf/jpa-pdf-caching-5-percent
[misc] pdf caching out of beta with 5%/5% control/treatment split test

GitOrigin-RevId: 06a741f56510b866be3380a99304d8ee67f849dd
2021-06-17 02:09:15 +00:00
Jakob Ackermann
e8bb0114f8 Merge pull request #4203 from overleaf/bg-admin-disable-service-worker
disable service worker via admin page

GitOrigin-RevId: 96ec9f07b32b831f5271827ab345ad831044f831
2021-06-17 02:09:06 +00:00
Jakob Ackermann
d9cd12db4e Merge pull request #4197 from overleaf/jpa-compile-metrics-version
[misc] PdfJsMetrics: add a version number to the compile segmentation

GitOrigin-RevId: 18d1481fe120f12895633adfd06a4036eca62de0
2021-06-15 02:06:29 +00:00
Jakob Ackermann
3b3f1fbb73 Merge pull request #4196 from overleaf/jpa-compile-metrics-version
[misc] PdfJsMetrics: add a version number to the event segmentation

GitOrigin-RevId: 4c5e1df9e3513edbfeae0f47303ce9512a25c118
2021-06-15 02:06:25 +00:00
Alf Eaton
8b40e760ca Merge pull request #4133 from overleaf/ae-project-too-large
Display project-too-large error

GitOrigin-RevId: 9078b4f24d3380a4554f9fd91fe0254524763830
2021-06-11 02:06:51 +00:00
Jakob Ackermann
c774ddd111 Merge pull request #4169 from overleaf/jpa-pdf-caching-full-beta
[misc] change pdf caching split test for beta users to 50/50 roll out

GitOrigin-RevId: 3153448db82a9f0fa821da9d6cf5255e1feaaf28
2021-06-11 02:06:24 +00:00
Alexandre Bourdin
c634f51eee Merge pull request #4116 from overleaf/ab-paywall-prompt-events
Add paywall prompt events

GitOrigin-RevId: 6b1b3b384590f14828f37210b2e14047e2ee33d6
2021-06-11 02:05:54 +00:00
Jakob Ackermann
862f7f413a Merge pull request #4137 from overleaf/jpa-fix-metrics-collection
[PdfJsMetrics] fix metrics collection with disabled service worker

GitOrigin-RevId: 607ecd15a3b95b33a45506c489557e5116168c3d
2021-06-03 02:08:56 +00:00
Jakob Ackermann
58c7b6188f Merge pull request #4123 from overleaf/jpa-pdf-caching-one-split-test
[misc] rework roll-out of pdf caching

GitOrigin-RevId: 98ff50918050fe8e9fb5bfecb862657d48cd2726
2021-06-02 02:05:50 +00:00
Jakob Ackermann
e1516aab2c Merge pull request #4110 from overleaf/jpa-omit-skewed-render-latency
[frontend] PdfJsMetrics: omit render time in case we detect hidden page

GitOrigin-RevId: b1ae3b29dbb9764cf67f2f1b1e2f93c83fe67426
2021-06-02 02:05:46 +00:00
Jakob Ackermann
5988e03dac Merge pull request #4108 from overleaf/jpa-lean-pdf-caching-metrics
[frontend] PdfJsMetrics: submit a subset of data points, flatten nested

GitOrigin-RevId: a98ede58f5823020a4c78f46b9800369185f1336
2021-06-02 02:05:43 +00:00
Jakob Ackermann
0015002e53 Merge pull request #4107 from overleaf/jpa-compile-time-client-e2e
[frontend] PdfController: track the e2e compile time seen by the client

GitOrigin-RevId: 1d7c8b815735fd3c0ad9a32284c37c621798fbd3
2021-06-02 02:05:40 +00:00
Jakob Ackermann
b93761f275 Merge pull request #4094 from overleaf/jpa-tag-pdf-caching-traffic
[frontend] PdfController: tag traffic that uses the pdf caching logic

GitOrigin-RevId: ab0d847ff1fe31131428c782ce95b3a5b3dff4fd
2021-05-27 02:05:59 +00:00
Jakob Ackermann
f0b3d8a26a Merge pull request #4076 from overleaf/jpa-events-split-test
[misc] submit events and prepare roll-out for pdf caching w/ split test

GitOrigin-RevId: a7b7af65e1adf5bf003b65d96f1641a343b4b09c
2021-05-22 02:05:44 +00:00
Jakob Ackermann
f49a539c91 Merge pull request #4073 from overleaf/jpa-verify-chunks
[misc] serviceWorker: add optional verification of chunk

GitOrigin-RevId: 7fe9619ab9a928409cdf665d938734bb6a77f853
2021-05-22 02:05:41 +00:00
Jakob Ackermann
dfabc3a93b Merge pull request #4072 from overleaf/jpa-pdfjs-metrics
[frontend] PdfController: observe PDF.js fetch/render performance

GitOrigin-RevId: bdd81ba06dabaa944b64266d0c36700d16790a30
2021-05-22 02:05:38 +00:00
Jakob Ackermann
7db7cd4a49 [misc] merge pdf caching into main (#4033)
* [frontend] WIP: pdf caching using service worker -- squashed

Ref: 920fbaa00b31530f7c457a2d93bad5e553798057
Co-Authored-By: Brian Gough <brian.gough@overleaf.com>
Co-Authored-By: Eric Mc Sween <eric.mcsween@overleaf.com>

* [misc] add contentId into the URL for protecting PDF stream contents

* [misc] gracefully handle missing ranges in serviceWorker

* [misc] support PDF stream caching for anonymous users

* [misc] polish header names and add URL to error message when fetch fails

* [misc] polish event handler registration

* [misc] limit serviceWorker scope to /project/ -- trailing slash

This will block the service worker from intercepting requests on the
 project dashboard.

* [misc] add per-request feature flag for enabling PDF stream caching

* [misc] expose compile stats and timings to the frontend

* [misc] serviceWorker: support clsiServerId and compileGroup url params

* [misc] serviceWorker: polish header maps

* [misc] serviceWorker: drop TODO for p-limit -- the browser has a queue

* [misc] serviceWorker: drop verbose log message on every fetch

* [misc] cut down size of diff in backend code

* [misc] add test case for forwarding of pdf caching and metrics details

* [misc] serviceWorker: drop all the log lines

* [misc] serviceWorker: add boundary guards to the compile request regex

Co-authored-by: Brian Gough <brian.gough@overleaf.com>
Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
GitOrigin-RevId: 4b291b4a4f2866cf07bccf8ec9068f33bbfdc916
2021-05-18 02:07:57 +00:00
Miguel Serrano
f9871103bf Merge pull request #3949 from overleaf/msm-reenable-eslint-const-rule
Reenable eslint `prefer-const` rule

GitOrigin-RevId: 4f3825be8b8dff381095209085a36eaab76260d5
2021-05-06 02:09:14 +00:00
Alf Eaton
1be43911b4 Merge pull request #3942 from overleaf/prettier-trailing-comma
Set Prettier's "trailingComma" setting to "es5"

GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00
Alf Eaton
1ebc8a79cb Merge pull request #3495 from overleaf/ae-prettier-2
Upgrade Prettier to v2

GitOrigin-RevId: 85aa3fa1acb6332c4f58c46165a43d1a51471f33
2021-04-15 02:05:22 +00:00
Paulo Jorge Reis
98e631a9c7 New logs UI out of beta + fixes (#3868)
* Update new logs pane: remove beta icons, add specific surveys

* Remove unneeded reset of log entries

* Remove unneeded reset of the autocompile linting error flag

* Lower compile event sampling rate ahead of prod release

* Never send logs UI subvariant when user is getting the existing UI

GitOrigin-RevId: ab726761ba372c6806e56fc0cf841099cc30df50
2021-04-13 02:05:54 +00:00
Shane Kilkelly
f013f33c05 Merge pull request #3884 from overleaf/jpa-meta-editor-take-2
[misc] migrate the editor templates to meta tags -- take 2

GitOrigin-RevId: 447d4c6c2197dd2c5f5e182a5edf57313557b8b9
2021-04-10 02:05:05 +00:00
Thomas
eb46f9a738 Merge pull request #3880 from overleaf/revert-3826-jpa-meta-editor
Revert "[views] migrate the editor templates to meta tags"

GitOrigin-RevId: 02caaf24ae0ee6a74a38ef870909527da19d4882
2021-04-02 02:05:02 +00:00
Miguel Serrano
d444ba3335 Merge pull request #3864 from overleaf/msm-show-syntex-spinner-double-click
Show the synctex spinner on PDF double click

GitOrigin-RevId: 420e65b822ba2879949fc600a5b15e97f1dccf0d
2021-04-01 02:05:21 +00:00
Miguel Serrano
eeb2b7d18b Merge pull request #3826 from overleaf/jpa-meta-editor
[views] migrate the editor templates to meta tags

GitOrigin-RevId: 01745172840c8ceb5fb9947ca6c14e919e9c4ac7
2021-04-01 02:05:07 +00:00
Paulo Jorge Reis
3f0e897e32 Logs UI variant without popup (#3794)
* Add logs UI without pop-up variant

* Implement frontend for logs UI without pop-up

* Add logs UI variants to admin panel and front user info

* Fix existing UI subvariant window global

GitOrigin-RevId: 075db56032354d782e489b5235925f55b1a67e0b
2021-03-24 03:04:41 +00:00
Brian Gough
0ca6b5921f Merge pull request #3789 from overleaf/bg-fix-root-doc-override
suppress root doc override when in the root doc

GitOrigin-RevId: 3671dece0857b114d0b40cdc2161be0546377985
2021-03-19 03:04:43 +00:00
Alexandre Bourdin
6e35561aeb Merge pull request #3725 from overleaf/ab-ta-pdf-sync-spinner
Stop spinner on PDF sync when file does not exist anymore

GitOrigin-RevId: cba4bf3dd3d90c2894c6c5f1b28d184f18bb08fd
2021-03-11 03:05:04 +00:00
Paulo Jorge Reis
70fb5da37d Send compile metrics (#3576)
* Support analytics events with a custom sampling rate

* Send compile metrics for beta users

GitOrigin-RevId: 86379f58e0bb4983a56cb6f0dcd6da916de3b8ba
2021-02-18 03:05:16 +00:00
Eric Mc Sween
38312fd7d3 Merge pull request #3557 from overleaf/jpa-reland-clear-persistance
[reland] cleanup pdf url composing and clear clsi persistance

GitOrigin-RevId: 59ac281d16564a64852ccc07dac0c99cadfba8f2
2021-01-22 03:04:48 +00:00
Paulo Jorge Reis
11e58b5844 Add timeout upgrade prompt to the new compile UI (#3528)
* Uncouple account-upgrade and exposted-settings from Angular

* Mock socket shim with the correct methods

* Extract timeout upgrade prompt to a component

GitOrigin-RevId: ee8058b38bf5e20924a21f40d32c5bb0ee06c555
2021-01-15 03:05:48 +00:00
Jakob Ackermann
9d47b05486 Merge pull request #3549 from overleaf/jpa-disable-downloads-before-clearing-cache
[frontend] PdfController: disable download buttons before clearing cache

GitOrigin-RevId: e685411c12c9962732a5ab88fcb7466b0f6df7ce
2021-01-13 03:04:11 +00:00
Jakob Ackermann
274dd56300 Merge pull request #3546 from overleaf/revert-3516-jpa-clsi-urls
Revert "[frontend] PdfController: cleanup the composing of download urls"

GitOrigin-RevId: 3243bd864ac0090c964ba2c471fa659a11528660
2021-01-08 03:04:52 +00:00
Jakob Ackermann
de646d3160 Merge pull request #3516 from overleaf/jpa-clsi-urls
[frontend] PdfController: cleanup the composing of download urls

GitOrigin-RevId: 599d9cb2fca1d75ca15cbb1bef7561215ee31aef
2021-01-08 03:04:36 +00:00
Alasdair Smith
7cbf2cdd9e Merge pull request #3496 from overleaf/ae-eslint-dot-notation
Enable the eslint dot-notation rule

GitOrigin-RevId: e11cbad3e8a77a4a60590d3674fbf34feccc5bc9
2020-12-17 03:07:31 +00:00
Alf Eaton
2ff1cf43d6 Merge pull request #3470 from overleaf/eslint
Upgrade and configure ESLint

GitOrigin-RevId: ad5aeaf85e72c847a125ff3a9db99a12855e38aa
2020-12-16 03:08:28 +00:00
Paulo Jorge Reis
4e74fb2694 Log pane improvements (#3418)
* Ordering of log entries in the new errors UI

* Don't show the expand-collapse widget when not needed; smaller font size in the raw log output

* Expose log actions in the log pane.

* Use "This project" instead of "Your project" in the new errors UI

* Better handling of long log messages; left-ellipsize the file/line number button

* Make log location more button-like; add tooltip when needed.

* Add a PDF expand button to the toolbar.

* Add a stop compilation button to the new compile UI

* Use aria-label for button accessible text; improve handling of long filenames in the log location button

* Set max-height correctly for the logs pane dropdown

* Avoid changing raw logs sizing when expanded and collapsed

* Add comment on the solution for right-to-left text and ellipsis

* Improve logs pane actions

GitOrigin-RevId: 4098d77a9ee6d333644906876b9ff27035b79319
2020-12-03 03:04:28 +00:00
Paulo Jorge Reis
081f4212a8 Add error and validation issues (#3400)
* Remove references to the duplicatePaths validation

* Make the log entries more generic, to support validation and CLSI errors

* Add validation issues to the new logs UI

* Add CLSI errors to the new logs UI

* Update tests; accessibility fixes

* Disable PDF viewing when compile fails; address PR feedback.

* Add accessible description for error and validation failed compiles

GitOrigin-RevId: 8b0597af8857712d47c20e4915470e8e745bb315
2020-11-27 03:04:38 +00:00
Paulo Jorge Reis
619ec15309 Add first error popup (#3369)
* Add first error popup

* Address PR feedback

GitOrigin-RevId: e924b3e6096584de6f363aae70a62328cd3de83d
2020-11-17 03:04:11 +00:00
Jakob Ackermann
c6a853c7ed Merge pull request #3332 from overleaf/pr-new-log-entries-ui
New log entries ui

GitOrigin-RevId: a13ccac04197e7c8f3777750b956d550c95c8f0d
2020-11-06 03:04:59 +00:00
Alasdair Smith
46be87f7c5 Merge pull request #3317 from overleaf/pr-prepare-log-hints-react
Prepare log hints for React

GitOrigin-RevId: 77435d26e9e5e74db8a76236cac64b67155adc59
2020-10-30 03:04:19 +00:00