Commit graph

23425 commits

Author SHA1 Message Date
Antoine Clausse
5afa892981 [fetch-utils] Fix unit tests (#20210)
* [fetch-utils] Fix FetchUtilsTests.js tests

* Cleanup between tests
* Define `AbortError`

* [fetch-utils] Add `expectConnectionCount` showcasing that the connection stays on when the stream is destroyed

* Revert "[fetch-utils] Add `expectConnectionCount` showcasing that the connection stays on when the stream is destroyed"

This reverts commit b10da7b3fc06a7345df8fd70f27fad70a478bbb4.

* [fetch-utils] Fix `supports abort signals` test

* [fetch-utils] Add tests "aborts the request when the request body is destroyed during transfer"

* [fetch-utils] Add extra waiting step before `expectRequestAborted`

* [fetch-utils] Add `while (!req?.destroyed) await wait(10)`

Unfortunately I couldn't find a better event to await.

To try with this to test flakiness
```
for i in {1..100}; do npm run test:unit || break; echo "Run $i completed"; done
```

* [fetch-utils] Replace arbitrary `wait(10)` by `this.server.waitForEvent('request-received')`

* [fetch-utils] Improve tests per PR comments

See https://github.com/overleaf/internal/pull/20210

1. Replace `waitForEvent` with `once`
2. Replace `waitForRequestAborted` by `expectRequestAborted`
3. Add comment in `expectRequestAborted` empty catch block

Non-flakiness rechecked with `for i in {1..100}; do npm run test:unit || break; echo "Run $i completed"; done`

* [fetch-utils] Add small wait before checking `lastReq === undefined`

Per https://github.com/overleaf/internal/pull/20210#discussion_r1743329462

GitOrigin-RevId: 5fe542e0a8e6011307e03237e2f81404d9a0e674
2024-09-05 08:05:57 +00:00
Davinder Singh
56b69a743b Plans page redesign - [light-design] Use the new "request overleaf common" UI on the student tab (#20199)
* making the university info section in students tab to follow the new design.

* adding the left alignment of the button

* adding light keyword for the classes that are being used in the light design version for this university info card

* removing text-capitalize class

* deleting the comment

GitOrigin-RevId: 641613cf6ab73edef57b917b58ebf10b698572d3
2024-09-05 08:05:52 +00:00
Davinder Singh
f8f111d023 Merge pull request #20154 from overleaf/ds-plans-annual-monthly-toggle-switch-gap
Plans page - Annual/Monthly toggle switch gap removal

GitOrigin-RevId: e14b1a595b127e7b22dc3fa6f5d679629ead3e0b
2024-09-05 08:05:48 +00:00
Tim Down
e88b971735 Merge pull request #20169 from overleaf/td-contact-modal-acknowledge
Add acknowledgement message to React contact modal after successful submission

GitOrigin-RevId: a27b968351857997df17fedde3baa9da3f82331a
2024-09-05 08:05:28 +00:00
Jakob Ackermann
4733eb1007 Merge pull request #20245 from overleaf/jpa-fix-e2e-local
[server-pro] tests: use AR for Server Pro image

GitOrigin-RevId: 7e870afbbfb8a6ae1bd369ad8e04abe3f47d23ed
2024-09-05 08:05:12 +00:00
Mathias Jakobsen
99269d3928 Merge pull request #20268 from overleaf/revert-19885-mj-resizeable-panels
Revert "[web] Upgrade react-resizable-panels"

GitOrigin-RevId: 65b6cf9656c1116f77ae5dc3ceec1106e898d6f9
2024-09-05 08:05:03 +00:00
Mathias Jakobsen
1a8cf9b87d Merge pull request #20235 from overleaf/mj-disable-sp-history-debugging
[web] Hide history debugging admin tab for Server Pro

GitOrigin-RevId: afba1dd0b2bc3d76b4931058f588ae4532ca9609
2024-09-05 08:04:58 +00:00
Mathias Jakobsen
5d57571e96 Merge pull request #20226 from overleaf/mj-restore-file-badge
[web] Add split test badge for file restore

GitOrigin-RevId: 59bbdd4cc5b76141a8bae06c2e7181e5a5c5ccc0
2024-09-05 08:04:53 +00:00
Mathias Jakobsen
2d9e4965f7 Merge pull request #19885 from overleaf/mj-resizeable-panels
[web] Upgrade react-resizable-panels

GitOrigin-RevId: 6b316dfb43ff841e863c83d1393ca88299eeefa2
2024-09-05 08:04:48 +00:00
ilkin-overleaf
86689a6269 Merge pull request #20205 from overleaf/ii-bs5-ide-header
[web] BS5 ide page header

GitOrigin-RevId: b7aad221d458d8403d60ff9950129394c74af856
2024-09-04 08:06:00 +00:00
Jimmy Domagala-Tang
7add11a190 Merge pull request #19642 from overleaf/jdt-latexmkrc-ce
feat: add latexmkrc for server-ce
GitOrigin-RevId: 0d7385808a6a0b98d0a759ce0e329e6b9f578f35
2024-09-04 08:05:55 +00:00
David
f4c57fce4c Merge pull request #20246 from overleaf/dp-math-preview-closing-delimiter
Don't show math preview tooltip if the node has a parse error

GitOrigin-RevId: 330ebb945c70da4b5fe9ee4ee2f149a95435899b
2024-09-04 08:05:50 +00:00
David
4802d04fb0 Merge pull request #20198 from overleaf/dp-math-preview-improvements
Remove transition from math-preview tooltip to avoid flashing

GitOrigin-RevId: 004c7eeb6d4421a3d11f175a80d217356dfcb2da
2024-09-04 08:05:46 +00:00
Jessica Lawshe
8aa544a5ae Merge pull request #20187 from overleaf/jel-plans-modal-edu-discount
[web] Use notification for when edu discount is applied or not on light touch redesign

GitOrigin-RevId: 38278ac94f5b3cae18a500b3801412ed1b9a7da0
2024-09-04 08:05:37 +00:00
Eric Mc Sween
4f37ef0b1a Merge pull request #20189 from overleaf/em-github-file-rejections
Show a detailed error message when GitHub rejects oversized files

GitOrigin-RevId: 6ae37c228f232a00f4d872623cb6e85a3b65f258
2024-09-04 08:05:21 +00:00
Tim Down
11d8b5162e Merge pull request #20237 from overleaf/td-bs5-contact-nav-item-button
Implement contact form nav item as a button rather than link

GitOrigin-RevId: 00690f70d343077b7884005f2e4ab8f8cc651b23
2024-09-04 08:05:17 +00:00
Rebeka Dekany
39b6b8baed Merge pull request #20172 from overleaf/rd-ide-fileoutline
[web] Migrate the file outline styling from LESS to SCSS

GitOrigin-RevId: 5e485b13a7358e5dcab2c75ee7d36a07e1401e26
2024-09-04 08:05:12 +00:00
Alf Eaton
de8acd2ed8 Upgrade @codemirror dependencies (#20103)
* Upgrade `@codemirror` dependencies
* Set EditorView.EDIT_CONTEXT=false

GitOrigin-RevId: 8024715748102a56f1b22e72be8a2019e80b5a07
2024-09-04 08:05:07 +00:00
Alf Eaton
27e558b484 Fix image upload modal dropzone overflow (#20102)
GitOrigin-RevId: 8caf4e631056ed00b167cff8a6cccea0e0ff8ae7
2024-09-04 08:05:02 +00:00
Alf Eaton
284a8256d4 Fix tag name overflow in projects list (#20120)
GitOrigin-RevId: 9fc317dbebd8115ab8af97f4753350f5ee79c1cd
2024-09-04 08:04:57 +00:00
Alf Eaton
abfa29e629 Ensure that the correct lines are spell-checked (#19967)
GitOrigin-RevId: f63601288821d37bddcddc776270263e291d3985
2024-09-04 08:04:53 +00:00
Alf Eaton
607b3e3494 feat: making highlighting of errors more specific (#19963)
GitOrigin-RevId: 63bc147e18e80c1e070722bc70114f8fca8509ae
2024-09-04 08:04:48 +00:00
roo hutton
31bb5939a1 Merge pull request #20156 from overleaf/rh-share-modal-dropdown-fix
[web] Add explicit width to share modal permission dropdown

GitOrigin-RevId: df20cedfffffb2ba8291dcae128845a03b2897ba
2024-09-04 08:04:39 +00:00
Rebeka Dekany
54fb884aaf Merge pull request #20219 from overleaf/rd-dropdown-alignment
[web] Language picker dropdown should expand to the top

GitOrigin-RevId: 591a6fc013d2a9e841acd09d6881727aed38471b
2024-09-03 08:04:34 +00:00
Tim Down
1f6418f48f Merge pull request #20161 from overleaf/td-bs5-contact-modal-wiki-search-visibility
Fix for learn wiki search results not appearing in BS5 nav contact modal

GitOrigin-RevId: 9f4476163c509ab6ec7fe119600276c906c44f7e
2024-09-02 08:05:49 +00:00
Tim Down
8219957436 Merge pull request #20196 from overleaf/td-notification-html-validity
Remove superfluous elements around notifications on project dashboard

GitOrigin-RevId: 975e6056e6e89703f24b5ae1853c58c998722202
2024-09-02 08:05:44 +00:00
M Fahru
a9af85b6ab Merge pull request #20024 from overleaf/mf-plans-page-click
[web] Implement `plans-page-click` event on new plans page

GitOrigin-RevId: 1dbfc5faa433985c1ad81ba645cdb8f6f3a0b864
2024-09-02 08:05:39 +00:00
Jessica Lawshe
feddc2158f Merge pull request #20186 from overleaf/jel-discount-color
[web] Increase color contrast on new plans page discount badge

GitOrigin-RevId: 3230a2debdf1c23a0b18b32b8062d5108f7e32ce
2024-09-02 08:05:35 +00:00
Jessica Lawshe
f8b10a41dc Merge pull request #20183 from overleaf/jel-plans-discount-line-height
[web] Fix line height on new plans discount badge

GitOrigin-RevId: e253c6f3fc66988d4eb978fc46002f1b9ad31ed1
2024-09-02 08:05:30 +00:00
Jakob Ackermann
3c5bd060f4 Merge pull request #20117 from overleaf/jpa-server-pro-test-local
[server-pro] tests: add support for running email tests on Macs

GitOrigin-RevId: 19a206f4ee70d43624094dd8da87091063d631a0
2024-09-02 08:05:25 +00:00
Davinder Singh
16eb99ee48 Merge pull request #20173 from overleaf/mf-fix-interstitial-student-desc
[web] Correct student header text on interstitial payment new design.

GitOrigin-RevId: 5f12f8bb4777c24513da79629bc9a501c4042318
2024-09-02 08:05:21 +00:00
Jakob Ackermann
0fff0a9e5b Merge pull request #20162 from overleaf/jpa-sandboxed-e2e-local
[server-pro] fix re-running of sandboxed compiles e2e tests

GitOrigin-RevId: 5c23b1018ffc8abc0af868100c8a600d2ed10267
2024-09-02 08:05:12 +00:00
Jakob Ackermann
831a40390a Merge pull request #20184 from overleaf/jpa-e2e-local
[server-pro] tests: make running test locally more robust

GitOrigin-RevId: 2944dc9faeb9ed5795e7ad28a5cabe7e018803bb
2024-09-02 08:05:08 +00:00
Mathias Jakobsen
496a63cf23 Merge pull request #20058 from overleaf/mj-promisify-tpr
[third-party-references] Promisify third-party-references

GitOrigin-RevId: cfc462abaca95ed10798b3d1756950f2997a5947
2024-09-02 08:04:55 +00:00
andrew rumble
b28d9c15e4 Convert github-sync files to use fetch-utils
GitOrigin-RevId: 5b3a40bbeac54d00d566144d5642b2b36171b239
2024-09-02 08:04:42 +00:00
M Fahru
229da9ef5f Add "For government" link in footer (for both default and website-redesign template)
GitOrigin-RevId: 47ebc6776281acd11b9a18f772feec2b5d45dbe4
2024-08-30 08:05:15 +00:00
M Fahru
0a54587176 Add "For government" link in navbar
GitOrigin-RevId: 4ffbcb355291570340d32a934b0ac93c922929ab
2024-08-30 08:05:10 +00:00
Jimmy Domagala-Tang
5b07afcd20 Merge pull request #20182 from overleaf/jdt-vim-gk-update
Update codemirror-vim to include gk arrow patch

GitOrigin-RevId: cb24eb4dca19644ea75b2b94092c6038ebb7328c
2024-08-30 08:05:02 +00:00
Jessica Lawshe
27b4dfbd79 Merge pull request #20174 from overleaf/jel-plans-page-query-param-part-3
[web] New plans page elements that are dependent on plan period type

GitOrigin-RevId: 677d4df1544aa901dd5c57d61c395f3045c1c024
2024-08-30 08:04:55 +00:00
Jessica Lawshe
3b864d4345 Merge pull request #20155 from overleaf/jel-plans-page-query-param-part-2
[web] Render initial plans tab on server

GitOrigin-RevId: cb4d59274c0fd2a40fd35b5301d0bd387e738a98
2024-08-30 08:04:50 +00:00
Jakob Ackermann
aa45f778c0 Merge pull request #20137 from overleaf/jpa-fix-e2e
[server-pro] fix e2e tests

GitOrigin-RevId: 589d23baf8bc815328f21b140f2086e135d13736
2024-08-30 08:04:46 +00:00
Jakob Ackermann
d655cb129a Merge pull request #20168 from overleaf/jpa-email-fallback-info
[web] log emails on level INFO from fallback transport

GitOrigin-RevId: a1f63e302cf6c5fcfa82b85ff2c79182fdc58945
2024-08-30 08:04:42 +00:00
Jessica Lawshe
3c86912f61 Merge pull request #20072 from overleaf/jel-plans-period-toggle
[web] Put plans period toggle within tabs that use it

GitOrigin-RevId: ccc2594467b3b31dd3fda82dd23e058911d0ec82
2024-08-30 08:04:34 +00:00
Rebeka Dekany
f6213de83b Merge pull request #20140 from overleaf/rd-footer-react
[web] Migrate the footer to React

GitOrigin-RevId: 9571d7b3ef9a267fb8250956f821b1ee34ce07c7
2024-08-30 08:04:29 +00:00
CloudBuild
eb0f3e5bf0 auto update translation
GitOrigin-RevId: 1e094aee257e0f1194bdefa81089a89177c5d3c3
2024-08-29 08:05:12 +00:00
M Fahru
250514b28e Merge pull request #20143 from overleaf/mf-fix-plan-features-mobile-header-text
[web] Change "Collaborator" text to "Standard" in individual tab plans (plans page and interstitial page new design)

GitOrigin-RevId: 064bb59b3fb84f1fb413035acc40e7f6b368b1f8
2024-08-29 08:04:56 +00:00
M Fahru
666c10860e Merge pull request #20151 from overleaf/mf-add-canonical-light-design-plans
[web] Add necessary config for canonical link and suppressing alternate links for different languages in plans light design

GitOrigin-RevId: f903b3c1eb31276ea8ffadc43ac240a4c16bcbbc
2024-08-29 08:04:51 +00:00
Anass Zurba
d1f15b7216 outline: handle texorpdfstring command. 2024-08-28 22:24:40 +03:00
Jakob Ackermann
169723f492 Merge pull request #20159 from overleaf/jpa-enable-sandboxed-by-default-dc
[server-pro] enable sandboxed compiles by default in docker-compose

GitOrigin-RevId: bb02fd992a6b36d4c49a8a642c156f014777d037
2024-08-28 11:35:26 +00:00
roo hutton
837b5a4b9b Merge pull request #19914 from overleaf/rh-viewer-comments
[web] Allow Viewers to access chat and view comments/tracked changes

GitOrigin-RevId: 72be0444afdf5e0ad5937bf25718a7566bad001a
2024-08-28 11:35:22 +00:00