Commit graph

540 commits

Author SHA1 Message Date
Alf Eaton
ecb94d6525 Improve spellcheck error handling and types (#21012)
GitOrigin-RevId: 0227122154f139401793aae2c8ca9c9960fe5e98
2024-10-14 11:09:46 +00:00
Rebeka Dekany
0131178491 Merge pull request #21002 from overleaf/rd-icon-updates
[web] Material icon changes in toolbars

GitOrigin-RevId: f0a36b2f0c2bc56a7fccfe6491ea4538a997c486
2024-10-14 11:09:41 +00:00
Alf Eaton
b81472329e Use cls for documentclass completion type (#20981)
GitOrigin-RevId: 938eaac212c7e08600db111563094c0447fafb9b
2024-10-14 11:09:21 +00:00
David
b1d1432183 Update add comment tooltip to match new designs (#20913)
* Update add comment tooltip to match new designs

* Rename AddCommentTooltip to ReviewTooltipMenu

* Split off add-comment-button specific padding

GitOrigin-RevId: 12a69b13b52b007eb97ba7ad6f290e3a98d741cd
2024-10-14 11:08:26 +00:00
Mathias Jakobsen
ee2e95ec01 Merge pull request #20987 from overleaf/mj-write-and-cite-settings-icons
[web] Add setting icons to Write and Cite section headers

GitOrigin-RevId: 18e5eefeb1271d17812b83f152e4d464a66185f8
2024-10-14 11:08:09 +00:00
Antoine Clausse
b054342ddb [web] Update bsVersion to return its arguments types (#20963)
* [web] Update `bsVersion` to return its arguments types

* [web] Remove `as string` after `bsVersion` calls

GitOrigin-RevId: 604ce87aaccd709299124a986e98cf45874484bb
2024-10-14 11:07:45 +00:00
Alf Eaton
53d6b4dfd0 Set workerPublicPath in webpack config (#20629)
GitOrigin-RevId: 3fba33a6b52bf2a91f3126efc9d76f6f1dfbc1c4
2024-10-14 11:06:45 +00:00
ilkin-overleaf
92eade7502 Merge pull request #20708 from overleaf/ii-bs5-pdf-toolbar
[web] BS5 pdf toolbar

GitOrigin-RevId: a04091c9e936e52f47c3977b3149ffe613d43bb9
2024-10-14 11:06:17 +00:00
Mathias Jakobsen
58b52db56d Merge pull request #20903 from overleaf/mj-load-write-and-cite-with-autocomplete
[web] Load Write and Cite with AutoComplete

GitOrigin-RevId: b496874447b00723410df01a96ea66aa8ec4da3c
2024-10-14 11:05:39 +00:00
Alf Eaton
139fde750a Add feedback link in spelling suggestion footer (#20867)
GitOrigin-RevId: 3bef428f810b88f56a76e3645cebcf22dd5ad9e3
2024-10-14 11:05:21 +00:00
Alf Eaton
e99ae3a459 Add Hunspell README (#20872)
GitOrigin-RevId: 0b02a1a03e467d0857766e70e3a3862f939c773c
2024-10-14 11:05:17 +00:00
Alf Eaton
a1ea50ded3 Load hunspell.wasm from the CDN (#20856)
GitOrigin-RevId: 0fcbc2102e280222ab4b9279f02c820a3b904496
2024-10-14 11:05:12 +00:00
David
175a4d024d Merge pull request #20805 from overleaf/dk-fix-focus-highlight
Fix focus highlight decoration for new review panel

GitOrigin-RevId: c69ba8dd8527b6c3797b1e986cfd87c1ca87da6d
2024-10-14 11:02:55 +00:00
David
b2dab4b1c0 Merge pull request #20709 from overleaf/dp-search-wrapping
Wrap search controls on small editor widths

GitOrigin-RevId: 513d046ba2951daf13385f48b73704e6feccd7d0
2024-10-14 11:02:40 +00:00
Alf Eaton
df6147bb4d Convert PDF.js code to TypeScript
GitOrigin-RevId: 840bc48816d78497131b927522b4f6f7940bb0c4
2024-10-14 11:00:45 +00:00
David
2117bfe29d Merge pull request #20541 from overleaf/dk-delete-widgets
Handle highlight/focus effects for track deletes in new review panel

GitOrigin-RevId: 102eed9e8af04599823c1bcf0598a0328901bdba
2024-10-14 10:59:47 +00:00
David
46198cd780 Merge pull request #20688 from overleaf/dk-fix-wrong-rangesdata
Fix "RangeError" when switching files using new review panel

GitOrigin-RevId: 399c8722584053c62acf5c413572fbbcdd1896cc
2024-10-14 10:59:33 +00:00
David
13545140ee Merge pull request #20681 from overleaf/dp-highlight-height
Add padding to change highlight/focus styles

GitOrigin-RevId: 6543fe6545ff8e7baff23d5262b941a5473be19e
2024-10-14 10:59:25 +00:00
Mathias Jakobsen
aba4694377 [web] Move ARS Write and Cite behind separate feature flag (#20631)
* [web] Move ARS Write and Cite behind separate feature flag

* [web] Use isSplitTestEnabled function

* [web] Only load Write and Cite if project has ARS access

* [web] Enable Write and Cite ARS by default

* [web] Fix condition for loading write and cite ref sources

* [web] Remove references settings button in free projects

GitOrigin-RevId: c4f3b7c60da9864409c788dcf34bdc77347441a8
2024-10-14 10:59:11 +00:00
Alf Eaton
24c8629cd4 Use Hunspell for client-side spellchecking (#20286)
GitOrigin-RevId: c4d0d9e06fe0cc9d7cb7a058fd0768eb024e44f5
2024-10-14 10:58:36 +00:00
ilkin-overleaf
35728d7681 Merge pull request #20436 from overleaf/ii-bs5-editor-toolbar
[web] BS5 editor toolbar

GitOrigin-RevId: a517fd52d648d165e89231d6f5551c026a951c43
2024-10-01 08:04:42 +00:00
Alf Eaton
c6633632d6 Move CodeMirror contexts into a separate file (#20643)
GitOrigin-RevId: 8425454a75ff8160a03fda1be5bda2242b41f6cd
2024-09-30 08:04:48 +00:00
David
06e24c9081 Merge pull request #20606 from overleaf/dk-add-comment-on-mouseup
show Add comment button on mouse up event

GitOrigin-RevId: 2c87f11fab9f9fb7e11637bb9eac2ca1ab9b298b
2024-09-27 08:04:39 +00:00
Alf Eaton
6f8a9a0f81 [visual] Improve cursor position in empty list items (#20611)
GitOrigin-RevId: 08a83b509e217573f680ca4a635d9480ade9b1ae
2024-09-26 08:05:32 +00:00
Alf Eaton
53e46632a9 Improve editor focus events (#20263)
GitOrigin-RevId: 710f42eb633289b43858b8f283735ed0aced5c0b
2024-09-26 08:05:25 +00:00
Alf Eaton
ca72351c8e Improve detection of pasted Excel table in Safari (#20374)
GitOrigin-RevId: 92b9c485b57f753f4fe161e582817f72244436e1
2024-09-26 08:05:21 +00:00
Alf Eaton
77ad90d59a Refactor to texOrPdfString function
GitOrigin-RevId: b084966a4fc13de4708973685844b2d9d2405e9b
2024-09-26 08:05:13 +00:00
Copybot
2a2bb3f064 Merge pull request #1245 from AnessZurba:tex-or-pdf
GitOrigin-RevId: 096f7e5bb581c3984db8dc74e7a4c525de862cce
2024-09-26 08:05:08 +00:00
David
22e4c2de2c Merge pull request #20411 from overleaf/dk-highlight-focus-ranges
Highlight and focus ranges in editor for new review panel

GitOrigin-RevId: 4fef31a8c9e6dc974519d925c7478665e0c8cc29
2024-09-20 08:05:13 +00:00
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
David
9cf94e57d3 Include \def, \let, \newenvironment and \renewenvironment commands in the math preview (#20197)
* Include \def commands in command definitions

* Allow command name to be in CtrlSym

* Pull nodeIntersectsChange check out of branches

* Fix \def handling

* Add handling for \newenvironment and \renewenvironment

* Allow \def to have optional arguments

* :x
Revert "Add handling for \newenvironment and \renewenvironment"

This reverts commit a70d3a0a13ed552daf3b761893e3f8609f0b0fc8.

* Add let commands to defintions

* Add environment names to math preview

* Ignore let command definitions in autocomplete

* Move nodeIntersectsChange check back into each block

* Add childOfNodeWithType utility and use to get command names

* commandNameText -> commandName

* Only include environment definitions

* Rename documentEnvironmentNames to documentEnvironments

* EnvironmentName -> Environment

* Format

GitOrigin-RevId: 9c5d701423ae786e5ff91960b4bcd94cd35d21c8
2024-09-17 08:04:53 +00:00
Alf Eaton
0230a296ac Remove underline from lint range highlight (#20243)
GitOrigin-RevId: 29c91fa8297cb92ceba3a088bff22c847b73455d
2024-09-13 08:05:05 +00:00
Alf Eaton
0e40011e14 Remove setTimeout from spell check results dispatch (#20342)
GitOrigin-RevId: 9973b216d60b20c2b6aaf5205c13e2db69cbd589
2024-09-13 08:04:55 +00:00
Alf Eaton
26af3e1ecf Use estimated height of math widget (#20359)
GitOrigin-RevId: b412e429b26ae51c83f84b855084b36a0015838d
2024-09-13 08:04:50 +00:00
David
565514a162 Merge pull request #20269 from overleaf/dp-single-math-tooltip
Only show single math tooltip

GitOrigin-RevId: 85608976f2dc6d15748a1bde24c837d2180d3cbe
2024-09-06 08:05:00 +00:00
David
f4c57fce4c Merge pull request #20246 from overleaf/dp-math-preview-closing-delimiter
Don't show math preview tooltip if the node has a parse error

GitOrigin-RevId: 330ebb945c70da4b5fe9ee4ee2f149a95435899b
2024-09-04 08:05:50 +00:00
David
4802d04fb0 Merge pull request #20198 from overleaf/dp-math-preview-improvements
Remove transition from math-preview tooltip to avoid flashing

GitOrigin-RevId: 004c7eeb6d4421a3d11f175a80d217356dfcb2da
2024-09-04 08:05:46 +00:00
Alf Eaton
de8acd2ed8 Upgrade @codemirror dependencies (#20103)
* Upgrade `@codemirror` dependencies
* Set EditorView.EDIT_CONTEXT=false

GitOrigin-RevId: 8024715748102a56f1b22e72be8a2019e80b5a07
2024-09-04 08:05:07 +00:00
Alf Eaton
abfa29e629 Ensure that the correct lines are spell-checked (#19967)
GitOrigin-RevId: f63601288821d37bddcddc776270263e291d3985
2024-09-04 08:04:53 +00:00
Alf Eaton
607b3e3494 feat: making highlighting of errors more specific (#19963)
GitOrigin-RevId: 63bc147e18e80c1e070722bc70114f8fca8509ae
2024-09-04 08:04:48 +00:00
Anass Zurba
d1f15b7216 outline: handle texorpdfstring command. 2024-08-28 22:24:40 +03:00
roo hutton
837b5a4b9b Merge pull request #19914 from overleaf/rh-viewer-comments
[web] Allow Viewers to access chat and view comments/tracked changes

GitOrigin-RevId: 72be0444afdf5e0ad5937bf25718a7566bad001a
2024-08-28 11:35:22 +00:00
Eric Mc Sween
8b4b454b97 Merge pull request #20052 from overleaf/em-tracked-deletes-limit
Include tracked deletes when limiting document size

GitOrigin-RevId: 9d7b2870001fb942eaa92db78993fee1ddb3937c
2024-08-27 08:04:31 +00:00
Domagoj Kriskovic
cab58d87dd extracted rejectChanges to a separate file
GitOrigin-RevId: 83c55c4823f6e18f22dbd6bc1fa7ec010c509e30
2024-08-26 08:05:10 +00:00
Domagoj Kriskovic
ea20f82ad6 remove callout widget from ranges extension
GitOrigin-RevId: fa7f36cb0270228b57162404ce5a17523790e396
2024-08-26 08:05:06 +00:00
Domagoj Kriskovic
be47b27d98 remove clearChanges and buildChanges effects from ranges extension
GitOrigin-RevId: 4782725bfaf50153007bbd9ae5c8146cca769cde
2024-08-26 08:05:01 +00:00
Domagoj Kriskovic
dc70054caf trackDetachedComments as separate extension
GitOrigin-RevId: 8039de3f9766b072e9bb2170b50e683073105748
2024-08-26 08:04:56 +00:00
Domagoj Kriskovic
ec6b17eb01 revert trackChanges extension to a version before redesign
GitOrigin-RevId: fc12968a3971cfee7594720076bb4dc271178e73
2024-08-26 08:04:52 +00:00
Domagoj Kriskovic
6547ce6aa1 remove updateRangesEffect and rejectChanges from trackChanges extension
GitOrigin-RevId: b93751421d235fd61a80ce64f47aec7998e4f6cf
2024-08-26 08:04:47 +00:00
Domagoj Kriskovic
3bdfd36613 copied track-changes.ts extension
GitOrigin-RevId: 95e383223c6e4e7a10112ebfaff4d3bda9530a01
2024-08-26 08:04:43 +00:00