github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
22241 commits 3 branches 7 tags 206 MiB
Commit graph

60 commits

Author SHA1 Message Date
Domagoj Kriskovic
8bde496da4 Send operations to project-history when resolving/unresolving comments (#17540) 
* Send operations to project-history when resolving/unresolving comments

* small fixes

* added doc_id in web unit test

* Revert "added doc_id in web unit test"

This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.

* fix mocked dependency in test

* wip: web unit tests

* document updater, reopen test

* document-updater tests

* format fix

* fix typo

* fix callsArgWith

* fix reopenThread calls in doc updater tests

* fix typos

* log error if chat api resolve failes

* log error when reopening thread

* sendStatus calls done() in tests

* using OError instead of logging

* removed timers

* preserve legacy endpoints

* update after merge

* Remove timer check in HttpControllerTest

* prettier

* added "legacy" in log

* remove metrics.timer

* fix promisify issues

* remove unused cb

GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
 2024-04-10 08:04:08 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier 
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
 2024-03-26 09:04:05 +00:00
ilkin-overleaf
fc3fb7318a Merge pull request #16493 from overleaf/ii-rp-mini-page-load 
[web] Prevent opening and closing of the mini review panel

GitOrigin-RevId: 25297a24ddfb2654b00efa8d33b825620f859147
 2024-01-17 09:03:17 +00:00
ilkin-overleaf
5dbe1a6121 Merge pull request #16114 from overleaf/ii-rp-track-changes-for-users 
[web] Review panel track changes for users fix

GitOrigin-RevId: 011b8ad5f9bef989da7802946241bc9be1c4f066
 2023-12-08 09:04:28 +00:00
Alf Eaton
17ac0eb16b Remove unused Angular code from "main" and "ide" endpoints (#15868) 
GitOrigin-RevId: dc7ed968c60ae6c64d3cd6d2ec47c93e8d32d7db
 2023-12-06 09:04:45 +00:00
Alf Eaton
d40de2018c Remove Angular/Pug review panel code (#15935) 
GitOrigin-RevId: de782d4b47d987f6434a34bea487568b269e8d85
 2023-11-29 09:04:13 +00:00
Alf Eaton
9875e55a27 Remove Ace (#14299) 
GitOrigin-RevId: ec8788fdbc8aea73ca33ec2810f4e588fe9476b5
 2023-11-29 09:04:08 +00:00
Alf Eaton
9868ce46ec Fix "add new comment" keyboard shortcut (#15404) 
GitOrigin-RevId: d675abbf0977d5c60f332136e98c55a765cf87e9
 2023-10-25 08:04:37 +00:00
Mathias Jakobsen
1a92e1b664 Merge pull request #15248 from overleaf/mj-eslint-angular-components 
[web] Add eslint rules for angularjs components

GitOrigin-RevId: 1343d584368faeb912f04c5879228bcbd07a042a
 2023-10-18 08:03:57 +00:00
Jakob Ackermann
e959529828 Merge pull request #15129 from overleaf/mj-jpa-angular-parameters 
[web] Explicitly name angular parameters

GitOrigin-RevId: 91beae68989d6c8122132b531a4338b116d87424
 2023-10-16 08:04:25 +00:00
Jakob Ackermann
1213709578 Merge pull request #14980 from overleaf/jpa-debug-console 
[web] migrate frontend logging to debugConsole

GitOrigin-RevId: b03ff9030b03fff059738d2270bc4b4912e79f16
 2023-09-28 08:04:12 +00:00
Domagoj Kriskovic
20f49ae325 send comment over sharejs after thread is created (#14807) 
* send comment over sharejs after thread is created

* only react version

* loading gif

GitOrigin-RevId: a6b16a8cae66faa3219f1c9141ee04e303d9f11b
 2023-09-21 08:04:05 +00:00
Tim Down
5cce9683fa Merge pull request #14628 from overleaf/td-review-panel-scroll-jump 
Fix scroll jump and improvements to React review panel layout and performance

GitOrigin-RevId: 3123f90abeb1bf9712ba4025a272e13990aebbd9
 2023-09-06 08:06:32 +00:00
Alf Eaton
c8f0885316 Remove CM5 Rich Text module (#11776) 
GitOrigin-RevId: 812d3b5f1df7e769c8be732ccb31653e8e9a8aa3
 2023-08-16 08:03:35 +00:00
Tim Down
38c673d057 Merge pull request #13720 from overleaf/td-review-panel-entry-pos 
React review panel entry positioning

GitOrigin-RevId: c22617b1d3243b7d54b093426358aeb291421b9e
 2023-07-19 08:03:52 +00:00
ilkin-overleaf
13a7e752d5 Merge pull request #13710 from overleaf/ii-review-panel-migration-bulk-actions-entry 
[web] Create bulk actions entry and bulk actions modal

GitOrigin-RevId: c88ce6213304a110ee7410529813310b863178c1
 2023-07-17 10:59:19 +00:00
ilkin-overleaf
9b930d2849 Merge pull request #13414 from overleaf/ii-review-panel-migration-create-context-api-fix 
[web] Create context api for review panel FIX

GitOrigin-RevId: fc6d8adf18d07e71b529a28deab4d49d62c43587
 2023-07-17 10:32:07 +00:00
Alf Eaton
480ec139ab Merge pull request #13408 from overleaf/ae-revert-resolve-comment 
Revert "create context api for review panel"

GitOrigin-RevId: 3be70d7afbe4f238a27149ab2de38175cf1bf029
 2023-07-17 10:30:27 +00:00
ilkin-overleaf
1918ef3767 Merge pull request #13378 from overleaf/ii-review-panel-migration-create-context-api 
[web] Create context api for review panel

GitOrigin-RevId: 3d550e2f3c14ecd0586d088f4ecb75acd44aa782
 2023-07-17 10:29:53 +00:00
ilkin-overleaf
2fceaa6085 Merge pull request #13343 from overleaf/ii-review-panel-migration-create-feature-flag 
[web] Create feature flag for review panel

GitOrigin-RevId: e7e83729a536dce1824f604fb66afe1785f4be25
 2023-07-17 10:26:04 +00:00
Alf Eaton
08ccdb79d3 [cm6] Improve alignment of review panel elements (#12710) 
* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity

GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
 2023-04-25 08:05:02 +00:00
Tim Down
cbc3aef728 Merge pull request #10109 from overleaf/ds-switch-component 
Modifying the Switch

GitOrigin-RevId: 93b8483aa4aa164ea0be5fc2b4ccc5cfb17eae3c
 2022-11-02 09:04:07 +00:00
Eric Mc Sween
7d099acfdd Merge pull request #9150 from overleaf/em-share-ranges-tracker 
Move RangesTracker to shared lib

GitOrigin-RevId: 62da7208f0b453dd7272c06873c7e415ed887817
 2022-10-05 13:26:01 +00:00
Alf Eaton
0b942bd8a8 Merge pull request #8708 from overleaf/ae-loading-threads-fix 
Only dispatch the loaded_threads event once

GitOrigin-RevId: d9b8bf4a84d115fcc00edbf1901565ddb407c8be
 2022-07-05 08:04:02 +00:00
Alf Eaton
4657465c0d Merge pull request #8703 from overleaf/ae-threads-loaded 
Ensure that the loaded_threads event isn't dispatched for read-only link sharing users

GitOrigin-RevId: e03581f29f1a0aff122c3c16f4f6a3b70293c301
 2022-07-05 08:03:56 +00:00
Alf Eaton
5c94bd81e7 Merge pull request #8699 from overleaf/ae-comment-threads 
Show tracked changes highlights if comment threads are not loaded

GitOrigin-RevId: 1aabe62e1aea0b63336ab33cbf199c3f24471495
 2022-07-05 08:03:15 +00:00
Alf Eaton
78df903b69 Merge pull request #8639 from overleaf/ae-loading-threads 
[cm6] Improve interaction between review panel and CM6

GitOrigin-RevId: 2f15a4821d4edfb5ee00013c74c7ae35fa59559c
 2022-07-04 08:03:30 +00:00
Jakob Ackermann
b04bc4798e Merge pull request #8473 from overleaf/ii-cm6-missing-keyboard-shortcuts-2 
[cm6] Add missing keyboard shortcuts 2

GitOrigin-RevId: 29f68cd2eb9d0ad931fff463f76ddb91b5275516
 2022-06-22 08:05:20 +00:00
Tim Down
ca5f438290 Merge pull request #8373 from overleaf/td-review-panel-scroll 
Scroll incrementally in response to mouse wheel in review panel

GitOrigin-RevId: 2c1f119ae8dfd09b378a3b265c3543f88e2d1f65
 2022-06-13 08:03:55 +00:00
Tim Down
fef395f431 Fix layout shift by nearly always applying overflow-y hidden on review panel (#8174) 
* Always hide vertical overflow on the review panel, not just when it's expanded, which prevents it scrolling slightly when scrolling the PDF in some circumstances
* Fix layout shift by always applying overflow-y hidden on review panel and make entry visible in minimized review panel by making the overflow visible while hovering over the entry

GitOrigin-RevId: 854ee47a762ee2cf78fbbb5856afddb3b723d679
 2022-06-13 08:03:37 +00:00
Tim Down
c0292d96a1 Add vertical padding to CM6 editor content to deal with overflowing entries in the review panel (#8321) 
GitOrigin-RevId: 9f8265dba773008ba8f97053ce66f23dc4b7121f
 2022-06-13 08:03:32 +00:00
Alf Eaton
9062d4ce5d Merge pull request #7983 from overleaf/td-cm6-smooth-scroll-between-comments 
Enable animation when positioning comments in CM6

GitOrigin-RevId: 9a5355c3c2105a3dfa26590c2b007571b55c9dcc
 2022-05-19 08:03:42 +00:00
Alf Eaton
5d05b2b21d Restore "layout-left" styles for collapsed review panel comment popover (#7999) 
GitOrigin-RevId: 230e202496c8bc7e4929fca9c35b7f8eba25653b
 2022-05-19 08:03:08 +00:00
Jakob Ackermann
f0bd6dda23 Merge pull request #7986 from overleaf/jpa-eslint-8 
[misc] upgrade eslint packages to the latest version everywhere

GitOrigin-RevId: f1480d4a171acef82fb26c4aa54be3a6088b0ab3
 2022-05-17 08:05:59 +00:00
Alf Eaton
e096bf051a Open the correct doc on tracked change click in overview (#7622) 
GitOrigin-RevId: 7bef9341c315f350c5428f8c94ce84cbc4f850c5
 2022-04-25 08:04:12 +00:00
Jakob Ackermann
862ff734c6 Merge pull request #7278 from overleaf/jpa-block-track-changes-access 
[web] block restricted token users from accessing track-changes details

GitOrigin-RevId: f2e734b48aaa1d1cae6d5db0e0312a78d42165de
 2022-04-05 12:21:09 +00:00
Tim Down
64dd07a50f Merge pull request #7052 from overleaf/td-suppress-comment-page-up-down 
Suppress Page Up/Down keypresses in comment textarea

GitOrigin-RevId: 244bfdc4f1a1470870180a166ba7d2b2792fe614
 2022-03-14 09:04:22 +00:00
Alf Eaton
5f9cc7512a [web] [cm6] Fix alignment of tracked changes/comments with review panel (#6557) 
GitOrigin-RevId: 65416f32874da1cc866e4949244c4934aeabe804
 2022-02-16 11:35:32 +00:00
Alf Eaton
34a296747b Merge pull request #6695 from overleaf/ae-cm6-review-panel-timing 
[web] [cm6] Improve track changes extension timings

GitOrigin-RevId: 6e374b785daf14bd4d4576747faa0a9b20c4d346
 2022-02-16 11:35:10 +00:00
Alf Eaton
4cad876173 [web] CodeMirror 6 track changes extension (#6455) 
GitOrigin-RevId: 038f375c40e7bc8009ee423016b711a2252f52fa
 2022-01-31 09:03:19 +00:00
Alf Eaton
50df230846 [web] Upgrade Prettier to match version in monorepo root (#6231) 
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
 2022-01-11 09:03:23 +00:00
Jakob Ackermann
a6f05109a3 Merge pull request #5352 from overleaf/jpa-no-var 
[misc] fix eslint violations for `no-var`

GitOrigin-RevId: c52e82f3a8a993b8662cc5aa56e7b95ca3c55832
 2021-10-27 08:03:00 +00:00
Timothée Alby
c5f883ad83 Merge pull request #5031 from overleaf/ab-paywall-events 
Merge paywall-prompt and paywall-click events

GitOrigin-RevId: d567631d08b89565f9a3049f9b88cc2d14a799c1
 2021-09-17 08:03:12 +00:00
Alexandre Bourdin
c634f51eee Merge pull request #4116 from overleaf/ab-paywall-prompt-events 
Add paywall prompt events

GitOrigin-RevId: 6b1b3b384590f14828f37210b2e14047e2ee33d6
 2021-06-11 02:05:54 +00:00
Eric Mc Sween
568e99ad47 Merge pull request #4125 from overleaf/em-analytics-keepalive 
Use keepalive when sending analytics events

GitOrigin-RevId: c4e5884483313cdc67abe98e18852680692ac229
 2021-06-04 02:08:19 +00:00
Miguel Serrano
73c47fa0e0 Layout divider for Symbol Palette (#4036) 
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: e22635978c16646060c80ceb8376a560bfbf6527
 2021-05-18 02:08:12 +00:00
Miguel Serrano
f9871103bf Merge pull request #3949 from overleaf/msm-reenable-eslint-const-rule 
Reenable eslint `prefer-const` rule

GitOrigin-RevId: 4f3825be8b8dff381095209085a36eaab76260d5
 2021-05-06 02:09:14 +00:00
Alf Eaton
1be43911b4 Merge pull request #3942 from overleaf/prettier-trailing-comma 
Set Prettier's "trailingComma" setting to "es5"

GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
 2021-04-28 02:10:01 +00:00
Alf Eaton
1ebc8a79cb Merge pull request #3495 from overleaf/ae-prettier-2 
Upgrade Prettier to v2

GitOrigin-RevId: 85aa3fa1acb6332c4f58c46165a43d1a51471f33
 2021-04-15 02:05:22 +00:00
Shane Kilkelly
f013f33c05 Merge pull request #3884 from overleaf/jpa-meta-editor-take-2 
[misc] migrate the editor templates to meta tags -- take 2

GitOrigin-RevId: 447d4c6c2197dd2c5f5e182a5edf57313557b8b9
 2021-04-10 02:05:05 +00:00